D17706: Fix lock screen focus

andreyby added a comment. mrd...@altlinux.org REVISION DETAIL https://phabricator.kde.org/D17706 To: andreyby, davidedmundson Cc: ngraham, graesslin, abetts, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D18831: [sddm-theme] Use more precise labels for "Different User"

This revision was automatically updated to reflect the committed changes. Closed by commit R120:5bdd05f27cf5: [sddm-theme] Use more precise labels for Different User (authored by filipf, committed by rooty). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D18831: [sddm-theme] Use more precise labels for "Different User"

ngraham accepted this revision. ngraham added a comment. All right, let's do it! REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D18831 To: filipf, ngraham, #plasma, #vdg, hein Cc: rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel,

D18831: [sddm-theme] Use more precise labels for "Different User"

rooty added a comment. perfect I think it's ready to land now REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D18831 To: filipf, ngraham, #plasma, #vdg, hein Cc: rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,

D18831: [sddm-theme] Use more precise labels for "Different User"

filipf updated this revision to Diff 51137. filipf added a comment. use title case for the second label REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18831?vs=51136=51137 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18831

D18831: [sddm-theme] Use more precise labels for "Different User"

rooty added a comment. Also I think the title of the log in by typing screen should follow title capitalization, hence: "Type in Username and Password" REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D18831 To: filipf, ngraham, #plasma,

D18831: [sddm-theme] Rename "Different User" to "Input User"

filipf updated this revision to Diff 51136. filipf added a comment. Better label, change the Type User screen label as well REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18831?vs=51135=51136 BRANCH master REVISION DETAIL

D18831: [sddm-theme] Rename "Different User" to "Input User"

rooty added a comment. In D18831#407445 , @ngraham wrote: > "Input" isn't a very common verb to start a sentence with in English. How about just "Type User" or "Type Username" Type User might be better (shorter, doesn't spill over into a

D18831: [sddm-theme] Rename "Different User" to "Input User"

ngraham added a comment. "Input" isn't a very common verb to start a sentence with in English. How about just "Type User" or "Type Username" REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18831 To: filipf, ngraham, #plasma, #vdg Cc: plasma-devel,

D18831: [sddm-theme] Rename "Different User" to "Input User"

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY The "Different User" action button label is wrong. The respectivebutton switches to a screen where usernames are manually inputed.

D18823: Create a dynamic way to provide component information

This revision was automatically updated to reflect the committed changes. Closed by commit R1014:d780fc1db376: Create a dynamic way to provide component information (authored by dkardarakos). REPOSITORY R1014 Kirigami Gallery CHANGES SINCE LAST UPDATE

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. This is a huge improvement over what we have right now. Very nice job! A few behavioral issues: - After removing a folder, the wallpaper grid should update immediately

D18823: Create a dynamic way to provide component information

dkardarakos created this revision. dkardarakos added a reviewer: mart. Herald added projects: Plasma, Kirigami. Herald added a subscriber: plasma-devel. dkardarakos requested review of this revision. REVISION SUMMARY In some components, an action is offered that provides descriptive info about

D18078: [plasma-workspace-wallpapers] Improve wallpaper selection

filipf added a comment. Excellent, thanks for the clarification. Next step is basically what @rooty said then, but I'd try to some more in (not just 5-6). REPOSITORY R131 Plasma Wallpapers REVISION DETAIL https://phabricator.kde.org/D18078 To: filipf, #plasma, #vdg, ngraham Cc:

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

davidre added a comment. Also It looks like this now because of D18737 F6597907: Screenshot_20190207_192144.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18809 To:

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

davidre updated this revision to Diff 51120. davidre added a comment. - remove checkbox stuff REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18809?vs=51088=51120 BRANCH slideshow-grid (branched from master) REVISION DETAIL

D18785: Use different Font Management KCM "All Fonts" icon

GB_2 updated this revision to Diff 51115. GB_2 added a comment. Use new icon "font" REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18785?vs=51032=51115 BRANCH use-different-font-management-all-fonts-icon (branched from master) REVISION DETAIL

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

davidre added a comment. In D18809#407144 , @ngraham wrote: > This looks great! > > I would recommend removing the checkbox feature for now, since that's really a separate thing from the UI overhaul. Then we can get the UI overhaul in first

D18805: Workaround for the bug 393630 - SystemTray part

trmdi added a comment. @davidedmundson Nice approach. I don't really understand the root cause though. So, could you please do it for me? Thank you! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18805 To: trmdi, #plasma, ngraham, broulik,

D18805: Workaround for the bug 393630 - SystemTray part

anthonyfieroni added a comment. Ok, so @trmdi you can apply exactly David suggest and discard D18804 , i've test it and it works. Push it in 5.15 not 5.16 that's bug fix not feature. 5.12 can be also interested path as LTS version. REPOSITORY R120

D18805: Workaround for the bug 393630 - SystemTray part

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. > I really don't know that sharing model between contexts cause a such behavior. Sorry, I used the wrong word. Sharing contexts is fine. Sharing across

D17706: Fix lock screen focus

ngraham added a comment. @andreyby, can you let us know your email address so we can land this with correct authorship information? Thanks! REVISION DETAIL https://phabricator.kde.org/D17706 To: andreyby, davidedmundson Cc: ngraham, graesslin, abetts, davidedmundson, plasma-devel,

D18817: Updated documentation (mention of QQuickControls, link to HIG, IRC channel, supported platforms)

This revision was automatically updated to reflect the committed changes. Closed by commit R169:1dc931ec70c5: Updated documentation (mention of QQuickControls, link to HIG, IRC channel… (authored by colomar). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D18815: Sort setting grid views alphabetically

This revision was automatically updated to reflect the committed changes. Closed by commit R119:6835000906d3: Sort setting grid views alphabetically (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18815?vs=51101=51106 REVISION

D18817: Updated documentation (mention of QQuickControls, link to HIG, IRC channel, supported platforms)

colomar created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. colomar requested review of this revision. REPOSITORY R169 Kirigami BRANCH update-docs (branched from master) REVISION DETAIL https://phabricator.kde.org/D18817 AFFECTED FILES

D18078: [plasma-workspace-wallpapers] Improve wallpaper selection

jriddell added a comment. > We need to ask Unsplash and/or the photographers to release their work into the public domain or if it already is in the public domain to ask for confirmation. Yes the copyright holder needs to give permission to copy it under public domain, CC0, CC-BY-SA or

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

davidedmundson added inline comments. INLINE COMMENTS > image.cpp:909 > +m_uncheckedSlides = uncheckedSlides; > +emit uncheckedSlidesChanged(); > +} You update m_uncheckedSlides but you're not updating m_slideshowBackgrounds so it does nothing till you restart REVISION DETAIL

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

ngraham added a comment. This looks great! I would recommend removing the checkbox feature for now, since that's really a separate thing from the UI overhaul. Then we can get the UI overhaul in first and work on the checkbox part after that. Does that sound like a plan? REVISION DETAIL

D18797: [Tooltips] Use 24px size for children to improve display, just like KInfoCenter

ngraham abandoned this revision. ngraham added a comment. All right, let's go do it. I'll submit the inverse of this patch to KInfoCenter, which will make its tooltips consistent with System Settings. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D18797

D18797: [Tooltips] Use 24px size for children to improve display, just like KInfoCenter

GB_2 added a comment. In D18797#407129 , @ngraham wrote: > So if this isn't an acceptable solution, then what we need to do is remove all the 22px monochrome versions of icons that have colorful 32px-and-larger versions. What I proposed

D18797: [Tooltips] Use 24px size for children to improve display, just like KInfoCenter

ngraham added a comment. So if this isn't an acceptable solution, then what we need to do is remove all the 22px monochrome versions of icons that have colorful 32px-and-larger versions. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D18797 To: ngraham,

D18815: Sort setting grid views alphabetically

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. The wallpaper chooser needs this too FWIW. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18815 To: broulik, #plasma, ngraham Cc: ngraham, plasma-devel,

D18797: [Tooltips] Use 24px size for children to improve display, just like KInfoCenter

broulik added a comment. In D18797#407113 , @ngraham wrote: > Doesn't look terrible with Oxygen icons to me. > F6596120: Screenshot_20190207_074302.png That compositor icon is out of the

D18797: [Tooltips] Use 24px size for children to improve display, just like KInfoCenter

ngraham added a comment. Doesn't look terrible with Oxygen icons to me. Here'w how it //already// looks in KInfoCenter: F6596110: Screenshot_20190207_071231.png And in System Settings with this patch: F6596111: Screenshot_20190207_074128.png

D18815: Sort setting grid views alphabetically

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY BUG: 400404 FIXED-IN: 5.15.1 TEST PLAN - Applying icon theme still works - Icon preview on

D18814: Clarify the label of the Shell KRunner.

vpilo abandoned this revision. vpilo added a comment. In D18814#407090 , @davidedmundson wrote: > What problem are we solving? > > If someone said "in a shell" I would expect to see a terminal (a shell) appear. That's not the case.

D18814: Clarify the label of the Shell KRunner.

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. By making this label long, the available room for the command itself is correspondingly reduced, and this UI already has a limited amount of horizontal space. It's probably

D18814: Clarify the label of the Shell KRunner.

davidedmundson added a comment. What problem are we solving? If someone said "in a shell" I would expect to see a terminal (a shell) appear. That's not the case. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18814 To: vpilo, #vdg, #plasma, ngraham

D18814: Clarify the label of the Shell KRunner.

vpilo added a comment. In D18814#407083 , @davidedmundson wrote: > It already says "Command line" in the group title on the left a console icon and unlike apps has the prefix "Run " "Run %1 in a shell" then? REPOSITORY R120 Plasma

D18814: Clarify the label of the Shell KRunner.

davidedmundson added a comment. It already says "Command line" in the group title on the left a console icon and unlike apps has the prefix "Run " REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18814 To: vpilo, #vdg, #plasma Cc: davidedmundson,

D18814: Clarify the label of the Shell KRunner.

vpilo created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. vpilo requested review of this revision. REVISION SUMMARY This makes sure the end result of the consequence of clicking this runner's results (running a shell command). REPOSITORY R120

Re: Plasma 5.15 tars

Updated tar for better cmake for checking runtime dependencies plasma-pa;Plasma/5.15;6b6e63a0388f3b0813295b565eda8ea003238589;plasma-pa-5.15.0.tar.xz;190a8d2d64227070082127cde98a2a3a91e30b7b16c8fd705b1e18d3cf13074f Jonathan On Thu, 7 Feb 2019 at 11:56, Jonathan Riddell wrote: > > Plasma 5.15

D18807: find volume feedback's runtime requirements

This revision was automatically updated to reflect the committed changes. Closed by commit R115:9cab61adecb1: find volume feedbacks runtime requirements (authored by sitter). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D18807: find volume feedback's runtime requirements

jriddell accepted this revision. jriddell added a comment. This revision is now accepted and ready to land. works good REPOSITORY R115 Plasma Audio Volume Applet BRANCH runtime-deps REVISION DETAIL https://phabricator.kde.org/D18807 To: sitter, jriddell Cc: jriddell, plasma-devel,

D18646: [Colors KCM] Add search and filter

broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in main.qml:129 > why do we need a different approach from the way you've done the clear button? If I could change the left padding of the `ComboBox` button I would have done that and placed an icon ontop. However, since

D18807: find volume feedback's runtime requirements

jriddell added a comment. I've not checked the logic but adding more cmake runtime dep notices is good and can go into Plasma/5.15 branch, I can also update the candidate tar REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D18807 To: sitter Cc:

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

davidre updated this revision to Diff 51088. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18809?vs=51087=51088 REVISION DETAIL https://phabricator.kde.org/D18809 AFFECTED FILES wallpapers/image/CMakeLists.txt wallpapers/image/backgroundlistmodel.h wallpapers/image/image.cpp

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

davidre created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY This shows all the pictures inside the folders added to the Folders list. I also tried to make single pictures excludable via a

D18805: Workaround for the bug 393630 - SystemTray part

anthonyfieroni added a comment. @davidedmundson it works. I really don't know that sharing model between contexts cause a such behavior. It's caused by some ref counting ? Did you know why, it's internal Qt issue that we can fix or it's expected ? REPOSITORY R120 Plasma Workspace

D18807: find volume feedback's runtime requirements

sitter created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY I'm in a good mood so there's even finders! - FindCanberra now also sets the version (this is necessary to hint directories for

Plasma 5.15 tars

Plasma 5.15 tars are available for now packaging from racnoss Release is scheduled for Tuesday http://embra.edinburghlinux.co.uk/~jr/tmp/5.15.0-release-data Jonathan

D18806: bump to cmake requirement to 3.5

sitter created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY kf5 requires 3.5, so plasma-pa effectively does too (this resolves policy deprecation warnings introduced in 3.3) REPOSITORY

KDE CI: Plasma » systemsettings » stable-kf5-qt5 SUSEQt5.12 - Build # 6 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/stable-kf5-qt5%20SUSEQt5.12/6/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Thu, 07 Feb 2019 11:03:38 + Build duration: 24 min and counting CONSOLE OUTPUT

KDE CI: Plasma » powerdevil » stable-kf5-qt5 SUSEQt5.12 - Build # 2 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.12/2/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Thu, 07 Feb 2019 11:03:30 + Build duration: 24 min and counting CONSOLE OUTPUT

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.12 - Build # 7 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.12/7/ Project: stable-kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 07 Feb 2019 11:00:22 + Build duration: 11 min and counting CONSOLE OUTPUT

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 4 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/4/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Thu, 07 Feb 2019 11:00:22 + Build duration: 1 min 59 sec and counting CONSOLE OUTPUT

D18805: Workaround for the bug 393630 - SystemTray part

davidedmundson added a comment. If the only usage is the SNI model lets just rebuild the model on the ConfigEntries side. You're right that sharing objects between contexts seems to cause issues. It's backed by a datasource so all the heavy operations are already implicitly shared.

D18646: [Colors KCM] Add search and filter

davidedmundson added inline comments. INLINE COMMENTS > main.qml:129 > + > +// HACK QQC2 doesn't support icons, so we just tamper with > the desktop style ComboBox's background > +// and inject a nice little filter icon. why do we need a different approach from

D18805: Workaround for the bug 393630 - SystemTray part

trmdi added a comment. In D18805#406916 , @anthonyfieroni wrote: > I notice that something with model goes wrong. I've try to fix it in D18249 but unfortunately I don't see problem in. Does my

Re: Plasma and Qt5.12

On Tue, Feb 5, 2019 at 12:47 PM David Edmundson wrote: > We've agreed that we want Plasma5.16 to depend on Qt5.12. > > Are there any objections to switching master to depend on this? > +1

D18805: Workaround for the bug 393630 - SystemTray part

anthonyfieroni added a comment. I notice that something with model goes wrong. I've try to fix it in D18249 but unfortunately I don't see problem in. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18805 To: trmdi,

Re: Thunderbolt KCM

On Thursday, February 7, 2019 6:22:59 AM CET Rajeesh K V wrote: > First, is this something you Plasma folks would like to have in regular > > > Plasma > > releases, or should I just make it an extragear project? If you think it > > makes > > sense to include it in Plasma, should it go to

D18805: Workaround for the bug 393630 - SystemTray part

trmdi created this revision. trmdi added reviewers: Plasma, ngraham, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REVISION SUMMARY - Require: https://phabricator.kde.org/D18804 BUG: 393630 REPOSITORY R120

D18797: [Tooltips] Use 24px size for children to improve display, just like KInfoCenter

ndavis added a comment. Oh I understand now. These sizes are user configurable. In that case, I suppose it doesn't make sense to add a 24px option and hardcoding is probably fine as long as it's compatible with UI scaling for HiDPI screens. REPOSITORY R124 System Settings REVISION DETAIL

D18797: [Tooltips] Use 24px size for children to improve display, just like KInfoCenter

broulik added a comment. What about non-SVG icon themes like Oxygen? They will look awful when downscaled from 32 to 24. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D18797 To: ngraham, #vdg Cc: broulik, rooty, ndavis, davidedmundson, plasma-devel,