D18892: Move Look and Feel KCM to top level

2019-02-13 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R119:0af980f5cab8: Move Look and Feel KCM to top level (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18892?vs=51301=51642 REVISION DETAIL

D15304: [KCM] Port to QQC2

2019-02-13 Thread Victor Ryzhykh
victorr added a comment. I put this patch on plasma-pa-5.15.80 https://cgit.kde.org/plasma-pa.git/patch/?id=00026cee9ec8c5d04067cf892b46e5a5507b7f6d As a result, the translation disappeared. I have installed a framework-5.55, Plasma-5.15.80. And there was a 100% translation. Where

D15304: [KCM] Port to QQC2

2019-02-13 Thread Nathaniel Graham
ngraham added a comment. What you're looking at was not touched in this patch. This patch only changed the category below it. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D15304 To: ngraham, #plasma, drosca Cc: victorr, apol, huftis,

D15304: [KCM] Port to QQC2

2019-02-13 Thread Victor Ryzhykh
victorr added a comment. Now the translation does not work. The current untranslatable (Russian locale): F6614010: plasma-pa.jpeg REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D15304 To: ngraham,

D18903: Make Appearance KCMs' labels consistent

2019-02-13 Thread Krešimir Čohar
This revision was automatically updated to reflect the committed changes. Closed by commit R119:089612d232fd: Make Appearance KCMs labels consistent (authored by filipf, committed by rooty). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D18991: [containment] Show an inline message when the Desktop Toolbox is hidden

2019-02-13 Thread Nathaniel Graham
ngraham created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Currently, when the Desktop Toolbox is hidden, the only way to return to the containment configuration window is by

D18990: [containment] Modernize tweaks page layout and port to QQC2

2019-02-13 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: VDG, Plasma, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Port the page to QQC2 and modernize the layout, using modern Kirigami APIs This

D18903: Make Appearance KCMs' labels consistent

2019-02-13 Thread David Edmundson
davidedmundson added a comment. +1 from my side. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D18903 To: filipf, GB_2, #vdg, ngraham, #plasma Cc: davidedmundson, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,

D18892: Move Look and Feel KCM to top level

2019-02-13 Thread David Edmundson
davidedmundson added a comment. Go for it REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18892 To: GB_2, #plasma, #vdg, rooty, ngraham, davidedmundson, abetts Cc: ngraham, davidedmundson, abetts, rooty, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen,

D18892: Move Look and Feel KCM to top level

2019-02-13 Thread Björn Feber
GB_2 added a comment. Ping? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18892 To: GB_2, #plasma, #vdg, rooty, ngraham, davidedmundson, abetts Cc: ngraham, davidedmundson, abetts, rooty, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel,

D18903: Make Appearance KCMs' labels consistent

2019-02-13 Thread Filip Fila
filipf added a comment. In D18903#411590 , @ngraham wrote: > BTW could you explain the changes in more detail in the Summary section? Sure, just did that now. Sounds pretty technical but I think it summarizes everything done here.

D18903: Make Appearance KCMs' labels consistent

2019-02-13 Thread Nathaniel Graham
ngraham added a comment. BTW could you explain the changes in more detail in the Summary section? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18903 To: filipf, GB_2, #vdg, ngraham, #plasma Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel,

D18903: Make Appearance KCMs' labels consistent

2019-02-13 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. Looking good to me now! I notice that the font installation and Emoticons KCMs display the comment rather than the KAboutData string in their headers, but this is a bug unrelated to your patch. Still, we should figure out what's

D18903: Make Appearance KCMs' labels consistent

2019-02-13 Thread Filip Fila
filipf updated this revision to Diff 51616. filipf added a comment. get rid of articles, better wording REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18903?vs=51602=51616 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18903

D18939: KMenuEdit: add search/filter bar

2019-02-13 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Weird. Well, this look good to me from a UX and basic code sanity check perspective, so I'll hand it over to other folks to do the more in-depth code review now. Thanks for the

D18939: KMenuEdit: add search/filter bar

2019-02-13 Thread Aidan Sojourner
tuxxi added a comment. In D18939#411450 , @ngraham wrote: > If you use a blank QWidget, you won't have to do that `setContentsMargin()` workaround, right? I actually tried this first, I was surprised when the plain `QWidget` still had

D18976: Improve Contextmenu

2019-02-13 Thread Michail Vourlakos
This revision was automatically updated to reflect the committed changes. Closed by commit R878:c893ab3d2281: Improve Contextmenu (authored by trmdi, committed by mvourlakos). REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18976?vs=51613=51615 REVISION

D18976: Improve Contextmenu

2019-02-13 Thread Tranter Madi
trmdi updated this revision to Diff 51613. REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18976?vs=51573=51613 REVISION DETAIL https://phabricator.kde.org/D18976 AFFECTED FILES containmentactions/contextmenu/menu.cpp To: trmdi, #latte_dock,

D18903: Make Appearance KCMs' labels consistent

2019-02-13 Thread Björn Feber
GB_2 added a comment. Oops REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18903 To: filipf, GB_2, #vdg, ngraham, #plasma Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: Plasma 5.16 Kickoff Meeting poll

2019-02-13 Thread Jonathan Riddell
New poll https://doodle.com/poll/tx5e78cqqcgnqtzd the old one had mistakes in the times with 12 am vs pm no need to fill it out if you correctly worked around that before Jonathan On Mon, 11 Feb 2019 at 22:57, Jonathan Riddell wrote: > > Plasma 5.16 Kickoff Meeting poll >

D18903: Make Appearance KCMs' labels consistent

2019-02-13 Thread Björn Feber
GB_2 accepted this revision. GB_2 added a comment. In D18903#411538 , @ngraham wrote: > In D18903#411529 , @filipf wrote: > > > For this patch (and moving forward) we still have 2 dilemmas left then:

D18976: Improve Contextmenu

2019-02-13 Thread Michail Vourlakos
mvourlakos added a comment. In D18976#411537 , @trmdi wrote: > Oh, wait... > I've just seen it is disabled unexpectedly. Do you know why ? yes, it comes from the setVisible(false) I dont know why, this is why I wanted to add in

D18903: Make Appearance KCMs' labels consistent

2019-02-13 Thread Nathaniel Graham
ngraham added a comment. In D18903#411529 , @filipf wrote: > For this patch (and moving forward) we still have 2 dilemmas left then: > > - remove the article -> "Configure system fonts" instead of "Configure the system fonts"? My

D18976: Improve Contextmenu

2019-02-13 Thread Tranter Madi
trmdi added a comment. Oh, wait... I've just seen it is disabled unexpectedly. Do you know why ? REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D18976 To: trmdi, #latte_dock, mvourlakos Cc: mvourlakos, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot,

D18903: Make Appearance KCMs' labels consistent

2019-02-13 Thread Filip Fila
filipf added a comment. In D18903#411528 , @ngraham wrote: > Perfect. This strikes me as the exactly correct way to do it: The `KAboutData` string shows a real title, and the `Comment` provides the tooltip text. Can we do this for the few

D18903: Make Appearance KCMs' labels consistent

2019-02-13 Thread Nathaniel Graham
ngraham added a comment. Perfect. This strikes me as the exactly correct way to do it: The `KAboutData` string shows a real title, and the `Comment` provides the tooltip text. Can we do this for the few remaining KCMs in the appearance section too? Looks like there's a bug in the font

D18859: cdb: First working version

2019-02-13 Thread Tomaz Canabrava
tcanabrava added inline comments. INLINE COMMENTS > tcanabrava wrote in backtraceparsercdb.h:31 > remove virtual, override. still missing the override. > tcanabrava wrote in backtraceparsercdb.h:34 > remove virtual, override. still missing the override. REPOSITORY R871 DrKonqi REVISION

D18983: Use the python version found by cmake in build_theme.sh

2019-02-13 Thread Heiko Becker
heikobecker created this revision. heikobecker added a reviewer: Build System. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. heikobecker requested review of this revision. REVISION SUMMARY Helpful if one has multiple python3 versions around. TEST PLAN builds fine

D18903: Make Appearance KCMs' labels consistent

2019-02-13 Thread Filip Fila
filipf updated this revision to Diff 51602. filipf added a comment. KAboutData i18n is the same as Name REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18903?vs=51601=51602 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18903

D18903: Make Appearance KCMs' labels consistent

2019-02-13 Thread Filip Fila
filipf updated this revision to Diff 51601. filipf added a comment. . REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18903?vs=51600=51601 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18903 AFFECTED FILES

D18903: Make Appearance KCMs' labels consistent

2019-02-13 Thread Filip Fila
filipf updated this revision to Diff 51600. filipf added a comment. . REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18903?vs=51598=51600 BRANCH 516-appearance-header-labels (branched from master) REVISION DETAIL

D18903: Make Appearance KCMs' labels consistent

2019-02-13 Thread Filip Fila
filipf updated this revision to Diff 51598. filipf added a comment. try to fix it? REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18903?vs=51597=51598 BRANCH 516-appearance-header-labels (branched from master) REVISION DETAIL

D18903: Make Appearance KCMs' labels consistent

2019-02-13 Thread Filip Fila
filipf added a comment. Bah sorry, it pulled in some other non-related changes as well. Will fix if I figure out how or open up a new diff. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18903 To: filipf, GB_2, #vdg, ngraham, #plasma Cc: broulik,

D18903: Make Appearance KCMs' labels consistent

2019-02-13 Thread Filip Fila
filipf updated this revision to Diff 51597. filipf added a comment. use verb style headers REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18903?vs=51329=51597 BRANCH 516-appearance-header-labels (branched from master) REVISION DETAIL

D18939: KMenuEdit: add search/filter bar

2019-02-13 Thread Nathaniel Graham
ngraham added a comment. If you use a blank QWidget, you won't have to do that `setContentsMargin()` workaround, right? REPOSITORY R103 KMenu Editor REVISION DETAIL https://phabricator.kde.org/D18939 To: tuxxi, ngraham, #plasma, cfeck Cc: mlaurent, ngraham, plasma-devel, jraleigh,

D15304: [KCM] Port to QQC2

2019-02-13 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R115:00026cee9ec8: [KCM] Port to QQC2 (authored by ngraham). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15304?vs=51557=51595 REVISION DETAIL

Plasma 5.14.5.1 updates

2019-02-13 Thread Jonathan Riddell
Plasma team have released some updates to 5.14. 5.14 has reached the end of its release cycle but some distros are still planning to ship it and may want to use these updated tars. discover-5.14.5.1.tar.xz tag baac08a40851699585e80b0a226c4fd683579a7b sha256

D18979: foldermodel: store information about screen used

2019-02-13 Thread Oleg Solovyov
McPain requested review of this revision. McPain added a comment. Seems like I can't use distinct screen mapping for each activity yet REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18979 To: McPain, broulik, sebas Cc: plasma-devel, jraleigh, GB_2, ragreen,

D18979: foldermodel: store information about screen used

2019-02-13 Thread Oleg Solovyov
McPain created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. McPain requested review of this revision. REVISION SUMMARY BUG: 401464 According to FolderModel::filterAcceptsRow code, it is possible that folderview is used by containment but not

plasma-pa 5.12.7.1 update

2019-02-13 Thread Jonathan Riddell
plasma-pa 5.12.7.1 is a minor bugfix update tar to Plasma 5.12.7 LTS to fix an issue with Qt 5.12 https://www.kde.org/info/plasma-5.12.7.php plasma-pa;Plasma/5.12;3b3b8c3d60e48db47d7b86e61f351bac03fd57b7;plasma-pa-5.12.7.1.tar.xz;ba444690f1999b9867905087a0f1779e5b299de24d9fea3a85ac0d16eaa82f7e

D18976: Improve Contextmenu

2019-02-13 Thread Tranter Madi
trmdi updated this revision to Diff 51573. REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18976?vs=51563=51573 REVISION DETAIL https://phabricator.kde.org/D18976 AFFECTED FILES containmentactions/contextmenu/menu.cpp To: trmdi, #latte_dock Cc: