D19036: [notifications] Lift up notification content if one line of body text droops

anthonyfieroni added inline comments. INLINE COMMENTS > NotificationItem.qml:34-47 > +if (bodyText.lineCount > 1) { > +return mainLayout.height > +} else { > +if (appIconItem.valid || imageItem.nativeWidth > 0) { > +return

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.12 - Build # 113 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.12/113/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 16 Feb 2019 04:46:43 + Build duration: 18 min and counting CONSOLE OUTPUT [...truncated 2653

KDE CI: Plasma » breeze » kf5-qt5 FreeBSDQt5.12 - Build # 15 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/breeze/job/kf5-qt5%20FreeBSDQt5.12/15/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 16 Feb 2019 04:45:57 + Build duration: 14 min and counting

D19036: [notifications] Lift up notification content if one line of body text droops

rooty added a comment. Okay, it works now and it uses if then else syntax (and a teeny tiny unintrusive ternary operator :D) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19036 To: rooty, #plasma, #vdg, broulik, ngraham Cc: filipf, ngraham, abetts,

D19036: [notifications] Lift up notification content if one line of body text droops

rooty updated this revision to Diff 51823. rooty added a comment. Fix bug, simplify REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19036?vs=51777=51823 BRANCH lift-up-noto (branched from master) REVISION DETAIL

D19064: Add break to fix tty information

apol added a comment. +1 I'd say so too. REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D19064 To: aacid Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D19036: [notifications] Lift up notification content if one line of body text droops

rooty requested review of this revision. rooty added a comment. There's a bug here that arises if I use the if-then-else syntax F6617956: image.png If I use the ternary operator this doesn't happen F6617962: image.png

D19070: Use AuthCore instead of Auth

aacid created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. aacid requested review of this revision. REVISION SUMMARY It's a smaller library and contains everything we need TEST PLAN Compiles REPOSITORY R128 User Manager BRANCH master REVISION

D19069: Use AuthCore instead of Auth

aacid updated this revision to Diff 51816. aacid added a comment. also update the KF5 requirement REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19069?vs=51815=51816 BRANCH arcpatch-D19069 REVISION DETAIL

D19069: Use AuthCore instead of Auth

aacid created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. aacid requested review of this revision. REVISION SUMMARY It's a smaller library and provides everything we need TEST PLAN Compiles REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH

D19068: Use AuthCore instead Auth

aacid created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. aacid requested review of this revision. REVISION SUMMARY It's a smaller library and provides everything we need TEST PLAN Compiles REPOSITORY R258 Plymouth KCM BRANCH master REVISION

D19067: Use AuthCore instead of Auth

aacid created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. aacid requested review of this revision. REVISION SUMMARY is a smaller library and provides all we need TEST PLAN Compiles REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL

D19066: Link to AuthCore instead of Auth

aacid created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. aacid requested review of this revision. REVISION SUMMARY Is a smaller library and provides everything we need REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL

D19064: Add break to fix tty information

aacid created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. aacid requested review of this revision. REVISION SUMMARY I'm not confident i understand the code, but without the break the value of ps->setTty is always overwritten, so i guess we need this?

D19036: [notifications] Lift up notification content if one line of body text droops

rooty added a comment. Sure thing. Hopefully it'll also close the bug now that I've adjusted my settings haha REPOSITORY R120 Plasma Workspace BRANCH lift-up-noto (branched from master) REVISION DETAIL https://phabricator.kde.org/D19036 To: rooty, #plasma, #vdg, broulik, ngraham

D19063: Use AuthCore instead of Auth

aacid added a subscriber: kdevelop-devel. aacid added a comment. KDevelope people the comment says to ask you too about it REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D19063 To: aacid Cc: kdevelop-devel, plasma-devel, jraleigh, GB_2, ragreen, Pitel,

D19063: Use AuthCore instead of Auth

aacid created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. aacid requested review of this revision. REVISION SUMMARY Gives us what we need and has less dependencies TEST PLAN Compiles REPOSITORY R111 KSysguard Library BRANCH master REVISION

D19062: Link against AuthCore instead of Auth

aacid created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. aacid requested review of this revision. REVISION SUMMARY It's a smaller library and provides everything we need TEST PLAN Compiles REPOSITORY R134 Discover Software Store BRANCH

D19013: [plasma-pa] Increase minimum size of expanded plasmoid

vpilo added a comment. In D19013#413022 , @ngraham wrote: > How about even bigger? In standalone form, there's no reason to skimp on size IMO. Thought there was some constraint :) I'll go crazy and say 18. REPOSITORY R115 Plasma Audio

D19050: [sddm-theme] Change "Type User" to "Other..."

rooty updated this revision to Diff 51788. rooty added a comment. Use i18ndc REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19050?vs=51786=51788 BRANCH other-label (branched from master) REVISION DETAIL https://phabricator.kde.org/D19050

D19050: [sddm-theme] Change "Type User" to "Other..."

rooty added a comment. In D19050#413024 , @ngraham wrote: > Well, you have to actually add the context. :) > > Like this: `text: i18ndc("plasma_lookandfeel_org.kde.lookandfeel", "For logging in as an arbitrary user", "Other...")`

D19055: Use the new KAuthCore

aacid created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. aacid requested review of this revision. REVISION SUMMARY Doesn't link to QtWidgets link KAuth does, which is unneeded for the helpers TEST PLAN Compiles REPOSITORY R122 Powerdevil

D19036: [notifications] Lift up notification content if one line of body text droops

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Code and behavior look good to me but I'd like @broulik or another #plasma person's review before landing this, please. Also, if and when

D19050: [sddm-theme] Change "Type User" to "Other..."

rooty updated this revision to Diff 51789. rooty added a comment. Add context REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19050?vs=51788=51789 BRANCH other-label (branched from master) REVISION DETAIL https://phabricator.kde.org/D19050

KDE CI: Plasma » breeze » kf5-qt5 FreeBSDQt5.12 - Build # 14 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/breeze/job/kf5-qt5%20FreeBSDQt5.12/14/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 15 Feb 2019 18:35:23 + Build duration: 2 hr 0 min and counting CONSOLE OUTPUT [...truncated

D19013: [plasma-pa] Increase minimum size of expanded plasmoid

abetts added a comment. +1 REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D19013 To: vpilo, #plasma, broulik, drosca Cc: abetts, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol,

D19050: [sddm-theme] Change "Type User" to "Other..."

This revision was automatically updated to reflect the committed changes. Closed by commit R120:ed20b9e3d4c9: [sddm-theme] Change Type User to Other... (authored by rooty). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19050?vs=51790=51791 REVISION

D19050: [sddm-theme] Change "Type User" to "Other..."

rooty added a comment. is this description ok? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19050 To: rooty, #vdg, ngraham Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19050: [sddm-theme] Change "Type User" to "Other..."

rooty updated this revision to Diff 51790. rooty added a comment. Fix typo REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19050?vs=51789=51790 BRANCH other-label (branched from master) REVISION DETAIL https://phabricator.kde.org/D19050

D19014: [plasma-pa] Add command to switch all applications to the selected device

ngraham added a comment. +1, a very nice feature. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D19014 To: vpilo, #plasma, broulik, drosca Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D19050: [sddm-theme] Change "Type User" to "Other..."

ngraham added a comment. Well, you have to actually add the context. :) Like this: `text: i18ndc("plasma_lookandfeel_org.kde.lookandfeel", "For logging in as an arbitrary user", "Other...")` REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19050 To:

D19013: [plasma-pa] Increase minimum size of expanded plasmoid

ngraham added a comment. How about even bigger? In standalone form, there's no reason to skimp on size IMO. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D19013 To: vpilo, #plasma, broulik, drosca Cc: ngraham, plasma-devel, jraleigh, GB_2,

D19050: [sddm-theme] Change "Type User" to "Other..."

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Single word-strings need context for translators. Please use `i18ndc()` REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19050 To: rooty,

D19050: [sddm-theme] Change "Type User" to "Other..."

rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH other-label (branched from master) REVISION DETAIL https://phabricator.kde.org/D19050 AFFECTED FILES

D19046: Make Breeze theme tooltip texts consistent and rename Breeze Snow cursors to Breeze Light

This revision was automatically updated to reflect the committed changes. Closed by commit R31:1befbfed8bbe: Make Breeze theme tooltip texts consistent and rename Breeze Snow cursors to… (authored by GB_2). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE

D19046: Make Breeze theme tooltip texts consistent and rename Breeze Snow cursors to Breeze Light

GB_2 updated this revision to Diff 51781. GB_2 added a comment. Fix comment REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19046?vs=51780=51781 BRANCH make-breeze-theme-tooltip-texts--consistent-and-rename-breeze-snow-cursors-to-breeze-light (branched

D19046: Make Breeze theme tooltip texts consistent and rename Breeze Snow cursors to Breeze Light

GB_2 added inline comments. INLINE COMMENTS > ngraham wrote in index.theme:46 > `Comment=Comment=Breeze`? :) Oops, haha REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D19046 To: GB_2, #plasma, #vdg, ngraham Cc: ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2,

D19046: Make Breeze theme tooltip texts consistent and rename Breeze Snow cursors to Breeze Light

ngraham requested changes to this revision. ngraham added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > index.theme:46 > Name[zh_TW]=Breeze > -Comment=KDE Plasma Cursor Theme > +Comment=Comment=Breeze by the KDE VDG > Comment[ar]=سمة مؤشّر بلازما كدي

D17217: Implement free memory notifier

davidedmundson added a comment. > It would just be nice not to have to think about this stuff Well that's the point. You're only going to run out of memory on a working system if you have a runaway process. There is an OOM killer. That OOM killer is faster than a human, has access to

D19046: Make Breeze theme tooltip texts consistent and rename Breeze Snow cursors to Breeze Light

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Improve wording and make texts consistent with others. TEST PLAN Open the Curors KCM and hover over

D19038: Make Appearance KCM tooltip texts consistent

This revision was automatically updated to reflect the committed changes. Closed by commit R119:6eb834d7: Make Appearance KCM tooltip texts consistent (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19038?vs=51761=51778 REVISION

D19036: [notifications] Lift up notification content if one line of body text droops

rooty added a comment. In D19036#412936 , @rooty wrote: > Actually use if-then-else instead of ternary operator My apologies guys I forgot to copy the file to the working copy REPOSITORY R120 Plasma Workspace REVISION DETAIL

D19036: [notifications] Lift up notification content if one line of body text droops

rooty updated this revision to Diff 51777. rooty added a comment. Actually use if-then-else instead of ternary operator REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19036?vs=51775=51777 BRANCH lift-up-noto (branched from master) REVISION

D18999: Remove ignored style properties from CSS

This revision was automatically updated to reflect the committed changes. Closed by commit R98:7687c366c69f: Remove ignored style properties from CSS (authored by andrzej1_1, committed by ngraham). REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE

D19036: [notifications] Lift up notification content if one line of body text droops

rooty updated this revision to Diff 51775. rooty added a comment. Use if-then-else instead of ternary operator for implicitHeight REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19036?vs=51756=51775 BRANCH lift-up-noto (branched from master)

D17217: Implement free memory notifier

rooty added a comment. In D17217#412918 , @ngraham wrote: > If it's not enabled by default like the free space notifier is, I'm okay with shipping this. I totally agree, it shouldn't be enabled by default REVISION DETAIL

D19044: [InlineMessage] Do not draw shadows around the message

ngraham accepted this revision as: VDG, ngraham. ngraham added a comment. This revision is now accepted and ready to land. +1 for all the reasons you gave! REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D19044 To: filipf, #vdg, #kirigami, ngraham

D17217: Implement free memory notifier

ngraham resigned from this revision. ngraham added a comment. If it's not enabled by default like the free space notifier is, I'm okay with shipping this. REVISION DETAIL https://phabricator.kde.org/D17217 To: McPain, broulik, #vdg Cc: rooty, davidedmundson, graesslin, abetts, ngraham,

D18999: Remove ignored style properties from CSS

ngraham accepted this revision. ngraham added a comment. Thanks, fixed now. Will land this. Thanks again for the contribution! REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D18999 To: andrzej1_1, #breeze, ngraham Cc: ngraham, plasma-devel, jraleigh, GB_2,

D19044: [InlineMessage] Do not draw shadows around the message

filipf created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY This patch removes InlineMessage's DropShadow for the following reasons: 1. consistency - there are no shadows in QWidgets'

D19036: [notifications] Lift up notification content if one line of body text droops

ngraham added a comment. Yes, clarity is always more important than conciseness with code. Code will be read many many more times than written, so it's always of paramount importance that it can be understood. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D18999: Remove ignored style properties from CSS

andrzej1_1 updated this revision to Diff 51773. andrzej1_1 added a comment. @ngraham Sorry, I made some mistake when generating new patch. This one should be correct. REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18999?vs=51720=51773 REVISION

D19036: [notifications] Lift up notification content if one line of body text droops

rooty added a comment. @ngraham I don't understand, should I use that instead of the ternary operator in the diff qml? It looks a lot tidier. But it's actually 23 lines (versus just one really long one :D) REPOSITORY R120 Plasma Workspace REVISION DETAIL

D18999: Remove ignored style properties from CSS

ngraham added a comment. With this latest version, I still see one warning: $ pavucontrol (pavucontrol:6494): Gtk-WARNING **: 09:45:33.717: Theme parsing error: gtk.css:71:30: The style property GtkExpander:expander-size is deprecated and shouldn't be used anymore. It will

D19036: [notifications] Lift up notification content if one line of body text droops

rooty added a comment. In D19036#412890 , @ngraham wrote: > Here, like this: > > function adjustHeight() > { > var layoutHeight = mainLayout.height > if (bodyText.lineCount > 1) { > layoutHeight =

D17217: Implement free memory notifier

rooty added a comment. Let me just say that I realize that this is pretty niche, but I would find it extremely useful and a lot of thought and care seem to have gone into this, hence +1. In D17217#412888 , @ngraham wrote: > In

D19036: [notifications] Lift up notification content if one line of body text droops

ngraham added a comment. Here, like this: function adjustHeight() { var layoutHeight = mainLayout.height if (bodyText.lineCount > 1) { layoutHeight = mainLayout.height } else { if (appIconItem.valid || imageItem.nativeWidth > 0) {

D19043: Fix warning

apol created this revision. apol added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY lib64/qml/org/kde/kirigami.2/private/ActionButton.qml:269: TypeError: Cannot read property 'a' of

D19036: [notifications] Lift up notification content if one line of body text droops

rooty added a comment. In D19036#412876 , @ngraham wrote: > The lines below an `if` or `else` are always indented. function adjustHeight() { var layoutHeight = mainLayout.height if (bodyText.lineCount > 1) {

D17217: Implement free memory notifier

ngraham added a comment. In D17217#412463 , @rooty wrote: > have OOM problems In D17217#412463 , @rooty wrote: > dislike swap space Erm, I think I may have found your problem.

D19036: [notifications] Lift up notification content if one line of body text droops

filipf added a comment. Nice, this patch makes it look better for me. Before: F6616985: image.png After: F6616988: image.png REPOSITORY R120 Plasma Workspace REVISION DETAIL

D19036: [notifications] Lift up notification content if one line of body text droops

rooty added a comment. In D19036#412855 , @filipf wrote: > Nice, this patch makes it look better for me. > > Before: > F6616985: image.png > > After: > F6616988: image.png

D19036: [notifications] Lift up notification content if one line of body text droops

ngraham added a comment. In D19036#412851 , @rooty wrote: > How's this? > > function adjustHeight() > { > var layoutHeight = mainLayout.height > if (bodyText.lineCount > 1) { > layoutHeight =

D19042: Fix warning when using QQuickAction

apol created this revision. apol added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY QQuickAction doesn't seem to have a parent property TEST PLAN Now I don't get a warning REPOSITORY

D19040: Remove some unnecessary QString constructions

apol updated this revision to Diff 51767. apol added a comment. More concise REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19040?vs=51766=51767 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19040 AFFECTED FILES src/settings.cpp To:

D19040: Remove some unnecessary QString constructions

apol updated this revision to Diff 51766. apol added a comment. wops REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19040?vs=51765=51766 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19040 AFFECTED FILES src/settings.cpp To: apol,

D19040: Remove some unnecessary QString constructions

apol created this revision. apol added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D19040 AFFECTED FILES

D19036: [notifications] Lift up notification content if one line of body text droops

rooty added a comment. In D19036#412830 , @ngraham wrote: > Can you use the typical KDE coding style for if/else blocks? How's this? function adjustHeight() { var layoutHeight = mainLayout.height if

D19033: [about-distro] run absolute paths through qicon intead of qpixmap

ngraham added a comment. The issue Kai is worried about is https://bugreports.qt.io/browse/QTBUG-63187. If we're not hitting that bug here, we need to understand why, or else there's a chance that the logo will not appear. REPOSITORY R102 KInfoCenter REVISION DETAIL

D19036: [notifications] Lift up notification content if one line of body text droops

ngraham added a comment. In D19036#412809 , @rooty wrote: > I hope I didn't mess up the syntax... Do you prefer this to the ternary operator? > > function adjustHeight() > { > var layoutHeight = mainLayout.height > if

D19036: [notifications] Lift up notification content if one line of body text droops

rooty marked 3 inline comments as done. rooty added a comment. I hope I didn't mess up the syntax... function adjustHeight() { var layoutHeight = mainLayout.height if (bodyText.lineCount > 1) { layoutHeight = mainLayout.height } else if

5.16 Kickoff Meeting Tuesday 19 middayUTC, 13:00CET

Meeting at midday on Tuesday UTC, 13:00CET in #plasma to discuss Plasma 5.16 plans Jonathan

D19011: Thunderbolt KCM and KDED module

ngraham added a comment. In D19011#412803 , @abetts wrote: > I believe the list of devices should be in a white box. There should also be a couple of controls at the bottom right of the box containing the devices. @ngraham Is that right?

D19011: Thunderbolt KCM and KDED module

abetts added subscribers: ngraham, fabianr, abetts. abetts added a comment. I believe the list of devices should be in a white box. There should also be a couple of controls at the bottom right of the box containing the devices. @ngraham Is that right? @fabianr ? REPOSITORY R119 Plasma

D19038: Make Appearance KCM tooltip texts consistent

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Improve wording and add an ellipsis where needed in tooltips in Appearance KCMs. TEST PLAN Open

D19036: [notifications] Lift up notification content if one line of body text droops

abetts added a comment. +1 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19036 To: rooty, #plasma, #vdg Cc: abetts, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19036: [notifications] Lift up notification content if one line of body text droops

rooty marked an inline comment as done. rooty added inline comments. INLINE COMMENTS > broulik wrote in NotificationItem.qml:175 > Is `smallSpacing` always even? That's the idea yes REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19036 To: rooty, #plasma,

D19036: [notifications] Lift up notification content if one line of body text droops

broulik added inline comments. INLINE COMMENTS > NotificationItem.qml:33 > width: parent.width > -implicitHeight: bodyText.lineCount > 1 ? mainLayout.height : > (appIconItem.valid || imageItem.nativeWidth > 0 ? > (Math.max((mainLayout.height + 2 *

D18859: cdb: First working version

cfeck added a comment. > This patch introduces support to CDB, providing useful backtraces in bug tickets created through DrKonqi on windows. Just noticed this. This will help a lot to get better crash reports for our Windows ports. Thanks! REPOSITORY R871 DrKonqi REVISION DETAIL

D19021: [Digital Clock] Fix 24h tri-state button broken in port to QQC2

Zren closed this revision. Zren added a comment. Shoot, I accidentally forgot the Phab Rev link in the commit message (though I remembered the bugzilla tags). I've setup a `.git/hook/prepare-commit-msg` -like thing for Sublime Text to

D19036: [notifications] Lift up notification content if one line of body text droops (improve padding)

rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REVISION SUMMARY This patch lifts up the text content of notifications in which the combination of a single line of body text and its heading are

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.12 - Build # 112 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.12/112/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 15 Feb 2019 13:52:21 + Build duration: 3 min 7 sec and counting CONSOLE OUTPUT [...truncated

D18859: cdb: First working version

This revision was automatically updated to reflect the committed changes. patrickelectric marked 2 inline comments as done. Closed by commit R871:a32ec5e298a4: cdb: First working version (authored by patrickelectric). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE

D19024: Exclude powerdevil from session management

This revision was automatically updated to reflect the committed changes. Closed by commit R122:b8a44a4cc87a: Exclude powerdevil from session management (authored by davidedmundson). REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19024?vs=51723=51752

D19025: Exclude kscreen backend launcher from session management

This revision was automatically updated to reflect the committed changes. Closed by commit R110:ee3f33ba4925: Exclude kscreen backend launcher from session management (authored by davidedmundson). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE

D18859: cdb: First working version

patrickelectric updated this revision to Diff 51750. patrickelectric added a comment. Add missing override REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18859?vs=51518=51750 BRANCH arcpatch-D18859 REVISION DETAIL https://phabricator.kde.org/D18859

D19026: Exclude kuiserver from session management

This revision was automatically updated to reflect the committed changes. Closed by commit R120:9d7d80134ea6: Exclude kuiserver from session management (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19026?vs=51725=51747

D19028: [ksmserver] Restore legacy sessions

This revision was automatically updated to reflect the committed changes. Closed by commit R120:b4ddae947936: [ksmserver] Restore legacy sessions (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19028?vs=51728=51748

D19033: [about-distro] run absolute paths through qicon intead of qpixmap

sitter added a comment. works fine here REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D19033 To: sitter, #plasma Cc: broulik, cfeck, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19033: [about-distro] run absolute paths through qicon intead of qpixmap

broulik added a comment. isn't `QIcon::fromTheme` buggy when passed an absolute path to an SVG file? REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D19033 To: sitter, #plasma Cc: broulik, cfeck, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,

D19033: [about-distro] run absolute paths through qicon intead of qpixmap

sitter updated this revision to Diff 51741. sitter added a comment. throw away the comment. upon reflection I actually find it unnecessary REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19033?vs=51740=51741 BRANCH Plasma/5.15 REVISION DETAIL

D19033: [about-distro] run absolute paths through qicon intead of qpixmap

sitter added a comment. Well, it won't resolve the path, it will simply load it. I do see the ambiguity though. ;) REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D19033 To: sitter, #plasma Cc: cfeck, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot,

D19033: [about-distro] run absolute paths through qicon intead of qpixmap

cfeck added a comment. The comment is confusing. If QIcon does not resolve absolute paths, but I can stil pass absolute paths, the comment could say that it ignores the path? Shouldn't this comment rather be part of the README, instead of the code? REPOSITORY R102 KInfoCenter REVISION

D19033: [about-distro] run absolute paths through qicon intead of qpixmap

sitter created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY qicon::fromtheme internally skips resolution of absolute paths and instead simply opens it by path. so, simplify the code by only

D19011: Thunderbolt KCM and KDED module

dvratil added inline comments. INLINE COMMENTS > broulik wrote in DeviceList.qml:11 > You might want to be using a `ScrollViewKCM` and put the enable checkbox in > the `header` and the `ListView` in `view`, see for instance KWin's virtual > desktop KCM Hmm, but then I couldn't push the device

D19011: Thunderbolt KCM and KDED module

dvratil updated this revision to Diff 51737. dvratil marked 9 inline comments as done. dvratil added a comment. - Fixed typos - Unified license - Addresses comments from kbroulik REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D19011: Thunderbolt KCM and KDED module

broulik added inline comments. INLINE COMMENTS > DeviceList.qml:11 > + > +Kirigami.Page { > +id: page You might want to be using a `ScrollViewKCM` and put the enable checkbox in the `header` and the `ListView` in `view`, see for instance KWin's virtual desktop KCM > DeviceList.qml:29 > +