D18646: [Colors KCM] Add search and filter

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. LGTM aside from the minor naming nitpick. INLINE COMMENTS > filterproxymodel.cpp:31 > + > +void FilterProxyModel::setSourceModelProxy(QAbstractItemModel *sourceModel) > +{ Why did you call

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.12 - Build # 104 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.12/104/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 19 Feb 2019 05:41:25 + Build duration: 1 min 29 sec and counting CONSOLE OUTPUT

D19148: Add ShadowVerySmall, linear shadow sizes and set Medium as default size

ndavis added a comment. In D19148#415123 , @rooty wrote: > I like this idea, more variety > Especially considering that the default setting doesn't really change, just gets renamed essentially? Not quite. Very Small is about the same

D19148: Add ShadowVerySmall, linear shadow sizes and set Medium as default size

rooty added a comment. I like this idea, more variety Especially considering that the default setting doesn't really change, just gets renamed essentially? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D19148 To: ndavis, #vdg, #breeze Cc: rooty, plasma-devel,

D19148: Add ShadowVerySmall, linear shadow sizes and set Medium as default size

ndavis created this revision. ndavis added reviewers: VDG, Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ndavis requested review of this revision. REVISION SUMMARY Before, shadow size doubled with each new size until Very Large and the smaller shadows were

D19148: Add ShadowVerySmall, linear shadow sizes and set Medium as default size

ndavis updated this revision to Diff 52036. ndavis added a comment. Change default shadow size to medium REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19148?vs=52035=52036 BRANCH shadow-sizes (branched from master) REVISION DETAIL

D19135: DelegateRecycler: Fix translation using the wrong domain

aacid created this revision. aacid added a reviewer: mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. aacid requested review of this revision. REVISION SUMMARY Use first KLocalizedContext as contextObject instead of the root one This way when there's a stack

D19134: Multiply radius by 0.5 in calculateBlurStdDev()

zzag added a comment. Please revert this change. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D19134 To: ndavis, #breeze, ngraham Cc: zzag, davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D19134: Multiply radius by 0.5 in calculateBlurStdDev()

davidedmundson added a comment. > so in order to not break existing shadow So won't this break existing shadow parameters? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D19134 To: ndavis, #breeze, ngraham Cc: davidedmundson, ngraham, plasma-devel, jraleigh,

D19126: block screen filtering for global menu applet

davidedmundson added a comment. > For example if the user has set different scale factors between its screens is it going to work? It will not, but there is no UI option for that. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19126 To: mvourlakos,

D19134: Multiply radius by 0.5 in calculateBlurStdDev()

This revision was automatically updated to reflect the committed changes. Closed by commit R31:cd04f42432a6: Multiply radius by 0.5 in calculateBlurStdDev() (authored by ndavis). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19134?vs=52016=52020 REVISION

D19134: Multiply radius by 0.5 in calculateBlurStdDev()

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Makes sense to do this while we're tweaking the appearance of the shadows for 5.16 anyway. REPOSITORY R31 Breeze BRANCH shadow-sizes (branched from master) REVISION DETAIL

D19044: [InlineMessage] Do not draw shadows around the message

ndavis added a comment. TBH, I like the shadow. Breeze as a widget theme tends to be a bit too flat. Here's how it looks with Breeze Dark.F6622189: Screenshot_20190218_172518.png REPOSITORY R169 Kirigami REVISION DETAIL

D19077: WIP: Fix long labels not being wrapped

filipf updated this revision to Diff 52018. filipf added a comment. go back to Rectangle as root REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19077?vs=51932=52018 BRANCH master REVISION DETAIL

D19134: Multiply radius by 0.5 in calculateBlurStdDev

ndavis created this revision. ndavis added a reviewer: Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ndavis requested review of this revision. REVISION SUMMARY Fix TODO to follow w3.org standard for shadow-blur REPOSITORY R31 Breeze BRANCH shadow-sizes

D19126: block screen filtering for global menu applet

mvourlakos added a comment. In D19126#414920 , @davidedmundson wrote: > If we're going to put in code, lets do: > > QPoint windowCentre = info.geometry().center(); > if (KWindowSystem::isPlatformX11()) { > windowCenter /=

D19126: block screen filtering for global menu applet

davidedmundson added a comment. If we're going to put in code, lets do: QPoint windowCentre = info.geometry().center(); if (KWindowSystem::isPlatformX11()) { windowCenter /= qApp->scale(); } I closed the bug because I was quite angry at the user randomly setting

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.12 - Build # 103 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.12/103/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 18 Feb 2019 20:50:15 + Build duration: 43 sec and counting CONSOLE OUTPUT

D19129: [sddm-theme] Apply new username prompt and user list icons

This revision was automatically updated to reflect the committed changes. Closed by commit R120:8ee8ca17290e: [sddm-theme] Apply new username prompt and user list icons (authored by rooty). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D18939: KMenuEdit: add search/filter bar

cfeck added inline comments. INLINE COMMENTS > kmenuedit.h:60 > QSplitter *m_splitter = nullptr; > +KTreeWidgetSearchLine* m_searchLine = nullptr; > Surrounding code uses `Type *var`. > treeview.cpp:1924 > +// expand all categories if we typed more than a few characters, >

D19129: [sddm-theme] Apply new username prompt and user list icons

filipf accepted this revision. filipf added a comment. This revision is now accepted and ready to land. +1 REPOSITORY R120 Plasma Workspace BRANCH apply-new-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D19129 To: rooty, #vdg, #plasma, ngraham, filipf Cc:

D19129: [sddm-theme] Apply new username prompt and user list icons

rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REVISION SUMMARY This patch applies the icons added in D19020 to the Breeze SDDM theme. REPOSITORY R120 Plasma

D19126: block screen filtering for global menu applet

mvourlakos created this revision. mvourlakos added reviewers: Plasma, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mvourlakos requested review of this revision. REVISION SUMMARY --when the user has enabled PLASMA_USE_QT_SCALING under X11 environment

D19125: Change shadow color to 0,0,0 for KStyle

This revision was automatically updated to reflect the committed changes. Closed by commit R31:3e78fa28585e: Change shadow color to 0,0,0 for KStyle (authored by ndavis). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19125?vs=51995=51998 REVISION DETAIL

D19125: Change shadow color to 0,0,0 for KStyle

ndavis added a comment. In D19125#414786 , @zzag wrote: > Should we adjust opacity as well? That's the strength value, right? I don't think so. REPOSITORY R31 Breeze BRANCH black-shadow (branched from master) REVISION DETAIL

D19125: Change shadow color to 0,0,0 for KStyle

ndavis added a comment. In D19125#414788 , @ngraham wrote: > Nah, I think that would begin to re-introduce the bug we're trying to solve (shadows not being visible in Breeze Dark). Also, worse color banding on cheap displays REPOSITORY

D19125: Change shadow color to 0,0,0 for KStyle

ngraham added a comment. Nah, I think that would begin to re-introduce the bug we're trying to solve (shadows not being visible in Breeze Dark). REPOSITORY R31 Breeze BRANCH black-shadow (branched from master) REVISION DETAIL https://phabricator.kde.org/D19125 To: ndavis, #vdg,

D19125: Change shadow color to 0,0,0 for KStyle

zzag added a comment. Should we adjust opacity as well? REPOSITORY R31 Breeze BRANCH black-shadow (branched from master) REVISION DETAIL https://phabricator.kde.org/D19125 To: ndavis, #vdg, #breeze, ngraham, zzag Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,

D19125: Change shadow color to 0,0,0 for KStyle

ndavis created this revision. ndavis added reviewers: VDG, Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ndavis requested review of this revision. REVISION SUMMARY Continuation of D19124 REPOSITORY R31 Breeze BRANCH

D19124: Change shadow color to 0,0,0

ndavis added a comment. alright REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D19124 To: ndavis, #vdg, ngraham, filipf Cc: zzag, filipf, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D19124: Change shadow color to 0,0,0

ngraham added a comment. Ah yes, gotta make the same change in `kstyle/breeze.kcfg` too. @ndavis can you do that? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D19124 To: ndavis, #vdg, ngraham, filipf Cc: zzag, filipf, ngraham, plasma-devel, jraleigh, GB_2, ragreen,

D19124: Change shadow color to 0,0,0

zzag added a comment. What about kstyle? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D19124 To: ndavis, #vdg, ngraham, filipf Cc: zzag, filipf, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D19124: Change shadow color to 0,0,0

This revision was automatically updated to reflect the committed changes. Closed by commit R31:dce32ce1e0ed: Change shadow color to 0,0,0 (authored by ndavis). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19124?vs=51989=51991 REVISION DETAIL

D19124: Change shadow color to 0,0,0

filipf accepted this revision. filipf added a comment. Another big +1 for all the reasons already mentioned. REPOSITORY R31 Breeze BRANCH black-shadow (branched from master) REVISION DETAIL https://phabricator.kde.org/D19124 To: ndavis, #vdg, ngraham, filipf Cc: filipf, ngraham,

D19124: Change shadow color to 0,0,0

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. I changed this from black to Shade Black as a compromise to get https://cgit.kde.org/breeze.git/commit/?id=9fb5d3abb18cde0ef63102cb06f1a936152ccaef done and I think we have to consider

D19124: Change shadow color to 0,0,0

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ndavis requested review of this revision. REVISION SUMMARY The current shadow color is Shade Black, which is also used as the ViewBackground color in Breeze

D19096: Increase the label's area to display 2 lines of text when needed

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Very nice! This fixes the bug and the code change looks sane. @hein are you good with this? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19096 To:

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.12 - Build # 107 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.12/107/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 18 Feb 2019 17:12:49 + Build duration: 53 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.12 - Build # 106 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.12/106/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 18 Feb 2019 17:10:09 + Build duration: 1 min 23 sec and counting CONSOLE OUTPUT

D19093: Improve the look of the Emoticons KCM UI

This revision was automatically updated to reflect the committed changes. Closed by commit R119:8b413729da44: Improve the look of the Emoticons KCM UI (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19093?vs=51978=51979 REVISION

D19093: Improve the look of the Emoticons KCM UI

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. +1 shipit! REPOSITORY R119 Plasma Desktop BRANCH improve-look-of-emoticons-kcm-ui (branched from master) REVISION DETAIL https://phabricator.kde.org/D19093 To: GB_2, #plasma,

D19093: Improve the look of the Emoticons KCM UI

GB_2 updated this revision to Diff 51978. GB_2 added a comment. Address comments REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19093?vs=51905=51978 BRANCH improve-look-of-emoticons-kcm-ui (branched from master) REVISION DETAIL

KDE CI: Plasma » discover » kf5-qt5 FreeBSDQt5.12 - Build # 40 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20FreeBSDQt5.12/40/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 18 Feb 2019 16:39:04 + Build duration: 1 min 47 sec and counting CONSOLE OUTPUT

D19077: WIP: Fix long labels not being wrapped

filipf added a comment. In D19077#414283 , @abetts wrote: > Just added some visual adjustments (mockup) > > F6620598: Screen Shot 2019-02-17 at 4.56.46 PM.png Thanks! I like all the adjustments.

D19077: WIP: Fix long labels not being wrapped

ngraham added a comment. Very much against adding a scrollbar into the preview area. I think we can come up with a better solution. REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D19077 To: filipf, #plasma, #vdg, ngraham Cc: abetts, rooty,

D19119: ApplicationPage: include the available version when selecting the source

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. This change would make the version number show up first in the string, assigning it primary visual importance. This would make the name of the dropdown menu ("Sources")

D19119: ApplicationPage: include the available version when selecting the source

apol created this revision. apol added a reviewer: Discover Software Store. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY A source will often have different versions of the same software. REPOSITORY R134

KDE CI: Plasma » discover » kf5-qt5 FreeBSDQt5.12 - Build # 39 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20FreeBSDQt5.12/39/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 18 Feb 2019 15:25:40 + Build duration: 1 min 50 sec and counting CONSOLE OUTPUT

D16886: [windowswitcher] Implement keyboard navigation

ngraham added a comment. Yes, that one already works in Plasma 5.15. All of them should now work with keyboard navigation, in fact. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16886 To: ngraham, #plasma, graesslin Cc: abetts, szafar, davidedmundson,

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.12 - Build # 117 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.12/117/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 18 Feb 2019 14:29:40 + Build duration: 4 min 18 sec and counting CONSOLE OUTPUT [...truncated

D19044: [InlineMessage] Do not draw shadows around the message

ngraham added a comment. In D19044#414479 , @mart wrote: > -1 > this has to be done at most for the desktop style and the desktop style only Can you explain a bit more? I don't understand the technical reason for why you think we

D19042: Fix warning when using QQuickAction

This revision was automatically updated to reflect the committed changes. Closed by commit R169:c503e0df3cfc: Fix warning when using QQuickAction (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19042?vs=51769=51962 REVISION DETAIL

D19040: Remove some unnecessary QString constructions

This revision was automatically updated to reflect the committed changes. Closed by commit R169:fc04142750c5: Remove some unnecessary QString constructions (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19040?vs=51767=51961 REVISION

D19043: Fix warning

This revision was automatically updated to reflect the committed changes. Closed by commit R169:9951b7913f3b: Fix warning (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19043?vs=51770=51960 REVISION DETAIL

D18189: Fix ComboBox

apol closed this revision. apol added a comment. This was fixed subsequently. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D18189 To: apol, #kirigami, mart Cc: broulik, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel,

D19110: Don't show the tooltip when the drop-down menu is shown

This revision was automatically updated to reflect the committed changes. Closed by commit R169:368ed3bf3df8: Dont show the tooltip when the drop-down menu is shown (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19110?vs=51937=51959

D18938: Show assigned shortcut in drawer action delegates

mart requested changes to this revision. mart added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > GlobalDrawerActionItem.qml:102 > +Layout.alignment: Qt.AlignVCenter | Qt.AlignRight > +visible: modelData.__shortcut.enabled &&

D19044: [InlineMessage] Do not draw shadows around the message

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. -1 this has to be done at most for the desktop style and the desktop style only REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D19044 To: filipf, #vdg,

D19118: Add (and use) a LinkLabel component

leinir created this revision. leinir added reviewers: apol, ngraham, Discover Software Store. leinir added a project: Discover Software Store. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. leinir requested review of this revision. REVISION SUMMARY The component, which

D19033: [about-distro] run absolute paths through qicon intead of qpixmap

sitter added a comment. If I understand it correctly, the bug would only show its ugly head with `QIcon::fromTheme("foo.svg")` but not `QIcon::fromTheme("foo")`. So, if that seems a concern we can just add a comment in the README. Distribution devs would set LogoPath's value manually, so we

Re: Breeze Dark theme question ?

On lunedì 18 febbraio 2019 08:57:55 CET Kai Uwe Broulik wrote: > Hi, > > I assume you're refering to the blue line when expanding an applet. That > one is only shown if it comes from the current theme to avoid issues > when using older Plasma 4 themes that don't expect this item to be used > in

Notes for 18/2/2019 monday meeting

David: * working on replacing libkworkspace * There's a branch davidedmundson/kworkspace2 which I'll update in a bit, everything is sooo much tidier. * documented my plans on phabricator under that ksmserver splitting task https://phabricator.kde.org/T9779 * fixed a regression in ksmserver Kai