Re: Plasma Sprint 2019 in València

Hi, Sounds like we have some critical mass, Alejandro tells me that there's space so let's settle for the 23rd June week. Is Wednesday, 19 Arrival day and Sunday, 23 Departure day, or actual sprint days? Cheers Kai Uwe

D19312: Add tooltip for quick search

simgunz added a comment. I never landed a diff before because I just got my KDE developer account. Few general questions: - Is it enough that one reviewer accept the revision, or all the listed ones should accept it? (or depends on the project?) - Can I directly land it once the

D19409: [sddm-theme/lock screen] Adjust login and lock screen blur

rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH adjust-blur (branched from master) REVISION DETAIL https://phabricator.kde.org/D19409 AFFECTED FILES

D19369: [sddm-theme] Remove login screen blur effect

rooty added a comment. In D19369#421581 , @ngraham wrote: > Much prettier than the current blur! Thanks, the transition is pretty awesome too now that the blur's less dim REPOSITORY R120 Plasma Workspace REVISION DETAIL

KDE CI: Plasma » powerdevil » stable-kf5-qt5 SUSEQt5.12 - Build # 8 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.12/8/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Thu, 28 Feb 2019 07:07:01 + Build duration: 10 min and counting JUnit Tests Name: (root)

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 10 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/10/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Thu, 28 Feb 2019 07:07:03 + Build duration: 9 min 8 sec and counting JUnit Tests

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.12 - Build # 13 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.12/13/ Project: stable-kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 28 Feb 2019 07:07:04 + Build duration: 3 min 17 sec and counting JUnit Tests

KDE CI: Plasma » systemsettings » stable-kf5-qt5 SUSEQt5.12 - Build # 12 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/stable-kf5-qt5%20SUSEQt5.12/12/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Thu, 28 Feb 2019 07:07:00 + Build duration: 3 min 15 sec and counting JUnit Tests

D19369: [sddm-theme] Remove login screen blur effect

ngraham added a comment. Much prettier than the current blur! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19369 To: rooty, #vdg, #plasma, filipf, ngraham, davidedmundson Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot,

D19391: Remove pointless inner layout

This revision was automatically updated to reflect the committed changes. Closed by commit R119:43804eb7f15f: Remove superfluous inner layout (authored by davidedmundson). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19391?vs=52741=52785 REVISION

D19064: Add break to fix tty information

This revision was automatically updated to reflect the committed changes. Closed by commit R111:dcb0901e5438: Add break to fix tty information (authored by aacid). REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19064?vs=51810=52784 REVISION DETAIL

D19369: [sddm-theme] Remove login screen blur effect

rooty added a comment. In D19369#421477 , @ngraham wrote: > In D19369#421378 , @davidedmundson wrote: > > > This makes it different to the lock screen. I said in the last patch that did this that

D19064: Add break to fix tty information

aacid added a comment. If noone disagrees i'll commit this next week REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D19064 To: aacid Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D19369: [sddm-theme] Remove login screen blur effect

ngraham added a comment. In D19369#421378 , @davidedmundson wrote: > This makes it different to the lock screen. I said in the last patch that did this that we shouldn't do that. I don't think this is applicable since the lock screen is

D19369: [sddm-theme] Remove login screen blur effect

rooty added a comment. In D19369#421405 , @davidedmundson wrote: > RE: blur > > To do it the same way that patch did it in the end (Using sRGB textures) would require a Qt patch. That would magically fix all shaders. I've not tried, but it

Re: Plasma Sprint 2019 in València

On Wed, Feb 27, 2019 at 4:19 PM Nate Graham wrote: > > On Wed, 27 Feb 2019 08:17:21 -0700 Eike Hein wrote > > > > > > On 2/27/19 7:49 AM, Aleix Pol wrote: > > > Hi, > > > It seems like the best dates are the week of the 23rd. Should we lock > > > the dates between the 19th and

D19011: Thunderbolt KCM and KDED module

dvratil updated this revision to Diff 52775. dvratil added a comment. - Use colors in device status indicators REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19011?vs=52593=52775 BRANCH arcpatch-D19011 REVISION DETAIL

D19399: SwipeListItem: make space for the actions when !supportsMouseEvents

apol updated this revision to Diff 52773. apol added a comment. Show test REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19399?vs=52772=52773 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19399 AFFECTED FILES

D19399: SwipeListItem: make space for the actions when !supportsMouseEvents

apol created this revision. apol added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY They will be shown all the time and we don't want the content over it CCBUG: 404755 REPOSITORY

D19392: shannon entropy to guess monochrome icon

cfeck added inline comments. INLINE COMMENTS > desktopicon.cpp:522 > +//don't try for too big images > +if (img.width() > 256 || m_theme->supportsIconColoring()) { > +return false; Did you mean `>= 256`? > desktopicon.cpp:545 > +if (findIt !=

D19369: [sddm-theme] Remove login screen blur effect

davidedmundson added a comment. RE: blur To do it the same way that patch did it in the end (Using sRGB textures) would require a Qt patch. That would magically fix all shaders. I've not tried, but it certainly looks feasible. (Patch QSGMaterial to have a flag to push/pop

D19372: [sddm-theme] Enlarge user avatar in focus

filipf added a comment. In D19372#421381 , @davidedmundson wrote: > Heh, I'm sure some old SDDM (maybe even LightDM) theme did that. There was a whole Carousel system. Our old SDDM theme

D19369: [sddm-theme] Remove login screen blur effect

rooty added a comment. P.S. @davidedmundson I know this may not be the place to ask this, in regard to the blur/wallpaper fader, is it possible to implement the changes from D18377 in the wallpaper fader? Is that something I could file a report with Qt

D19372: [sddm-theme] Enlarge user avatar in focus

abetts added a comment. In D19372#421386 , @rooty wrote: > In D19372#421381 , @davidedmundson wrote: > > > Heh, I'm sure some old SDDM (maybe even LightDM) theme did that. There was a whole

D19372: [sddm-theme] Enlarge user avatar in focus

rooty added a comment. In D19372#421381 , @davidedmundson wrote: > Heh, I'm sure some old SDDM (maybe even LightDM) theme did that. There was a whole Carousel system. I'm not sold on this idea :D I'm just worried it'll come out tacky

D19369: [sddm-theme] Remove login screen blur effect

rooty added a comment. In D19369#421378 , @davidedmundson wrote: > This makes it different to the lock screen. I said in the last patch that did this that we shouldn't do that. I can't believe I'm going to walk back my original argument

D19230: [Digital Clock] Replace 12/24hr tri-state checkbox in config UI with combobox

abetts added a comment. In D19230#421336 , @ngraham wrote: > Sounds good. What should the string be? "Use region's default setting"? > > F6643429: Screenshot_20190227_114945.png Yes, I am with

D19372: [sddm-theme] Enlarge user avatar in focus

davidedmundson added a comment. Heh, I'm sure some old SDDM (maybe even LightDM) theme did that. There was a whole Carousel system. If you do animate, generally I've found that animating width won't do what you want, it'll cause the text to re-lay out and that looks weird. Using

D19369: [sddm-theme] Remove login screen blur effect

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. This makes it different to the lock screen. I said in the last patch that did this that we shouldn't do that. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D19379: [sddm-theme] Add a bottom panel

filipf planned changes to this revision. filipf added a comment. In D19379#421197 , @abetts wrote: > I can help with defining how they can look in the center? That would be of great help, please do. I agree there could be better

D19369: [sddm-theme] Remove login screen blur effect

rooty added a comment. In D19369#421370 , @ngraham wrote: > Yep, looks great now! Let's wait to land this until all the dependent patches are approved too. Sure thing REPOSITORY R120 Plasma Workspace BRANCH no-more-blur (branched

D19369: [sddm-theme] Remove login screen blur effect

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Yep, looks great now! Let's wait to land this until all the dependent patches are approved too. REPOSITORY R120 Plasma Workspace BRANCH no-more-blur (branched from master) REVISION

D19364: [sddm-theme/lock screen] Add shadows to action buttons

ngraham added a comment. In D19364#421341 , @rooty wrote: > In D19364#421161 , @ngraham wrote: > > > Yep, needs an outline instead of a shadow when using software rendering, just like the other

D19372: [sddm-theme] Enlarge user avatar in focus

rooty added a comment. In D19372#421170 , @ngraham wrote: > Hmm, that's a shame. Well, regardless of implementation, I'd like to see //some// form of animation when the size changes. :) But it looks very smooth already. It's choppy in

D19369: [sddm-theme] Remove login screen blur effect

rooty added a comment. In D19369#421353 , @rooty wrote: > Bring back timer Better? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19369 To: rooty, #vdg, #plasma, filipf, ngraham Cc: plasma-devel,

D19369: [sddm-theme] Remove login screen blur effect

rooty updated this revision to Diff 52766. rooty marked 2 inline comments as done. rooty added a comment. Bring back timer REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19369?vs=52684=52766 BRANCH no-more-blur (branched from master) REVISION

D19369: [sddm-theme] Remove login screen blur effect

rooty marked an inline comment as done. rooty added inline comments. INLINE COMMENTS > ngraham wrote in Main.qml:136 > I'm not sure this removal is necessary or related to this patch. We might be > able to remove it anyway, if its fixed in 0.14 like the comment says, but > that should be in a

D19364: [sddm-theme/lock screen] Add shadows to action buttons

rooty added a comment. In D19364#421161 , @ngraham wrote: > Yep, needs an outline instead of a shadow when using software rendering, just like the other text with shadows. I'll add an outline sure > Another thing is that in my

D19391: Remove pointless inner layout

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Yep. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D19391 To: davidedmundson, #plasma, ngraham Cc: ngraham, plasma-devel, jraleigh,

D19230: [Digital Clock] Replace 12/24hr tri-state checkbox in config UI with combobox

ngraham added a comment. Sounds good. What should the string be? "Use region's default setting"? F6643429: Screenshot_20190227_114945.png REPOSITORY R120 Plasma Workspace BRANCH replace-tristate-checkbox-with-combobox (branched from master)

D19370: [sddm-theme] Add circles behind action buttons

ngraham added a comment. Oh one more thing: the `ActionButton` component is also used in the logout screen. Does this look good there too when the background is dark, or does it become kind of muddy? The way we solved this in the old version was by adding a light-colored outline around

D19394: Show a warning if a plugin requires a newer version

This revision was automatically updated to reflect the committed changes. Closed by commit R242:02ec1b77c23e: Show a warning if a plugin requires a newer version (authored by fvogt). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D19394: Show a warning if a plugin requires a newer version

fvogt created this revision. fvogt added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. fvogt requested review of this revision. REVISION SUMMARY Currently it just fails silently. TEST PLAN Loaded a plasmoid with an incompatible

D19392: shannon entropy to guess monochrome icon

mart added a comment. the final visual problem is that often i get people complaining are things like icons in a menu or in a list view that have here and there a colored breeze icon that became an unrecognizable black splorch or the opposite problem, a monochrome black icon that is

D19392: shannon entropy to guess monochrome icon

mart added a comment. > Can you elaborate on the problem we're trying to fix. so, when we have KiconLoader (ie using the desktop style and we can rely on kf5 dependencies) to colorize icons we use our stylesheet-based color replacement in svgs and everything is always awesome:

D19392: shannon entropy to guess monochrome icon

davidedmundson added a comment. Can you elaborate on the problem we're trying to fix. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D19392 To: mart, #kirigami Cc: davidedmundson, plasma-devel, domson, dkardarakos, apol, mart, hein

D19392: shannon entropy to guess monochrome icon

mart created this revision. mart added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY since we can't directly access the svg file, when we can't use KIconLoader try to detect monochrome

D19230: [Digital Clock] Replace 12/24hr tri-state checkbox in config UI with combobox

abetts added a comment. In D19230#421229 , @ndavis wrote: > In D19230#421215 , @abetts wrote: > > > Do you think that "locale" is a very specific term? Could it be different? > > > The

D19391: Remove pointless inner layout

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY This lays out the label "Cursor:" to be aligned with the first entry.

D19230: [Digital Clock] Replace 12/24hr tri-state checkbox in config UI with combobox

ndavis added a comment. In D19230#421215 , @abetts wrote: > Do you think that "locale" is a very specific term? Could it be different? The alternative would be "region", which is the term we use in the related settings KCM.F6643106:

D19230: [Digital Clock] Replace 12/24hr tri-state checkbox in config UI with combobox

ndavis accepted this revision. ndavis added a comment. +1 This is a much more usable design and more in line with our HIG. REPOSITORY R120 Plasma Workspace BRANCH replace-tristate-checkbox-with-combobox (branched from master) REVISION DETAIL https://phabricator.kde.org/D19230

D19389: [WIP] Rewrite kworkspace logout, shutdown and suspend API

davidedmundson updated this revision to Diff 52736. davidedmundson added a comment. update one line REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19389?vs=52733=52736 BRANCH davidedmundson/kworkspace2 REVISION DETAIL

D19230: [Digital Clock] Replace 12/24hr tri-state checkbox in config UI with combobox

abetts added a comment. Do you think that "locale" is a very specific term? Could it be different? REPOSITORY R120 Plasma Workspace BRANCH replace-tristate-checkbox-with-combobox (branched from master) REVISION DETAIL https://phabricator.kde.org/D19230 To: ngraham, #plasma, Zren,

D19390: adjust the size of the window after the labels sizes were changed

sitter created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY during backtrace loading the widgets get mutated a lot, changing their size to very long, or very short, but certainly different

Re: Plasma Sprint 2019 in València

On Wed, 27 Feb 2019 08:17:21 -0700 Eike Hein wrote > > > On 2/27/19 7:49 AM, Aleix Pol wrote: > > Hi, > > It seems like the best dates are the week of the 23rd. Should we lock > > the dates between the 19th and 26th? > > Then we can open the reimbursements request and

D19379: [sddm-theme] Add a bottom panel

abetts added a comment. Back in the day, when I proposed changes to these elements, I put them on the center. People said that it looked crowded, boring, etc... However, my reasoning was because the selections are too far in the corners. It wasn't a problem with smaller older screens but it

D19230: [Digital Clock] Replace 12/24hr tri-state checkbox in config UI with combobox

ngraham added a comment. Ping! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19230 To: ngraham, #plasma, Zren, #vdg Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: Plasma Sprint 2019 in València

On 2/27/19 7:49 AM, Aleix Pol wrote: Hi, It seems like the best dates are the week of the 23rd. Should we lock the dates between the 19th and 26th? Then we can open the reimbursements request and start looking into where to stay. +1 Aleix Cheers, Eike

D19389: [WIP] Rewrite kworkspace logout, shutdown and suspend API

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY The old code path is old and even sometimes uses the ICE protocol to start

D19184: [Kicker, Kickoff & Dash] Use the word "Sleep" instead of "Suspend"

This revision was automatically updated to reflect the committed changes. Closed by commit R119:360b565d8cab: [Kicker, Kickoff Dash] Use the word Sleep instead of Suspend (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D19186: [KCM & UI] Use the word "Sleep" instead of "Suspend"

This revision was automatically updated to reflect the committed changes. Closed by commit R122:7ba43d4767f6: [KCM UI] Use the word Sleep instead of Suspend (authored by ngraham). REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19186?vs=52242=52732

D19185: [KRunner, SDDM theme, Logout screen, Login widget] Use the word "Sleep" instead of "Suspend"

This revision was automatically updated to reflect the committed changes. Closed by commit R120:952411732200: [KRunner, SDDM theme, Logout screen, Login widget] Use the word Sleep instead… (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D19369: [sddm-theme] Remove login screen blur effect

ngraham added a comment. Almost there! INLINE COMMENTS > Main.qml:136 > - > -Timer { > -//SDDM has a bug in 0.13 where even though we set the focus > on the right item within the window, the window doesn't have focus I'm not sure this removal is necessary or

D19379: [sddm-theme] Add a bottom panel

ndavis added a comment. In D19379#421001 , @rooty wrote: > Center how? Vertically? > Where would the elements be placed (with respect to the Clock / user names/avatars / action buttons)? Horizontally and maybe vertically. They could

D19372: [sddm-theme] Enlarge user avatar in focus

ngraham added a comment. Hmm, that's a shame. Well, regardless of implementation, I'd like to see //some// form of animation when the size changes. :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19372 To: rooty, #vdg, ngraham Cc: abetts, filipf,

Re: kwin_wayland window decoration

thanks. glad to hear that kwin wont rely on XDG_CURRENT_DESKTOP=KDE default deco: https://blog.qt.io/blog/2018/12/14/whats-new-wayland-platform-plugin-qt-5-12/ On Wed, Feb 27, 2019 at 4:09 PM David Edmundson wrote: > > Kwin will decorate the window if and only if the client tells it to. > >

D19364: [sddm-theme/lock screen] Add shadows to action buttons

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Yep, needs an outline instead of a shadow when using software rendering, just like the other text with shadows. Another thing is that in my previous attempt at this, I made

D19325: [sddm-theme/lock screen] Tighten clock and username shadows

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Very classy. I think this is a nice improvement. REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D19325 REVISION DETAIL https://phabricator.kde.org/D19325 To: rooty, #vdg,

D19370: [sddm-theme] Add circles behind action buttons

ngraham added inline comments. INLINE COMMENTS > ActionButton.qml:46 > +color: PlasmaCore.ColorScope.backgroundColor > +opacity: ( containsMouse || activeFocus ) ? 1 : 0.9 > +} How about 0.9 and 0.7? REPOSITORY R120 Plasma Workspace REVISION DETAIL

D19379: [sddm-theme] Add a bottom panel

ngraham added a comment. The bottom panel was always my least favorite element of my previous design and I share others' reservations. +1 for the idea of making these more like the actionbuttons, and putting them closer to the center of the UI with their own backgrounds. REPOSITORY R120

Re: kwin_wayland window decoration

Kwin will decorate the window if and only if the client tells it to. With Qt < 5.12 this was injected by plasma-integration plugin which relies on those XDG_CURRENT_DESKTOP For Qt >= 5.12 (with latest plasma) it will work out the box without plasma-integration For GTK apps you will need the

kwin_wayland window decoration

Hello, I don't know if this is the correct list to use (I subscribe to one called k...@kde.org - the archives of it are empty). I am trying a 'slim' wayland-session, I do see an issue, the session starts this: /usr/bin/kwin_wayland --xwayland --libinput konsole It would get the default wayland

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

davidre added a comment. In D18809#419441 , @davidedmundson wrote: > I have a sequence that breaks. > > Add /opt/kde5/share/wallpapers > Add /opt/kde5/share/wallpapers/Cascade > > (weirdly this last one now lists every size

D19340: Search new knsrc locations

leinir updated this revision to Diff 52713. leinir marked an inline comment as done. leinir added a comment. Don't search fallback locations - we're trying to avoid crashes, so unless people update their installation locations, they don't get Discovered:tm: ;) REPOSITORY R134 Discover

D19382: port to ECM's FindCanberra

sitter created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY - bump required kf5 version to 5.56 - use new VERSION var in FindCanberraPulse - use new imported target when linking TEST PLAN

D19381: search our cmake dir first

sitter created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY if we search our dir last we risk not being forwards compatible with ECM. specific current example: FindCanberra is now also in

D19379: [sddm-theme] Add a bottom panel

rooty added a comment. In D19379#421018 , @broulik wrote: > I would prefer something less intrusive like a gradient. > > > wouldn't it be better to move them towards the center? > > People not finding the keyboard layout button and other

D19379: [sddm-theme] Add a bottom panel

broulik added a comment. I would prefer something less intrusive like a gradient. > wouldn't it be better to move them towards the center? People not finding the keyboard layout button and other controls tucked in the corners came up a lot in the past, so that could be a good idea.

D19340: Search new knsrc locations

leinir marked an inline comment as done. leinir added inline comments. INLINE COMMENTS > apol wrote in KNSBackend.cpp:69 > Discover should probably not fallback, i.e. pass false as an argument. > Otherwise the problem will persist. > > This is Plasma 5.16 and by then we should have all

D19364: [sddm-theme/lock screen] Add shadows to action buttons

rooty added a comment. In D19364#420865 , @filipf wrote: > Will let Nate verify that the outline patch has been done well here, but otherwise looks good. Wait but I haven't added outlines, just shadows... Should I add outlines for

D19379: [sddm-theme] Add a bottom panel

rooty added a comment. In D19379#420988 , @ndavis wrote: > -1 > > I don't think it looks very nice. If you're worried about those UI elements not being visible, wouldn't it be better to move them towards the center? Then, if it's necessary,

D19379: [sddm-theme] Add a bottom panel

ndavis added a comment. -1 I don't think it looks very nice. If you're worried about those UI elements not being visible, wouldn't it be better to move them towards the center? Then, if it's necessary, you can add a background to all the floating UI elements so that they're all