D19309: Improve Unity Indicator

trmdi added a comment. In D19309#422634 , @mvourlakos wrote: > @trmdi do you have commit access? > > If not you can apply for one and you can reference me I tried it, but not sure if/when they will accept it. So could you please lan

D19434: Change entry of Endpoint UI

andersonbruce added a comment. In D19434#423458 , @jgrulich wrote: > Shouldn't we maybe use QSpinBox for the port? With the spinbox you can also set min and max values so you don't need to validate it. My preference is to only use a spinb

D19479: [SDDM theme] Add visual feedback when hovering over action buttons

rooty added a comment. Actually this works on the logout screen too, at least on my setup: F6651424: simplescreenrecorder-2019-03-03_04.21.58.mp4 REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D194

D19372: [sddm-theme] Enlarge user avatar in focus

rooty added a comment. P.S. Should we use "live: true" or just delete the line? Because it's true by default, but this makes it clear that it shouldn't be live: false REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19372 To: rooty, #vdg, ngraham Cc: davided

D19372: [sddm-theme] Enlarge user avatar in focus

rooty updated this revision to Diff 53030. rooty added a comment. Prevent user avatar in focus from becoming blurred REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19372?vs=53028&id=53030 BRANCH arcpatch-D19372 REVISION DETAIL https://phabric

D19186: [KCM & UI] Use the word "Sleep" instead of "Suspend"

aspotashev added a comment. Hi Nate, You missed this one at daemon/actions/bundled/suspendsessionconfig.cpp:88: m_comboBox->addItem(QIcon::fromTheme("system-suspend-hybrid"), i18n("Hybrid suspend"), (uint)SuspendSession::SuspendHybridMode); REPOSITORY R122 Powerdevil REVISION D

D19372: [sddm-theme] Enlarge user avatar in focus

rooty updated this revision to Diff 53028. rooty added a comment. Rebase; add property animation REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19372?vs=52683&id=53028 BRANCH arcpatch-D19372 REVISION DETAIL https://phabricator.kde.org/D19372

D19372: [sddm-theme] Enlarge user avatar in focus

rooty added a comment. In D19372#421391 , @filipf wrote: > In D19372#421381 , @davidedmundson wrote: > > > Heh, I'm sure some old SDDM (maybe even LightDM) theme did that. There was a whole Carousel

D19301: Use Kirigami.ActionTextField for the SearchField

ognarb added a comment. In D19301#423523 , @ngraham wrote: > Also it would be nice to port Discover itself to use this. I'm not sure, I understand your comment. What do you mean with this? Discover already implement the actionSearchField.

D19479: [SDDM theme] Add opacity on hover to action buttons

filipf updated this revision to Diff 53027. filipf added a comment. Add circle with animation in preparation for changes in the logout screen REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19479?vs=53026&id=53027 BRANCH master REVISION DETAIL

D19479: [SDDM theme] Add opacity on hover to action buttons

filipf updated this revision to Diff 53026. filipf added a comment. For now copy the OpacityAnimator from LogoutButton.qml REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19479?vs=53010&id=53026 BRANCH master REVISION DETAIL https://phabricato

D19301: Use Kirigami.ActionTextField for the SearchField

ngraham added a comment. Also it would be nice to port Discover itself to use this. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D19301 To: ognarb, #discover_software_store, ngraham Cc: ngraham, apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, Zr

D19479: [SDDM theme] Add opacity on hover to action buttons

filipf added a comment. In D19479#423518 , @ngraham wrote: > That sounds suspiciously like my approach in D16034 that we decided not to implement. :) Yep, it's more or less the same, but the background

D19479: [SDDM theme] Add opacity on hover to action buttons

ngraham added a comment. That sounds suspiciously like my approach in D16034 that we decided not to implement. :) REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D19479 To: filipf, rooty, ngraham, #vdg, #

D19479: [SDDM theme] Add opacity on hover to action buttons

filipf added a comment. Okay so the logout screen is the bigger issue, I propose we make icons with the equivalent of: color: PlasmaCore.ColorScope.textColor // because doing backgroundColor would add little to no contrast, unless we add a light border opacity: 0.15 or 0.2 They wo

D19479: [SDDM theme] Add opacity on hover to action buttons

filipf added a comment. Very interesting and tricky issue which we should try to solve. Two differences between the logout screen and SDDM though: the former is darker. (unlike 5.15, in master it now fades to pitch black, bug?) That's why it allows for the opacity of unselected items to

D16034: Improve logout screen button appearance and contrast

ngraham abandoned this revision. ngraham added a comment. We're going in another direction with this. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16034 To: ngraham, #vdg, #plasma, mart Cc: mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesl

D19478: [Login, Lock, and Logout Screen] Make the avatar background circle more subtle

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. This is fine. It makes it even more important that we make the current user's avatar bigger though. :) REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabr

D19479: [SDDM theme] Add opacity on hover to action buttons

ngraham added a comment. +1 conceptually. But there may be a more elegant way to do this... Specifically, perhaps we should just migrate the opacity logic implemented in the the Logout screen's `ActionButton` subclass to the base item itself, and then remove the subclass. That way all `

D19306: send a signal over dbus when the wrong password is provided

jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. Good idea to remove the failed connection. INLINE COMMENTS > secretagent.cpp:412 > sendError(SecretAgent::NoSecrets, "Cannot authenticate", > request.message); > +emit

D19479: [SDDM theme] Add opacity on hover to action buttons

rooty accepted this revision as: rooty. rooty added a comment. This revision is now accepted and ready to land. Very elegant REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D19479 To: filipf, rooty, ngraham, #vdg, #plasma Cc: plasma-devel, jr

D19434: Change entry of Endpoint UI

jgrulich added a comment. Shouldn't we maybe use QSpinBox for the port? With the spinbox you can also set min and max values so you don't need to validate it. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D19434 To: andersonbruce, jgrulich

D19440: Exclude non-managed devices from plasma-nm

jgrulich added a comment. Can you attach output from: 1. nmcli -f all connection 2. nmcli -f all device show I wonder why those veth connections are shown in the applet for unmanaged devices, because we show only "available connections" and I would expect NM to ignore them, but th

D19478: [Login, Lock, and Logout Screen] Make the avatar background circle more subtle

filipf added a comment. There's a little bit of fringing around the white border so I can subtract 2 from the width? F6649343: image.png Left is before, right after. Doesn't quite solve it, but is a bit better. REPOSITORY R120 Plasma Workspac

D19479: [SDDM theme] Add opacity on hover to action buttons

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY Unlike in the logout screen, our action buttons in the SDDM theme currently offer no visual feedback when hovered over. This patch

D19478: [Login, Lock, and Logout Screen] Make the avatar background circle more subtle

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY Added in D16879 , the background circle was designed to work on a blurless login screen. Since

[Breeze] [Bug 367696] breeze dark: konsole icon is barely visible

https://bugs.kde.org/show_bug.cgi?id=367696 Patrick Silva changed: What|Removed |Added Summary|konsole icon is almost |breeze dark: konsole icon |in

D19467: [colors-kcm] Fix blurry previews

filipf updated this revision to Diff 52986. filipf added a comment. don't round numbers unnecessarily REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19467?vs=52951&id=52986 BRANCH fix-blurry-previews (branched from master) REVISION DETAIL https

D19467: [colors-kcm] Fix blurry previews

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. I don't understand Kirigami.gridUnit is a whole number 13 is a a whole number Why does Math.round fix anything? REPOSITORY R119 Plasma Desktop REVIS

D19467: [colors-kcm] Fix blurry previews

rooty accepted this revision as: rooty. rooty added a comment. This revision is now accepted and ready to land. Looks good to me. You might want to wait for someone else's say-so too tho REPOSITORY R119 Plasma Desktop BRANCH fix-blurry-previews (branched from master) REVISION DETAIL ht

D19475: Only match service text strings once

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Minor optimisation, should behave identically. TEST PLAN Ran krunner Sea

D19472: [Task Manager] Make sure "Alternatives..." context menu item is always available

This revision was automatically updated to reflect the committed changes. Closed by commit R119:fd7b359f8461: [Task Manager] Make sure "Alternatives..." context menu item is always available (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.

D19472: [Task Manager] Make sure "Alternatives..." context menu item is always available

rooty accepted this revision. rooty added a comment. You have no idea how much of a headache not having this option has been huge +1 REPOSITORY R119 Plasma Desktop BRANCH task-manager-alternatives-in-item-context-menu (branched from master) REVISION DETAIL https://phabricator.kde.

D19472: [Task Manager] Make sure "Alternatives..." context menu item is always available

ngraham created this revision. ngraham added reviewers: Plasma, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Currently, the Task Manager does not show the Alternatives... item in the context menu for

D19468: [sddm-theme/lock screen] Remove username shadow and show clock shadow only when unfocused

rooty updated this revision to Diff 52978. rooty added a comment. Correct typographical error REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19468?vs=52976&id=52978 BRANCH shadows-only-when-inactive (branched from master) REVISION DETAIL http

D19468: [sddm-theme/lock screen] Remove username shadow and show clock shadow only when unfocused

rooty added a comment. In D19468#423093 , @ngraham wrote: > Won't the outlines get drawn when blurred if software rendering is in use? I can't get any blur with software rendering though? Another problem too - forcing software rendering

D19468: [sddm-theme/lock screen] Remove username shadow and show clock shadow only when unfocused

rooty updated this revision to Diff 52976. rooty added a comment. Disable shadows with softwareRendering enabled REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19468?vs=52954&id=52976 BRANCH shadows-only-when-inactive (branched from master) REV

D19460: [powerdevil] Correct labels

ngraham added inline comments. INLINE COMMENTS > rooty wrote in activityWidget.ui:72 > Haha I had the idea to use turn off too, because you don't really ever "shut > down" a screen Eh, let's make the English teachers happy. :) REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator

D19468: [sddm-theme/lock screen] Remove username shadow and show clock shadow only when unfocused

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Won't the outlines get drawn when blurred if software rendering is in use? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19468 To: rooty, #v

D19460: [powerdevil] Correct labels

rooty added a comment. I wonder if people would notice if it ended in a preposition (ironically "Never turn the screen off" sounds nicer to me) INLINE COMMENTS > ngraham wrote in activityWidget.ui:72 > While we're touching this, I think "Never turn off the screen" would sound > more natural

D19460: [powerdevil] Correct labels

rooty updated this revision to Diff 52958. rooty marked an inline comment as done. rooty added a comment. Shut down --> turn off REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19460?vs=52938&id=52958 BRANCH powerdevil-hig (branched from master) REVIS

D19458: [Logout screen] Change labels to match SDDM theme labels

This revision was automatically updated to reflect the committed changes. Closed by commit R120:d8a7443605bd: [Logout screen] Change labels to match SDDM theme labels (authored by rooty). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19458?vs=52937&i

D19459: [Kicker, Kickoff & Dash] Change labels to match SDDM theme labels

This revision was automatically updated to reflect the committed changes. Closed by commit R119:604244b6cb66: [Kicker, Kickoff & Dash] Change labels to match SDDM theme labels (authored by rooty). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19459?vs=

D19469: [sddm-theme] Update login screen preview image

filipf added a comment. Good work, but let's wait a bit with this since D19214 hasn't landed yet. I was also thinking of tweaking the background circle behind the user avatar. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.o

D19469: [sddm-theme] Update login screen preview image

rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH update-preview-image (branched from master) REVISION DETAIL https://phabricator.kde.org/D19469 AFFECTED FI

D19468: [sddm-theme/lock screen] Remove username shadow and show clock shadow only when opaque

rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REVISION SUMMARY This patch removes the shadow from the usernames on the login and lock screens. It also restricts the clock shadow to just the opaque v

D19467: [colors-kcm] Fix blurry previews

filipf added a comment. If this is too small the next number that doesn't result in blurry previews is multiplying with 16: F6648523: image.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19467 To: filipf, broul

D19467: [colors-kcm] Fix blurry previews

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY With the current settings text in color scheme previews is blurry. This patch aims to fix that and as a side-effect also creates mo

D19460: [powerdevil] Correct labels

ngraham added a comment. In D19460#422873 , @rooty wrote: > Should "Act like" be replaced with "Behave as?" Is the control associated with this string actually used anywhere? I can't even find it. INLINE COMMENTS > activityWidget.ui:72

D19465: Port to ECM's component/imported target based FindXCB

vkrause created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. vkrause requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D19465 AFFECTED FILES kcms/touchpad/cmake/modules/C

D19463: Use FindGLIB2 from ECM

vkrause created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. vkrause requested review of this revision. REPOSITORY R115 Plasma Audio Volume Applet BRANCH master REVISION DETAIL https://phabricator.kde.org/D19463 AFFECTED FILES cmake/FindGLIB2.c

D19370: [sddm-theme] Add circles behind action buttons

filipf abandoned this revision. filipf added a comment. Parent dependency was abandoned. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19370 To: filipf, #vdg, ngraham, rooty, #plasma Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, a

D19379: [sddm-theme] Add a bottom panel

filipf abandoned this revision. filipf added a comment. Parent dependency was abandoned. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19379 To: filipf, #vdg, #plasma, ngraham, rooty Cc: abetts, broulik, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel