kwayland question

2019-03-05 Thread Damian Ivanov
Hello, I can't figure out what I'm doing wrong. Any help would be appreciated. I have attached an example but code is also below. I try to set the example as Bottom Panel. It is shown but it takes over the whole screen for its view strut instead of just the height. int main(int argc, char

Re: Plasma Sprint 2019 in València

2019-03-05 Thread Aleix Pol
I guess that I formulated it in a confusing way, I'll try to be more clear next time. I created this wiki page too to keep track of who's coming. There's an etherpad where we could add topics to discuss there. https://community.kde.org/Sprints/Plasma/2019 Aleix On Tue, Mar 5, 2019 at 3:54 PM

D18912: [libinput-touchpad-kcm-click-method] Add click method Areas and Clickfinger for buttonless touchpads

2019-03-05 Thread Nathaniel Graham
ngraham added a comment. Wonderful news!!! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18912 To: atulbi, ngraham, #plasma, romangg, davidedmundson Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D19550: [Media Frame] Use mipmapping for higher quality

2019-03-05 Thread Nathaniel Graham
ngraham added a comment. Good call, that works too! REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D19550 To: ngraham, #plasma Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D19550: [Media Frame] Use mipmapping for higher quality

2019-03-05 Thread Nathaniel Graham
ngraham updated this revision to Diff 53249. ngraham added a comment. Set SourceSize instead of using mipmapping REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19550?vs=53228=53249 BRANCH use-mipmapping-for-higher-quality (branched from

D19550: [Media Frame] Use mipmapping for higher quality

2019-03-05 Thread David Edmundson
davidedmundson added a comment. Would it be better to set the sourceSize? If we're downscaling during rendering we're wasting memory REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D19550 To: ngraham, #plasma Cc: davidedmundson, plasma-devel, jraleigh, GB_2,

D19419: [KdePlasma-Addons/POTD/NOAA] Fixed RegEx string to suit latest changes on the webpage

2019-03-05 Thread Tagore Chandan Reddy
tagorechandanreddy marked an inline comment as done. tagorechandanreddy added inline comments. INLINE COMMENTS > davidedmundson wrote in noaaprovider.cpp:93 > Why are we losing multiline? The new string pattern doesn't need Multiline option. It handles newline character. REPOSITORY R114

D18912: [libinput-touchpad-kcm-click-method] Add click method Areas and Clickfinger for buttonless touchpads

2019-03-05 Thread Atul Bisht
atulbi added a comment. Thanks. Yes, I'll take this for sure. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18912 To: atulbi, ngraham, #plasma, romangg, davidedmundson Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D19419: [KdePlasma-Addons/POTD/NOAA] Fixed RegEx string to suit latest changes on the webpage

2019-03-05 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > noaaprovider.cpp:93 > QString url; > -QRegularExpression re(QStringLiteral("a href='(.*)'> QRegularExpression::MultilineOption); > +QRegularExpression > re(QStringLiteral("a//s+href='(.*)'//s*>[//s//n]*

D18438: [Task Manager] When closing apps, resize only when mouse is out.

2019-03-05 Thread Thomas Surrel
thsurrel updated this revision to Diff 53240. thsurrel added a comment. Use the WinIdList role REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18438?vs=50291=53240 BRANCH arc_taskmanagerclose (branched from master) REVISION DETAIL

D18912: [libinput-touchpad-kcm-click-method] Add click method Areas and Clickfinger for buttonless touchpads

2019-03-05 Thread Nathaniel Graham
ngraham added a comment. Nice work. Any chance you'd be interested in porting the Wayland-only libinput touchpad KCM to work on X11 too, just like how the Libinput mouse KCM does? https://bugs.kde.org/show_bug.cgi?id=387153 REPOSITORY R119 Plasma Desktop REVISION DETAIL

D18912: [libinput-touchpad-kcm-click-method] Add click method Areas and Clickfinger for buttonless touchpads

2019-03-05 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R119:8ca7335288fa: [libinput-touchpad-kcm-click-method] Add click method Areas and Clickfinger for… (authored by atulbi, committed by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D19373: [RFC] [Splash Screen] Use current "Next" wallpaper as the background

2019-03-05 Thread Nathaniel Graham
ngraham added a comment. In D19373#425115 , @davidedmundson wrote: > I don't think we can ship anything without a config, if a user can configure login background and desktop background, showing a "random" wallpaper in the middle is bound to

D19550: [Media Frame] Use mipmapping for higher quality

2019-03-05 Thread Nathaniel Graham
ngraham created this revision. ngraham added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Without mipmapping, diagonal lines are aliased and many images look terrible. TEST PLAN

D19548: [Media frame] Modernize and improve settings window

2019-03-05 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This patch modernizes the Media Frame's user interface by doing the following: - Port to

D18437: Improve saving an invalid certificate fingerprint to avoid the need to accept it every time

2019-03-05 Thread Enrique Melendez
enriquem added a comment. Diff updated, but please note that this patch would break compatibility with NetworlManager, and with existing configured networks. I still think changes are reasonable, but had to be synchronized with similar changes in NetworkManager. Not that those are

D18437: Improve saving an invalid certificate fingerprint to avoid the need to accept it every time

2019-03-05 Thread Enrique Melendez
enriquem updated this revision to Diff 53225. REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18437?vs=50022=53225 REVISION DETAIL https://phabricator.kde.org/D18437 AFFECTED FILES vpn/openconnect/CMakeLists.txt

D17487: Check if the form has changed, and only reconnect if it has

2019-03-05 Thread Enrique Melendez
enriquem added a comment. That is correct. It was fixed with a different approach In D17487#425037 , @jgrulich wrote: > Can be closed if I'm not mistaken, the issue has been already fixed. REPOSITORY R116 Plasma Network Management Applet

D19547: [sddm-theme/lock screen] Use default font size adjustments instead of hardcoded sizes

2019-03-05 Thread Krešimir Čohar
This revision was automatically updated to reflect the committed changes. Closed by commit R120:9816994ecd02: [sddm-theme/lock screen] Use default font size adjustments instead of hardcoded… (authored by rooty). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D19547: [sddm-theme/lock screen] Use default font size adjustments instead of hardcoded sizes

2019-03-05 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. Yeah, you're probably right. REPOSITORY R120 Plasma Workspace BRANCH not-hardcoded (branched from master) REVISION DETAIL https://phabricator.kde.org/D19547 To: rooty, #vdg, #plasma, filipf, ngraham Cc: plasma-devel, jraleigh,

D19547: [sddm-theme/lock screen] Use default font size adjustments instead of hardcoded sizes

2019-03-05 Thread Filip Fila
filipf added a comment. In D19547#425306 , @ngraham wrote: > Hmm, this means that when the user has customized the text size in their own user account, the text size will be different on the Login screen (which does not follow user settings) vs

D19547: [sddm-theme/lock screen] Use default font size adjustments instead of hardcoded sizes

2019-03-05 Thread Krešimir Čohar
rooty added a comment. In D19547#425306 , @ngraham wrote: > Hmm, this means that when the user has customized the text size in their own user account, the text size will be different on the Login screen (which does not follow user settings) vs

D19547: [sddm-theme/lock screen] Use default font size adjustments instead of hardcoded sizes

2019-03-05 Thread Nathaniel Graham
ngraham added a comment. Hmm, this means that when the user has customized the text size in their own user account, the text size will be different on the Login screen (which does not follow user settings) vs the lock and logout screens (which do). Looks like there's really no way around

D19547: [sddm-theme/lock screen] Use default font size adjustments instead of hardcoded sizes

2019-03-05 Thread Krešimir Čohar
rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH not-hardcoded (branched from master) REVISION DETAIL https://phabricator.kde.org/D19547 AFFECTED FILES

D16093: Consistent arrow key handling in the Informative Alt+Tab skin

2019-03-05 Thread Vlad Zagorodniy
zzag added a comment. I'll backport it to Plasma/5.15. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D16093 To: Zren, davidedmundson, ngraham Cc: zzag, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D18961: [WIP] [weather] Migrate nativeInterface config to plasmoid.configuration.*

2019-03-05 Thread Chris Holland
Zren added a comment. Was skimming the Plasma Scripting API today for something else and found where I saw the "update scripts" before: - https://userbase.kde.org/KDE_System_Administration/PlasmaDesktopScripting#Update_scripts -

D18912: [libinput-touchpad-kcm-click-method] Add click method Areas and Clickfinger for buttonless touchpads

2019-03-05 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. UI looks good to me too. REPOSITORY R119 Plasma Desktop BRANCH libinput-click-method (branched from master) REVISION DETAIL https://phabricator.kde.org/D18912 To: atulbi, ngraham, #plasma, romangg, davidedmundson Cc:

D19543: move version definition into generated header instead of passing it on CLI

2019-03-05 Thread Jonathan Riddell
jriddell added a comment. okay dokay REPOSITORY R871 DrKonqi BRANCH master REVISION DETAIL https://phabricator.kde.org/D19543 To: sitter, jriddell, apol Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19543: move version definition into generated header instead of passing it on CLI

2019-03-05 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R871:082d0f1bb10e: move version definition into generated header instead of passing it on CLI (authored by sitter). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE

D19373: [RFC] [Splash Screen] Use current "Next" wallpaper as the background

2019-03-05 Thread Andres Betts
abetts added a comment. +1 on looks REPOSITORY R120 Plasma Workspace BRANCH splash-screen-uses-next-wallpaper (branched from master) REVISION DETAIL https://phabricator.kde.org/D19373 To: ngraham, #vdg, #plasma, rooty Cc: abetts, davidedmundson, filipf, rooty, plasma-devel, jraleigh,

D19543: move version definition into generated header instead of passing it on CLI

2019-03-05 Thread Harald Sitter
sitter created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY easier to for IDEs to follow where it comes from and also more in line with how other defines are set in drkonqi TEST PLAN

Re: Plasma 5.12.8 LTS

2019-03-05 Thread Jonathan Riddell
An update to sddm-kcm to fix compile with older versions of Qt http://download.kde.org/stable/plasma/5.12.8/sddm-kcm-5.12.8.1.tar.xz http://embra.edinburghlinux.co.uk/~jr/tmp/pkgdiff_reports/sddm-kcm/5.12.8_to_5.12.8.1/changes_report.html sha256:

D19373: [RFC] [Splash Screen] Use current "Next" wallpaper as the background

2019-03-05 Thread Krešimir Čohar
rooty added a comment. Wait so the flicker's fixable? REPOSITORY R120 Plasma Workspace BRANCH splash-screen-uses-next-wallpaper (branched from master) REVISION DETAIL https://phabricator.kde.org/D19373 To: ngraham, #vdg, #plasma, rooty Cc: davidedmundson, filipf, rooty, plasma-devel,

Re: Plasma Sprint 2019 in València

2019-03-05 Thread Kai Uwe Broulik
Just to be clear, Wednesday, 19 June arrival and Wednesday, 26 departure? Kinda got confused over that 19 till 23 thing in the initial mail Cheers Kai Uwe

D18912: [libinput-touchpad-kcm-click-method] Add click method Areas and Clickfinger for buttonless touchpads

2019-03-05 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > main.qml:602 > +function syncCurrent() { > +if (enabled && !root.loading) { > +touchpad.clickMethodAreas

Re: Plasma Sprint 2019 in València

2019-03-05 Thread Noah Davis
I will, thank you. On 3/5/19, Aleix Pol wrote: > Please, remember to submit your reimbursement request here: > https://reimbursements.kde.org/events/88 > > Aleix > > On Tue, Mar 5, 2019 at 1:12 PM Noah Davis wrote: >> >> Not immediately, but I've never traveled outside the US and I'd like to be

D19373: [RFC] [Splash Screen] Use current "Next" wallpaper as the background

2019-03-05 Thread David Edmundson
davidedmundson added a comment. The original rationale of the time of having the black background was to hide the flickering blank framebuffer as we switch from SDDM to the login - and we're autologigng in we're coming from a black background too. From a tech POV I like that because loading

Plasma 5.12.8 LTS

2019-03-05 Thread Jonathan Riddell
Plasma 5.12.8 LTS is now released https://www.kde.org/announcements/plasma-5.12.8.php

Re: Plasma Sprint 2019 in València

2019-03-05 Thread Aleix Pol
Please, remember to submit your reimbursement request here: https://reimbursements.kde.org/events/88 Aleix On Tue, Mar 5, 2019 at 1:12 PM Noah Davis wrote: > > Not immediately, but I've never traveled outside the US and I'd like to be > prepared. > > On March 4, 2019 9:34:16 PM EST, Aleix Pol

D19468: [sddm-theme/lock screen] Remove username shadow and show clock shadow only when unfocused

2019-03-05 Thread Krešimir Čohar
rooty updated this revision to Diff 53201. rooty added a comment. Fix trailing whitespace REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19468?vs=52978=53201 BRANCH shadows-only-when-inactive (branched from master) REVISION DETAIL

D19214: [sddm-theme] Replace login button label with icon

2019-03-05 Thread Krešimir Čohar
rooty updated this revision to Diff 53200. rooty added a comment. Fix comments and trailing whitespace REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19214?vs=53078=53200 REVISION DETAIL https://phabricator.kde.org/D19214 AFFECTED FILES

Re: Plasma Sprint 2019 in València

2019-03-05 Thread Noah Davis
Not immediately, but I've never traveled outside the US and I'd like to be prepared. On March 4, 2019 9:34:16 PM EST, Aleix Pol wrote: >I don't have it at hand, but does that really matter? > >Aleix > >On Mon, Mar 4, 2019 at 6:54 PM Noah Davis wrote: >> >> What is the address of the place we

D19214: [sddm-theme] Replace login button label with icon

2019-03-05 Thread Krešimir Čohar
rooty added a comment. P.S. This is what happens if I try to bump the PlasmaComponents version up to 3.0 F6658850: image.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19214 To: rooty, #vdg, #plasma,

D17487: Check if the form has changed, and only reconnect if it has

2019-03-05 Thread Jan Grulich
jgrulich added a comment. Herald added 1 blocking reviewer(s): jgrulich. Can be closed if I'm not mistaken, the issue has been already fixed. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D17487 To: enriquem, jgrulich Cc: plasma-devel,

D18437: Improve saving an invalid certificate fingerprint to avoid the need to accept it every time

2019-03-05 Thread Jan Grulich
jgrulich added a comment. Herald added 1 blocking reviewer(s): jgrulich. Can you please rebase this change on top of master? It doesn't apply. INLINE COMMENTS > openconnectwidget.cpp:55 > connect(d->ui.leGateway, ::textChanged, this, > ::slotWidgetChanged); > - > + > +//

D19392: shannon entropy to guess monochrome icon

2019-03-05 Thread Marco Martin
mart added a comment. In D19392#424581 , @davidedmundson wrote: > > so, for gtk4/qt6, the base qiconengine included in qt should support whatever coloring is used, in which case i wouldn't need to do anything on my part.. tough that's for Qt6.

D19468: [sddm-theme/lock screen] Remove username shadow and show clock shadow only when unfocused

2019-03-05 Thread Filip Fila
filipf added a comment. In D19468#424925 , @rooty wrote: > In D19468#424857 , @filipf wrote: > > > In D19468#423984 , @rooty wrote: > > > > >