D19606: [Task Manager] Reorganize and improve presentation of context menu

ngraham updated this revision to Diff 53409. ngraham added a comment. Actually use the correct icon REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19606?vs=53407=53409 BRANCH reorganize-task-manager-context-menu (branched from master) REVISION

D19548: [Media frame] Modernize and improve settings window

ngraham updated this revision to Diff 53408. ngraham marked 2 inline comments as done. ngraham added a comment. Address review comments REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19548?vs=53226=53408 BRANCH modernize-media-frame-settings

D19548: [Media frame] Modernize and improve settings window

ngraham marked an inline comment as done. ngraham added a comment. We kinda sorta have a convention to use the app/widget's own icon for its "general" category, so I think this makes sense. The widget probably needs a better icon though than just this generic image mimetype. REPOSITORY

D19606: [Task Manager] Reorganize and improve presentation of context menu

ngraham updated this revision to Diff 53407. ngraham marked 2 inline comments as done. ngraham added a comment. Correct erroneously-changed fullscreen icon REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19606?vs=53406=53407 BRANCH

D19606: [Task Manager] Reorganize and improve presentation of context menu

ngraham added a comment. In D19606#426946 , @ndavis wrote: > I like it overall, but some of those icons need changing. Not just here, but in breeze-icons as well. > > Resize: I don't like how busy that icon looks, but I"m not sure if it's

D19606: [Task Manager] Reorganize and improve presentation of context menu

ndavis added subscribers: trickyricky26, ndavis. ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. I like it overall, but some of those icons need changing. Not just here, but in breeze-icons as well. Resize: I don't like

D19603: Fix colours of header bar for acitve and inactive windows

ngraham added reviewers: Breeze, zzag, VDG. ngraham added a comment. Nice! REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D19603 To: davidedmundson, #breeze, zzag, #vdg Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,

D19606: [Task Manager] Reorganize and improve presentation of context menu

ngraham updated this revision to Diff 53406. ngraham added a comment. Updating per VDG comments in chat: - Move the Task Manager section to the top so the Close button is on the very bottom again - Use standard menu section headers instead of fake custom-synthesized ones REPOSITORY

D19605: Sharpen ApplicationMenu, Shade, ContextHelp icons

ndavis updated this revision to Diff 53405. ndavis added a comment. Fix formatting on line parameters for Shade button REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19605?vs=53403=53405 BRANCH fix-titlebar-buttons (branched from master) REVISION DETAIL

D19606: [Task Manager] Reorganize and improve presentation of context menu

ngraham added a comment. One issue I have with this patch is that sometimes the Alternatives menu item doesn't appear under the right conditions anymore, and I need to do `visible: alternativesAction && !alternativesAction.visible` instead, which is obviously wrong. This doesn't happen all

D19606: [Task Manager] Reorganize improve presentation of context menu

ngraham created this revision. ngraham added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This patch improves the UX of the Task Manager's context menu by offering more logical

D19605: Sharpen ApplicationMenu, Shade, ContextHelp icons

ndavis created this revision. ndavis added reviewers: VDG, Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ndavis requested review of this revision. REVISION SUMMARY Parts of these icons did not line up well with the pixel grid making them seem blurry or faded.

D19468: [sddm-theme/lock screen] Remove username shadow and show clock shadow only when unfocused

rooty updated this revision to Diff 53402. rooty added a comment. Rebase REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19468?vs=53201=53402 BRANCH arcpatch-D19468 REVISION DETAIL https://phabricator.kde.org/D19468 AFFECTED FILES

D19468: [sddm-theme/lock screen] Remove username shadow and show clock shadow only when unfocused

rooty added a comment. The last holdout :D REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19468 To: rooty, #vdg, ngraham Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19214: [sddm-theme] Replace login button label with icon

rooty added a comment. Thank you so much this particular landing has been a long time coming :D It's a little strange the way 602e5533d348 took inventory of the changes? But I've checked the tree and

D19214: [sddm-theme] Replace login button label with icon

This revision was automatically updated to reflect the committed changes. Closed by commit R120:602e5533d348: [sddm-theme] Replace login button label with icon (authored by rooty). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19214?vs=53365=53400

D19603: Fix colours of header bar for acitve and inactive windows

davidedmundson added a comment. F6671827: Screenshot_20190308_011741.png two window titles of different colours matching breeze. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D19603 To: davidedmundson Cc:

D19603: Fix colours of header bar for acitve and inactive windows

davidedmundson created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Use and generate correct colours from the window manager palette rather than the window palette in the headerbar.

D19214: [sddm-theme] Replace login button label with icon

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Outstanding. REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D19214 REVISION DETAIL https://phabricator.kde.org/D19214 To: rooty, #vdg, #plasma, ngraham, filipf Cc:

D19479: [Lock, Login, and Logout screen] Adjust visual feedback of action buttons

This revision was automatically updated to reflect the committed changes. Closed by commit R120:99dd92635f27: [Lock, Login, and Logout screen] Adjust visual feedback of action buttons (authored by filipf). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D18438: [Task Manager] When closing apps, resize only when mouse is out.

thsurrel added a comment. Thank you so much for your patient reviews! As a side note, I noticed something a bit odd while testing: if the task manager is configured with grouping, and you open a bunch of Kate instances and close them all at once by middle-clicking on the "grouped task",

D18438: [Task Manager] When closing apps, resize only when mouse is out.

thsurrel updated this revision to Diff 53394. thsurrel added a comment. Fix code for groups and WinId-less tasks. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18438?vs=53240=53394 BRANCH arc_taskmanagerclose (branched from master) REVISION

D19548: [Media frame] Modernize and improve settings window

filipf added a comment. Tested it, works well, looks good. What I really like about this are the extended time options and better wording of the options. I added some minor comments in the code, mostly just related to my understanding of the code, not any issues. And while we're at

D18438: [Task Manager] When closing apps, resize only when mouse is out.

hein requested changes to this revision. hein added a comment. This revision now requires changes to proceed. Almost! This is not going to work reliably for groups, because the order in which their children are deleted is up to the client processes. That means once a group goes from two to

D19479: [Lock, Login, and Logout screen] Adjust visual feedback of action buttons

filipf added a comment. In D19479#426481 , @rooty wrote: > These screenshots might make this problem more appreciable. > > OpacityAnimator: > > F6669246: image.png > > (Sleep darker than the

D19596: color monochrome icons to tooltip colors

mart added a comment. In D19596#426701 , @sitter wrote: > The sidepanel (which I guess is the mainview) gets the icon from InfoKcmModel::data from what I can tell. ::data and ::generateToolTipLine are the only places where I see ::icon get

D19596: color monochrome icons to tooltip colors

sitter added a comment. The sidepanel (which I guess is the mainview) gets the icon from InfoKcmModel::data from what I can tell. ::data and ::generateToolTipLine are the only places where I see ::icon get called. So what I am thinking is these changes: ::icon goes away in favor of

D19595: use a TextMetrics for height

sitter added a comment. I think this is the wrong TextField for SDDM/kscreenlocker actually. They use PlasmaComponents 2, which judging by my printf debugging isn't loading that particular TextField.qml. TextFieldStyle.qml seems to be what's loaded there, however when applying the

D19596: color monochrome icons to tooltip colors

mart added a comment. In D19596#426652 , @sitter wrote: > I think what we need is to change `KcmTreeItem::icon()` (and its derived class KcmCategoryItem) to `QString KcmTreeItem::iconName()` and use that on the KDE::icon call. And

D19596: color monochrome icons to tooltip colors

ngraham added a comment. Sweet, could you do the same thing for System Settings' tooltip too? It's a fork of this code (or maybe the reverse is true). REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D19596 To: mart, #plasma, sitter Cc: ngraham, plasma-devel,

D19596: color monochrome icons to tooltip colors

sitter requested changes to this revision. sitter added a comment. This revision now requires changes to proceed. That seems to break the category icons because `KDE::icon(menuItem->kcm().icon()` is only working on Kcm entries, while KcmCategory entries overload `::icon` with divergent

D19596: color monochrome icons to tooltip colors

mart added a comment. F6670098: image.png REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D19596 To: mart, #plasma, sitter Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D19596: color monochrome icons to tooltip colors

mart created this revision. mart added reviewers: Plasma, sitter. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY when the tooltips are dark, monochrome icons can be black on black use kiconloader with a custom

D19595: use a TextMetrics for height

ngraham added a comment. Hmm, this does not actually fix the problem for me in Neon with all default font settings. The password field still gets taller when the first character of the password is typed. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL

D19595: use a TextMetrics for height

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY as contentHeight could change when switching to password mode, use a textmetrics which always computes

D19214: [sddm-theme] Replace login button label with icon

davidedmundson added inline comments. INLINE COMMENTS > rooty wrote in MainBlock.qml:99 > Is that how you do it? I just assumed it was the same as "text" Perfect. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19214 To: rooty, #vdg, #plasma, ngraham, filipf

D19214: [sddm-theme] Replace login button label with icon

rooty marked 2 inline comments as done. rooty added inline comments. INLINE COMMENTS > davidedmundson wrote in MainBlock.qml:99 > Please add > > Accessible.name: "Unlock" > > which helps screen readers Is that how you do it? I just assumed it was the same as "text" > davidedmundson wrote in

D19214: [sddm-theme] Replace login button label with icon

rooty updated this revision to Diff 53365. rooty added a comment. Rebase; add Accessible.name REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19214?vs=53200=53365 BRANCH arcpatch-D19214 REVISION DETAIL https://phabricator.kde.org/D19214

D19214: [sddm-theme] Replace login button label with icon

D19214: [sddm-theme] Replace login button label with icon

davidedmundson added inline comments. INLINE COMMENTS > MainBlock.qml:99 > +id: loginButton > +implicitHeight: passwordBox.height - units.smallSpacing * 0.5 // > otherwise it comes out taller than the password field > Please add Accessible.name: "Unlock" which helps

D19214: [sddm-theme] Replace login button label with icon

rooty added a comment. In D19214#424074 , @ngraham wrote: > Looks like https://bugs.kde.org/show_bug.cgi?id=399155 has revealed that the text field itself just isn't tall enough. Fixing that should fix both the bug mentioned above, as well as

D19479: [Lock, Login, and Logout screen] Adjust visual feedback of action buttons

filipf updated this revision to Diff 53360. filipf added a comment. divide radius with 2 REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19479?vs=53356=53360 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19479 AFFECTED FILES

D19588: [Notifications] Improve finished notification

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > anthonyfieroni wrote in Jobs.qml:117-120 > displayDestUrl = destUrl.replace(/^(file:\/{2})/, "") All of this is wrong. Removing file:/// leaves something

D19479: [Lock, Login, and Logout screen] Adjust visual feedback of action buttons

rooty added a comment. These screenshots might make this problem more appreciable. OpacityAnimator: F6669246: image.png (Sleep darker than the other buttons, certain other buttons become dark on hover then white, I can't explain why)

D19479: [Lock, Login, and Logout screen] Adjust visual feedback of action buttons

rooty added a comment. In D19479#426474 , @davidedmundson wrote: > Visual indication on mouseover is generally a good thing ++ It's this problem (keep your eye on Sleep) F6655268: consequences-of-advanced-spellcasting.mp4

D19479: [Lock, Login, and Logout screen] Adjust visual feedback of action buttons

davidedmundson added a comment. Visual indication on mouseover is generally a good thing ++ INLINE COMMENTS > ActionButton.qml:44 > +Behavior on opacity { > +PropertyAnimation { // OpacityAnimator makes it turn black at > random intervals > +duration:

D19588: [Notifications] Improve finished notification

anthonyfieroni added inline comments. INLINE COMMENTS > Jobs.qml:117-120 > +var displayDestUrl = (destUrl ? destUrl.toString() : ""); > +if (displayDestUrl.indexOf("file:///") === 0) { > +displayDestUrl = displayDestUrl.substr(7);

D19587: [Notifications] Enable default set of thumbnailers

broulik planned changes to this revision. broulik added a comment. Probably shouldn't generate thumbnails for folders REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19587 To: broulik, #plasma Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot,

D19588: [Notifications] Improve finished notification

rooty added a comment. > A thumbnail Hmm... A privacy issue, but I suppose it's an acceptable compromise. Is it possible to turn this thumbnail preview thing off? > This is how the thumbnail stuff in notifications has been working ever since Plasma 5.9... it's also kinda modular

D19479: [Lock, Login, and Logout screen] Adjust visual feedback of action buttons

filipf added a comment. Anyone from #plasma have an opinion on the code or functionality? REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D19479 To: filipf, rooty, ngraham, #vdg, #plasma Cc:

D19479: [Lock, Login, and Logout screen] Adjust visual feedback of action buttons

filipf updated this revision to Diff 53356. filipf added a comment. Actually fix comment: "intervals" -> "random intervals" REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19479?vs=53355=53356 BRANCH master REVISION DETAIL

D19479: [Lock, Login, and Logout screen] Adjust visual feedback of action buttons

rooty accepted this revision. rooty added a comment. This revision is now accepted and ready to land. Perfect REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D19479 To: filipf, rooty, ngraham, #vdg, #plasma Cc: davidedmundson, plasma-devel,

D19479: [Lock, Login, and Logout screen] Adjust visual feedback of action buttons

filipf updated this revision to Diff 53355. filipf added a comment. fix comment: "intervals" -> "random intervals" REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19479?vs=53354=53355 BRANCH master REVISION DETAIL

D19479: [Lock, Login, and Logout screen] Adjust visual feedback of action buttons

filipf updated this revision to Diff 53354. filipf added a comment. replace yet another OpacityAnimator with PropertyAnimation and explain why REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19479?vs=53353=53354 BRANCH master REVISION DETAIL

D19479: [Lock, Login, and Logout screen] Adjust visual feedback of action buttons

filipf updated this revision to Diff 53353. filipf added a comment. replace OpacityAnimator with PropertyAnimation and explain why REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19479?vs=53325=53353 BRANCH master REVISION DETAIL

D19588: [Notifications] Improve finished notification

broulik added a comment. In D19588#426440 , @rooty wrote: > Is this the JPG itself or a thumbnail? A thumbnail > The new icon doesn't seem to do much here - why not make "3689 files" a hyperlink with a context menu? Or replace the

D19588: [Notifications] Improve finished notification

rooty added a comment. A few concerns: F6668002: Screenshot_20190307_114122.png Is this the JPG itself or a thumbnail? F6668009: Screenshot_20190307_114338.png The new icon doesn't seem to do

D19589: [DownloadJob] Set destUrl and total amount

broulik created this revision. broulik added reviewers: Plasma, VDG, dfaure. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Will give it a nice finished notification. BUG: 404182 BUG: 402144 FIXED-IN:

D19588: [Notifications] Improve finished notification

broulik created this revision. broulik added reviewers: Plasma, VDG, dfaure. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Right now when a job finishes, we get a notification that just contains whatever

D19587: [Notifications] Enable default set of thumbnailers

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Shows thumbnails for more files in notifications. TEST PLAN Now also shows thumbnails for SVGs

D19561: Don't crash if the fwupd error is null

This revision was automatically updated to reflect the committed changes. Closed by commit R134:1d8ab1561d0b: Dont crash if the fwupd error is null (authored by leinir). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19561?vs=53263=53341

D19577: [sddm-theme/lock screen] Fix "unable to assign [undefined]" error

This revision was automatically updated to reflect the committed changes. Closed by commit R120:06793f21d1ce: [sddm-theme/lock screen] Fix unable to assign [undefined] error (authored by rooty). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D19580: Use high dpi pixmaps

broulik created this revision. broulik added reviewers: Plasma, jgrulich. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY BUG: 405160 FIXED-IN: 5.15.3 TEST PLAN Verified that save dialog icons are sharp