D19606: [Task Manager] Reorganize and improve presentation of context menu

2019-03-09 Thread Eike Hein
hein added a comment. I'm concerned that having title labels on everything could be overdoing it a bit? It makes the context menu very large and have a lot of dead space, and adds to the noise. Isn't that rather a detriment to utility on repeated use? It's sometimes important to remember

D19096: Improvements for long label items in Application Dashboard

2019-03-09 Thread Eike Hein
hein added a comment. In D19096#427339 , @trmdi wrote: > In D19096#427329 , @hein wrote: > > > ... I'll need to set some time aside to analyze what you're trying to achieve there and propose an

D18979: foldermodel: store information about screen used

2019-03-09 Thread Eike Hein
hein added a comment. Can you explain more what this is trying to achieve / what it solves with an example? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18979 To: McPain, broulik, hein, #plasma Cc: cfeck, plasma-devel, jraleigh, GB_2, ragreen, Pitel,

D19647: [sddm-theme/lock screen] Use QQC2 instead of PlasmaComponents

2019-03-09 Thread Krešimir Čohar
rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH dont-crop-the-clock (branched from master) REVISION DETAIL https://phabricator.kde.org/D19647 AFFECTED

D19469: [sddm-theme] Update login screen preview image

2019-03-09 Thread Krešimir Čohar
rooty updated this revision to Diff 53570. rooty added a comment. Make Katie uppercase REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19469?vs=53567=53570 BRANCH update-preview-image (branched from master) REVISION DETAIL

D19469: [sddm-theme] Update login screen preview image

2019-03-09 Thread Krešimir Čohar
rooty updated this revision to Diff 53567. rooty added a comment. Update preview to reflect latest theme version REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19469?vs=52955=53567 BRANCH update-preview-image (branched from master) REVISION

D19631: [sddm-theme/lock screen] Overhaul font sizes

2019-03-09 Thread Krešimir Čohar
rooty updated this revision to Diff 53561. rooty edited the summary of this revision. rooty added a comment. Make the logout screen work too REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19631?vs=53557=53561 BRANCH revert-more (branched from

D17073: Do not crop albumArt

2019-03-09 Thread Nathaniel Graham
ngraham added a comment. Probably someone else should commandeer it and finish it up so we can get it in for 5.16. Do you wanna do that, @filipf or @rooty? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17073 To: trmdi, hein, broulik, ngraham, #vdg Cc:

D19631: [sddm-theme/lock screen] WIP, Overhaul font sizes

2019-03-09 Thread Krešimir Čohar
rooty updated this revision to Diff 53557. rooty added a comment. Apply theme.conf approach to all modifications REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19631?vs=53556=53557 BRANCH revert-more (branched from master) REVISION DETAIL

D19631: [sddm-theme/lock screen] WIP, Overhaul font sizes

2019-03-09 Thread Krešimir Čohar
rooty updated this revision to Diff 53555. rooty added a comment. Use fixed font size for SDDM theme but not lock screen REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19631?vs=53518=53555 BRANCH revert-more (branched from master) REVISION

D19631: [sddm-theme/lock screen] WIP, Overhaul font sizes

2019-03-09 Thread Krešimir Čohar
rooty updated this revision to Diff 53556. rooty added a comment. Revert changes to UserDelegate.qml (empty line) REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19631?vs=53555=53556 BRANCH revert-more (branched from master) REVISION DETAIL

D19472: [Task Manager] Make sure "Alternatives..." context menu item is always available

2019-03-09 Thread Björn Feber
GB_2 added a comment. In D19472#427613 , @ngraham wrote: > In D19472#427046 , @broulik wrote: > > > This suffers from the same bug as the action in the D17410 .

D19631: [sddm-theme/lock screen] WIP, Overhaul font sizes

2019-03-09 Thread Krešimir Čohar
rooty added a comment. Can confirm. theme.defaultFont.pointSize is indeed 9 pt. I've already got a hack in mind in case we can't make the sddm user's default font size 10 pt haha REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19631 To: rooty, #vdg,

D19631: [sddm-theme/lock screen] WIP, Overhaul font sizes

2019-03-09 Thread Filip Fila
filipf added a comment. Something's odd. It's not that the +1 and the +2 code isn't working, but it's as if `theme.defaultFont.pointSize` is actually 9pt in SDDM. Lock screen: F6677937: Screenshot_20190309_175127.png SDDM: F6677940:

D19631: [sddm-theme/lock screen] WIP, Overhaul font sizes

2019-03-09 Thread Krešimir Čohar
rooty added a comment. In D19631#427916 , @ngraham wrote: > In D19631#427911 , @rooty wrote: > > > In D19631#427905 , @ngraham wrote: > > > > > I don't

D19631: [sddm-theme/lock screen] WIP, Overhaul font sizes

2019-03-09 Thread Nathaniel Graham
ngraham added a comment. In D19631#427911 , @rooty wrote: > In D19631#427905 , @ngraham wrote: > > > I don't think we should use hardcoded font sizes in either place. Maybe what we should do is

D19631: [sddm-theme/lock screen] WIP, Overhaul font sizes

2019-03-09 Thread Krešimir Čohar
rooty added a comment. In D19631#427905 , @ngraham wrote: > I don't think we should use hardcoded font sizes in either place. Maybe what we should do is have both of them use `font.pointSize: theme.defaultFont.pointSize + 1` (etc.). Yes

D19631: [sddm-theme/lock screen] WIP, Overhaul font sizes

2019-03-09 Thread Nathaniel Graham
ngraham added a comment. I don't think we should use hardcoded font sizes in either place. Maybe what we should do is have both of them use `font.pointSize: theme.defaultFont.pointSize + 1` (etc.). That way they will both use the same font sizes unless the user changes that. There will be

D17073: Do not crop albumArt

2019-03-09 Thread Filip Fila
filipf added a comment. I liked this patch, how come you abandoned it @trmdi ? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17073 To: trmdi, hein, broulik, ngraham, #vdg Cc: rooty, filipf, ndavis, abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel,

D19036: [notifications] Lift up notification content if one line of body text droops

2019-03-09 Thread Krešimir Čohar
This revision was automatically updated to reflect the committed changes. Closed by commit R120:23f3345a2287: [notifications] Lift up notification content if one line of body text droops (authored by rooty). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D19036: [notifications] Lift up notification content if one line of body text droops

2019-03-09 Thread Krešimir Čohar
rooty updated this revision to Diff 53523. rooty added a comment. Rebase if needed REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19036?vs=52409=53523 BRANCH arcpatch-D19036 REVISION DETAIL https://phabricator.kde.org/D19036 AFFECTED FILES

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

2019-03-09 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R120:2003b267d4bc: Image Wallpaper Slideshow - display the list of images that will be shown (authored by davidre, committed by ngraham). CHANGED PRIOR TO COMMIT

D19036: [notifications] Lift up notification content if one line of body text droops

2019-03-09 Thread Filip Fila
filipf added a comment. In D19036#427849 , @rooty wrote: > In D19036#427845 , @cfeck wrote: > > > The status of this says 'Accepted', so developers might not check it. > > > > If you want to wait

KDE Review passes

2019-03-09 Thread Jonathan Riddell
Welcome the following projects which passed kdereview process plasma-simplemenu now in selfrelease/extra and released on store.kde.org pulseaudio-qt now in selfrelease/extra and released on download.kde.org rust-qt-binding-generator now in selfrelease/extra plasma-redshift-control now in

D18979: foldermodel: store information about screen used

2019-03-09 Thread Christoph Feck
cfeck added a comment. Could a Plasma developer please review? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18979 To: McPain, broulik, sebas, hein Cc: cfeck, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D19036: [notifications] Lift up notification content if one line of body text droops

2019-03-09 Thread Krešimir Čohar
rooty added a comment. In D19036#427845 , @cfeck wrote: > The status of this says 'Accepted', so developers might not check it. > > If you want to wait for a developer's review, I suggest to keep the status 'Needs Review'. I could

D19631: [sddm-theme/lock screen] Overhaul font sizes

2019-03-09 Thread Krešimir Čohar
rooty added a comment. Can anyone please help - how do I tell Main.qml to set the integer "nameFontSize" to 12 pt? My knowledge here is very limited and nothing I've tried has worked :/ REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19631 To: rooty,

Welcome Latte Dock to KDE

2019-03-09 Thread Jonathan Riddell
Latte is a dock based on plasma frameworks that provides an elegant and intuitive experience for your tasks and plasmoids. It animates its contents by using parabolic zoom effect and tries to be there only when it is needed. It's been part of KDE for a while but the incubation process stalled.

D19036: [notifications] Lift up notification content if one line of body text droops

2019-03-09 Thread Christoph Feck
cfeck added a comment. The status of this says 'Accepted', so developers might not check it. If you want to wait for a developer's review, I suggest to keep the status 'Needs Review'. REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D19036 REVISION DETAIL

D19631: [sddm-theme/lock screen] Overhaul font sizes

2019-03-09 Thread Krešimir Čohar
rooty updated this revision to Diff 53518. rooty edited the summary of this revision. rooty added a comment. (WIP) Switch back to the default theme font + 1 (or 2) for the lock screen REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

2019-03-09 Thread David Redondo
davidre updated this revision to Diff 53512. davidre added a comment. const REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18809?vs=52797=53512 BRANCH arcpatch-D18809_2 REVISION DETAIL https://phabricator.kde.org/D18809 AFFECTED FILES

D19631: [sddm-theme/lock screen] Overhaul font sizes

2019-03-09 Thread Krešimir Čohar
rooty added a comment. > What hardcoding font sizes gives us are 2 places in Plasma losing their flexibility and not taking the user's preferences into consideration = SDDM-ing it. Then the solution is obvious - we should make the sddm theme (SDDM itself) more customizable

D19631: [sddm-theme/lock screen] Overhaul font sizes

2019-03-09 Thread Filip Fila
filipf added a comment. In D19631#427731 , @rooty wrote: > In D19631#427726 , @filipf wrote: > > > There has to be a better solution. We're dragging the quality of Plasma down simply because SDDM

D19631: [sddm-theme/lock screen] Overhaul font sizes

2019-03-09 Thread Krešimir Čohar
rooty added a comment. In D19631#427726 , @filipf wrote: > There has to be a better solution. We're dragging the quality of Plasma down simply because SDDM isn't on par with it. If there's no other way, hardcoded font sizes should only be

D19631: [sddm-theme/lock screen] Overhaul font sizes

2019-03-09 Thread Krešimir Čohar
rooty added a subscriber: davidedmundson. rooty added a comment. @davidedmundson thoughts? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19631 To: rooty, #vdg, #plasma, ngraham, filipf Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel,

D19631: [sddm-theme/lock screen] Overhaul font sizes

2019-03-09 Thread Filip Fila
filipf requested changes to this revision. filipf added a comment. This revision now requires changes to proceed. There has to be a better solution. We're dragging the quality of Plasma down simply because SDDM isn't on par with it. If there's no other way, hardcoded font sizes should only

D19465: Port to ECM's component/imported target based FindXCB

2019-03-09 Thread Rik Mills
rikmills added a comment. Results in cmake configure build failure on Neon https://build.neon.kde.org/job/bionic_unstable_kde_plasma-desktop_bin_amd64/292/consoleFull REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19465 To: vkrause, apol Cc: rikmills,

D19631: [sddm-theme/lock screen] Overhaul font sizes

2019-03-09 Thread Krešimir Čohar
rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH revert-more (branched from master) REVISION DETAIL https://phabricator.kde.org/D19631 AFFECTED FILES