D19678: Feature: Add an option to adjust screen brightness by quadratic curve instead of linear when using brightness keys

vishaw abandoned this revision. vishaw added a comment. abondon because its a duplicate. REVISION DETAIL https://phabricator.kde.org/D19678 To: vishaw, #plasma, ngraham Cc: thsurrel, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D19694: [RFC] Reduce sidebar icon size/increase list information density

ndavis added a comment. > Though the icons are indeed pretty, and the problem with small monochrome icons has been resolved, the information density is now quite low. When? I still get a mix of color and monochrome icons in System Settings with the git master versions of it and

D19687: Allow single images to be excluded from the slideshow

davidre added a comment. In D19687#429332 , @ngraham wrote: > Also, this has nothing to do with your patch specifically, but seeing so many checkesd checkboxes in the slideshow's preview pane makes me realize just how much I want the Breeze

D19687: Allow single images to be excluded from the slideshow

davidre added a comment. In D19687#429367 , @abetts wrote: > How would the folders on the folder list on the left be removed as sources? In D18809 I changedthe ListItems to Kirigami SwipeListItems.

D19687: Allow single images to be excluded from the slideshow

abetts added a comment. How would the folders on the folder list on the left be removed as sources? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19687 To: davidre, #plasma, #vdg, ngraham Cc: abetts, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel,

D19687: Allow single images to be excluded from the slideshow

davidre updated this revision to Diff 53697. davidre added a comment. Set checked to false if checkboxes are not visible REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19687?vs=53696=53697 BRANCH toggleSlides REVISION DETAIL

D19687: Allow single images to be excluded from the slideshow

davidre updated this revision to Diff 53696. davidre added a comment. Sorry for that. Actually these warnings were the reason why the checkboxes were visible everywhere. Even if the checkboxes are not visible I got these warnings. In an attempt to get rid of them I tried enabled.

D19678: Feature: Add an option to adjust screen brightness by quadratic curve instead of linear when using brightness keys

thsurrel added a comment. And I could guide you around the kernel except in the graphic area ... REVISION DETAIL https://phabricator.kde.org/D19678 To: vishaw, #plasma, ngraham Cc: thsurrel, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D19678: Feature: Add an option to adjust screen brightness by quadratic curve instead of linear when using brightness keys

ngraham added a comment. Well I've got one! Unfortunately my kernel-fu is non-existent, but I can follow instructions and commands like a trained monkey pretty well. :) REVISION DETAIL https://phabricator.kde.org/D19678 To: vishaw, #plasma, ngraham Cc: thsurrel, plasma-devel, jraleigh,

D19694: [RFC] Reduce sidebar icon size/increase list information density

ngraham added a comment. In D19694#429341 , @broulik wrote: > Not a huge fan of going back and forth with design decisions all the time but +1 I preferred the smaller icons we used to habe //Technically// this isn't actually going back

D19678: Feature: Add an option to adjust screen brightness by quadratic curve instead of linear when using brightness keys

thsurrel added a comment. Yeah, that would help if I had a laptop that has this behavior, but I couldn't find any. REVISION DETAIL https://phabricator.kde.org/D19678 To: vishaw, #plasma, ngraham Cc: thsurrel, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D19678: Feature: Add an option to adjust screen brightness by quadratic curve instead of linear when using brightness keys

ngraham added a comment. In D19678#429348 , @thsurrel wrote: > I would love to see something like this getting in somehow, but as Nate described, we run into a problem with literally the first person that tested the patch. That sounds

D19678: Feature: Add an option to adjust screen brightness by quadratic curve instead of linear when using brightness keys

thsurrel added a comment. I would love to see something like this getting in somehow, but as Nate described, we run into a problem with literally the first person that tested the patch. That sounds statistically bad. I did not find a way to ensure that a given minimal step would turn on

D19694: [RFC] Reduce sidebar icon size/increase list information density

broulik added a comment. Not a huge fan of going back and forth with design decisions all the time but +1 I preferred the smaller icons we used to habe REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D19694 To: ngraham, #vdg Cc: broulik, plasma-devel,

D19678: Feature: Add an option to adjust screen brightness by quadratic curve instead of linear when using brightness keys

ngraham requested changes to this revision. ngraham added a subscriber: thsurrel. ngraham added a comment. This revision now requires changes to proceed. -1 for making this user-configurable, sorry. The brightness curve is an implementation detail and I don't think exposing it to the user

D19687: Allow single images to be excluded from the slideshow

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. This puts permanently disabled checkboxes on the wallpaper delegates that aren't used in the slideshow version, possibly related to a flood of warnings that gets printed to the

D19560: [Desktop Sessions KCM] Add Restart to BIOS/UEFI checkbox

ngraham accepted this revision. ngraham added a comment. The KMessageWidget within the group box is only weird because there's a group box IMO. This KCM is a good candidate for being re-laid-out with a FormLayout so it looks and feels like everything else these days. I can do that after this

D19694: [RFC] Reduce sidebar icon size/increase list information density

ngraham created this revision. ngraham added a reviewer: VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Ever since increasing the list item size to accommodate 32px icons, System Settings' sidebar has

D19654: Add lazy instantiation for submenus

This revision was automatically updated to reflect the committed changes. Closed by commit R169:d06e7280045d: Add lazy instantiation for submenus (authored by cordlandwehr). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19654?vs=53596=53688 REVISION DETAIL

D19670: [appmenu] Port configuration window to QQC2 and Kirigami.FormLayout

filipf added a comment. Okay so I checked additionally and the top level Item doesn't seem necessary. I guess I copied that style by looking at the systemtray and folderview icon configuration window code, which has an Item as a top level element. #plasma

[Powerdevil] [Bug 348529] Turn off screen after lock screen

https://bugs.kde.org/show_bug.cgi?id=348529 --- Comment #20 from Lukas Ba. --- > 2.) Add option to reduce turn off timeout when screen is locked (to e.g. 30 > seconds or 1 minute) ← would be my preference Here is how to implement this behaviour with the event workaround. I added two commands.

D19605: Sharpen ApplicationMenu, Shade, ContextHelp icons

ndavis added a comment. @zzag Is there anything you want me to change? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D19605 To: ndavis, #vdg, #breeze, zzag, davidedmundson Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D19259: [Task Manager] Fix sorting of tasks on last desktop in sort-by-desktop mode

This revision was automatically updated to reflect the committed changes. Closed by commit R120:53290043796c: [Task Manager] Fix sorting of tasks on last desktop in sort-by-desktop mode (authored by hein). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D19518: Make Ctrl+A work regardless of focus and visualize active selection in search heading

This revision was automatically updated to reflect the committed changes. Closed by commit R119:4d0f1a3e6ec7: Make Ctrl+A work regardless of focus and visualize active selection in search… (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D19257: [Task Manager] Fix virtual desktops subtext on task tooltip

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d769b7aa8838: [Task Manager] Fix virtual desktops subtext on task tooltip (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D19688: kirigami_package_breeze_icons: Search among size 16 icons as well

This revision was automatically updated to reflect the committed changes. Closed by commit R169:31e91fbbf7f5: kirigami_package_breeze_icons: Search among size 16 icons as well (authored by hein). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D19688: kirigami_package_breeze_icons: Search among size 16 icons as well

hein created this revision. hein added a reviewer: mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. hein requested review of this revision. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D19688 AFFECTED FILES

D19687: Allow single images to be excluded from the slideshow

davidre updated this revision to Diff 53672. davidre added a comment. - Remove debug statement REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19687?vs=53671=53672 BRANCH toggleSlides REVISION DETAIL https://phabricator.kde.org/D19687

D19687: Allow single images to be excluded from the slideshow

davidre created this revision. davidre added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY This allows to exlude single images from the slideshow by unchecking the little checkbox in

D19560: [Desktop Sessions KCM] Add Restart to BIOS/UEFI checkbox

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. LGTM. I'll put it on the record that I still think the "yo you wanna restart now" message should be at the top of the KCM and not inside the groupbox. REPOSITORY R119 Plasma Desktop

D19612: RFC port to bugzilla REST API

sitter updated this revision to Diff 53669. sitter added a comment. - repair dupe detection - was running on empty list - refactor bug fetching to not include comment fetching and port all users of it - stop holding all comments of all bugs in memory. we have no use for like 99% of them

D19662: Fix Qmake based build

This revision was automatically updated to reflect the committed changes. Closed by commit R169:f7100e2c9ca6: Fix Qmake based build (authored by ognarb). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19662?vs=53621=53664 REVISION DETAIL

D19684: drop explicit disconnect in dtor

This revision was automatically updated to reflect the committed changes. Closed by commit R871:f7fbcff86ac4: drop explicit disconnect in dtor (authored by sitter). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19684?vs=53662=53663 REVISION DETAIL

D19662: Fix Qmake based build

mart requested changes to this revision. mart added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kirigami.qrc:21 > alias="ActionTextField.qml">src/controls/ActionTextField.qml > -

D19684: drop explicit disconnect in dtor

sitter created this revision. sitter added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY when this is getting destroyed the qobject dtor will automatically disconnect everything. the

D19560: [Desktop Sessions KCM] Add Restart to BIOS/UEFI checkbox

broulik updated this revision to Diff 53661. broulik added a comment. - Enable word wrap for message widget REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19560?vs=53659=53661 REVISION DETAIL https://phabricator.kde.org/D19560 AFFECTED FILES

D19562: [Logout Screen] Show info that rebooting will enter firmware setup

broulik updated this revision to Diff 53660. broulik added a comment. - Restore QML REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19562?vs=53654=53660 REVISION DETAIL https://phabricator.kde.org/D19562 AFFECTED FILES

D19560: [Desktop Sessions KCM] Add Restart to BIOS/UEFI checkbox

broulik updated this revision to Diff 53659. broulik added a comment. - Fix xml - Better init dbus iface REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19560?vs=53652=53659 REVISION DETAIL https://phabricator.kde.org/D19560 AFFECTED FILES

D19562: [Logout Screen] Show info that rebooting will enter firmware setup

sitter added a comment. I think you lost the QML part of the diff. LGTM, can't really comment on the qml side though. Haven't worked with qml in years. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19562 To: broulik, #plasma, #vdg, ngraham Cc:

D19682: Set colorSet on categories header

This revision was automatically updated to reflect the committed changes. Closed by commit R124:441697ca9b81: Set colorSet on categories header (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19682?vs=53656=53657#toc REPOSITORY R124 System Settings CHANGES SINCE

D19682: Set colorSet on categories header

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY After a recent Kirigami change, the header behind the search box became white whereas the

D19670: [appmenu] Port configuration window to QQC2 and Kirigami.FormLayout

abetts added a comment. +1 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19670 To: filipf, #plasma, #vdg Cc: abetts, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19651: Improve the look of the Application Style KCM UI

abetts added a comment. Is there any way that we can make the preview window have more right and left margins? When presented like this, it seems like it is actually another module that users interact with. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D19560: [Desktop Sessions KCM] Add Restart to BIOS/UEFI checkbox

sitter requested changes to this revision. sitter added a comment. This revision now requires changes to proceed. XML broken. The KMessageWidget being inside the groupbox looks a bit weird to me. Don't we usually put the messages at the top of the KCM? INLINE COMMENTS >

D19562: [Logout Screen] Show info that rebooting will enter firmware setup

broulik updated this revision to Diff 53654. broulik added a comment. - Async call REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19562?vs=53265=53654 REVISION DETAIL https://phabricator.kde.org/D19562 AFFECTED FILES

D19562: [Logout Screen] Show info that rebooting will enter firmware setup

sitter added a comment. I think it's bad practice to do blocking dbus calls. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19562 To: broulik, #plasma, #vdg, ngraham Cc: sitter, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,

D19560: [Desktop Sessions KCM] Add Restart to BIOS/UEFI checkbox

broulik updated this revision to Diff 53652. broulik added a comment. - Use introspected DBus stuff; used the nicer synchronous APIs, should be fine since this isn't a background service that we must not block REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D19675: Do not use SYSTEM when including header paths

hannahk added a comment. I don't have commit access Plz push this with: Hannah Kiekens hannahkiek...@gmail.com REPOSITORY R97 Bluedevil REVISION DETAIL https://phabricator.kde.org/D19675 To: hannahk, #plasma, drosca, apol Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot,

D19675: Do not use SYSTEM when including header paths

This revision was automatically updated to reflect the committed changes. Closed by commit R97:9ee6488290a8: Do not use SYSTEM when including header paths (authored by hannahk, committed by nicolasfella). REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE

D19678: Feature: Add an option to adjust screen brightness by quadratic curve instead of linear when using brightness keys

vishaw updated this revision to Diff 53645. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19678?vs=53644=53645 REVISION DETAIL https://phabricator.kde.org/D19678 AFFECTED FILES PowerDevilSettings.kcfg daemon/powerdevilbrightnesslogic.cpp kcmodule/global/GeneralPage.cpp

D19678: Feature: Add an option to adjust screen brightness by quadratic curve instead of linear when using brightness keys

vishaw created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. vishaw requested review of this revision. REVISION SUMMARY Add an option to make brightness up / brightness down key increase/decrease brightness along a quadratic curve instead of the usual

Notes for Monday Plasma meeting of 11/03/2019

Eike: * I have D19259 and D19518 waiting on review and would like to clear out my review queue before a trip this Friday if anyone has time. Diff 19259 "[Task Manager] Fix sorting of tasks on last desktop in sort-by- desktop mode" [Needs Review] https://phabricator.kde.org/D19259 Diff 19518

D19560: [Desktop Sessions KCM] Add Restart to BIOS/UEFI checkbox

sitter added a comment. I feel like this would be nicer a dbus interface class thingy. INLINE COMMENTS > kcmsmserver.cpp:118 > + > +if (enable) { > + > dialog->firmwareSetupMessageWidget->setMessageType(KMessageWidget::Information); Perhaps reduce the nesting by

[Powerdevil] [Bug 348529] Turn off screen after lock screen

https://bugs.kde.org/show_bug.cgi?id=348529 --- Comment #19 from goodmi...@goodmirek.com --- arne anka: The issue seems to be there is not enough people able to contribute their manpower or money to buy such a manpower. If I create an issue for this bug on bountysource.com and add $50 bounty, how

D19676: Fix out of bounds access error in SystemLoadViewer.qml

stefantux created this revision. stefantux added a project: Plasma. Herald added a subscriber: plasma-devel. stefantux requested review of this revision. REVISION SUMMARY Fixes bugs on startup of plasmashell if the widget is loaded by the user BUG: 405346 REPOSITORY R114 Plasma Addons

D19675: Do not use SYSTEM when including header paths

hannahk created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. hannahk requested review of this revision. REVISION SUMMARY Using SYSTEM here forces CMake to pass -isystem to gcc. This breaks crosscompiling on multiple occasions This incorrectly tells

[Powerdevil] [Bug 348529] Turn off screen after lock screen

https://bugs.kde.org/show_bug.cgi?id=348529 --- Comment #18 from Kai Uwe Broulik --- If it were trivially implemented, I would have long done it. Feel free to poke the code and submit a patch, relevant code can be found in powerdevil/daemon/actions/dpms -- You are receiving this mail because:

[Powerdevil] [Bug 348529] Turn off screen after lock screen

https://bugs.kde.org/show_bug.cgi?id=348529 arne anka changed: What|Removed |Added CC||kde-b...@ginguppin.de --- Comment #17 from arne

D19651: Improve the look of the Application Style KCM UI

GB_2 added a comment. In D19651#428459 , @GB_2 wrote: > In D19651#428458 , @ndavis wrote: > > > Can it have the same default width as the toolbar text location comboboxes? > > > Yeah, I can

D19651: Improve the look of the Application Style KCM UI

GB_2 updated this revision to Diff 53635. GB_2 added a comment. Check if configure button should be enabled after clicking "Defaults" and rename "cbStyle" to "comboStyle" REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19651?vs=53592=53635 BRANCH

D19670: [appmenu] Port configuration window to QQC2 and Kirigami.FormLayout

filipf added inline comments. INLINE COMMENTS > ngraham wrote in configGeneral.qml:21 > Is going that far actually required by anything? Probably not but I'm always checking Qt documentation and simply using the import they recommend. Because 5.16 will depend on Qt 5.12 it shouldn't be a

D19656: Comparisson has a typo, === and not = ==.

lbeltrame added a comment. This was already fixed by 0d5c93b7c5318600f53d214efca2a060c0f0eea7 . REPOSITORY R119 Plasma Desktop BRANCH fixMouseHandlerLoading REVISION DETAIL https://phabricator.kde.org/D19656