D19701: [Splash KCM] Sort "None" first

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Like it used to be before it was alphabetically sorted. TEST PLAN 5.15 None is now first,

D17073: Do not crop albumArt

trmdi updated this revision to Diff 53710. trmdi added a comment. This revision is now accepted and ready to land. Improve some stuff: - Use smaller fontsize, lineHeight for track/artist - "Anchor" albumArtImage's bottom to playerControlsLoader's top - When artist == "", let the song n

[Powerdevil] [Bug 348529] Turn off screen after lock screen

https://bugs.kde.org/show_bug.cgi?id=348529 --- Comment #21 from arne anka --- (In reply to Kai Uwe Broulik from comment #18) > If it were trivially implemented, I would have long done it. Feel free to > poke the code and submit a patch, relevant code can be found in > powerdevil/daemon/actions/d

[Powerdevil] [Bug 348529] Turn off screen after lock screen

https://bugs.kde.org/show_bug.cgi?id=348529 --- Comment #22 from arne anka --- (In reply to goodmirek from comment #19) > arne anka: The issue seems to be there is not enough people able to > contribute their manpower or money to buy such a manpower. > If I create an issue for this bug on bountys

D17073: Do not crop albumArt

filipf accepted this revision. filipf added a comment. Looking real good. Big props for keeping the same tooltip height as in all other situations. For reference here's what it looks like with a light scheme: F6686129: Screenshot_20190312_100751.png

D19605: Sharpen ApplicationMenu, Shade, ContextHelp icons

zzag added a comment. Not really, I still think it's not worth that. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D19605 To: ndavis, #vdg, #breeze, zzag, davidedmundson Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensr

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 11 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/11/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 12 Mar 2019 09:44:31 + Build duration: 1 min 35 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.12 - Build # 14 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.12/14/ Project: stable-kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 12 Mar 2019 09:44:31 + Build duration: 20 min and counting CONSOLE OUTPUT

KDE CI: Plasma » powerdevil » stable-kf5-qt5 SUSEQt5.12 - Build # 11 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.12/11/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 12 Mar 2019 09:48:25 + Build duration: 17 min and counting CONSOLE OUTPUT [...trunc

KDE CI: Plasma » systemsettings » stable-kf5-qt5 SUSEQt5.12 - Build # 14 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/stable-kf5-qt5%20SUSEQt5.12/14/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 12 Mar 2019 09:48:37 + Build duration: 22 min and counting CONSOLE OUTPUT [...t

D19703: connect clicked signal of view (again)

sitter created this revision. sitter added a reviewer: mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY activated, when the system is in double click mode is only triggered on double click. but even with i

D19704: style++

sitter created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY - drop excessive disconnect. when qobjects get destroyed they auto-disconnect all their connections, so the explicit disconnect serve

D19703: connect clicked signal of view (again)

This revision was automatically updated to reflect the committed changes. Closed by commit R102:dbaf5ba7e833: connect clicked signal of view (again) (authored by sitter). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19703?vs=53715&id=53718 REVISION DETA

D19704: style++

This revision was automatically updated to reflect the committed changes. Closed by commit R102:515575b9495b: style++ (authored by sitter). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19704?vs=53716&id=53720 REVISION DETAIL https://phabricator.kde.org

KDE CI: Plasma » breeze » stable-kf5-qt5 FreeBSDQt5.12 - Build # 21 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/breeze/job/stable-kf5-qt5%20FreeBSDQt5.12/21/ Project: stable-kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 12 Mar 2019 09:43:56 + Build duration: 2 hr 1 min and counting CONSOLE OUTPUT [..

D19707: Make QQC2 desktop style a RUNTIME dependency

broulik created this revision. broulik added reviewers: Plasma, sitter, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Should avoid cases of "my settings look ugly" because it is not installed TEST PLAN

D19701: [Splash KCM] Sort "None" first

This revision was automatically updated to reflect the committed changes. Closed by commit R119:ac3537178361: [Splash KCM] Sort "None" first (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19701?vs=53709&id=53723 REVISION DETAIL

D19596: color monochrome icons to tooltip colors

mart updated this revision to Diff 53724. mart added a comment. - icon()->iconName() REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19596?vs=53369&id=53724 BRANCH phab/iconColor REVISION DETAIL https://phabricator.kde.org/D19596 AFFECTED FILES

[Powerdevil] [Bug 348529] Turn off screen after lock screen

https://bugs.kde.org/show_bug.cgi?id=348529 --- Comment #23 from Christoph Feck --- Comment #11 works perfect for me. -- You are receiving this mail because: You are the assignee for the bug.

D19596: color monochrome icons to tooltip colors

mart updated this revision to Diff 53725. mart added a comment. - unbreak category icons REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19596?vs=53724&id=53725 BRANCH phab/iconColor REVISION DETAIL https://phabricator.kde.org/D19596 AFFECTED FILE

D19596: color monochrome icons to tooltip colors

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. It's gorgeous! sheepit REPOSITORY R102 KInfoCenter BRANCH phab/iconColor REVISION DETAIL https://phabricator.kde.org/D19596 To: mart, #plasma, sitter Cc: broulik, ngraham, plas

D19596: color monochrome icons to tooltip colors

This revision was automatically updated to reflect the committed changes. Closed by commit R102:23fa36983170: color monochrome icons to tooltip colors (authored by mart). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19596?vs=53725&id=53726 REVISION DETA

Plasma 5.15.3

Plasma 5.15.3 is now available for packaging https://kde.org/announcements/plasma-5.15.3.php

D19707: Make QQC2 desktop style a RUNTIME dependency

fvogt added inline comments. INLINE COMMENTS > CMakeLists.txt:68 > +DESCRIPTION "QtQuickControls 2 style that uses QWidget's QStyle for > painting" > +PURPOSE "Required at runtime by many KCMs" > +TYPE RUNTIME IIRC not only KCMs, but also some other dialogs REPOSITORY R119 Plasma

KDE CI: Plasma » breeze » stable-kf5-qt5 FreeBSDQt5.12 - Build # 22 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/breeze/job/stable-kf5-qt5%20FreeBSDQt5.12/22/ Project: stable-kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 12 Mar 2019 12:36:57 + Build duration: 18 min and counting

D19605: Sharpen ApplicationMenu, Shade, ContextHelp icons

ngraham added a comment. What's not worth what? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D19605 To: ndavis, #vdg, #breeze, zzag, davidedmundson Cc: ngraham, abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, s

D19605: Sharpen ApplicationMenu, Shade, ContextHelp icons

zzag added a comment. > What's not worth what? Making some icons sharp only for particular button size and font size. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D19605 To: ndavis, #vdg, #breeze, zzag, davidedmundson Cc: ngraham, abetts, plasma-devel, jraleigh,

D19605: Sharpen ApplicationMenu, Shade, ContextHelp icons

ngraham added a comment. If it doesn't cause regressions for other fonts and sizes, what's the drawback? Especially if the sizes and fonts that this improves are the default settings (are they, @ndavis?) REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D19605 To: ndavi

D19707: Make QQC2 desktop style a RUNTIME dependency

broulik added inline comments. INLINE COMMENTS > fvogt wrote in CMakeLists.txt:68 > IIRC not only KCMs, but also some other dialogs I just copied that over from the line above :) Plasma config dialogs also loosely qualify as KCMs REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phab

D19707: Make QQC2 desktop style a RUNTIME dependency

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. +1 for concept, functionality, and execution. Use whatever string seems most appropriate to you, I say. :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/

D17073: Do not crop albumArt

ngraham added a comment. In D17073#429514 , @filipf wrote: > F6686129: Screenshot_20190312_100751.png > > The only thing I'd do now is add a just a little bit of a left margin for the artist & track inf

D19596: color monochrome icons to tooltip colors

ngraham added a comment. Nice! Would you mind doing the same for System Settings, which has the same code? Dolphin's Tooltip could use the same treatment too, see https://bugs.kde.org/show_bug.cgi?id=404858 REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D19

D19687: Allow single images to be excluded from the slideshow

ngraham added a comment. In D19687#429373 , @davidre wrote: > In D19687#429332 , @ngraham wrote: > > > Also, this has nothing to do with your patch specifically, but seeing so many checkesd checkbox

D19605: Sharpen ApplicationMenu, Shade, ContextHelp icons

zzag resigned from this revision. zzag added a comment. Just to be clear, I'm not against good defaults. I don't like that the defaults are adjusted in such way that icons look sharp only with one particular font size and one particular button size. After all, KDE Plasma is configurable. If

D19687: Allow single images to be excluded from the slideshow

abetts added a comment. In D19687#429373 , @davidre wrote: > In D19687#429332 , @ngraham wrote: > > > Also, this has nothing to do with your patch specifically, but seeing so many checkesd checkboxe

D19687: Allow single images to be excluded from the slideshow

ngraham added a comment. In D19687#429700 , @abetts wrote: > One thing that might work is the behavior that google photos uses. When you select an item, the item shrinks by about 20% and a blue selection box appears around the image. It just mak

D19687: Allow single images to be excluded from the slideshow

abetts added a comment. In D19687#429709 , @ngraham wrote: > In D19687#429700 , @abetts wrote: > > > One thing that might work is the behavior that google photos uses. When you select an item, the it

D19605: Sharpen ApplicationMenu, Shade, ContextHelp icons

ngraham added a comment. I think I agree that it's much better to improve things universally if we can. But if we can't, then improving things for the default settings is good too. @ndavis, how well tested is this? We can't land this if it causes any regressions. I didn't spot any with

D19687: Allow single images to be excluded from the slideshow

ngraham added a comment. It is a selection, it's just that everything is selected by default. :) I think we should try to improve the checkbox's appearance rather than working around its deficiencies IMO. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1968

D19687: Allow single images to be excluded from the slideshow

davidre added a comment. In D19687#429710 , @abetts wrote: > In D19687#429709 , @ngraham wrote: > > > In D19687#429700 , @abetts wrote: > > > > > One t

D19707: Make QQC2 desktop style a RUNTIME dependency

This revision was automatically updated to reflect the committed changes. Closed by commit R119:737b114c2fa5: Make QQC2 desktop style a RUNTIME dependency (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19707?vs=53721&id=53734 REV

D19605: Sharpen ApplicationMenu, Shade, ContextHelp icons

ndavis added a comment. In D19605#429711 , @ngraham wrote: > I think I agree that it's much better to improve things universally if we can. But if we can't, then improving things for the default settings is good too. > > @ndavis, how well te

D19711: Use brush for painting line edits

mwoehlke created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mwoehlke requested review of this revision. REVISION SUMMARY Modify Style::drawFrameLineEditPrimitive to use the brush rather than the color to fill the background of line edits. This is mor

D19711: Use brush for painting line edits

mwoehlke added a comment. Note: this is "inspired" by qtColorButton , which uses a textured brush for colors with non-opaque alpha. This renders correctly with built-in styles, but not with current Oxygen. (I have a

D19711: Use brush for painting line edits

mwoehlke updated this revision to Diff 53743. mwoehlke added a comment. Also use brush in fallback path REPOSITORY R113 Oxygen Theme CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19711?vs=53742&id=53743 REVISION DETAIL https://phabricator.kde.org/D19711 AFFECTED FILES kstyl

D19711: Use brush for painting line edits

cfeck added inline comments. INLINE COMMENTS > oxygenstyle.cpp:3273 > > -const QColor background( palette.color( QPalette::Base ) ); > +const QBrush& background( palette.brush( QPalette::Base ) ); > Why the reference? REPOSITORY R113 Oxygen Theme REVISION DETAIL

D19651: Improve the look of the Application Style KCM UI

GB_2 updated this revision to Diff 53747. GB_2 added a comment. Improve preview REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19651?vs=53635&id=53747 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19651 AFFECTED FILES kcms/style

D19711: Use brush for painting line edits

mwoehlke added inline comments. INLINE COMMENTS > cfeck wrote in oxygenstyle.cpp:3273 > Why the reference? Force of habit... supposedly it forces copy elision (although new C++ is trying to make that happen regardless). Same pattern is used for `rect` and `palette` a couple lines above here.

D19712: Restore proper background color on list and sources pages

ngraham created this revision. ngraham added reviewers: apol, Discover Software Store. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Kirigami changed the defaults in 49856625cc4fb7136099ce69bfb92d99a5bca480 <

D19606: [Task Manager] Reorganize and improve presentation of context menu

ngraham updated this revision to Diff 53750. ngraham added a comment. Use new `window-*` icons from D19575 REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19606?vs=53462&id=53750 BRANCH reorganize-task-manager-c

Re: [kde-release-team] Re: Plasma 5.15.3

Would people like me to make tars with the id docs removed? I see kwin, systemsettings and plasma-desktop are affected. Jonathan On Tue, Mar 12, 2019 at 02:37:19PM +0100, Antonio Rojas wrote: > kwin doesn't build: > > index.docbook:159: parser error : Entity 'Alt' not defined > > >&Alt;

Re: [kde-release-team] Re: Plasma 5.15.3

Jonathan Riddell ha scritto: Would people like me to make tars with the id docs removed? I see kwin, systemsettings and plasma-desktop are affected. That's what everyone is waiting for :) For the record, I removed the Indonesian generated documentation from SVN for now. It can be re-added

D19714: Fixes crash when closing with Detailed Memory Information open

hallas created this revision. hallas added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. hallas requested review of this revision. REVISION SUMMARY Fixes a crash that occurs if you close KSysGuard with a Detailed Memory Information window open. Th

D19606: [Task Manager] Reorganize and improve presentation of context menu

ngraham added a comment. Idea to make the menu smaller: put the Configure and Alternatives items into the sub-menu, and rename it to just More Actions...: F6687262: Screenshot_20190312_135407.png Thoughts? REPOSITORY R119 Plasma Desktop BRA

D19605: Sharpen ApplicationMenu, Shade, ContextHelp icons

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Could not find any visual regressions at multiple integer and fractional scale factors with several fonts and plausible sizes (9pt, 11pt, 12pt). I say ship it. REPOSITORY R31 Breeze B

D19194: Adjust date string height to match time string with vertical panel

cfeck added inline comments. INLINE COMMENTS > Zren wrote in DigitalClock.qml:305 > This is inside a `State { when: plasmoid.formFactor == > PlasmaCore.Types.Vertical }` Could you please clarify? Are changes needed? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.

D19669: [binary-clock] Port configuration window to QQC2 and Kirigami.FormLayout

filipf updated this revision to Diff 53760. filipf added a comment. color pickers in the same row as their option; drop top-level Item REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19669?vs=53628&id=53760 BRANCH master REVISION DETAIL https://p

Plasma 5.15.3.1 updated tars

Three tars have been updated for Plasma 5.15.3.1 updated. They have the "id" docs manually removed as they do not compile. d9177bc7b9a884e5e85cb90f20b6858a17d87085c4b3f34050f4c863f9aaf86c kwin-5.15.3.1.tar.xz 6972769b7f63467a5cf0fe8960051c46b43a01d2b9ab89bb99a873f693383657 plasma-desktop-5.15.3.1

D19606: [Task Manager] Reorganize and improve presentation of context menu

hein added a comment. In D19606#429891 , @ngraham wrote: > Idea to make the menu smaller: put the Configure and Alternatives items into the sub-menu, and rename it to just More Actions...: > > F6687262: Screenshot_20190312_135407.png

D19605: Sharpen ApplicationMenu, Shade, ContextHelp icons

This revision was automatically updated to reflect the committed changes. Closed by commit R31:be9f150abe2d: Sharpen ApplicationMenu, Shade, ContextHelp icons (authored by ndavis). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19605?vs=53405&id=53764 REVISION