D19748: [Desktop Theme KCM] "Normalize" margin around background in previews

kossebau updated this revision to Diff 53856. kossebau added a comment. On a second look, of course the normalized margins should be also used for the content shown in the widget REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19748?vs=53855=53856

D19747: [fuzzy-clock] Port configuration window to QQC2 and Kirigami.FormLayout

filipf planned changes to this revision. filipf added a comment. Unforunately I'm getting bad stepSize behavior with the QQC2.Slider. It's reproducible even when keeping the original code and only porting the slider to QQC2 (that entails "from", "to", and removing "tickmarks"). If we can't

D19748: [Desktop Theme KCM] "Normalize" margin around background in previews

kossebau added a comment. The hack for "Air" was especially annoying as it fails for themes inheriting "Air" and reusing the widget background, like "Air openSUSE" Before: F6690445: Screenshot_20190314_060226.png After: F6690447:

D19748: [Desktop Theme KCM] "Normalize" margin around background in previews

kossebau created this revision. kossebau added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Instead of a hard-coded hack for a single theme ("Air") to deal with themes with large

D19747: [fuzzy-clock] Port configuration window to QQC2 and Kirigami.FormLayout

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REPOSITORY R114 Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D19747 AFFECTED FILES

D19745: Fix system tray UI/UX & refactor

ratijastk added a comment. In D19745#430695 , @anthonyfieroni wrote: > Video or screenshot will be helpful. Here they are, "debug" mode via colored rectangles with `anchors.fill: parent`. F6690427: old.mp4

D19746: [lock-logout] Port configuration window to QQC2 and Kirigami.FormLayout

filipf marked an inline comment as done. filipf added a comment. Forgot about that :) There's still strings to fix in the main qml file for this applet (lockout.qml). REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19746 To: filipf, #plasma, #vdg,

D19746: [lock-logout] Port configuration window to QQC2 and Kirigami.FormLayout

filipf updated this revision to Diff 53853. filipf added a comment. suspend -> sleep REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19746?vs=53852=53853 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19746 AFFECTED FILES

D19746: [lock-logout] Port configuration window to QQC2 and Kirigami.FormLayout

ngraham requested changes to this revision. ngraham added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > ConfigGeneral.qml:72 > +id: sleep > +text: i18n("Suspend") > +enabled: iconsPage.canSuspend && (checkedOptions > 1 || !checked) The

D19746: [lock-logout] Port configuration window to QQC2 and Kirigami.FormLayout

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D19746 AFFECTED FILES

D19745: Fix system tray UI/UX & refactor

anthonyfieroni added reviewers: VDG, Plasma, broulik. anthonyfieroni added a comment. Video or screenshot will be helpful. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19745 To: ratijastk, #vdg, #plasma, broulik Cc: anthonyfieroni, plasma-devel,

D19745: Fix system tray UI/UX & refactor

ratijastk created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ratijastk requested review of this revision. REVISION SUMMARY System tray widget had the following UX problem: Icons are laid out in a Flow QML layout, using minimal amount of space,

D19744: [taskmanager] Fix desktop file mapping for some apps

nicolasfella created this revision. nicolasfella added reviewers: Plasma, hein, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY Some apps (e.g. Nautilus) have more complex commands in their

D19664: [quickshare] Port configuration window to QQC2 and Kirigami.FormLayout

This revision was automatically updated to reflect the committed changes. Closed by commit R114:1a171706e7b3: [quickshare] Port configuration window to QQC2 and Kirigami.FormLayout (authored by filipf). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D19669: [binary-clock] Port configuration window to QQC2 and Kirigami.FormLayout

This revision was automatically updated to reflect the committed changes. Closed by commit R114:7437b39cf8d0: [binary-clock] Port configuration window to QQC2 and Kirigami.FormLayout (authored by filipf). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D19670: [appmenu] Port configuration window to QQC2 and Kirigami.FormLayout

This revision was automatically updated to reflect the committed changes. Closed by commit R120:08feca1f6859: [appmenu] Port configuration window to QQC2 and Kirigami.FormLayout (authored by filipf). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D19664: [quickshare] Port configuration window to QQC2 and Kirigami.FormLayout

filipf added a comment. ^ Also I may have may the window wider in the pic than it would be normally REPOSITORY R114 Plasma Addons BRANCH modernize-quickshare-config (branched from master) REVISION DETAIL https://phabricator.kde.org/D19664 To: filipf, #vdg, #plasma, apol, ngraham Cc:

D19669: [binary-clock] Port configuration window to QQC2 and Kirigami.FormLayout

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM! REPOSITORY R114 Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D19669 To: filipf, #vdg, #plasma, ngraham Cc: abetts, ngraham, plasma-devel,

D19606: [Task Manager] Reorganize and improve presentation of context menu

This revision was automatically updated to reflect the committed changes. Closed by commit R119:1daf42d9d734: [Task Manager] Reorganize and improve presentation of context menu (authored by ngraham). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19606?vs=53832=53833#toc REPOSITORY

D19606: [Task Manager] Reorganize and improve presentation of context menu

ngraham updated this revision to Diff 53832. ngraham added a comment. Rebase and fix merge conflicts REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19606?vs=53804=53832 BRANCH reorganize-task-manager-context-menu (branched from master) REVISION

D17073: Do not crop albumArt

rooty added a comment. In D17073#430519 , @ngraham wrote: > Just use a real bold if you want it bold. :) In which case, the label below it should have normal 100% opacity instead of 75%. +1 for the Bold. In for a penny in for a pound :D

D19664: [quickshare] Port configuration window to QQC2 and Kirigami.FormLayout

ngraham accepted this revision. ngraham added a comment. I think it looks fine, actually. Visually, the only change is centering the controls rather than left-aligning them. And the page already has a title. REPOSITORY R114 Plasma Addons BRANCH modernize-quickshare-config (branched

D17073: Do not crop albumArt

ngraham added a comment. Just use a real bold if you want it bold. :) In which case, the label below it should have normal 100% opacity instead of 75%. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17073 To: trmdi, hein, broulik, ngraham, #vdg, filipf,

D17073: Do not crop albumArt

rooty requested changes to this revision. rooty added a comment. This revision now requires changes to proceed. We still need to resolve the DemiBold issue. DemiBold fonts either aren't present or don't work in neon. (Or both...) REPOSITORY R119 Plasma Desktop REVISION DETAIL

D19340: Search new knsrc locations

leinir added inline comments. INLINE COMMENTS > ngraham wrote in KNSBackend.cpp:68 > Needs to be 57 now (we'll get all of this landed soon, not to worry!) > > Also, should the second one be `KNEWSTUFFCORE_VERSION_MINOR`? Seems weird > that both conditions are checking the major version. It

D19664: [quickshare] Port configuration window to QQC2 and Kirigami.FormLayout

abetts added a comment. While it makes sense to change it to the new form, the alignment feels odd because there are just a couple of items in the kcm. I wonder if having a title label would help ground the elements on the page. REPOSITORY R114 Plasma Addons BRANCH

D19664: [quickshare] Port configuration window to QQC2 and Kirigami.FormLayout

filipf updated this revision to Diff 53824. filipf added a comment. be conservative with imports and don't use a top level Item REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19664?vs=53623=53824 BRANCH modernize-quickshare-config (branched from

D19670: [appmenu] Port configuration window to QQC2 and Kirigami.FormLayout

filipf updated this revision to Diff 53823. filipf added a comment. be conservative with imports & don't use a top-level Item REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19670?vs=53629=53823 BRANCH master REVISION DETAIL

D19669: [binary-clock] Port configuration window to QQC2 and Kirigami.FormLayout

filipf updated this revision to Diff 53821. filipf added a comment. fix anchors & imports REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19669?vs=53760=53821 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19669 AFFECTED FILES

D17073: Do not crop albumArt

ngraham accepted this revision. ngraham added a comment. Awesome! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17073 To: trmdi, hein, broulik, ngraham, #vdg, filipf, rooty Cc: rooty, filipf, ndavis, abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel,

D17073: Do not crop albumArt

rooty added a comment. In D17073#430382 , @trmdi wrote: > Increase the contrast between the song name and the artist. > F6689279: image.png I would avoid using "Font.DemiBold" because - it

D17073: Do not crop albumArt

trmdi updated this revision to Diff 53812. trmdi added a comment. Increase the contrast between the song name and the artist. F6689279: image.png REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D19194: Adjust date string height to match time string with vertical panel

This revision was automatically updated to reflect the committed changes. Closed by commit R120:8f1b10b23a96: Adjust date string height to match time string with vertical panel (authored by antnyzilla, committed by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D19500: [KDirModel] Fix job urls change signal connection

broulik added a comment. Ping REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19500 To: broulik, #frameworks, dfaure, jtamate Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19340: Search new knsrc locations

ngraham requested changes to this revision. ngraham added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > KNSBackend.cpp:68 > QVector ret; > -for (const QString : >

D19194: Adjust date string height to match time string with vertical panel

ngraham added inline comments. INLINE COMMENTS > cfeck wrote in DigitalClock.qml:305 > Could you please clarify? Are changes needed? No changes are needed; that comment was indicating why @anthonyfieroni's comment was not applicable. REPOSITORY R120 Plasma Workspace BRANCH newclock2

D19194: Adjust date string height to match time string with vertical panel

rooty accepted this revision. rooty added a comment. +1 from me too REPOSITORY R120 Plasma Workspace BRANCH newclock2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D19194 To: antnyzilla, #vdg, #plasma, davidedmundson, Zren, ngraham, rooty Cc: rooty, cfeck, mart,

D19669: [binary-clock] Port configuration window to QQC2 and Kirigami.FormLayout

abetts added a comment. +1 REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D19669 To: filipf, #vdg, #plasma, ngraham Cc: abetts, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19606: [Task Manager] Reorganize and improve presentation of context menu

broulik added a comment. +1! REPOSITORY R119 Plasma Desktop BRANCH reorganize-task-manager-context-menu (branched from master) REVISION DETAIL https://phabricator.kde.org/D19606 To: ngraham, #plasma, #vdg, ndavis, hein Cc: abetts, broulik, ndavis, trickyricky26, plasma-devel,

D19606: [Task Manager] Reorganize and improve presentation of context menu

ngraham added a comment. All good now, @hein? REPOSITORY R119 Plasma Desktop BRANCH reorganize-task-manager-context-menu (branched from master) REVISION DETAIL https://phabricator.kde.org/D19606 To: ngraham, #plasma, #vdg, ndavis, hein Cc: abetts, broulik, ndavis, trickyricky26,

D19651: Improve the look of the Application Style KCM UI

This revision was automatically updated to reflect the committed changes. Closed by commit R119:a946944edb20: Improve the look of the Application Style KCM UI (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19651?vs=53803=53806

D19651: Improve the look of the Application Style KCM UI

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks! Code is sane too. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D19651 To: GB_2, #plasma, #vdg, rooty, ngraham Cc: ngraham,

D19606: [Task Manager] Reorganize and improve presentation of context menu

ngraham updated this revision to Diff 53804. ngraham added a comment. Put the Task-Manager-Specific actions in the "More Actions" submenu REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19606?vs=53750=53804 BRANCH

D19669: [binary-clock] Port configuration window to QQC2 and Kirigami.FormLayout

ngraham requested changes to this revision. ngraham added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > configGeneral.qml:23 > > -import QtQuick 2.0 > -import QtQuick.Controls 1.0 as QtControls > -import QtQuick.Layouts 1.1 > +import QtQuick 2.12 > +import

D19651: Improve the look of the Application Style KCM UI

GB_2 updated this revision to Diff 53803. GB_2 added a comment. Update Quick Help text REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19651?vs=53798=53803 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19651 AFFECTED FILES

D19194: Adjust date string height to match time string with vertical panel

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. No, changes are not needed. This works great for me and the code makes sense. I could not find any regressions in my testing. I recommend landing it. REPOSITORY R120 Plasma

D19651: Improve the look of the Application Style KCM UI

ngraham requested changes to this revision. ngraham added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kcmstyle.cpp:174 > +setQuickHelp( i18n("This module allows you to modify the visual > appearance " > + "of user interface

D19651: Improve the look of the Application Style KCM UI

GB_2 updated this revision to Diff 53798. GB_2 added a comment. Update preview REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19651?vs=53792=53798 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19651 AFFECTED FILES

Re: Upgrading Widgets from plasma-workspace

Hello, Thanks for your response! I tried to fix this once but unfortunately the systemactivity dataengine uses ksysguard which then probes kernel interfaces directly through some C code. It doesn't use Solid, where filtering out those interfaces would be easy. I'm not knowledgable enough in

D19651: Improve the look of the Application Style KCM UI

GB_2 updated this revision to Diff 53792. GB_2 added a comment. Implement Rooty's suggestions and update preview REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19651?vs=53747=53792 BRANCH master REVISION DETAIL

D19651: Improve the look of the Application Style KCM UI

GB_2 added a comment. In D19651#430117 , @rooty wrote: > Please consider abbreviating the labels: > > - dropping text in the last two dropdown menu items (No Text, Text Only, Beside Icons, Below Icons) > - dropping the word location (it's

D19651: Improve the look of the Application Style KCM UI

broulik added a comment. +1 on the new clean layout and for getting rid of tabs REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19651 To: GB_2, #plasma, #vdg Cc: broulik, rooty, abetts, ndavis, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel,

D17073: Do not crop albumArt

rooty added a comment. > @rooty is right though that usually there is always a hierarchy between the song and the artist. I'd also prefer a level 5 bold song title, but yeah it's a controversial topic these days. F6688452: Screenshot_20190313-134318_Spotify.jpg

D19651: Improve the look of the Application Style KCM UI

rooty added a comment. Please consider abbreviating the labels: - dropping text in the last two dropdown menu items (No Text, Text Only, Beside Icons, Below Icons) - dropping the word location (it's implicit) - substituting the word text with the word label (it's more accurate)

D17073: Do not crop albumArt

filipf added a comment. Nothing's a deal-breaker for me. I'm happy with the padding as it is. @rooty is right though that usually there is always a hierarchy between the song and the artist. I'd also prefer a level 5 bold song title, but yeah it's a controversial topic these days.

D17073: Do not crop albumArt

rooty added a comment. F6688411: image.png Level 5 for both labels would be acceptable to me if you make the song name bold. I would actually prefer this. However, it's likely that mart would throw a hissy fit over this change :D REPOSITORY

D19589: [DownloadJob] Set destUrl and total amount

This revision was automatically updated to reflect the committed changes. Closed by commit R856:b09312ad384b: [DownloadJob] Set destUrl and total amount (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE

D17073: Do not crop albumArt

rooty added a comment. > - Using a bigger font size means less characters could be display. The song name is always going to be elided, so that doesn't matter. > I don't see what is more important between artist/song. The song name is more important (more 'current' and calls for

D17073: Do not crop albumArt

trmdi added a comment. - Using a bigger font size means less characters could be display. I don't see what is more important between artist/song. - I don't think the topMargin is needed because there is already a space between the song name and the cover image. My goal is to keep the cover

D17073: Do not crop albumArt

rooty requested changes to this revision. rooty added a comment. This revision now requires changes to proceed. How about adding a little bit of a margin above the song name (Layout.topMargin 2, same as the left margin) And why not keep the level of the track name at 4? It's more important

D19562: [Logout Screen] Show info that rebooting will enter firmware setup

This revision was automatically updated to reflect the committed changes. Closed by commit R120:4c28cc3346d7: [Logout Screen] Show info that rebooting will enter firmware setup (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

Re: Upgrading Widgets from plasma-workspace

Hi Pavel, first of all thanks for your efforts!   - It is necessary to make the widget display only real disk devices (not virtual, not loop or ram) by default. I tried to fix this once but unfortunately the systemactivity dataengine uses ksysguard which then probes kernel interfaces

D19560: [Desktop Sessions KCM] Add Restart to BIOS/UEFI checkbox

This revision was automatically updated to reflect the committed changes. Closed by commit R119:0f5c7ede9da2: [Desktop Sessions KCM] Add Restart to BIOS/UEFI checkbox (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19560?vs=53661=53772#toc REPOSITORY R119 Plasma

Re: Upgrading Widgets from plasma-workspace

Any ideas would be greatly appreciated! 04.03.2019 15:55, Pavel: Good day. Need your help.  I am Upgrading Widgets from plasma-workspace and faced a number of problems.  I will show the modernization goals using the example of the diskactivity widget, designed to visualize hard drive

D17073: Do not crop albumArt

trmdi updated this revision to Diff 53770. trmdi added a comment. Remove duplicated "ToolTipWindowMouseArea" REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17073?vs=53769=53770 REVISION DETAIL https://phabricator.kde.org/D17073 AFFECTED FILES

D17073: Do not crop albumArt

trmdi updated this revision to Diff 53769. trmdi added a comment. - Add 2px to leftMargin of track/artist. I don't set the margin of the Next button because it has its own padding. - Resize the player icon when "minimized, we don't have a preview" Is it fine enough to commit now ?

Re: Plasma 5.15.3.1 updated tars

These have been further updated to use the correct compression method and to remove more broken docs 3c7b5ced440cf9ecd23b5905727cea4730188fbfe6388b4fcdb5eb3f52323147 kwin-5.15.3.2.tar.xz 21e54d489817751173049122410737db641a8e58955b84264a4ec861e302ff8a plasma-desktop-5.15.3.2.tar.xz