D19747: [fuzzy-clock] Port configuration window to QQC2 and Kirigami.FormLayout

filipf added a comment. Unless I'm doing something wrong, QQC2 Slider seems broken when `minimumValue` aka `from` is 1: import QtQuick.Controls 2.5 Slider { from: 1 to: 5 stepSize: 1 } REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D1

D19746: [lock-logout] Port configuration window to QQC2 and Kirigami.FormLayout

filipf updated this revision to Diff 53858. filipf added a comment. actually fix the "sleep" string REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19746?vs=53853&id=53858 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19746 AFFEC

D19746: [lock-logout] Port configuration window to QQC2 and Kirigami.FormLayout

filipf added a comment. ^ Ignore that, I was working on an older template. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19746 To: filipf, #plasma, #vdg, ngraham Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreute

D19744: [taskmanager] Fix desktop file mapping for some apps

hein requested changes to this revision. hein added a comment. This revision now requires changes to proceed. Sorry, that's too fast and loose for me. Let's investigate why Nautilus and GEdit hit this fallback path in the first place instead of matching via preferred means? Did you inve

D19744: [taskmanager] Fix desktop file mapping for some apps

broulik added a comment. Seems to match Nautilus and GEdit fine here. I have a `nautilus.desktop` and `org.gnome.Nautilus.desktop` on my system for some reason and it maps to `nautilus.desktop` REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19744 To: nico

D19744: [taskmanager] Fix desktop file mapping for some apps

nicolasfella added a comment. I did. The usual path fails because the Nautilus window announces itself with Nautilus/nautilus as appId/wmClass, but the name defined in the desktop file is "Files". Other useful entries like StartupWmClass are not set at all. The only indication that "Fil

D19748: [Desktop Theme KCM] "Normalize" margin around background in previews

broulik added a comment. +1 Since there is no "proper" way I think this is fine and also looks a lot better than the previous Kraut und Rüben. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19748 To: kossebau, #plasma, #vdg Cc: broulik, plasma-devel, jraleig

D19751: [Pager] Shrink label font size dynamically

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Tiny font is still more useful than "..." CCBUG: 405454 TEST PLAN Before F6690755: S

D19751: [Pager] Shrink label font size dynamically

This revision was automatically updated to reflect the committed changes. Closed by commit R119:de1c1c93c883: [Pager] Shrink label font size dynamically (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19751?vs=53862&id=53863 REVIS

D19752: [Splash KCM] Use InlineMessage for testing error

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY When testing a splash screen fails, a message box appears. This changes it to an `InlineLabel

D19753: [KSplashQML] Register DBus before loading the splash theme

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Loading the theme and setting everything up can take a while. Ensure that we catch all `setStage

D19687: Allow single images to be excluded from the slideshow

davidre updated this revision to Diff 53870. davidre added a comment. Change email address REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19687?vs=53697&id=53870 BRANCH toggleSlides REVISION DETAIL https://phabricator.kde.org/D19687 AFFECTED

D19340: Search new knsrc locations

leinir updated this revision to Diff 53876. leinir added a comment. Update to require 5.57, and also actually inspect the minor version rather than two instances of the major version. REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19340?vs=

D19748: [Desktop Theme KCM] "Normalize" margin around background in previews

kossebau added a comment. Seems the broken openSUSEdark display was due to cached rendered pixmaps, at least I can no longer reproduce it. So for completeness, and do celebrate the initial recovery of good old Fluffy Bunny theme, here another After (beware, can harm sensitive eyes): F66910

D19748: [Desktop Theme KCM] "Normalize" margin around background in previews

ngraham accepted this revision as: VDG. ngraham added a comment. This visual change makes sense to me, +1. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19748 To: kossebau, #plasma, #vdg Cc: ngraham, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, Zre

D19745: Fix system tray UI/UX & refactor

ngraham added a comment. Pretty nice stuff! While you're at it, how about implementing a UI change so that while the popup is open, its contents change as you slide the mouse along the icons (but only when there's a single row/column)? REPOSITORY R120 Plasma Workspace REVISION DETAIL ht

D19747: [fuzzy-clock] Port configuration window to QQC2 and Kirigami.FormLayout

ngraham added a comment. We'll need a bug report on this slider issue if we're gonna work around it, at a minimum. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D19747 To: filipf, #plasma, #vdg, ngraham Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBo

D19340: Search new knsrc locations

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nice. So do we need to change KNS providers/apps to install their files in the new location now? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D

D19340: Search new knsrc locations

leinir added a comment. In D19340#430964 , @ngraham wrote: > Nice. So do we need to change KNS providers/apps to install their files in the new location now? We'll need to wait until the next time the CI system gets updated for dependenc

D19747: [fuzzy-clock] Port configuration window to QQC2 and Kirigami.FormLayout

abetts added a comment. +1 REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D19747 To: filipf, #plasma, #vdg, ngraham Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17073: Do not crop albumArt

trmdi updated this revision to Diff 53884. trmdi added a comment. Use `Font.Bold` for the song name. (I feel it's a bit too bold though.) REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17073?vs=53812&id=53884 REVISION DETAIL https://phabricator.

D17073: Do not crop albumArt

ngraham added inline comments. INLINE COMMENTS > ToolTipInstance.qml:338 > +visible: text != "" > +opacity: 0.75 > } No need to reduce the opacity here if the song name is bold. REPOSITORY R119 Plasma Desktop RE

D19687: Allow single images to be excluded from the slideshow

ngraham added a comment. In D19687#429746 , @davidre wrote: > Anchoring to the whole delegate: F6686885: grafik.png Yeah that doesn't look great with the Breeze style checkbox. Within the frame seem

D19612: RFC port to bugzilla REST API

sitter updated this revision to Diff 53888. sitter added a comment. search now searches long description so only get somewhat pertinent bugs come back as results. also implement pagniation of results (ie. only 25 results at a time are queried, this is both much faster to query and to parse).

D17073: Do not crop albumArt

trmdi added inline comments. INLINE COMMENTS > ngraham wrote in ToolTipInstance.qml:338 > No need to reduce the opacity here if the song name is bold. I think that makes it look nicer. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17073 To: trmdi, hein, broul

D19612: RFC port to bugzilla REST API

sitter updated this revision to Diff 53889. sitter added a comment. redo diff so it maybe doesn't include nonesense REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19612?vs=53888&id=53889 BRANCH webservice REVISION DETAIL https://phabricator.kde.org/D1

D17073: Do not crop albumArt

rooty accepted this revision as: rooty. rooty added a comment. I normally wouldn't ask this but seeing as my fonts have been acting up, can you please post a screenshot? Sorry :D I'm giving you my +1, if the others decide we shouldn't go ahead with the bold (in case it's too bold) then I

D17073: Do not crop albumArt

rooty added a comment. P.S. We could also implement this in latte-dock. Not just that, but also give latte's ToolTipInstance a makeover (the fonts are really huge). I've actually already used this diff to modify latte-dock's ToolTipInstance: F6691364: image.png

D19747: [fuzzy-clock] Port configuration window to QQC2 and Kirigami.FormLayout

filipf updated this revision to Diff 53893. filipf added a comment. link the bug report for qqc2 slider REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19747?vs=53854&id=53893 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19747 AFFE

D19747: [fuzzy-clock] Port configuration window to QQC2 and Kirigami.FormLayout

filipf added a comment. In D19747#430961 , @ngraham wrote: > We'll need a bug report on this slider issue if we're gonna work around it, at a minimum. Done: https://bugs.kde.org/show_bug.cgi?id=405471 REPOSITORY R114 Plasma Addons REV

D17073: Do not crop albumArt

mvourlakos added a comment. In D17073#431047 , @rooty wrote: > P.S. We could also implement this in latte-dock. Not just that, but also give latte's ToolTipInstance a makeover (the fonts are really huge). No problem... Concerning Latte, j

D17073: Do not crop albumArt

rooty added a comment. > HInt: Please dont discuss here the Latte case because it creates noise for all the reviewers interested in this Sure thing. Sorry :D REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17073 To: trmdi, hein, broulik, ngraham, #vdg, f

D19763: [Desktop Theme KCM] Emit current index change when resetting the model

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY When the model is reset, `GridView` invalidates its `currentIndex` resulting in no theme being se

D19745: Fix system tray UI/UX & refactor

ratijastk added a comment. In D19745#430958 , @ngraham wrote: > Pretty nice stuff! While you're at it, how about implementing a UI change so that while the popup is open, its contents change as you slide the mouse along the icons (but only when

D17073: Do not crop albumArt

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Huge improvement. Let's do it. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17073 To: trmdi, hein, broulik, ngraham, #vdg, filipf, rooty Cc: mvourlakos

D17073: Do not crop albumArt

rooty added a comment. Looks amazing. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17073 To: trmdi, hein, broulik, ngraham, #vdg, filipf, rooty Cc: mvourlakos, rooty, filipf, ndavis, abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai

D19747: [fuzzy-clock] Port configuration window to QQC2 and Kirigami.FormLayout

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks. I can confirm the bug not only here but in the wild in our libinput mouse and touchpad KCMs. The workaround seems sane for now. REPOSITORY R114 Plasma Addons BRANCH master R

D17073: [Task Manager] Do not crop album art in tooltip

This revision was automatically updated to reflect the committed changes. Closed by commit R119:e8af68ad76bb: [Task Manager] Do not crop album art in tooltip (authored by trmdi, committed by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17073

D19763: [Desktop Theme KCM] Emit current index change when resetting the model

This revision was automatically updated to reflect the committed changes. Closed by commit R119:fa99dfb2fd7a: [Desktop Theme KCM] Emit current index change when resetting the model (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19

D19746: [lock-logout] Port configuration window to QQC2 and Kirigami.FormLayout

This revision was automatically updated to reflect the committed changes. Closed by commit R120:cef563e560ac: [lock-logout] Port configuration window to QQC2 and Kirigami.FormLayout (authored by filipf). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D

D19747: [fuzzy-clock] Port configuration window to QQC2 and Kirigami.FormLayout

This revision was automatically updated to reflect the committed changes. Closed by commit R114:e32e12df50d3: [fuzzy-clock] Port configuration window to QQC2 and Kirigami.FormLayout (authored by filipf). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D197

D19687: Allow single images to be excluded from the slideshow

filipf added a comment. The checkboxes are right where they're supposed to be, as for their visibility: maybe it would be useful if we had a variable that would allow us to add a background behind a checkbox. F6692107: image.png REPOSITORY R120 P

D19631: [sddm-theme/lock screen] Overhaul font sizes

filipf accepted this revision as: filipf. filipf added a comment. If we're not going to be able to change SDDM's default font, this is the second best solution. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19631 To: rooty, #vdg, #plasma, ngraham, filipf

D19777: Apply changes for tooltip from upstream

trmdi created this revision. trmdi added reviewers: mvourlakos, rooty. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REVISION SUMMARY - Do not crop albumArt - Use smaller fontsizes for labels. REPOSITORY R878 Latte Dock BR

D19748: [Desktop Theme KCM] "Normalize" margin around background in previews

kossebau updated this revision to Diff 53938. kossebau added a comment. Clip the background to not overrun the item border and thus also the selection/highlight markup Hit & found thanks to fluffy themes :) F6692527: Screenshot_20190315_073305.png