D19777: Apply changes for tooltip from upstream

trmdi updated this revision to Diff 53940. trmdi added a comment. Delete the forgotten lines REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19777?vs=53937&id=53940 BRANCH update-tooltip (branched from master) REVISION DETAIL https://phabricator.kde

D19777: Apply changes for tooltip from upstream

rooty requested changes to this revision. rooty added a comment. This revision now requires changes to proceed. Does this work for you? It doesn't work for me at all. There are no icons in the dock and the one applet that does show up has its label misplaced by a huge margin: F6692585:

D19777: Apply changes for tooltip from upstream

trmdi added a comment. Yes, it works for me. How did you apply the patch ? REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D19777 To: trmdi, mvourlakos, rooty Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abett

D19777: Apply changes for tooltip from upstream

rooty added a comment. In D19777#431430 , @trmdi wrote: > Yes, it works for me. How did you apply the patch ? Overwrote ToolTipInstance.qml with your version REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D197

D19777: Apply changes for tooltip from upstream

rooty added a comment. Hold on I'm gonna try it with the git version REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D19777 To: trmdi, mvourlakos, rooty Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, seb

D19777: Apply changes for tooltip from upstream

trmdi updated this revision to Diff 53941. trmdi added a comment. Small fix for margins REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19777?vs=53940&id=53941 BRANCH update-tooltip (branched from master) REVISION DETAIL https://phabricator.kde.org/

D19434: Change entry of Endpoint UI

andersonbruce added a comment. In D19434#424235 , @jgrulich wrote: > In D19434#423613 , @andersonbruce wrote: > > > In D19434#423458 , @jgrulich wrote: >

D19777: Apply changes for tooltip from upstream

mvourlakos accepted this revision. mvourlakos added a comment. I tested it and I like it a lot... I dont know how to show album art but it works just fine... big improvement!!! @trmdi please apply it REPOSITORY R878 Latte Dock BRANCH update-tooltip (branched from master) REVISION

D19784: Avoid calling QT_LSTAT and accessing recent documents

hoffmannrobert created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. hoffmannrobert requested review of this revision. REVISION SUMMARY Document entries pointing to unavailable network shares freeze the application menu, so avoid calling QT_LSTAT (lsta

D19777: Apply changes for tooltip from upstream

This revision was automatically updated to reflect the committed changes. Closed by commit R878:432d6fb75349: Apply changes for tooltip from upstream (authored by trmdi). REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19777?vs=53941&id=53952 REVISION DETAI

D19612: RFC port to bugzilla REST API

sitter updated this revision to Diff 53953. sitter added a comment. competing api design on commentsclient::getfrombug2 this has some more cruft but looks nicer from a usage POV IMO it's basically lambda chaining originating in a signal... instead of return a kjob the getter returns

D19434: Change entry of Endpoint UI

This revision was automatically updated to reflect the committed changes. Closed by commit R116:3dea89bad64a: Change entry of Endpoint UI (authored by andersonbruce, committed by jgrulich). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org

D19788: [service runner] throw out kde3 "compat" code for KCMs

sitter created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY Desktop files such as kde/foo.desktop are identified as kde-foo.desktop because of the menu spec If the directory contains su

D19788: [service runner] throw out kde3 "compat" code

GB_2 added a comment. This is bug 383287 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19788 To: sitter, broulik Cc: GB_2, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18438: [Task Manager] When closing apps, resize only when mouse is out.

thsurrel added a comment. Ping Does this seem better now, @hein ? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18438 To: thsurrel, #plasma, #vdg, hein Cc: hein, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterber

D19789: [color-picker] Port configuration window to QQC2 and Kirigami.FormLayout

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REPOSITORY R114 Plasma Addons BRANCH qqc2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D19789 AFFECTED FILES applets/col

D19789: [color-picker] Port configuration window to QQC2 and Kirigami.FormLayout

filipf updated this revision to Diff 53965. filipf added a comment. forgot to add anchors REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19789?vs=53964&id=53965 BRANCH qqc2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D1978

D19790: Improve the look of the GTK Application Style KCM UI

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Apply the KDE HIG, move the KCM below the Application Style KCM, drop the word GNOME, update strings a

D19748: [Desktop Theme KCM] "Normalize" margin around background in previews

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Let's ship Plasma Bunny by default! /s REPOSITORY R119 Plasma Desktop BRANCH normalizeplasmathemepreviewmargins REVISION DETAIL https://phabricator.kde.org/D19748 To: kossebau, #p

D19784: Avoid calling QT_LSTAT and accessing recent documents

ngraham added a comment. Nice, kinda sounds like this fixes https://bugs.kde.org/show_bug.cgi?id=373352. Can you confirm? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19784 To: hoffmannrobert Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenB

D19748: [Desktop Theme KCM] "Normalize" margin around background in previews

kossebau added a comment. Personally I would consider this a bug fix and apply to 5.12. I always thought the openSUSE themes are broken just by their preview being so messy. It's a simple fix with no side-effects by what I can tell. What do you think? REPOSITORY R119 Plasma Desktop BRAN

D19790: Improve the look of the GTK Application Style KCM UI

apol added inline comments. INLINE COMMENTS > kde-gtk-config.desktop:1 > [Desktop Entry] > +Exec=kcmshell5 kde-gtk-config All this not saying they're right or wrong but unrelated to the change at stake. > kde-gtk-config.desktop:59 > + > +X-KDE-Keywords=gnome,gtk,style,styles,look,widget,icons,

D19784: Avoid calling QT_LSTAT and accessing recent documents

apol added inline comments. INLINE COMMENTS > recentusagemodel.cpp:254 > +// return any useful information for our purposes here. > +url.setScheme(QString()); > +KFileItem fileItem(url); This looks very much like a workaround. How about adding an argument to the KFileItem to skip th

D19784: Avoid calling QT_LSTAT and accessing recent documents

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > recentusagemodel.cpp:261 > > if (!url.isValid() || !(fileItem.isFile() || fileItem.isDir())) { > return QVariant(); How do you expect isFile()

D19796: [Device Notifier] Restore Solid notification messages

thsurrel created this revision. thsurrel added reviewers: Plasma, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. thsurrel requested review of this revision. REVISION SUMMARY Commit 17380886

D19340: Search new knsrc locations

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. All right, since the app dependency freeze is passed, it looks like any changes to apps will need to go into 19.08.0. Changes to anything on the Plasma release cycle can go in i

D19340: Search new knsrc locations

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Er, whoops. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D19340 To: leinir, #discover_software_store, apol, ngraham Cc: plasma-devel, #discover

D19797: [fifteen-clock] Modernize settings window

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY Fifteen-clock's configuration window is ported to QQC2 and Kirigami.FormLayout. Setting are reorganized in a way that makes more se

D19789: [color-picker] Port configuration window to QQC2 and Kirigami.FormLayout

This revision was automatically updated to reflect the committed changes. Closed by commit R114:fb4fcae3f94e: [color-picker] Port configuration window to QQC2 and Kirigami.FormLayout (authored by filipf). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19

D19797: [fifteen-clock] Modernize settings window

filipf updated this revision to Diff 53983. filipf added a comment. forgot anchors again REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19797?vs=53981&id=53983 BRANCH modernize-15clock-settings (branched from master) REVISION DETAIL https://phab