D19469: [sddm-theme] Update login screen preview image

rooty added a comment. Sure thing Sorry it's been taking so long, I've been having the hardest time getting virtualbox to work... REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19469 To: rooty, #vdg, ngraham, filipf Cc: plasma-devel, jraleigh, GB_2, ragr

D19096: [Kicker] Fix "Tooltip can not be displayed"

trmdi requested review of this revision. trmdi added a comment. Are you ok with the new implementation? @hein REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19096 To: trmdi, ngraham, hein, #plasma, broulik Cc: abetts, ndavis, plasma-devel, jraleigh, GB_2, rag

D19469: [sddm-theme] Update login screen preview image

ngraham added a comment. Ping. :) Would be nice to get T10325 closed out. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19469 To: rooty, #vdg, ngraham, filipf Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot,

D19899: Adapt leaf Category names for kns backend, and ensure correct filters

This revision was automatically updated to reflect the committed changes. Closed by commit R134:c4e8f04a2489: Adapt leaf Category names for kns backend, and ensure correct filters (authored by leinir). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19899?vs=54366&id=54378#toc REPOSITORY

D19880: Fix crash in category comparison caused by incorrect filters

This revision was automatically updated to reflect the committed changes. Closed by commit R134:356fe5019436: Fix crash in category comparison caused by incorrect filters (authored by leinir). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1988

D19880: Fix crash in category comparison caused by incorrect filters

leinir updated this revision to Diff 54373. leinir added a comment. Remove some future-leftovers REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19880?vs=54302&id=54373 REVISION DETAIL https://phabricator.kde.org/D19880 AFFECTED FILES l

D19550: [Media Frame] Set sourceSize for higher quality and lower memory consumption

This revision was automatically updated to reflect the committed changes. Closed by commit R114:4665d0b41aac: [Media Frame] Set sourceSize for higher quality and lower memory consumption (authored by ngraham). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.or

D19550: [Media Frame] Set sourceSize for higher quality and lower memory consumption

ngraham added a comment. @d_ed told me to shipit! REPOSITORY R114 Plasma Addons BRANCH use-mipmapping-for-higher-quality (branched from Plasma/5.15) REVISION DETAIL https://phabricator.kde.org/D19550 To: ngraham, #plasma, broulik, davidedmundson Cc: anthonyfieroni, broulik, davidedmun

D19550: [Media Frame] Set sourceSize for higher quality and lower memory consumption

ngraham updated this revision to Diff 54370. ngraham added a comment. Improve comment REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19550?vs=54364&id=54370 BRANCH use-mipmapping-for-higher-quality (branched from Plasma/5.15) REVISION DETAIL htt

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.12 - Build # 171 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.12/171/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 19 Mar 2019 21:29:01 + Build duration: 1 min 44 sec and counting CONSOLE OUTPUT [...truncated 21

D19899: Adapt leaf Category names for kns backend, and ensure correct filters

leinir created this revision. leinir added reviewers: Discover Software Store, apol, ngraham. leinir added a project: Discover Software Store. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. leinir requested review of this revision. REVISION SUMMARY Previously, categorie

D19550: [Media Frame] Set sourceSize for higher quality and lower memory consumption

ngraham updated this revision to Diff 54364. ngraham added a comment. Don't initially reload twice REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19550?vs=54155&id=54364 BRANCH use-mipmapping-for-higher-quality (branched from Plasma/5.15) REVISION

D19894: Use https for links in the UI

vkrause created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. vkrause requested review of this revision. REPOSITORY R871 DrKonqi BRANCH master REVISION DETAIL https://phabricator.kde.org/D19894 AFFECTED FILES src/aboutbugreportingdialog.cpp sr

D19454: Fix errors in kirigami example files

This revision was automatically updated to reflect the committed changes. Closed by commit R169:8dc09a000125: Fix errors in kirigami example files (authored by ognarb). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19454?vs=54124&id=54354#toc REPOSITORY R169 Kirigami CHANGES SINCE LA

D19502: Add a SearchField and PasswordField component

This revision was automatically updated to reflect the committed changes. Closed by commit R169:546f82f9e645: Add a SearchField and PasswordField component (authored by ognarb). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19502?vs=54119&id=54353 REVISION

D19893: Fix "Tooltip can not be displayed"

trmdi created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH fix-tooltip (branched from master) REVISION DETAIL https://phabricator.kde.org/D19893 AFFECTED FILES apple

D19096: Improvements for long label items in Application Dashboard

trmdi added a comment. In D19096#434638 , @abetts wrote: > Does this patch only concern itself with the icons and labels below them or also the categories on the right? If so, it feels like the category labels on the right are huge in comparison

D19890: Changes the drawing of QToolButton inline indicator arrows

hallas added a comment. Hi @ngraham , I have made this separate change to discuss the redesign of the indicator arrows. The current patch changes the indicator arrow so that the toolbutton stays the same size and the indicator arrow is drawn as a two pixel arrow with one pixel margin to

D19096: Improvements for long label items in Application Dashboard

abetts added a comment. Does this patch only concern itself with the icons and labels below them or also the categories on the right? If so, it feels like the category labels on the right are huge in comparison to the icon labels. Maybe those also need some touch up? REPOSITORY R119 Plasm

D19096: Improvements for long label items in Application Dashboard

trmdi updated this revision to Diff 54349. trmdi added a comment. This revision is now accepted and ready to land. Update code style, only fix the tooltip bug. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19096?vs=52321&id=54349 BRANCH fix-toolt

D19890: Changes the drawing of QToolButton inline indicator arrows

hallas created this revision. hallas added reviewers: VDG, Breeze, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. hallas requested review of this revision. REVISION SUMMARY Changes the drawing of inline indicators with QToolButtons so that it is drawn as a sm

D19166: Add application path as valid path for debuggers

patrickelectric updated this revision to Diff 54345. patrickelectric added a comment. Update style again REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19166?vs=54316&id=54345 BRANCH arcpatch-D19166 REVISION DETAIL https://phabricator.kde.org/D19166

D19873: [image-wallpaper] Fix horizontal alignment of the "Positioning:" row

filipf added a comment. In D19873#434571 , @davidre wrote: > It seems it was changed in this commit to explicitly use Kirigami units: 98d9f681a37e2ac2feb6bf5cb5e8a54f4c7e874e

D19873: [image-wallpaper] Fix horizontal alignment of the "Positioning:" row

davidre added a comment. It seems it was changed in this commit to explicitly use Kirigami units: 98d9f681a37e2ac2feb6bf5cb5e8a54f4c7e874e Was the Color wallpaper forgotten or did this reason not apply to it? Shoul

D19873: [image-wallpaper] Fix horizontal alignment of the "Positioning:" row

filipf added a comment. In D19873#434568 , @davidre wrote: > Mhm if I change it to use units like Color instead of Kirigami units it seems aligned properly: > F6702138: grafik.png The spacing in t

D19873: [image-wallpaper] Fix horizontal alignment of the "Positioning:" row

davidre added a comment. Mhm if I change it to use units like Color instead of Kirigami units it seems aligned properly: F6702138: grafik.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19873 To: filipf, #plasma,

D19784: Avoid calling QT_LSTAT and accessing recent documents

hoffmannrobert marked an inline comment as done. hoffmannrobert added a comment. In D19784#431683 , @ngraham wrote: > Nice, kinda sounds like this fixes https://bugs.kde.org/show_bug.cgi?id=373352. Can you confirm? No, unfortunately it do

D19873: [image-wallpaper] Fix horizontal alignment of the "Positioning:" row

davidre added a comment. Maybe it would be worth it to check out how the other wallpaper plugins that don't suffer from this issue align their controls ? potd: F6702121: grafik.png color: F6702124: grafik.png C

D19784: Avoid calling QT_LSTAT and accessing recent documents

hoffmannrobert marked 3 inline comments as done. hoffmannrobert added a comment. See https://phabricator.kde.org/D19887 INLINE COMMENTS > dfaure wrote in recentusagemodel.cpp:261 > How do you expect isFile() and isDir() to work without a QT_LSTAT call? A document should always be a file, so

D19784: Avoid calling QT_LSTAT and accessing recent documents

hoffmannrobert updated this revision to Diff 54339. hoffmannrobert added a comment. - Use new KFileItem constructor with skipStat set to true REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19784?vs=53951&id=54339 BRANCH fix_recent_documents_kicker

D19874: [Kickoff] Reduce the margins of KickoffItem

ndavis added a comment. Another thing is the ratio between the left/right margins and the top/bottom margins varies with font size, so maybe Kickoff really does need some fixing up. The height is `2 * units.smallSpacing`, plus the maximum value of the icon, title+subtile or arrow height.

D19874: [Kickoff] Reduce the margins of KickoffItem

ndavis added a comment. In D19874#434319 , @ngraham wrote: > +1 conceptually. Since Kickoff has its own side margins, these additional margins in the items themselves are just unnecessary. I tried to see how they would look with no margin

D19873: [image-wallpaper] Fix horizontal alignment of the "Positioning:" row

filipf added a subscriber: mart. filipf added a comment. @mart would you happen to know how to trick one FormLayout into thinking its content is as wide as another FormLayout's content? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19873 To: filipf, #plas

D19873: [image-wallpaper] Fix horizontal alignment of the "Positioning:" row

filipf added a comment. In D19873#434468 , @ngraham wrote: > In D19873#434441 , @filipf wrote: > > > I just have to figure out how trick the image wallpaper's FormLayout into thinking its form is as

D19873: [image-wallpaper] Fix horizontal alignment of the "Positioning:" row

ngraham added a comment. In D19873#434441 , @filipf wrote: > I just have to figure out how trick the image wallpaper's FormLayout into thinking its form is as wide as the main one's. That's why. :) They come from different sources, so the

D19873: [image-wallpaper] Fix horizontal alignment of the "Positioning:" row

filipf added a comment. In D19873#434426 , @ngraham wrote: > In D19873#434232 , @filipf wrote: > > > This is just theoretical, but what are the obstacles with adding this whole row to the actual Form

D19873: [image-wallpaper] Fix horizontal alignment of the "Positioning:" row

ngraham added a comment. In D19873#434232 , @filipf wrote: > This is just theoretical, but what are the obstacles with adding this whole row to the actual FormLayout file and just setting `visible: when_image_wallpaper_is_used` ? Because

D19873: [image-wallpaper] Fix horizontal alignment of the "Positioning:" row

abetts added a comment. +1 visually REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19873 To: filipf, #plasma, ngraham Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19874: [Kickoff] Reduce the margins of KickoffItem

rooty added a comment. You should test this with all four orientations. And if you redo the screenshots do them like this: Category - before after Long description - before after It's really hard to appreciate the differences this way. REPOSITORY R119 Plasma Desktop REVISI

D19821: Fix breeze dialog background with Qt 5.12.2

rooty added a comment. In D19821#434410 , @fvogt wrote: > In D19821#434405 , @rooty wrote: > > > This wasn't supposed to land in Plasma 5.15 as well as master? > > > Plasma Framework is (in this

D19821: Fix breeze dialog background with Qt 5.12.2

fvogt added a comment. In D19821#434405 , @rooty wrote: > This wasn't supposed to land in Plasma 5.15 as well as master? Plasma Framework is (in this case unfortunately) a Framework, so no stable branches. REPOSITORY R242 Plasma Framew

D19821: Fix breeze dialog background with Qt 5.12.2

rooty added a comment. This wasn't supposed to land in Plasma 5.15 as well as master? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19821 To: fvogt, #plasma, rooty Cc: acooligan, filipf, heikobecker, falqueto, rooty, Zren, arojas, rikmills, astu

D19821: Fix breeze dialog background with Qt 5.12.2

fvogt added a comment. In D19821#434371 , @rikmills wrote: > I guess it is very likely, but all the same for the record I will request that this results in a 5.56.2 release of plasma-framework. I agree - as this touches binary files, appl

D19821: Fix breeze dialog background with Qt 5.12.2

This revision was automatically updated to reflect the committed changes. Closed by commit R242:3aba8a7e10e5: Fix breeze dialog background with Qt 5.12.2 (authored by fvogt). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19821?vs=54176&id=5

D19166: Add application path as valid path for debuggers

patrickelectric updated this revision to Diff 54316. patrickelectric added a comment. Update style REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19166?vs=52099&id=54316 BRANCH arcpatch-D19166 REVISION DETAIL https://phabricator.kde.org/D19166 AFFEC

D19821: Fix breeze dialog background with Qt 5.12.2

rikmills added a comment. I guess it is very likely, but all the same for the record I will request that this results in a 5.56.2 release of plasma-framework. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D19821 To: fvogt, #plasm

D19821: Fix breeze dialog background with Qt 5.12.2

fvogt added a comment. In D19821#434345 , @acooligan wrote: > Does this patch cover tooltips as shown in https://i.imgur.com/WrISfNg.png ? Yes. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phab

D19851: [kirigami] make it compile without foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R169:12fb6c5de392: [kirigami] make it compile without foreach (authored by mlaurent). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19851?vs=54207&id=54311 REVISION D

D19855: Fix bugzilla login page widgets tab order

marcelomariano added reviewers: sitter, cfeck, Plasma. marcelomariano added a comment. That is true. I will consider taking a look at KPasswordLineEdit implementation. Thanks a lot! REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D19855 To: marcelomariano, sitter,

D19855: Fix bugzilla login page widgets tab order

marcelomariano removed reviewers: patrickelectric, sitter, cfeck, Plasma. marcelomariano added a comment. That is true. I will consider taking a look at KPasswordLineEdit implementation. Thanks a lot! REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D19855 To: marc

D19821: Fix breeze dialog background with Qt 5.12.2

acooligan added a comment. Does this patch cover tooltips as shown in https://i.imgur.com/WrISfNg.png ? REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D19821 To: fvogt, #plasma, rooty Cc: acooligan, filipf, heikobecker, falqueto, r

Re: Plasma distro-specific installation path?

I am trying to find a way to access some application data. Examples are, plasma desktopthemes and kwin colorschemes... In the future this will also be needed because Latte will provide installable qml indicators (something like plasma qml applets currently do but these are going to be used only to

D19874: [Kickoff] Reduce the margins of KickoffItem

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. +1 conceptually. Since Kickoff has its own side margins, these additional margins in the items themselves are just unnecessary. I think there's already enough indentation with c

D19880: Fix crash in category comparison caused by incorrect filters

leinir created this revision. leinir added reviewers: Discover Software Store, apol, ngraham. leinir added a project: Discover Software Store. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. leinir requested review of this revision. REVISION SUMMARY Prior to this, we wou

D19748: [Desktop Theme KCM] "Normalize" margin around background in previews

kossebau added a comment. In D19748#432027 , @broulik wrote: > F6696238: Screenshot_20190316_121442.png > Seems it does break things here (both with and without Qt scaling :/) @broulik Any chance

Re: Plasma distro-specific installation path?

Can you elaborate on what you're trying to accomplish?

D19821: Fix breeze dialog background with Qt 5.12.2

rooty accepted this revision. rooty added a comment. This revision is now accepted and ready to land. If it works for you ship it, I'm nowhere near a computer right now REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D19821 To: fvog

D19821: Fix breeze dialog background with Qt 5.12.2

fvogt added a comment. Is anyone able to review this? If there's no review in 24h I'll merge it as it affects users severely and the fix is trivial. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19821 To: fvogt, #plasma Cc: filipf, heikobecker,

D19873: [image-wallpaper] Fix horizontal alignment of the "Positioning:" row

filipf added a comment. This is just theoretical, but what are the obstacles with adding this whole row to the actual FormLayout file and just setting `visible: when_image_wallpaper_is_used` ? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19873 To: filip

D19874: [Kickoff] Reduce the margins of KickoffItem

filipf added a comment. I actually like the right margin because it contributes to visual hierarchy when headings are present: F6701391: image.png As for long descriptions, how often would you say it occurs that you have one? From my experience

D19872: [plasma-workspace-wallpapers] Add the Elarun wallpaper

This revision was automatically updated to reflect the committed changes. Closed by commit R131:484ff7c7c3d3: [plasma-workspace-wallpapers] Add the Elarun wallpaper (authored by filipf). REPOSITORY R131 Plasma Wallpapers CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19872?vs=54283&i

D19874: [Kickoff] Reduce the margins of KickoffItem

rooty added a comment. Looks a lot better, +1. Please check whether there is subpixel placement of either the fonts or the selection rectangle with some other fonts (because gridUnit is being multiplied by a non-integer). I know it doesn't make sense but @flipwise and I have had to modi