hein added a comment.
I'm not a fan of the checkbox, I think it's a little gratuitous. If you add a
small feature and need to immediately add a checkbox to disable it, it's rather
a red flag to me. It means either the feature or the checkbox should probably
go. Firefox gets away without the
hallas closed this revision.
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D19890
To: hallas, #vdg, #breeze, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.
REVISION SUMMARY
"Type to search." is changed to "Type to search..." because there is a user
input action that
needs to be performed.
REPOSITORY
apol updated this revision to Diff 54903.
apol added a comment.
Also animate when expanding, as suggested by @davidedmundson
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19947?vs=54779=54903
BRANCH
arcpatch-D19947
REVISION DETAIL
tigrang created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
tigrang requested review of this revision.
REVISION SUMMARY
Config widgets were loading in when a service item was clicked.
This change loads all config widgets at the start so the window
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:a3d4b38574fb: Support Kirigami.twinFormLayouts in
individual wallpaper plugins (authored by filipf).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
BUILD SUCCESS
Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/stable-kf5-qt5%20FreeBSDQt5.12/71/
Project:
stable-kf5-qt5 FreeBSDQt5.12
Date of build:
Tue, 26 Mar 2019 18:57:43 +
Build duration:
8 min 30 sec and counting
JUnit Tests
BUILD SUCCESS
Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.12/168/
Project:
kf5-qt5 FreeBSDQt5.12
Date of build:
Tue, 26 Mar 2019 18:57:43 +
Build duration:
4 min 8 sec and counting
JUnit Tests
Name:
Sorry about this, fixing it now.
Nate
On Tue, 26 Mar 2019 12:15:39 -0600 CI System wrote
> BUILD FAILURE
> Build URL
> https://build.kde.org/job/Plasma/job/plasma-workspace/job/stable-kf5-qt5%20SUSEQt5.12/50/
>
> Project: stable-kf5-qt5 SUSEQt5.12
>
BUILD FAILURE
Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/stable-kf5-qt5%20SUSEQt5.12/50/
Project:
stable-kf5-qt5 SUSEQt5.12
Date of build:
Tue, 26 Mar 2019 18:10:43 +
Build duration:
4 min 55 sec and counting
CONSOLE OUTPUT
BUILD FAILURE
Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.12/167/
Project:
kf5-qt5 FreeBSDQt5.12
Date of build:
Tue, 26 Mar 2019 18:10:43 +
Build duration:
3 min 0 sec and counting
CONSOLE OUTPUT
BUILD FAILURE
Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/106/
Project:
kf5-qt5 SUSEQt5.12
Date of build:
Tue, 26 Mar 2019 18:10:43 +
Build duration:
2 min 26 sec and counting
CONSOLE OUTPUT
BUILD FAILURE
Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/stable-kf5-qt5%20FreeBSDQt5.12/70/
Project:
stable-kf5-qt5 FreeBSDQt5.12
Date of build:
Tue, 26 Mar 2019 18:10:43 +
Build duration:
1 min 45 sec and counting
CONSOLE
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:6a178a5b4e65: Change default Klipper behavior to accept
images (authored by kdautovic, committed by ngraham).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
thanks
REPOSITORY
R120 Plasma Workspace
BRANCH
clipboard
REVISION DETAIL
https://phabricator.kde.org/D19852
To: kdautovic, #plasma_workspaces, davidedmundson
Cc:
kdautovic updated this revision to Diff 54871.
kdautovic added a comment.
Add m_bIgnoreImage to get the correct behavior
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19852?vs=54717=54871
BRANCH
clipboard
REVISION DETAIL
davidedmundson added inline comments.
INLINE COMMENTS
> kdautovic wrote in klipper.cpp:744
> But bIgnoreImages is used later in the code, when determining whether to save
> images to history or not. Is it really necessary here? If it's added here
> then we're back to square one because copying
kdautovic added a comment.
Any updates? This is buildable and works. Is it acceptable to merge?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D19852
To: kdautovic, #plasma_workspaces, davidedmundson
Cc: ngraham, davidedmundson, plasma-devel,
hoffmannrobert updated this revision to Diff 54863.
hoffmannrobert added a comment.
- Use new KFileItem::SkipMimeTypeDetermination parameter
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19784?vs=54339=54863
BRANCH
ngraham added a comment.
Nice work, thanks. I'm looking forward to seeing your next patches!
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D20035
To: jayeshbhoot, #plasma, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot,
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:763c0cf117bc: Set autofocus to child KPluginSelector on
UI load (authored by jayeshbhoot, committed by ngraham).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
jayeshbhoot added a comment.
This is my first patch. So I will need someone to land it.
INLINE COMMENTS
> ngraham wrote in kcm.cpp:41
> Don't need to include `QTimer` anymore.
Fixed
> ngraham wrote in kcm.cpp:89
> I'm not thrilled about this workaround. Any chance you can figure out why
>
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.
Thanks! Do you have commit access or do you need someone to land these
patches for you?
REPOSITORY
R119 Plasma Desktop
BRANCH
fix/focus-searchbar-in-plasmasearch-kcm (branched from
jayeshbhoot updated this revision to Diff 54855.
jayeshbhoot added a comment.
- Remove unused dependency
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D20035?vs=54853=54855
BRANCH
fix/focus-searchbar-in-plasmasearch-kcm (branched from master)
ngraham added inline comments.
INLINE COMMENTS
> kcm.cpp:41
> #include
> +#include
>
Don't need to include `QTimer` anymore.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D20035
To: jayeshbhoot, #plasma
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen,
jayeshbhoot updated this revision to Diff 54853.
jayeshbhoot added a comment.
- Fix autofocus on searchbar on UI load
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D20035?vs=54744=54853
BRANCH
fix/focus-searchbar-in-plasmasearch-kcm (branched
ngraham added subscribers: broulik, ngraham.
ngraham added reviewers: Plasma, broulik.
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.
LGTM, seems like the correct fix. @broulik?
REPOSITORY
R122 Powerdevil
REVISION DETAIL
https://bugs.kde.org/show_bug.cgi?id=370594
Harald Sitter changed:
What|Removed |Added
Status|REPORTED|RESOLVED
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:00dcb777918e: Enable blurbehind also for panel controls
only if theme sets it (authored by kossebau).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
kossebau created this revision.
kossebau added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
kossebau requested review of this revision.
REPOSITORY
R120 Plasma Workspace
BRANCH
blurconfigalsoforpanelcontrol
REVISION DETAIL
30 matches
Mail list logo
