Re: CI system maintainability

On Friday, 29 March 2019 20:54:54 CET Ben Cooksley wrote: > On Fri, Mar 29, 2019 at 6:45 AM Johannes Zarl-Zierl > > I fear that a mandatory reviews would add too juch strain on smaller > > teams. If there's just one person with an intimate knowledge of the > > code-base, plus two co-developers, the

D19281: Highlight the hovered item in the task group tooltip

nickguletskii updated this revision to Diff 55061. nickguletskii edited the summary of this revision. nickguletskii added a comment. I have replaced the previous version of a patch with a new version, which is based on the latest master. The new version doesn't wrap the whole tooltip item wit

D19784: Avoid calling QT_LSTAT and accessing recent documents

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. This needs a KIO version ifdef for KIO >= 5.57. `#if KIO_VERSION >= QT_VERSION_CHECK(5,57,0)` REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D

D19281: Highlight the hovered item in the task group tooltip

mvourlakos accepted this revision. mvourlakos added a comment. This revision is now accepted and ready to land. I like it! can you apply it? REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D19281 To: nickguletskii, #latte_dock, mvourlakos Cc: mvourlakos, plasm

D19687: Allow single images to be excluded from the slideshow

davidedmundson accepted this revision. davidedmundson added inline comments. INLINE COMMENTS > config.qml:41 > property int cfg_SlideInterval: 0 > +property var cfg_UncheckedSlides: "" > default should be [] > slidemodel.cpp:57 > + QHash roleNames = BackgroundListModel::roleNames()

D20128: Center align shortcut badges when iconSize < 48

trmdi created this revision. trmdi added a reviewer: Latte Dock. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REVISION SUMMARY When iconSize is not big enough, center aligned shortcut badges look better than top-left aligned o

D20128: Center align shortcut badges when iconSize < 48

mvourlakos added a comment. Checking the Badge height didn't work out well? REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D20128 To: trmdi, #latte_dock Cc: mvourlakos, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg

D20130: Add option to show window title instead of app name when the window is maximized

kirstus created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kirstus requested review of this revision. REVISION SUMMARY If you use the option to hide the title bar when the window is maximized and you also choose to only show the application name on t

D20128: Center align shortcut badges when iconSize < 48

trmdi added a comment. In D20128#440574 , @mvourlakos wrote: > Checking the Badge height didn't work out well? I think checking the iconSize is enough. Because: - when iconSize >= 60, height = 0.4 * iconSize -> no need to center alig

D20072: Fix Default Applications KCM window size

This revision was automatically updated to reflect the committed changes. Closed by commit R119:cf1305a2fb40: Fix Default Applications KCM window size (authored by tigrang, committed by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20072?vs=5

D20055: Fixed initial size and content width of Activity Settings KCM

This revision was automatically updated to reflect the committed changes. Closed by commit R122:806c4c073ff4: Fixed initial size and content width of Activity Settings KCM (authored by tigrang, committed by ngraham). REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kd

D20128: Center align shortcut badges when iconSize < 48

mvourlakos added a comment. Oh, 0.4*60=24 No problem, it just was too clever! 1. Please set 58px. instead of 48px. for the checks 2. Please add a relevant comment why 58px. was chosen for the ckeck. 58px=23px so it is oversized when 24px. are applied afterwards it is ready to

D20086: Fix window height of Screen Locking KCM

ngraham accepted this revision. ngraham added a comment. Let's land this now and then you can try the other approach in another patch (if you want to). REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D20086 To: tigrang, davidedmundson, ngraham Cc: ngraham, abet

D20086: Fix window height of Screen Locking KCM

This revision was automatically updated to reflect the committed changes. Closed by commit R133:35864f76ffe8: Fix window height of Screen Locking KCM (authored by tigrang, committed by ngraham). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20086?vs=549

D19281: Highlight the hovered item in the task group tooltip

nickguletskii added a comment. Sorry, I don't believe I can land it myself since I don't have a developer account. REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D19281 To: nickguletskii, #latte_dock, mvourlakos Cc: mvourlakos, plasma-devel, jraleigh, GB_2, ragre

D20132: Actually make the network list view show up

vkrause created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. vkrause requested review of this revision. REPOSITORY R116 Plasma Network Management Applet BRANCH master REVISION DETAIL https://phabricator.kde.org/D

D19281: Highlight the hovered item in the task group tooltip

mvourlakos added a comment. In D19281#440636 , @nickguletskii wrote: > Sorry, I don't believe I can land it myself since I don't have a developer account. ok, I will land it for you, can you provide your email? REPOSITORY R878 Latte D

D19281: Highlight the hovered item in the task group tooltip

nickguletskii added a comment. Thanks! My email is: n...@nickguletskii.com REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D19281 To: nickguletskii, #latte_dock, mvourlakos Cc: mvourlakos, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-moha

D19284: Close the window selected in the task group tooltip on middle click

nickguletskii added a comment. Sorry, didn't notice the email notification for the comment before. My email is: n...@nickguletskii.com REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D19284 To: nickguletskii, #latte_dock, mvourlakos Cc: mvourlakos, plasma-devel, j

D14147: Port from GConf to GSettings

nicolasfella updated this revision to Diff 55090. nicolasfella marked 11 inline comments as done. nicolasfella added a comment. - Use and reqire GSettings by default and add CMake option to use GConf - Coding style REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE htt

D19284: Close the window selected in the task group tooltip on middle click

This revision was automatically updated to reflect the committed changes. Closed by commit R878:0a3755dce570: Close the window selected in the task group tooltip on middle click (authored by nickguletskii, committed by mvourlakos). REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https:/

D19281: Highlight the hovered item in the task group tooltip

This revision was automatically updated to reflect the committed changes. Closed by commit R878:6f84812a537d: Highlight the hovered item in the task group tooltip (authored by nickguletskii, committed by mvourlakos). REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kd

D20128: Center align shortcut badges when iconSize < 48

trmdi added a comment. Can you explain more about the number 58? I choose 48 because I think it is the minimum size that center aligning still looks good. REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D20128 To: trmdi, #latte_dock Cc: mvourlakos, plasma-devel,

D20128: Center align shortcut badges when iconSize < 48

mvourlakos added a comment. From mathematical point of view, 58px. Is the first icon value that breaks the visual size we want for Badge, best fit is Badge to be 40% of height, but for 58px. is the first time that this is 41% going up to 50% when icon size 48px. But you are right icon

D20128: Center align shortcut badges when iconSize < 48

trmdi updated this revision to Diff 55107. trmdi added a comment. Add comments REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20128?vs=55072&id=55107 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20128 AFFECTED FILES containment/pac

D20128: Center align shortcut badges when iconSize < 48

This revision was automatically updated to reflect the committed changes. Closed by commit R878:5fe27176fa12: Center align shortcut badges when iconSize < 48 (authored by trmdi). REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20128?vs=55107&id=55108 REVISI