D14147: Port from GConf to GSettings

ngraham added a comment. Now that this is in, can we now finally fix https://gitlab.freedesktop.org/pulseaudio/pulseaudio/issues/509? Or is there yet more to do before that can happen? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D14147 To:

D20144: Make location of "Lock Widgets" and "Remove Panel" buttons more obvious

ngraham added a comment. Hmm, maybe well then just with a spacer between them then? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20144 To: GB_2, #plasma, #vdg Cc: ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.12 - Build # 183 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.12/183/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 31 Mar 2019 18:54:48 + Build duration: 18 min and counting CONSOLE OUTPUT

D20144: Make location of "Lock Widgets" and "Remove Panel" buttons more obvious

GB_2 added a comment. In D20144#441087 , @ngraham wrote: > Maybe just switch the buttons' positions and add a spacer between them, then? I can try putting a spacer or seperator between the 2 buttons, but if I switch the positions of

D20144: Make location of "Lock Widgets" and "Remove Panel" buttons more obvious

ngraham added a comment. Maybe just switch the buttons' positions and add a spacer between them, then? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20144 To: GB_2, #plasma, #vdg Cc: ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel,

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.12 - Build # 182 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.12/182/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 31 Mar 2019 17:40:24 + Build duration: 1 hr 14 min and counting CONSOLE OUTPUT

D20144: Make location of "Lock Widgets" and "Remove Panel" buttons more obvious

GB_2 added a comment. In D20144#441083 , @ngraham wrote: > +1 for moving out out from under the More Settings... button; this isn't a setting so that was clearly wrong. However I'm not sure I like the new placement of the button. Now it's right

D20144: Make location of "Lock Widgets" and "Remove Panel" buttons more obvious

ngraham added a comment. +1 for moving out out from under the More Settings... button; this isn't a setting so that was clearly wrong. However I'm not sure I like the new placement of the button. Now it's right next to Lock Widgets, which is non-destructive. Seems like it would be easy to

D20086: Fix window height of Screen Locking KCM

tigrang added a comment. @ngraham Sorry for the late response. > Let's land this now and then you can try the other approach in another patch (if you want to). Sounds good. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D20086 To: tigrang,

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 129 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/129/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 31 Mar 2019 17:40:24 + Build duration: 3 min 38 sec and counting CONSOLE OUTPUT

D19784: Avoid calling QT_LSTAT and accessing recent documents

This revision was automatically updated to reflect the committed changes. Closed by commit R119:408f03ca989e: Avoid calling QT_LSTAT and accessing recent documents (authored by hoffmannrobert, committed by dfaure). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D20132: Actually make the network list view show up

jgrulich added a subscriber: mart. jgrulich added a comment. Hmm, I would say it should work even without your change, to me setting the view to fill the parent is correct. Can anyone else confirm this issue? Marco @mart ? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL

D20144: Make location of "Lock Widgets" and "Remove Panel" buttons more obvious

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY BUG: 406079 Move these two buttons to the left/top of the panel edit mode toolbar.

KDE CI: Plasma » plasma-pa » kf5-qt5 FreeBSDQt5.12 - Build # 18 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-pa/job/kf5-qt5%20FreeBSDQt5.12/18/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 31 Mar 2019 15:11:24 + Build duration: 51 min and counting CONSOLE OUTPUT [...truncated 371

D14147: Port from GConf to GSettings

This revision was automatically updated to reflect the committed changes. Closed by commit R115:e04e034c24b8: Port from GConf to GSettings (authored by nicolasfella). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14147?vs=55133=55136

D19606: [Task Manager] Reorganize and improve presentation of context menu

ngraham added a comment. I had a feeling that I wouldn't be able to please everyone with this diff. :) The problem is that the more things you put on the main level, the more overwhelming it looks, especially for apps that have recent docs and jump list items. I didn't think that having

D14147: Port from GConf to GSettings

nicolasfella updated this revision to Diff 55133. nicolasfella added a comment. - address comments REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14147?vs=55090=55133 BRANCH arcpatch-D14147 REVISION DETAIL

D19606: [Task Manager] Reorganize and improve presentation of context menu

cfeck added a comment. Hm, is moving "Minimize" one level deeper an UX improvement? Is it worth to create a bug about this issue? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19606 To: ngraham, #plasma, #vdg, ndavis, hein Cc: cfeck, abetts, broulik,

D19784: Avoid calling QT_LSTAT and accessing recent documents

hoffmannrobert updated this revision to Diff 55115. hoffmannrobert added a comment. - Add KIO_VERSION check, use SkipMimeTypeFromContent REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19784?vs=54863=55115 BRANCH fix_recent_documents_kicker_hang

D14147: Port from GConf to GSettings

drosca added inline comments. INLINE COMMENTS > pino wrote in gsettingsitem.cpp:42 > As I said, to better not silently miss new types of keys, as logging to > terminal will not help with a GUI application. Sure, but qFatal here will take down the whole plasmashell and effectively break the

D14147: Port from GConf to GSettings

pino added inline comments. INLINE COMMENTS > drosca wrote in gsettingsitem.cpp:42 > qCritical is not hard-fail, that would be qFatal, but don't really see a > reason to abort here in any case. > > It should be at least qWarning though, as qDebug is usually disabled by > default. As I said,

D14147: Port from GConf to GSettings

drosca added inline comments. INLINE COMMENTS > pino wrote in gsettingsitem.cpp:42 > should this be qCCritical, to hard-fail in case other types of keys are used > (instead of silently doing nothing)? qCritical is not hard-fail, that would be qFatal, but don't really see a reason to abort

D14147: Port from GConf to GSettings

pino added inline comments. INLINE COMMENTS > gsettingsitem.cpp:39 > +case G_VARIANT_CLASS_STRING: > +toReturn = QVariant(QString::fromUtf8(g_variant_get_string(gvalue, > NULL))); > +break; nullptr here > gsettingsitem.cpp:42 > +default: > +qCDebug(PLASMAPA())

D14147: Port from GConf to GSettings

drosca added inline comments. INLINE COMMENTS > gsettingsitem.cpp:58 > +GVariant *oldValue = g_settings_get_value(m_settings, > key.toLatin1().data()); > +GVariant *newValue; > + `= nullptr`, otherwise you have a crash if the following switch falls to default case. REPOSITORY R115

D20128: Center align shortcut badges when iconSize < 48

This revision was automatically updated to reflect the committed changes. Closed by commit R878:5fe27176fa12: Center align shortcut badges when iconSize 48 (authored by trmdi). REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20128?vs=55107=55108 REVISION

D20128: Center align shortcut badges when iconSize < 48

trmdi updated this revision to Diff 55107. trmdi added a comment. Add comments REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20128?vs=55072=55107 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20128 AFFECTED FILES

D20128: Center align shortcut badges when iconSize < 48

mvourlakos added a comment. From mathematical point of view, 58px. Is the first icon value that breaks the visual size we want for Badge, best fit is Badge to be 40% of height, but for 58px. is the first time that this is 41% going up to 50% when icon size 48px. But you are right