D20257: Fix incorrect vertical spacing between main layout and individual wallpaper plugins

This revision was automatically updated to reflect the committed changes. Closed by commit R119:230ac60a3195: Fix incorrect vertical spacing between main layout and individual wallpaper… (authored by filipf). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D19963: Avoid serializing base64 encoded favicon data twice

This revision was automatically updated to reflect the committed changes. Closed by commit R856:c3611dc98170: Avoid serializing base64 encoded favicon data twice (authored by bruns). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE

D19874: [Kickoff] Reduce the margins of KickoffItem, KickoffHighlight and use smallSpacing

This revision was automatically updated to reflect the committed changes. Closed by commit R119:51f7912368e6: [Kickoff] Reduce the margins of KickoffItem, KickoffHighlight and use… (authored by ndavis). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D19874: [Kickoff] Reduce the margins of KickoffItem, KickoffHighlight and use smallSpacing

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. I agree that this makes it feel more left-heavy. However I still think this patch is an improvement because the artificial margins we're getting rid of don't really solve that problem

D19874: [Kickoff] Reduce the margins of KickoffItem, KickoffHighlight and use smallSpacing

ndavis added a comment. In D19874#444153 , @filipf wrote: > This makes Kickoff even a bit more more left-centered = looking like it's wasting horizontal space. That's why I prefer the way it was before, but I tested the patch and everything

D19874: [Kickoff] Reduce the margins of KickoffItem, KickoffHighlight and use smallSpacing

filipf added a comment. This makes Kickoff even a bit more more left-centered = looking like it's wasting horizontal space. That's why I prefer the way it was before, but I tested the patch and everything seems symmetric at least. It seems that in the screenshots the "Small" font is set

D19874: [Kickoff] Reduce the margins of KickoffItem, KickoffHighlight and use smallSpacing

ndavis added a comment. I haven't tested this with many different fonts, but the current version works well for Noto Sans at 10, 11 and 12 pts. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19874 To: ndavis, #plasma, #vdg, ngraham, hein Cc: hein, ngraham,

D19874: [Kickoff] Reduce the margins of KickoffItem, KickoffHighlight and use smallSpacing

ndavis updated this revision to Diff 55502. ndavis marked 2 inline comments as done. ndavis added a comment. - Remove commented out bit of old code REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19874?vs=55500=55502 BRANCH KickoffItem-margins

D20249: Make the Configuration button more understandable

filipf added a comment. Hey @trmdi rooty's not participating in KDE at this point so he won't be able to do the review. Just so I don't stop by without giving a contribution: I like the idea of making it more obvious that it's a button. Maybe you could reach a compromise here and have

D19874: [Kickoff] Reduce the margins of KickoffItem

ndavis updated this revision to Diff 55500. ndavis added a comment. Use smallSpacing for KickoffItem and KickoffHighlight REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19874?vs=54292=55500 BRANCH KickoffItem-margins (branched from master)

D20266: Add new notification plasmoid

GB_2 added a comment. I made a better timeout indicator that you can use: F6755221: TimeoutIndicator.qml This is how it looks like: F6755222: Circular Timeout.mp4 REPOSITORY R120 Plasma Workspace REVISION

D20266: Add new notification plasmoid

abetts added a comment. In D20266#443993 , @ngraham wrote: > This UI is fantastic. A huge improvement over the status quo. > > It seems like there's no Do Not Disturb mode that stays on until manually turned off though? I was

D20266: Add new notification plasmoid

ngraham added a comment. This UI is fantastic. A huge improvement over the status quo. It seems like there's no Do Not Disturb mode that stays on until manually turned off though? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20266 To: broulik,

D20237: Port to new KWorkspace API

hein updated this revision to Diff 55487. hein added a comment. Fix refcounting Happened because `refresh` used to be `init` REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20237?vs=55440=55487 BRANCH master REVISION DETAIL

D20237: Port to new KWorkspace API

hein added a comment. In D20237#443594 , @davidedmundson wrote: > > Personally I tend to prefer just readable, explicit code for simple cases. > > Now the timing of my comment becomes awkward :/ It's so readable you found the bug 

D20265: Introduce libnotificationmanager

ngraham added inline comments. INLINE COMMENTS > org.freedesktop.Notifications.xml:57 > + > +--> > + Why is this commented out? Should it just be deleted instead? Or is it supposed to be used? > job.cpp:175 > +dirtyRoles.append(Notifications::ErrorTextRole); > +}*/ > +

D19874: [Kickoff] Reduce the margins of KickoffItem

ngraham added a comment. Thanks @hein, now we just need the requested code changes. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19874 To: ndavis, #plasma, #vdg, ngraham, hein Cc: hein, ngraham, filipf, rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel,

D19874: [Kickoff] Reduce the margins of KickoffItem

hein accepted this revision. hein added a comment. In D19874#443917 , @filipf wrote: > @hein what's your opinion on reducing the margins? LGTM. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19874 To:

D19874: [Kickoff] Reduce the margins of KickoffItem

filipf added a subscriber: hein. filipf added a comment. @hein what's your opinion on reducing the margin? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19874 To: ndavis, #plasma, #vdg, ngraham Cc: hein, ngraham, filipf, rooty, plasma-devel, jraleigh, GB_2,

D19874: [Kickoff] Reduce the margins of KickoffItem

ngraham added a comment. Ping! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19874 To: ndavis, #plasma, #vdg, ngraham Cc: ngraham, filipf, rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

Re: [RFC] store.kde.org: splitting off pre-Plasma5 Plasma themes?

See also https://phabricator.kde.org/T8126 We have the "ghns_exclude" keyword that can be used to prevent old content from showing up in Get Hot New Stuff windows, but of course this doesn't solve the problem of old stuff appearing on the website. Nate On Fri, 05 Apr 2019 07:41:22

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi added a comment. In D20186#443723 , @knambiar wrote: > > Wherever you're currently listed, remove your name and replace it with Atul's. :) The only place I can find it on Bugzilla. I've gone ahead and made @atulbi the default assignee

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi added a comment. In D20186#443554 , @ngraham wrote: > In D20186#443262 , @knambiar wrote: > > > >> I happen to be the ‘accidental’ maintainer of the Touchpad KCM. I’d be more than happy to

D19963: Avoid serializing base64 encoded favicon data twice

bruns added a comment. Ping! REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D19963 To: bruns, #plasma, broulik Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20257: Fix incorrect vertical spacing between main layout and individual wallpaper plugins

abetts added a comment. +1 REPOSITORY R119 Plasma Desktop BRANCH beautiful-vertical-spacing (branched from master) REVISION DETAIL https://phabricator.kde.org/D20257 To: filipf, hein, mart, #plasma, ngraham, davidedmundson Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel,

D20249: Make the Configuration button more understandable

mvourlakos added inline comments. INLINE COMMENTS > HeaderSettings.qml:87 > +textColor: colorizerManager.buttonTextColor > +backgroundColor: containsMouse? colorizerManager.buttonHoverColor : > colorizerManager.buttonBackgroundColor > checkedTextColor:

D20266: Add new notification plasmoid

GB_2 added a comment. Amazing! INLINE COMMENTS > FullRepresentation.qml:247 > +opacity: 0.6 > +text: list.count === 0 ? i18n("No unread notifications.") : > i18n("Notifications") > +} Please remove the dot to make it consistent with other Plasmoids.

[RFC] store.kde.org: splitting off pre-Plasma5 Plasma themes?

Hi, when one goes to try some Plasme themes with Plasma5 from store.kde.org, one also gets a long list of KDE4 times themes. Often those due to their age even have high ratings & big download numbers because their were great at their time. so being listed first in the respective categories in

D20262: [StreamRestore] Don't mess with channels

This revision was automatically updated to reflect the committed changes. Closed by commit R994:afeb7fb8e0ed: [StreamRestore] Dont mess with channels (authored by broulik). REPOSITORY R994 Pulseaudio Qt Bindings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20262?vs=55464=55473

D20265: Introduce libnotificationmanager

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Introduce libnotification A library revolving around notifications. This serves as a

D20266: Add new notification plasmoid

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This completely rewrites the notification plasmoid using `libnotificationmanager` The

D20249: Make the Configuration button more understandable

trmdi updated this revision to Diff 55472. trmdi added a comment. Set hoverColor REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20249?vs=55412=55472 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20249 AFFECTED FILES

D20198: Don't lose list position after installing KNS cursor themes

leinir added a comment. In D20198#443779 , @ngraham wrote: > FYI the patch gets closed automatically only if the commit message has `Differential Revision: https://phabricator.kde.org/D20198` somewhere in it. If you use `arc land` or

D17187: Set the default cursor theme to breeze_cursors

ngraham added a comment. Thanks Fabian! REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D17187 To: fvogt, #plasma, ngraham Cc: wbauer, ngraham, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D20198: Don't lose list position after installing KNS cursor themes

ngraham added a comment. FYI the patch gets closed automatically only if the commit message has `Differential Revision: https://phabricator.kde.org/D20198` somewhere in it. If you use `arc land` or cherry-pick the commit hash of the arc-created patch, that happens automatically. REPOSITORY

D20198: Don't lose list position after installing KNS cursor themes

leinir closed this revision. leinir added a comment. Forgot to close the revision in R119:4545601adec0 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20198 To: leinir, #plasma,

D20262: [StreamRestore] Don't mess with channels

drosca accepted this revision. drosca added a comment. This revision is now accepted and ready to land. Please also to stable branch. REPOSITORY R994 Pulseaudio Qt Bindings REVISION DETAIL https://phabricator.kde.org/D20262 To: broulik, sitter, drosca, nicolasfella Cc: plasma-devel,

D20262: [StreamRestore] Don't mess with channels

broulik created this revision. broulik added reviewers: sitter, drosca, nicolasfella. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Just set volume for all of them. Otherwise when just calling `setMuted`,

D20257: Fix incorrect vertical spacing between main layout and individual wallpaper plugins

filipf added a comment. In D20257#443626 , @ngraham wrote: > Yep, looks like the correct solution to me. Nice find! One step closer to perfection! I think it's the correct solution as well. Maybe to elaborate better for the other

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

knambiar added a comment. > Wherever you're currently listed, remove your name and replace it with Atul's. :) The only place I can find it on Bugzilla. I've gone ahead and made @atulbi the default assignee for bugs to the Touchpad-KCM product. @atulbi Congratulations, you’re now the

D20253: [Context] Update StreamRestore before inserting it

This revision was automatically updated to reflect the committed changes. Closed by commit R994:24103093025f: [Context] Update StreamRestore before inserting it (authored by broulik). REPOSITORY R994 Pulseaudio Qt Bindings CHANGES SINCE LAST UPDATE

KDE CI: Plasma » drkonqi » stable-kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/stable-kf5-qt5%20WindowsMSVCQt5.11/1/ Project: stable-kf5-qt5 WindowsMSVCQt5.11 Date of build: Fri, 05 Apr 2019 10:26:41 + Build duration: 2 min 36 sec and counting CONSOLE

KDE CI: Plasma » powerdevil » stable-kf5-qt5 SUSEQt5.12 - Build # 14 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.12/14/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Fri, 05 Apr 2019 10:09:11 + Build duration: 8 min 0 sec and counting JUnit Tests Name:

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 14 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/14/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Fri, 05 Apr 2019 10:07:12 + Build duration: 9 min 15 sec and counting JUnit Tests

D14147: Port from GConf to GSettings

kossebau added a comment. Seems this patch sadly broke the build on FreeBSD: https://build.kde.org/job/Plasma/view/Everything/job/plasma-pa/job/kf5-qt5%20FreeBSDQt5.12/18/ REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D14147 To: nicolasfella,

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.12 - Build # 17 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.12/17/ Project: stable-kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 05 Apr 2019 10:07:08 + Build duration: 1 min 39 sec and counting JUnit Tests

D20253: [Context] Update StreamRestore before inserting it

broulik updated this revision to Diff 55462. broulik added a comment. - Insert only if not already REPOSITORY R994 Pulseaudio Qt Bindings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20253?vs=55423=55462 REVISION DETAIL https://phabricator.kde.org/D20253 AFFECTED FILES

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

arrowd added a comment. Can I finally push this? REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D18296 To: arrowd, #plasma, #ktexteditor, broulik Cc: apol, cullmann, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D17187: Set the default cursor theme to breeze_cursors

fvogt added a comment. In D17187#443675 , @wbauer wrote: > I just noticed that this change is missing again in 5.15. > Apparently it was reverted (by mistake?) in R98:e1f97ce5

D17187: Set the default cursor theme to breeze_cursors

wbauer added a comment. I just noticed that this change is missing again in 5.15. Apparently it was reverted (by mistake?) in R98:e1f97ce5 ... REPOSITORY R98 Breeze for Gtk REVISION DETAIL

D20248: Update link to Kdelibs_Coding_Style

This revision was automatically updated to reflect the committed changes. Closed by commit R120:c69acc0973a5: Update link to Kdelibs_Coding_Style (authored by meven). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20248?vs=55408=55456 REVISION

D20198: Don't lose list position after installing KNS cursor themes

leinir updated this revision to Diff 55455. leinir marked an inline comment as done. leinir added a comment. Address @apol's comment REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20198?vs=55403=55455 REVISION DETAIL

D20198: Don't lose list position after installing KNS cursor themes

leinir marked 2 inline comments as done. leinir added inline comments. INLINE COMMENTS > apol wrote in kcmcursortheme.cpp:468 > Use splitRef if you're just taking the last one. Quite - still need to convert that last to a string later, but less string creation's good :) Kind of a