D17410: Add alternatives button to applet configuration in panel edit mode

GB_2 added a comment. Nice, thank you so much! INLINE COMMENTS > ConfigOverlay.qml:392 > +iconSource: "preferences-desktop-default-applications" > +text: i18n("Alternatives...") > +enabled: >

D17410: Add alternatives button to applet configuration in panel edit mode

ngraham added a comment. Nice, it works great! INLINE COMMENTS > ConfigOverlay.qml:391 > +Layout.fillWidth: true > +iconSource: "preferences-desktop-default-applications" > +text: i18n("Alternatives...") This should now be

KDE CI: Plasma » powerdevil » kf5-qt5 SUSEQt5.12 - Build # 18 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/powerdevil/job/kf5-qt5%20SUSEQt5.12/18/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 10 Apr 2019 03:38:16 + Build duration: 3 min 44 sec and counting CONSOLE OUTPUT [...truncated

D8626: DDCUtil: Improved DDCUtil support for brightness control over DDC/CI channel for supported monitors

ngraham added a comment. Thanks @dvogel! Nice patch. May it be the second of many. :) For the next one, you might consider setting up `arc`, which makes submitting and managing patches easier for you, and reviewing and landing them easier for us. See

D8626: DDCUtil: Improved DDCUtil support for brightness control over DDC/CI channel for supported monitors

This revision was automatically updated to reflect the committed changes. Closed by commit R122:cbd6d0eaa6fc: DDCUtil: Improved DDCUtil support for brightness control over DDC/CI channel… (authored by dvogel, committed by ngraham). CHANGED PRIOR TO COMMIT

D20418: Support custom icon size for ToolButton

ngraham added a comment. What's the use case, out of curiosity? REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D20418 To: broulik, #plasma, mart, apol Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,

D20407: [Folder View] Improve label crispness

ngraham added a comment. Did that in D20420 . REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20407 To: ngraham, fvogt, #plasma, hein, filipf Cc: abetts, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot,

D20403: AppChooserDialog: make it more usable

ngraham added a comment. +1 for unifying, and I'll admit that I kind of like this one better than the other one which is really complicated and fiddly. With an added search/filter field, this one would be just right. REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION

D20265: Introduce libnotificationmanager

davidedmundson added a comment. Then we can't use it. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20265 To: broulik, #plasma Cc: nicolasfella, davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D20265: Introduce libnotificationmanager

nicolasfella added inline comments. INLINE COMMENTS > davidedmundson wrote in CMakeLists.txt:26 > I don't know the status of this, but please make sure we don't depend on > something in review It's in Extragear REPOSITORY R120 Plasma Workspace REVISION DETAIL

D20265: Introduce libnotificationmanager

davidedmundson added a comment. It's a big review :/ The general infrastructure and design makes sense. I shall review the individual classes separately during the week. INLINE COMMENTS > CMakeLists.txt:3 > +if(BUILD_TESTING) > + #add_subdirectory(autotests) > +endif() That's one

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

dfaure added inline comments. INLINE COMMENTS > arrowd wrote in urlinfo.h:39 > > const QString & > > There is `path.chop(match.capturedLength());`, which requires non-const > `QString`. > > > And what if it's a URL? At this point this string is pathOrUrl. > > Well, `if (QFile::exists(path))`

D20420: [Folder View] use Math.floor() instead of Math.round()

This revision was automatically updated to reflect the committed changes. Closed by commit R119:b5d0043c33db: [Folder View] use Math.floor() instead of Math.round() (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D20420: [Folder View] use Math.floor() instead of Math.round()

ngraham created this revision. ngraham added reviewers: hein, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This is more technically correct and doesn't leave any empty space on the right side of

D20313: Hook up the main form layout with child form layouts

filipf added a comment. @mart before you suggested we should do something like: `twinFormLayouts: stack.item && stack.item.formLayout ? [stack.item.formLayout] : []` but I'm not seeing any errors or issues if twinFormLayouts doesn't find `main.currentItem.formLayout`. Is the

D20418: Support custom icon size for ToolButton

broulik created this revision. broulik added reviewers: Plasma, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. TEST PLAN Copied from `PushButton` ToolButton { icon.width: 128 icon.height: 128

D20407: [Folder View] Improve label crispness

hein added a comment. I think it would be safer to Math.floor() rather than Math.round(). REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20407 To: ngraham, fvogt, #plasma, hein, filipf Cc: abetts, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel,

D17410: Add alternatives button to applet configuration in panel edit mode

davidedmundson updated this revision to Diff 55856. davidedmundson added a comment. fix TODO REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17410?vs=47054=55856 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17410 AFFECTED FILES

D19925: Split up subcategories for KNS categories

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM otherwise INLINE COMMENTS > KNSBackend.cpp:149 > +const QString catName = cat->name().append(QLatin1Char('/')); > +for (auto& potentialSubCat: categories) { > +

D20403: AppChooserDialog: make it more usable

apol added a comment. What Nate says makes sense to me. Single click should be fine, there's no real value in just selecting it. Don't we already have another dialog for choosing applications? It could make sense to use the same everywhere and improve it once. i.e. KOpenWithDialog

D8626: DDCUtil: Improved DDCUtil support for brightness control over DDC/CI channel for supported monitors

dvogel updated this revision to Diff 55854. dvogel added a comment. Applied changes suggested by @broulik. Thank you for your help. REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8626?vs=55690=55854 REVISION DETAIL https://phabricator.kde.org/D8626

D3209: [Notification Applet] Position dialog before showing it

broulik abandoned this revision. broulik added a comment. Likely obsoleted by notification rewrite REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3209 To: broulik, #plasma, mck182, mart Cc: davidedmundson, mart, plasma-devel, jraleigh, GB_2, ragreen,

D14830: Add "Configure Displays" context menu entry on the desktop

broulik added a comment. > "back in Windows 7": you mean Windows 10? No, Windows 7. To quote from my favorite OS review page on Windows 7 [1] "The desktop right-click context menu also now contains a "Screen Resolution" option. […] I wonder if MS actually listened to consumers on this

D20227: Remove player from known players list when it disappears

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R856:5940d353366f: Remove player from known players list when it disappears (authored by broulik). CHANGED PRIOR TO COMMIT

D17410: Add alternatives button to applet configuration in panel edit mode

GB_2 added a comment. In D17410#446874 , @Codezela wrote: > This icon have a lot of details for this small size we need more clear one I guess The icon was added here: D20367 I think it's still ok,

D17410: Add alternatives button to applet configuration in panel edit mode

Codezela added a comment. This icon have all of details for this small size we need more clear one I guess REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17410 To: GB_2, #plasma, #vdg Cc: Codezela, broulik, davidedmundson, ngraham, ndavis, #vdg,

D20399: [Kickoff] Anchor right of subTitleElement in KickoffItem to arrow.right

This revision was automatically updated to reflect the committed changes. Closed by commit R119:e09cc99b5250: [Kickoff] Anchor right of subTitleElement in KickoffItem to arrow.right (authored by ndavis). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D20407: [Folder View] Improve label crispness

This revision was automatically updated to reflect the committed changes. Closed by commit R119:05e59e1c77c4: [Folder View] Improve label crispness (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20407?vs=55819=55836 REVISION

D20407: [Folder View] Improve label crispness

fvogt added a comment. Sounds good enough to me, let's get this in so openQA won't complain anymore REPOSITORY R119 Plasma Desktop BRANCH improve-folder-view-label-crispness (branched from Plasma/5.12) REVISION DETAIL https://phabricator.kde.org/D20407 To: ngraham, fvogt, #plasma,

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.12 - Build # 181 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.12/181/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 09 Apr 2019 16:14:14 + Build duration: 3 min 3 sec and counting JUnit Tests Name:

D18419: Adjust some KCMs to implement new Appearance section layout

GB_2 added a comment. In D18419#446564 , @davidedmundson wrote: > From my last comment > > >> Merge various KCMs together (e.g. Icons and Emoticons, Widget Style and GNOME Applications Style (GTK)) > > > > > This is by /far/ the

D20407: [Folder View] Improve label crispness

ngraham added a comment. In D20407#446723 , @fvogt wrote: > It was actually discovered by openQA as a regression introduced yesterday: https://openqa.opensuse.org/tests/902646#step/finish_desktop/8 (bad) vs

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 122 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/122/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 09 Apr 2019 14:46:52 + Build duration: 53 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.12 - Build # 180 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.12/180/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 09 Apr 2019 14:46:52 + Build duration: 38 sec and counting CONSOLE OUTPUT

D17796: Show accurate checked state for system monitor configuration pages

This revision was automatically updated to reflect the committed changes. Closed by commit R120:83045375ec2b: Show accurate checked state for system monitor configuration pages (authored by pavelmos, committed by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D20407: [Folder View] Improve label crispness

fvogt added a comment. It was actually discovered by openQA as a regression introduced yesterday: https://openqa.opensuse.org/tests/902646#step/finish_desktop/8 (bad) vs https://openqa.opensuse.org/tests/902110#step/finish_desktop/2 (good) Probably a side effect of the label width

D20377: do no install .so symlinks for private libraries

This revision was automatically updated to reflect the committed changes. Closed by commit R113:a3c095352bb1: do no install .so symlinks for private libraries (authored by sitter). REPOSITORY R113 Oxygen Theme CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20377?vs=55736=55824

D20407: [Folder View] Improve label crispness

abetts added a comment. +1 REPOSITORY R119 Plasma Desktop BRANCH improve-folder-view-label-crispness (branched from Plasma/5.12) REVISION DETAIL https://phabricator.kde.org/D20407 To: ngraham, fvogt, #plasma, hein, filipf Cc: abetts, filipf, plasma-devel, jraleigh, GB_2, ragreen,

D20407: [Folder View] Improve label crispness

filipf accepted this revision. filipf added a comment. This revision is now accepted and ready to land. Huge improvement, Nate, and an excellent find. The rest of the reviewers can also have a look at my before and after photos for proof: Before: F6762110:

D8626: DDCUtil: Improved DDCUtil support for brightness control over DDC/CI channel for supported monitors

ngraham added a comment. @dvogel I'll land this for you after you address those review comments. REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D8626 To: dvogel, broulik, davidedmundson Cc: ngraham, asturmlechner, plasma-devel, jraleigh, GB_2, ragreen, Pitel,

D8626: DDCUtil: Improved DDCUtil support for brightness control over DDC/CI channel for supported monitors

broulik accepted this revision. broulik added inline comments. INLINE COMMENTS > CMakeLists.txt:77 > > + > + Stray whitespace > ddcutilbrightness.cpp:38 > // Inquire about detected monitors. > -DDCA_Display_Info_List * dlist = ddca_get_display_info_list(); > -qCDebug(POWERDEVIL)

D20403: AppChooserDialog: make it more usable

ngraham added a comment. In D20403#446653 , @jgrulich wrote: > In D20403#446650 , @ngraham wrote: > > > IMO this should be a single-click UI, with no Open button: since there's nothing useful you

D20407: [Folder View] Improve label crispness

ngraham created this revision. ngraham added reviewers: fvogt, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Without rounding the result, sub-pixel rounding errors accumulate over time, making the

D20403: AppChooserDialog: make it more usable

jgrulich added a comment. In D20403#446650 , @ngraham wrote: > IMO this should be a single-click UI, with no Open button: since there's nothing useful you can do with a selected item besides opening it, it should always open with a

D20403: AppChooserDialog: make it more usable

ngraham added a comment. IMO this should be a single-click UI, with no Open button: since there's nothing useful you can do with a selected item besides opening it, it should always open with a single-click. REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL

D20406: Adapt an x option for app-carrying knsrc files

leinir created this revision. leinir added reviewers: Discover Software Store, apol, ngraham. leinir added a project: Discover Software Store. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. leinir requested review of this revision. REVISION SUMMARY This adds in an

D20383: [KRunner] Avoid writing history if addToHistory is idempotent

This revision was automatically updated to reflect the committed changes. Closed by commit R120:9686c05c7226: [KRunner] Avoid writing history if addToHistory is idempotent (authored by bruns). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D20382: [KRunner] Move trivial check in addToHistory to the front

This revision was automatically updated to reflect the committed changes. Closed by commit R120:4a5f62fee952: [KRunner] Move trivial check in addToHistory to the front (authored by bruns). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D19925: Split up subcategories for KNS categories

leinir updated this revision to Diff 55813. leinir marked an inline comment as done. leinir added a comment. Remove unnecessary (very noisy) debug messages REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19925?vs=54446=55813 REVISION DETAIL

D19925: Split up subcategories for KNS categories

leinir planned changes to this revision. leinir added inline comments. INLINE COMMENTS > KNSBackend.cpp:149 > +const QString catName = cat->name().append(QLatin1Char('/')); > +qDebug() << "Checking" << catName; > +for (auto& potentialSubCat: categories) { Just realised

D19925: Split up subcategories for KNS categories

leinir added a comment. Ping? :) REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D19925 To: leinir, #discover_software_store, apol, ngraham Cc: plasma-devel, #discover_software_store, jraleigh, bam, GB_2, ragreen, ixoos, Pitel, ZrenBot, James,

D20399: [Kickoff] Anchor right of subTitleElement in KickoffItem to arrow.right

filipf accepted this revision. filipf added a comment. This revision is now accepted and ready to land. Works as desired and is more efficient than anchoring to parent.right and then adding symmetrical units.smallSpacing * 6 right margin (since that's how the arrow is already anchored).

D18419: Adjust some KCMs to implement new Appearance section layout

davidedmundson added a comment. From my last comment >> Merge various KCMs together (e.g. Icons and Emoticons, Widget Style and GNOME Applications Style (GTK)) > This is by /far/ the most important step to do before shuffling top levels about. Otherwise you don't know what

D20378: Make KNS applications act more like applications

leinir updated this revision to Diff 55802. leinir marked an inline comment as done. leinir added a comment. We now assume that an AdoptionCommand is set. This reduces the code overhead, which is always nice. REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D20378: Make KNS applications act more like applications

leinir planned changes to this revision. leinir marked an inline comment as done. leinir added inline comments. INLINE COMMENTS > apol wrote in KNSResource.cpp:213 > Can't we do this in the adoption command? This way we won't have another > special case. Hmm... I guess we could... It requires

D20403: AppChooserDialog: make it more usable

jgrulich created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jgrulich requested review of this revision. REVISION SUMMARY Add 'open' button so users doesn't need to choose only with double-click and also allow to open app with enter REPOSITORY