D17410: Add alternatives button to applet configuration in panel edit mode

2019-04-10 Thread Björn Feber
GB_2 updated this revision to Diff 55960. GB_2 added a comment. Try to fix diff REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17410?vs=55959=55960 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17410 AFFECTED FILES

D16425: Added new Suspend then Hibernate option

2019-04-10 Thread Bryan Soriano
soriano added a comment. Were these changes not committed? I still don't have a suspend-then-hibernate option on powerdevil. Is there any way I can enable it? Any suggestions would be much appreciated. REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D16425 To:

D17410: Add alternatives button to applet configuration in panel edit mode

2019-04-10 Thread Björn Feber
GB_2 updated this revision to Diff 55959. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17410?vs=55958=55959 REVISION DETAIL https://phabricator.kde.org/D17410 AFFECTED FILES containments/panel/contents/ui/ConfigOverlay.qml To: GB_2, #plasma,

D17410: Add alternatives button to applet configuration in panel edit mode

2019-04-10 Thread Björn Feber
GB_2 updated this revision to Diff 55958. GB_2 edited the summary of this revision. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17410?vs=55856=55958 REVISION DETAIL https://phabricator.kde.org/D17410 AFFECTED FILES containments/panel/contents/ui/ConfigOverlay.qml To: GB_2,

D17410: Add alternatives button to applet configuration in panel edit mode

2019-04-10 Thread Björn Feber
GB_2 added a comment. BTW, @davidedmundson or someone else: How do I get the icon name/source here: `iconSource: plasmoid.action("alternatives").icon`? It currently returns a QIcon, but I want the name/source of it from QML. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D17410: Add alternatives button to applet configuration in panel edit mode

2019-04-10 Thread Björn Feber
GB_2 commandeered this revision. GB_2 edited reviewers, added: davidedmundson; removed: GB_2. GB_2 added a comment. Sure! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17410 To: GB_2, #plasma, #vdg, davidedmundson Cc: Codezela, broulik, davidedmundson,

D17410: Add alternatives button to applet configuration in panel edit mode

2019-04-10 Thread David Edmundson
davidedmundson added a comment. GB2 do you want to commandeer it back and make those changes? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17410 To: davidedmundson, #plasma, #vdg, GB_2 Cc: Codezela, broulik, davidedmundson, ngraham, ndavis, #vdg,

D20451: [Context] Update StreamRestore before inserting it

2019-04-10 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, drosca, nicolasfella. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Otherwise we would signal an empty StreamRestore only to then signal it has

D20450: [StreamRestore] Don't mess with channels

2019-04-10 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, drosca, nicolasfella. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Just set volume for all of them. Otherwise when just calling setMuted, we

D20213: [kcolorschemeeditor] Use config path instead of searching again

2019-04-10 Thread Kai Uwe Broulik
broulik added a comment. Ping REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20213 To: broulik, #plasma Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20445: signalplotter: Add highdpi support

2019-04-10 Thread Vlad Zagorodniy
zzag added a comment. Yep, those issues are still present. :( F6764644: foo.png REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D20445 To: volkov Cc: zzag, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot,

D20445: signalplotter: Add highdpi support

2019-04-10 Thread Vlad Zagorodniy
zzag added a comment. Oh, nice! FWIW, I made a patch to add HighDPI support some time ago as well. I haven't uploaded it for review because there were issues with beams not being smooth. INLINE COMMENTS > ksignalplotter.cpp:681-682 > +const auto dpr =

D20445: signalplotter: Add highdpi support

2019-04-10 Thread Alexander Volkov
volkov created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. volkov requested review of this revision. REPOSITORY R111 KSysguard Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D20445 AFFECTED FILES

D20442: Provide a KModifierKeyInfoProvider implementation

2019-04-10 Thread Aleix Pol Gonzalez
apol created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. TEST PLAN Used teh keyboardindicator plasmoid REPOSITORY R130 Frameworks integration plugin using KWayland BRANCH master REVISION DETAIL

D17410: Add alternatives button to applet configuration in panel edit mode

2019-04-10 Thread Nathaniel Graham
ngraham added a comment. And actually maybe we could programmatically get the name and icon from the action itself, like the Task Manager does: property QtObject alternativesAction: null enabled: alternativesAction && alternativesAction.enabled visible: alternativesAction

D20436: No need to set height to implicitHeight

2019-04-10 Thread Jan Grulich
jgrulich created this revision. jgrulich added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jgrulich requested review of this revision. REVISION SUMMARY There seem to bug a bug in PlasmaComponents.TextField causing to use different height

Re: Plasma Sprint 2019 in València

2019-04-10 Thread Aleix Pol
On Wed, Mar 6, 2019 at 2:22 AM Aleix Pol wrote: > > I guess that I formulated it in a confusing way, I'll try to be more > clear next time. > > I created this wiki page too to keep track of who's coming. There's an > etherpad where we could add topics to discuss there. >

D19940: always support all command line options

2019-04-10 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R871:abc37a6aef2d: always support all command line options (authored by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19940?vs=54480=55887#toc REPOSITORY R871 DrKonqi CHANGES SINCE

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 123 - Fixed!

2019-04-10 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/123/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 09 Apr 2019 16:14:14 + Build duration: 45 min and counting BUILD ARTIFACTS

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 138 - Fixed!

2019-04-10 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/138/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 06 Apr 2019 09:35:05 + Build duration: 21 min and counting JUnit Tests Name: (root) Failed:

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 132 - Fixed!

2019-04-10 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/132/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 05 Apr 2019 10:06:07 + Build duration: 5 min 9 sec and counting JUnit Tests Name: (root)

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.12 - Build # 105 - Still unstable!

2019-04-10 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.12/105/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 06 Apr 2019 08:57:16 + Build duration: 4 hr 45 min and counting JUnit Tests Name: (root) Failed: 0

Re: CI system maintainability

2019-04-10 Thread Ralf Habacker
Am 29.03.19 um 21:01 schrieb Ben Cooksley: > With the shift to Gitlab we should be able to provide this hopefully. > > We're still figuring out how to be able to provide CI in an easy to > maintain manner (in terms of controlling platforms builds are done > for, which branches, etc). In case, an

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 118 - Fixed!

2019-04-10 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/118/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 06 Apr 2019 09:35:02 + Build duration: 22 min and counting BUILD ARTIFACTS

KDE CI: Plasma » kwin » stable-kf5-qt5 SUSEQt5.12 - Build # 34 - Unstable!

2019-04-10 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kwin/job/stable-kf5-qt5%20SUSEQt5.12/34/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Sat, 06 Apr 2019 09:35:14 + Build duration: 2 hr 8 min and counting JUnit Tests Name: (root)

KDE CI: Plasma » kwin » stable-kf5-qt5 SUSEQt5.12 - Build # 38 - Still unstable!

2019-04-10 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kwin/job/stable-kf5-qt5%20SUSEQt5.12/38/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Mon, 08 Apr 2019 09:55:13 + Build duration: 5 hr 6 min and counting JUnit Tests Name: (root)

D20378: Make KNS applications act more like applications

2019-04-10 Thread Dan Leinir Turthra Jensen
This revision was automatically updated to reflect the committed changes. Closed by commit R134:727d8e55e46c: Make KNS applications act more like applications (authored by leinir). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D20406: Adapt an x option for app-carrying knsrc files

2019-04-10 Thread Dan Leinir Turthra Jensen
This revision was automatically updated to reflect the committed changes. Closed by commit R134:6589e22f08e7: Adapt an x option for app-carrying knsrc files (authored by leinir). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D19925: Split up subcategories for KNS categories

2019-04-10 Thread Dan Leinir Turthra Jensen
This revision was automatically updated to reflect the committed changes. Closed by commit R134:29be60b13647: Split up subcategories for KNS categories (authored by leinir). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19925?vs=55813=55881#toc REPOSITORY R134 Discover Software Store

D20403: AppChooserDialog: make it more usable

2019-04-10 Thread Jan Grulich
jgrulich added a comment. Uppps, I accidentaly pushed the change instead running "arc diff". I made it to select app with just a single click as you wanted to, without buttons below. I'm not sure this will be easy to replace with KOpenWithDialog() as we receive from the portal just list

D20403: AppChooserDialog: make it more usable

2019-04-10 Thread Jan Grulich
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R838:5ddeff154725: AppChooserDialog: make it more usable (authored by jgrulich). REPOSITORY R838 Flatpak Support: KDE

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

2019-04-10 Thread Gleb Popov
arrowd added inline comments. INLINE COMMENTS > dfaure wrote in urlinfo.h:77 > But then you can't do `kde-open5 www.google.fr` anymore, right? > > I see what you mean with typo handling, but there is no perfect solution. > Either we treat typos as URLs (but it means we also treat actual URLs

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

2019-04-10 Thread Gleb Popov
arrowd updated this revision to Diff 55879. arrowd marked 5 inline comments as done. arrowd added a comment. Address comments. REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18296?vs=54774=55879 BRANCH cursor REVISION DETAIL

D20418: Support custom icon size for ToolButton

2019-04-10 Thread Kai Uwe Broulik
broulik added a subscriber: laysrodrigues. broulik added a comment. @laysrodrigues asked for it. I don't think there's a usecase for a "proper" desktop app, but having an API in Qt that we then silently ignored is bad, especially since it works fine with a regular `Button` REPOSITORY R858