avaldes updated this revision to Diff 56024.
avaldes added a comment.
Removed CMakeList change
REPOSITORY
R122 Powerdevil
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16425?vs=56023&id=56024
BRANCH
suspend-then-hibernate (branched from master)
REVISION DETAIL
https://phabr
avaldes added a comment.
@ngraham I updated the patch with the comments, I'm not sure if I'm updating
it corrrectly, I have tested it on my machine and it can suspend, but for some
reason the dedicated keys to change the brightness are not working on my
laptop. I'm still checking if this is
avaldes updated this revision to Diff 56023.
avaldes edited the summary of this revision.
avaldes added a comment.
Rebasing changes to master, adding latest comments
REPOSITORY
R122 Powerdevil
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16425?vs=44950&id=56023
BRANCH
suspend
davidedmundson added a comment.
I don't have webkit built, so can't test this, but I have one concern:
- refreshAction is owned by mScriptingHtmlDialog
- when refresh action is triggered we will delete mScriptingHtmlDialog
immediately
- which means we've now killed refreshAction whils
hallas added a comment.
Ping - anyone?
REPOSITORY
R111 KSysguard Library
REVISION DETAIL
https://phabricator.kde.org/D19714
To: hallas, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
ngraham added a comment.
Oh and I'm sorry that this patch has sat idle for so long. Once you make my
requested change, I'll see if I can help push this along. Thanks for your
patience!
REPOSITORY
R122 Powerdevil
REVISION DETAIL
https://phabricator.kde.org/D16425
To: avaldes, broulik, n
ngraham requested changes to this revision.
ngraham added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> suspendsessionconfig.cpp:82
> +m_suspendThenHibernateCheck = new QCheckBox(
> +i18nc("Hibernate after 3 hours when suspended", "Hibernate after 3
jgrulich abandoned this revision.
jgrulich added a comment.
Doesn't seem to make any effect.
REPOSITORY
R838 Flatpak Support: KDE Portal for XDG Desktop
REVISION DETAIL
https://phabricator.kde.org/D20461
To: jgrulich, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, les
BUILD SUCCESS
Build URL
https://build.kde.org/job/Plasma/job/powerdevil/job/kf5-qt5%20SUSEQt5.12/19/
Project:
kf5-qt5 SUSEQt5.12
Date of build:
Thu, 11 Apr 2019 07:07:45 +
Build duration:
4 hr 16 min and counting
JUnit Tests
Name: (root) Failed:
broulik marked an inline comment as done.
broulik added inline comments.
INLINE COMMENTS
> nicolasfella wrote in CMakeLists.txt:26
> It's in Extragear
Changed code to use plasma-pa QML only now like in task manager
> ngraham wrote in org.freedesktop.Notifications.xml:57
> Why is this commented
volkov added a comment.
Hi, thanks for the review.
I know about the issues, I've uploaded the patch to avoid losing it :)
REPOSITORY
R111 KSysguard Library
REVISION DETAIL
https://phabricator.kde.org/D20445
To: volkov
Cc: zzag, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, les
jgrulich updated this revision to Diff 55975.
jgrulich added a comment.
Remove additional call of items initialization
REPOSITORY
R838 Flatpak Support: KDE Portal for XDG Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D20461?vs=55974&id=55975
BRANCH
Plasma/5.15
REVISION
jgrulich created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
jgrulich requested review of this revision.
REVISION SUMMARY
Do not delay dialog initialization with parsing all desktop files to get apps
information, which is
causing UI not to respond f
This revision was automatically updated to reflect the committed changes.
Closed by commit R126:8072a6acf221: Add support for passing cursor information
via URL parameters when running… (authored by arrowd).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D18296?vs=55879&id=55973#toc
REPOS
BUILD FAILURE
Build URL
https://build.kde.org/job/Plasma/job/plasma-pa/job/kf5-qt5%20FreeBSDQt5.12/21/
Project:
kf5-qt5 FreeBSDQt5.12
Date of build:
Thu, 11 Apr 2019 07:28:54 +
Build duration:
36 sec and counting
CONSOLE OUTPUT
[...truncated 369
This revision was automatically updated to reflect the committed changes.
Closed by commit R115:fbdef07f554b: [StreamRestore] Don't mess with
channels (authored by broulik).
REPOSITORY
R115 Plasma Audio Volume Applet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D20450?vs=55935&id=55
This revision was automatically updated to reflect the committed changes.
Closed by commit R115:8f3060794cab: [Context] Update StreamRestore before
inserting it (authored by broulik).
REPOSITORY
R115 Plasma Audio Volume Applet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D20451?vs=5
This revision was automatically updated to reflect the committed changes.
Closed by commit R858:d9024903e297: Support custom icon size for ToolButton
(authored by broulik).
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D20418?vs=5585
broulik added a comment.
You had the files in the wrong place, I moved them, not it builds :)
REPOSITORY
R122 Powerdevil
REVISION DETAIL
https://phabricator.kde.org/D8626
To: dvogel, broulik, davidedmundson
Cc: ngraham, asturmlechner, plasma-devel, jraleigh, GB_2, ragreen, Pitel,
ZrenBo
broulik added a comment.
There's a build failure on CI now:
https://build.kde.org/view/OS%20-%20Linux/job/Administration/job/Dependency%20Build%20Plasma%20kf5-qt5%20SUSEQt5.12/lastFailedBuild/console
CMake Error at daemon/backends/CMakeLists.txt:49 (add_library):
No SOURCES given to
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:c0b1a7e16e69: [kcolorschemeeditor] Use config path
instead of searching again (authored by broulik).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D20213?vs=55309&id=55968#toc
REPOSITORY
R11
21 matches
Mail list logo
