D16425: Added new Suspend then Hibernate option

2019-04-12 Thread Alejandro Valdes
avaldes added a comment. In D16425#448828 , @ngraham wrote: > In D16425#448822 , @avaldes wrote: > > > In D16425#448820 , @ngraham wrote: > > > > > So

Re: Plasma Dev Docs questions

2019-04-12 Thread Juan Carlos Torres
On Fri, Apr 12, 2019 at 9:22 PM David Edmundson wrote: > Doxyqml is about input rather than output. > > We have 3 cases: > 1) C++ - > used by C++ devs > 2) C++ - > used by QML devs (currently the same docs as #1) > 3) QML -> used by QML devs > > Doxyqml makes QML readable by doxygen to give a

D20445: signalplotter: Add highdpi support

2019-04-12 Thread Alexander Volkov
volkov updated this revision to Diff 56102. volkov added a comment. use QPen::setWidthF() instead of QPen::setWidth() REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20445?vs=56079=56102 BRANCH master REVISION DETAIL

Re: Unannounced Dependency Change - plasma-framework

2019-04-12 Thread Friedrich W. H. Kossebau
Am Freitag, 12. April 2019, 20:47:51 CEST schrieb Ben Cooksley: > Hi all, > > Recently builds of plasma-framework have started failing on Windows > due to the absence of "gzip", which was added as a Dependency without > any announcement as is required of all new dependencies. > > With regards to

D19796: [Device Notifier] Restore Solid notification messages

2019-04-12 Thread Thomas Surrel
thsurrel added a comment. Anyone could have a look at this ? Thanks in advance. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19796 To: thsurrel, #plasma, broulik Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

Unannounced Dependency Change - plasma-framework

2019-04-12 Thread Ben Cooksley
Hi all, Recently builds of plasma-framework have started failing on Windows due to the absence of "gzip", which was added as a Dependency without any announcement as is required of all new dependencies. With regards to Windows in particular, usually Craft based systems will make use of 7-Zip

D20492: [WIP] Display time remaining to fill/empty the battery in the notification when the ac adapter is plugged/unplugged.

2019-04-12 Thread Nathaniel Graham
ngraham added inline comments. INLINE COMMENTS > powerdevilcore.cpp:635 > +if (m_batteryRemainingTime > 0) { > +detail = i18n("You need %s to fill the battery", > KFormat().formatDuration(m_batteryRemainingTime, KFormat::HideSeconds)); > +} else {

D20492: [WIP] Display time remaining to fill/empty the battery in the notification when the ac adapter is plugged/unplugged.

2019-04-12 Thread Méven Car
meven added a comment. In D20492#448825 , @ngraham wrote: > Screenshots would be nice. :) That's my intent, we can yet talk about wording. I can now move forward after recompiling everything... REPOSITORY R122 Powerdevil REVISION

D17410: Add alternatives button to applet configuration in panel edit mode

2019-04-12 Thread Björn Feber
GB_2 added a comment. It seems like Elisa has a function to do this: https://lxr.kde.org/source/extragear/multimedia/elisa/src/elisaapplication.h#0083 Maybe something like this could be added to KDE/Plasma Franeworks? REPOSITORY R119 Plasma Desktop REVISION DETAIL

D17410: Add alternatives button to applet configuration in panel edit mode

2019-04-12 Thread Björn Feber
GB_2 added a comment. In D17410#448842 , @davidedmundson wrote: > Toolbutton should be able to take a qicon as a source Nope, when I use `iconSource: plasmoid.action("alternatives").icon` this happens: `ConfigOverlay.qml:392:21:

D17410: Add alternatives button to applet configuration in panel edit mode

2019-04-12 Thread David Edmundson
davidedmundson added a comment. Toolbutton should be able to take a qicon as a source REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17410 To: GB_2, #plasma, #vdg, davidedmundson Cc: Codezela, broulik, davidedmundson, ngraham, ndavis, #vdg, plasma-devel,

D16425: Added new Suspend then Hibernate option

2019-04-12 Thread Nathaniel Graham
ngraham added a comment. In D16425#448822 , @avaldes wrote: > In D16425#448820 , @ngraham wrote: > > > So is everything now working for you, or not? > > > No, I can't use my keyboard to change

D20492: [WIP] Display time remaining to fill/empty the battery in the notification when the ac adapter is plugged/unplugged.

2019-04-12 Thread Nathaniel Graham
ngraham added a comment. Screenshots would be nice. :) REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D20492 To: meven, #plasma_workspaces Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D16425: Added new Suspend then Hibernate option

2019-04-12 Thread Alejandro Valdes
avaldes added a comment. In D16425#448820 , @ngraham wrote: > So is everything now working for you, or not? No, I can't use my keyboard to change brightness, but it might be related on how I test my changes. I need guidance on how can I

D16425: Added new Suspend then Hibernate option

2019-04-12 Thread Nathaniel Graham
ngraham added a comment. So is everything now working for you, or not? REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D16425 To: avaldes, broulik, ngraham Cc: soriano, abalaji, graesslin, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot,

D20445: signalplotter: Add highdpi support

2019-04-12 Thread Alexander Volkov
volkov updated this revision to Diff 56079. volkov added a comment. reduced beam width REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20445?vs=55922=56079 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20445 AFFECTED FILES

D17410: Add alternatives button to applet configuration in panel edit mode

2019-04-12 Thread Björn Feber
GB_2 added a comment. in the toolbutton icon source/name property. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17410 To: GB_2, #plasma, #vdg, davidedmundson Cc: Codezela, broulik, davidedmundson, ngraham, ndavis, #vdg, plasma-devel, #plasma, cblack,

D17410: Add alternatives button to applet configuration in panel edit mode

2019-04-12 Thread Björn Feber
GB_2 added a comment. In D17410#448756 , @davidedmundson wrote: > > It currently returns a QIcon, but I want the name/source of it from QML. > > What for? So I can use the same icon that is in the context menu REPOSITORY R119

Re: More Love for Aether

2019-04-12 Thread Michail Vourlakos
maybe irrelevant but it has a bug concerning its panel shadows... The theme has a small bug. It misses a "shadow-center" element. Without this element plasma framework does not indicate that there is a full shadow element in the svgs. 1. This is the reason you do not see the shadow in plasma

D17410: Add alternatives button to applet configuration in panel edit mode

2019-04-12 Thread David Edmundson
davidedmundson added a comment. > It currently returns a QIcon, but I want the name/source of it from QML. What for? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17410 To: GB_2, #plasma, #vdg, davidedmundson Cc: Codezela, broulik, davidedmundson,

Re: More Love for Aether

2019-04-12 Thread David Edmundson
It's already hosted on KDE infrastructure. We also try to keep theme compatibility. I don't see a need to make it "official". I want to push for Plasma to become a much smaller well-maintained core with a flourishing wider ecosystem. David

More Love for Aether

2019-04-12 Thread Boudhayan Gupta
Hi all, I've been using Aether Dark (https://store.kde.org/p/1245521/) pretty much exclusively on all my computers for over half a year now. I think it's beautiful (I prefer dark themes and IMO this is currently far better than the default Plasma Dark theme). I haven't _really_ noticed anything

Re: Plasma Dev Docs questions

2019-04-12 Thread David Edmundson
On Sat, Apr 6, 2019 at 12:55 PM Juan Carlos Torres wrote: > > Hi Jonathan and David! > > Thanks for the replies and sorry for not getting back to you ASAP. > > It's good there's Workboard for some of those tasks already. Will be > easier to keep track of them at least and hopefully we can get the

D20492: [WI] Display time remaining to fill/empty the battery in the notification when the ac adapter is plugged/unplugged.

2019-04-12 Thread Méven Car
meven created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Improve the notification when the ac adapter is plugged/unplugged. Displaying direcly in them the time remaining to empty or fill the

D20491: Rewrite applicationjobs dataengine to work with libnotificationmanager

2019-04-12 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Keeps it mostly working for compatibility. TEST PLAN Depends on D20265

D20490: Rewrite notifications dataengine to work with libnotificationmanager

2019-04-12 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Keeps it mostly working for compatibility. The grouping stuff in there has been dropped, the

D20266: Add new notification plasmoid

2019-04-12 Thread Kai Uwe Broulik
broulik updated this revision to Diff 56059. broulik added a comment. - Fix diff screwup REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20266?vs=56057=56059 REVISION DETAIL https://phabricator.kde.org/D20266 AFFECTED FILES

D20266: Add new notification plasmoid

2019-04-12 Thread Kai Uwe Broulik
broulik updated this revision to Diff 56057. broulik added a comment. - Grouping fixes, unread notifications are automatically expanded now and collapsing a group scrolls to the top of it - Added "4 hours" and "until disabled" do not disturb mode - Job progress bar is hidden when

D20265: Introduce libnotificationmanager

2019-04-12 Thread Kai Uwe Broulik
broulik updated this revision to Diff 56056. broulik edited the summary of this revision. broulik added a comment. - Address review comments - Rewrite job handling to be kuiserver and kill it I removed the dataengine rewrite from the diff to make it a bit less overwhelming, will come

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

2019-04-12 Thread Roman Gilg
romangg added a comment. In D20186#31 , @atulbi wrote: > In D20186#443596 , @romangg wrote: > > > Nice work. Most of the stuff in libinputtouchpad.cpp and its header file are copy-paste from

D20113: [Desktop Theme KCM] Adapt clock to new hand rotation center options

2019-04-12 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R119:dfdbc19d9fc9: [Desktop Theme KCM] Adapt clock to new hand rotation center options (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D20113?vs=55781=56046#toc REPOSITORY

D20112: [analog-clock] Allow themes to define hand shadow offset & hand rot center

2019-04-12 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R120:2558f3626280: [analog-clock] Allow themes to define hand shadow offset hand rot center (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D20112?vs=55777=56045#toc

KDE CI: Plasma » drkonqi » stable-kf5-qt5 WindowsMSVCQt5.11 - Build # 2 - Still Failing!

2019-04-12 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/stable-kf5-qt5%20WindowsMSVCQt5.11/2/ Project: stable-kf5-qt5 WindowsMSVCQt5.11 Date of build: Fri, 12 Apr 2019 07:03:44 + Build duration: 37 min and counting CONSOLE OUTPUT