D20242: Add flatpak mime types

eszlari added a comment. @apol Have forgotten to commit? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D20242 To: eszlari, apol Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D20676: [Kickoff] Make the tabbar separator width consistent with tab selection line

This revision was automatically updated to reflect the committed changes. Closed by commit R119:60181eca4414: [Kickoff] Make the tabbar separator width consistent with tab selection line (authored by filipf). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.or

D20676: [Kickoff] Make the tabbar separator width consistent with tab selection line

filipf added a comment. Sidenote:` units.smallSpacing` wasn't a good solution, it ended being 5 pixels wide on my laptop and 4 pixels wide on my PC. 4 pixels works consistently on both machines, and with various resolutions and scaling. REPOSITORY R119 Plasma Desktop REVISION DETAIL htt

D20676: [Kickoff] Make the tabbar separator width consistent with tab selection line

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY This minor patch shortens the tabbar separator so that it is not longer than the width of leftmost and rightmost tab selection line.

D20675: LoadingPage: Use Kirigami.Heading

This revision was automatically updated to reflect the committed changes. Closed by commit R134:f061345ad6fe: LoadingPage: Use Kirigami.Heading (authored by jbbgameich). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20675?vs=56565&id=56568 RE

D20675: LoadingPage: Use Kirigami.Heading

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. And we also need to give this page a spinner, just like the Updates page has. REPOSITORY R134 Discover Software Store BRANCH loading-kirigami-heading (branched from master) REVISION

D20674: Word wrap "No backends found" error message

This revision was automatically updated to reflect the committed changes. Closed by commit R134:4d644303be08: Word wrap "No backends found" error message (authored by jbbgameich). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20674?vs=56564&id

D20675: LoadingPage: Use Kirigami.Heading

jbbgameich created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jbbgameich requested review of this revision. REVISION SUMMARY Unifies the look of the loading message with the other messages in discover. TEST PLAN Font size is correct when installing

D20313: Hook up the main form layout with child form layouts

filipf added a comment. I'll land this tomorrow night since it's a prerequisite for fixing the PoTD plugin. REPOSITORY R119 Plasma Desktop BRANCH hook-main-and-child-layouts-up (branched from master) REVISION DETAIL https://phabricator.kde.org/D20313 To: filipf, #plasma, ngraham, mar

D20612: [Kickoff] Modernize settings window layout

ngraham updated this revision to Diff 56561. ngraham added a comment. largeSpacing -> smallSpacing REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20612?vs=56550&id=56561 BRANCH kickoff-settings-layout-update (branched from master) REVISION DETAIL

D20612: [Kickoff] Modernize settings window layout

ngraham added inline comments. INLINE COMMENTS > filipf wrote in ConfigButtons.qml:29 > maybe `units.smallSpacing` would be enough, what do you think? Yeah, good call REPOSITORY R119 Plasma Desktop BRANCH kickoff-settings-layout-update (branched from master) REVISION DETAIL https://phab

D20612: [Kickoff] Modernize settings window layout

filipf added inline comments. INLINE COMMENTS > ConfigButtons.qml:29 > > -cellHeight: units.gridUnit * 5 > +cellHeight: units.gridUnit * 6 + units.largeSpacing > cellWidth: units.gridUnit * 6 maybe `units.smallSpacing` would be enough, what do you think? REPOSITORY R119 Plasma

D20612: [Kickoff] Modernize settings window layout

filipf accepted this revision. filipf added a comment. This revision is now accepted and ready to land. Nice! The last label is getting cut off for me with the default window size, but not sure what could be done about it. F6780515: image.png REPOSI

D15418: Dim application icon when it is not playing anything

squeakypancakes added a comment. Could we just group them like we do on the devices tab? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D15418 To: broulik, #plasma, #vdg Cc: squeakypancakes, meven, mart, svenmauch, acrouthamel, abetts, ngraham, pl

D19011: Thunderbolt KCM and KDED module

ngraham added a comment. Submit it in a patch to breeze-icons! :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19011 To: dvratil, #vdg, #plasma Cc: zzag, GB_2, knambiar, bernieinnocenti, andreask, ndavis, trickyricky26, abetts, fabianr, ngraham, broulik, o

D17105: Add a new lookandfeel runner

ngraham added a comment. In D17105#452140 , @apol wrote: > Maybe what would make sense is to define an alternative Look and Feel theme for every theme, and have Breeze dark point at Breeze and vice-versa. This could then be easily toggled then f

D19011: Thunderbolt KCM and KDED module

yurchor added a comment. It might be not very stylish but just to make the whole thing work... F6780264: preferences-desktop-thunderbolt.svg REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19011 To: dvratil, #vdg, #pla

D20645: process: add NoNewPrivileges

topimiettinen updated this revision to Diff 56551. topimiettinen added a comment. Updated per comments from @davidedmundson. REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20645?vs=56475&id=56551 BRANCH master REVISION DETAIL https://phabric

D20612: [RFC] [Kickoff] Modernize settings window layout

ngraham updated this revision to Diff 56550. ngraham added a comment. - Fix button height issue - Add padding between sections - Add vertical spacing between button categories - Rename to "General" and use appropriate icon REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE htt

D20612: [RFC] [Kickoff] Modernize settings window layout

filipf added a comment. Some other comments: - it's not correct for the configuration category to be called Appearance; we have behavior checkboxes present -> we can just call the category "General" - we need to add `isSection` spacing underneath the icon -> looks different in my scree

D20612: [RFC] [Kickoff] Modernize settings window layout

filipf added a comment. In D20612#452054 , @GB_2 wrote: > In D20612#451981 , @ngraham wrote: > > > Use `onPressed` And `Layout.preferredHeight` (still doesn't fix the button height though) > >

D20661: [MPRIS Data Engine] Avoid blocking calls when changing volume

This revision was automatically updated to reflect the committed changes. Closed by commit R120:9b24060c632e: [MPRIS Data Engine] Avoid blocking calls when changing volume (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20661?vs=

D20661: [MPRIS Data Engine] Avoid blocking calls when changing volume

broulik created this revision. broulik added reviewers: Plasma, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Avoids plasmashell freezing when the player app is unresponsive or has a broken MP

D20651: Support default action, priority hints, set desktop-entry

jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. Works for me. I tested both like the default action and urgency. REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL https://phabricator.kde.org/D20651 To:

D20645: process: add NoNewPrivileges

davidedmundson added a comment. FYI, you can update an old phabricator request with new changes. Arc should should do it automatically if the phabricator line is in the commit message. We've now set the change flag, but I would still expect a line around processmodel.cpp:750 if(pr

D20635: Show Vaults action only for local folders

This revision was automatically updated to reflect the committed changes. Closed by commit R845:b553905222dc: Show Vaults action only for local folders (authored by broulik). REPOSITORY R845 Plasma Vault CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20635?vs=56442&id=56497 REVISION

D20651: Support default action, priority hints, set desktop-entry

broulik created this revision. broulik added reviewers: Plasma, jgrulich. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This adds support for default actions and priority hints, both of which we support in `K

D15418: Dim application icon when it is not playing anything

broulik added a comment. Not a huge fan of this giant gap tbh REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D15418 To: broulik, #plasma, #vdg Cc: meven, mart, svenmauch, acrouthamel, abetts, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel,

D15418: Dim application icon when it is not playing anything

meven added a comment. In D15418#452214 , @meven wrote: > In D15418#364811 , @mart wrote: > > > In D15418#331397 , @ngraham wrote: > > > > > Maybe somet

D15418: Dim application icon when it is not playing anything

meven added a comment. In D15418#364811 , @mart wrote: > In D15418#331397 , @ngraham wrote: > > > Maybe something like this? > > > > F6283615: Screenshot_20180924_195355.png