D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi added a comment. In D20186#454420 , @ngraham wrote: > @atulbi ping! Does Roman's request make sense? In general I think it does make sense to do code clean-up in a separate patch first. Totally!! I'm working on it... Currently faci

D20726: Call into native Media Session browser API if available

This revision was automatically updated to reflect the committed changes. Closed by commit R856:4c5ee86a48cb: Call into native Media Session browser API if available (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20726

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

ngraham added a comment. @atulbi ping! Does Roman's request make sense? In general I think it does make sense to do code clean-up in a separate patch first. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20186 To: atulbi, ngraham, romangg, davidedmundson, #p

D20747: [FifteenPuzzle] Modernize settings window

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY - Port to Kirigami+FormLayout and QQC2 - Disable custom image controls when not using a cust

D20746: Remove disable for showing only minimized tasks on Icons only task manager

cblack created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY This patch removes the visible: property that hides the option to show only tasks that are minimized to users of the icons only task

D20736: Limit thumbnail size

fvogt requested changes to this revision. fvogt added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > mprisplugin.cpp:493 > > -if (!biggest.isValid() || (actualSize.width() >= biggest.width() && > actualSize.height() >= biggest.height())) { > +

D20743: [Kicker] Modernize settings window

This revision was automatically updated to reflect the committed changes. Closed by commit R119:2e2cfa891534: [Kicker] Modernize settings window (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20743?vs=56764&id=56765 REVISION DETA

D20743: [Kicker] Modernize settings window

ngraham updated this revision to Diff 56764. ngraham marked an inline comment as done. ngraham added a comment. Use correct casing for label REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20743?vs=56761&id=56764 BRANCH modernize-kicker-settings (b

D20743: [Kicker] Modernize settings window

GB_2 accepted this revision. GB_2 added a comment. Looks good INLINE COMMENTS > ConfigGeneral.qml:194 > > -text: recentOrdering.currentIndex == 0 > -? i18n("Show recent documents") > -: i18n("Show often used documen

D20743: [Kicker] Modernize settings window

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Port Kicker's settings window to Kirigami+FormLayout and QQC2. TEST PLAN F6787455: New.png

D20612: [Kickoff] Modernize settings window layout

This revision was automatically updated to reflect the committed changes. Closed by commit R119:7bbe5fc1e1fa: [Kickoff] Modernize settings window layout (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20612?vs=56561&id=56751 REVIS

D20612: [Kickoff] Modernize settings window layout

hein accepted this revision. hein added a comment. LGTM. REPOSITORY R119 Plasma Desktop BRANCH kickoff-settings-layout-update (branched from master) REVISION DETAIL https://phabricator.kde.org/D20612 To: ngraham, #plasma, #vdg, filipf, hein Cc: hein, filipf, GB_2, broulik, plasma-deve

D20736: Limit thumbnail size

ngraham added a comment. +1, makes sense for the stable branch. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D20736 To: broulik, #plasma, fvogt Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreut

D20736: Limit thumbnail size

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Unfortunately we don't know the appropriate thumbnail size in advance but enforce some sort of ma

D20726: Call into native Media Session browser API if available

broulik updated this revision to Diff 56731. REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20726?vs=56706&id=56731 REVISION DETAIL https://phabricator.kde.org/D20726 AFFECTED FILES extension/content-script.js To: broulik, #plasma, fvo

D20724: Keep player around when emptied but the website tells us it's actually just paused

This revision was automatically updated to reflect the committed changes. Closed by commit R856:eb583434a561: Keep player around when emptied but the website tells us it's actually just… (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabr

D20724: Keep player around when emptied but the website tells us it's actually just paused

broulik updated this revision to Diff 56711. broulik added a comment. - Add active player check REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20724?vs=56704&id=56711 REVISION DETAIL https://phabricator.kde.org/D20724 AFFECTED FILES

D20726: Call into native Media Session browser API if available

fvogt added inline comments. INLINE COMMENTS > content-script.js:584 > +if (!navigator.mediaSession) { > +navigator.mediaSession = function() {}; > +} Why a function instead of an object now? REPOSITORY R856 Plasma Browser Integration REVIS

D20724: Keep player around when emptied but the website tells us it's actually just paused

fvogt added inline comments. INLINE COMMENTS > broulik wrote in content-script.js:358 > No. This case here is so when you empty the player, e.g. use ajax page nav to > navigate away, we stop controlling the player. It is always paused when > emptied, so this would just noop. > With media sessio

D20725: Support "stop" Media Sessions action handler

This revision was automatically updated to reflect the committed changes. Closed by commit R856:44f251b4f74b: Support "stop" Media Sessions action handler (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20725?vs=56705&i

D20724: Keep player around when emptied but the website tells us it's actually just paused

broulik added inline comments. INLINE COMMENTS > fvogt wrote in content-script.js:358 > Doesn't `player.paused` work here? No. This case here is so when you empty the player, e.g. use ajax page nav to navigate away, we stop controlling the player. It is always paused when emptied, so this woul

D20726: Call into native Media Session browser API if available

broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Since Chrome 73 it also supports Media Session also on the desktop. The calls are re-arran

D20724: Keep player around when emptied but the website tells us it's actually just paused

fvogt added inline comments. INLINE COMMENTS > content-script.js:358 > +// keep it around (Bug 402324: Soundcloud does this) > +if (playerPlaybackState === "paused") { > +return; Doesn't `player.paused` work here? REPOSITORY R856 Plasma Browser Integration REVISIO

D20725: Support "stop" Media Sessions action handler

broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This was recently added to the spec [1]. [1] https://github.com/WICG/mediasession/comm

D20724: Keep player around when emptied but the website tells us it's actually just paused

broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Requires "Enhanced media controls" to be enabled in extension settings to work BUG: 402