D20746: Remove disable for showing only minimized tasks on Icons only task manager

cblack added a comment. In D20746#455012 , @ngraham wrote: > -snip- > Can you describe what it is that makes you want this functionality in the IOTM rather than just using the regular task manager and enabling this feature? The regular

D20747: [FifteenPuzzle] Port configuration window to QQC2 and Kirigami.FormLayout

ngraham planned changes to this revision. ngraham added a comment. Oh, duh. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D20747 To: ngraham, #vdg, #plasma Cc: GB_2, filipf, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterb

D20747: [FifteenPuzzle] Port configuration window to QQC2 and Kirigami.FormLayout

filipf added a comment. Tried it out, looks good and is efficient. One behavior thing though, I'm not getting any background option that's being defaulted to: F6789170: image.png The "Color" option is not being remembered either (the color

D20774: Import QtGraphicalEffects 1.0 instead of 1.2 to fix dependency issue.

This revision was automatically updated to reflect the committed changes. Closed by commit R878:99454c0b15ba: Import QtGraphicalEffects 1.0 instead of 1.2 to fix dependency issue. (authored by mathiastillman). REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D

D20774: Import QtGraphicalEffects 1.0 instead of 1.2 to fix dependency issue.

mvourlakos accepted this revision. mvourlakos added a comment. This revision is now accepted and ready to land. no prob, this is a new introduced code for scrolling tasks it shouldnt break something REPOSITORY R878 Latte Dock BRANCH qtgraphicaleffects-dependency (branched from master) R

D20747: [FifteenPuzzle] Port configuration window to QQC2 and Kirigami.FormLayout

GB_2 added inline comments. INLINE COMMENTS > configAppearance.qml:130 > +RowLayout { > +Kirigami.FormData.label: i18n("Colored numbers on tiles:") > You could make it like this: `Tiles: [ ] Colored numbers: [ Button ]` REPOSITORY R114 Plasma Addons REVISION DETAIL https://ph

D20774: Import QtGraphicalEffects 1.0 instead of 1.2 to fix dependency issue.

mathiastillman created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mathiastillman requested review of this revision. REVISION SUMMARY Fixes an issue where the shell plasmoid fails to load when QtGraphicalEffects 1.2 is missing from the system. This ca

D20576: Add new notifications KCM

GB_2 added a comment. You can now use `edit-remove`, which got added in D20700 . REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20576 To: broulik, #plasma, #vdg Cc: ndavis, GB_2, mmustac, ngraham, zzag, plasma-devel, jrale

D20773: [Task Manager] Bring to current desktop with middle-click

ngraham added inline comments. INLINE COMMENTS > ConfigBehavior.qml:116 > +i18nc("When clicking it would toggle grouping windows of a > specific app", "Group/Ungroup"), > +i18n("Bring to the current desktop") > ] Maybe "virtual desktop" instead of ju

D20773: [Task Manager] Bring to current desktop with middle-click

thsurrel created this revision. thsurrel added reviewers: Plasma, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. thsurrel requested review of this revision. REVISION SUMMARY This adds a new possible action when middle-click is used on a task in the task manager:

D20747: [FifteenPuzzle] Port configuration window to QQC2 and Kirigami.FormLayout

ngraham updated this revision to Diff 56840. ngraham marked 2 inline comments as done. ngraham added a comment. Improve it even more (hopefully) REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20747?vs=56769&id=56840 BRANCH modernize-fifteenpuzzle-s

D19797: [fifteen-puzzle] Modernize settings window

filipf added a comment. In D19797#455008 , @ngraham wrote: > Oh whoops, I had completely forgotten that you already had this revision open, sorry :( No prob, I should have been done with it sooner :P REPOSITORY R114 Plasma Addons REVI

D20746: Remove disable for showing only minimized tasks on Icons only task manager

ngraham added a comment. The Icons-only task manager show apps, not windows/tasks. Apps don't get minimized; windows/tasks do. So I'm guessing that this feature isn't exposed in the IOTM because it conceptually doesn't make any sense given the IOTM's UX ("Show apps, not windows/tasks").

D19797: [fifteen-puzzle] Modernize settings window

ngraham added a comment. Oh whoops, I had completely forgotten that you already had this revision open, sorry :( REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D19797 To: filipf, #plasma, #vdg, ngraham Cc: rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, Z

D20746: Remove disable for showing only minimized tasks on Icons only task manager

ndavis added a comment. @hein You appear to have been the one who created the first version of this line, but I can't figure out why it was added. This is the commit where it was added: commit 3b84f96dc32b60e45127b8d30111ac232f9e Author: Eike Hein Date: Fri Sep 5 22:

D20746: Remove disable for showing only minimized tasks on Icons only task manager

davidedmundson added subscribers: hein, davidedmundson. davidedmundson added a comment. The original code is pretty clear, this isn't just a bugfix over what the author originally intended, so we need to understand that first. Git logs didn't tell me enough detail why it's there. It was a

D20771: Make sure we don't squeeze out the ActionButton

This revision was automatically updated to reflect the committed changes. Closed by commit R169:94b8482946db: Make sure we don't squeeze out the ActionButton (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20771?vs=56832&id=56833 REVISION

D20771: Make sure we don't squeeze out the ActionButton

apol created this revision. apol added a reviewer: mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Use the implicit height to set its height, we're using it to put it on its Loader. This would sometimes re

D19694: [RFC] Reduce sidebar icon size/increase list information density

ngraham added a comment. The "after" version is already in the wild because of a Kirigami Frameworks change to make list items shorter, and I haven't seen any user complaints at all about it. In fact, I've seen a few positive ones. So I'm going to land this and preserve the current status qu

D19694: [RFC] Reduce sidebar icon size/increase list information density

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R124:f8a9bdfdd7bf: [RFC] Reduce sidebar icon size/increase list information density (authored by ngraham). REPOSITORY R12

D20747: [FifteenPuzzle] Port configuration window to QQC2 and Kirigami.FormLayout

filipf added inline comments. INLINE COMMENTS > configAppearance.qml:54 > +id: pieceColorPicker > > +Kirigami.FormData.label: i18nc("@label:chooser", "Piece color:") You could have `enabled: !useImageCheckBox.checked` here > configAppearance.qml:64 > +id: numberColorPi

D20651: Support default action, priority hints, set desktop-entry

This revision was automatically updated to reflect the committed changes. Closed by commit R838:532534a135e6: Support default action, priority hints, set desktop-entry (authored by broulik). REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabric

KDE CI: Plasma » xdg-desktop-portal-kde » kf5-qt5 SUSEQt5.12 - Build # 12 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/xdg-desktop-portal-kde/job/kf5-qt5%20SUSEQt5.12/12/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 23 Apr 2019 10:56:19 + Build duration: 1 min 11 sec and counting CONSOLE OUTPUT [...t

KDE CI: Plasma » xdg-desktop-portal-kde » kf5-qt5 FreeBSDQt5.12 - Build # 14 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/xdg-desktop-portal-kde/job/kf5-qt5%20FreeBSDQt5.12/14/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 23 Apr 2019 10:56:19 + Build duration: 52 sec and counting CONSOLE OUTPUT [...t

D20736: Make artwork selection more standards-compliant and smarter

fvogt requested changes to this revision. fvogt added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > mprisplugin.cpp:489 > +// now parse the size... > +const QVector sizeSegments = > size.splitRef(QLatin1Char('x'), QString::SkipEmptyPart

D20736: Make artwork selection more standards-compliant and smarter

broulik updated this revision to Diff 56800. broulik retitled this revision from "Limit thumbnail size" to "Make artwork selection more standards-compliant and smarter". broulik edited the summary of this revision. broulik edited the test plan for this revision. REPOSITORY R856 Plasma Browser I

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

romangg added a comment. In D20186#454584 , @atulbi wrote: > In D20186#454420 , @ngraham wrote: > > > @atulbi ping! Does Roman's request make sense? In general I think it does make sense to do code