D20859: Crash in sddmthemeinstaller invalid use of errorString

anthonyfieroni added a comment. That's maybe KAuth bug or KCoreAddons one, when job fails it should have errorString. Also check jobs does not delete itself. REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D20859 To: johngehrig, ngraham Cc:

D20786: ProcessList: add support for cgroups

anthonyfieroni added inline comments. INLINE COMMENTS > ProcessList.c:420-421 > +if ( buf[0] == '0' && buf[1] == ':' && buf[2] == ':' ) { > + while (buf[strlen(buf) - 1] == '\n') > +buf[strlen(buf) - 1] = '\0'; /* trim trailing newlines */ > + ps->cGroup = strdup( [3] );

D20859: Crash in sddmthemeinstaller invalid use of errorString

johngehrig added a comment. It looks like my alternate error "unknown error" isn't showing up in the dialog... So this isn't quite right yet. I will fix this together with any other feedback. The segfault does appears to be resolved. REPOSITORY R123 SDDM Configuration Panel (KCM)

D20851: [Pager] Improve label legibility

ndavis added a comment. In D20851#456931 , @ngraham wrote: > [...] In the first screenshot you can see that the number "1" is actually almost invisible. I'm open to suggestions for alternative ways to improve this. Yes, but this is

D20854: process: show SELinux context

topimiettinen added a comment. F6795665: Screenshot_fedora.png Fedora with SELinux REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D20854 To: topimiettinen Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot,

D20854: process: show SELinux context

topimiettinen created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. topimiettinen requested review of this revision. REVISION SUMMARY Signed-off-by: Topi Miettinen REPOSITORY R111 KSysguard Library BRANCH master REVISION DETAIL

D20853: ProcessList: show SELinux context

topimiettinen created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. topimiettinen requested review of this revision. REVISION SUMMARY Signed-off-by: Topi Miettinen REPOSITORY R106 KSysguard BRANCH processlist-add-cgroup REVISION DETAIL

D20786: ProcessList: add support for cgroups

topimiettinen updated this revision to Diff 57070. topimiettinen added a comment. trim trailing newlines REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20786?vs=56890=57070 BRANCH processlist-add-cgroup REVISION DETAIL

D20787: process: add support for cgroups

topimiettinen updated this revision to Diff 57069. topimiettinen added a comment. fix copy-pasta REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20787?vs=57068=57069 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20787 AFFECTED

D20851: [Pager] Improve label legibility

filipf added a comment. An outline could work, but maybe not at 100% opacity. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20851 To: ngraham, #vdg, #plasma Cc: filipf, abetts, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,

D20851: [Pager] Improve label legibility

abetts added a comment. In D20851#456936 , @ngraham wrote: > In D20851#456932 , @abetts wrote: > > > I agree with this too. Do you think it would be too weird of other methods are used? For example:

D20851: [Pager] Improve label legibility

ngraham added a comment. In D20851#456932 , @abetts wrote: > I agree with this too. Do you think it would be too weird of other methods are used? For example: > > - Use a more legible font that is independent from system font > - Use

D20851: [Pager] Improve label legibility

abetts added a comment. In D20851#456931 , @ngraham wrote: > Well, I find it almost impossible to read the text with the status quo version when there are a bunch of window outlines. In the first screenshot you can see that the number "1" is

D20851: [Pager] Improve label legibility

ngraham added a comment. Well, I find it almost impossible to read the text with the status quo version when there are a bunch of window outlines. In the first screenshot you can see that the number "1" is actually almost invisible. I'm open to suggestions for alternative ways to improve

D20787: process: add support for cgroups

topimiettinen added a comment. F6795486: screenshot3.png Looks much better! REPOSITORY R111 KSysguard Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D20787 To: topimiettinen, #plasma, hein, davidedmundson Cc: davidedmundson,

D20787: process: add support for cgroups

topimiettinen updated this revision to Diff 57068. topimiettinen added a comment. phabricate only one git commit, sorry REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20787?vs=57067=57068 BRANCH master REVISION DETAIL

D20787: process: add support for cgroups

topimiettinen updated this revision to Diff 57067. topimiettinen added a comment. Trim trailing newline for proper vertical alignment REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20787?vs=56908=57067 BRANCH master REVISION DETAIL

D20585: [FormLayout] Use even top and bottom spacing for separator

ngraham accepted this revision as: ngraham. ngraham added a comment. This looks okay to me, but wait for @mart. :) REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D20585 To: filipf, mart, #kirigami, ngraham Cc: plasma-devel, domson, dkardarakos, apol,

D20585: [FormLayout] RFC: Use even top and bottom spacing for separator

filipf updated this revision to Diff 57065. filipf added a comment. OK I solved it, but not sure if there isn't a better way REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20585?vs=56330=57065 BRANCH even-separator-spacing (branched from master)

D20851: [Pager] Improve label legibility

abetts added a comment. In D20851#456903 , @ndavis wrote: > To me, the white text with the shadows doesn't really improve legibility and just looks "off". For some reason, shadow behind small text messes with my eyes and makes it harder to

D20851: [Pager] Improve label legibility

ndavis added a comment. To me, the white text with the shadows doesn't really improve legibility and just looks "off" REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20851 To: ngraham, #vdg, #plasma Cc: ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel,

D20851: [Pager] Improve label legibility

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Currently, when displaying pager labels (either number or name), text legibility is often

D20849: [aboutpage] hide Authors header if there are no authors

nicolasfella created this revision. nicolasfella added a reviewer: mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REPOSITORY R169 Kirigami BRANCH author REVISION DETAIL https://phabricator.kde.org/D20849

D20820: Add Show Desktop applet to default panel

This revision was automatically updated to reflect the committed changes. Closed by commit R119:4d3bfe3c0d31: Add Show Desktop applet to default panel (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20820?vs=57059=57060 REVISION

D20820: Add Show Desktop applet to default panel

GB_2 updated this revision to Diff 57059. GB_2 added a comment. Fix diff REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20820?vs=56976=57059 BRANCH add-showdesktop-applet-to-default-panel (branched from master) REVISION DETAIL

D20817: Remove the Show Desktop applet (it's in plasma-desktop now)

This revision was automatically updated to reflect the committed changes. Closed by commit R114:00cd377ecc57: Remove the Show Desktop applet (its in plasma-desktop now) (authored by GB_2). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D20818: Add the Show Desktop applet (moved from kdeplasma-addons)

This revision was automatically updated to reflect the committed changes. Closed by commit R119:b6d785370d53: Add the Show Desktop applet (moved from kdeplasma-addons) (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D18645: BasicListItem: use specified tint color when transparency is 0

pwegner added a comment. Sorry for not creating a bug report.. Your build issue might be caused by pkg-config not being able to find moc. You might have to set PKG_CONFIG_LIBDIR / PKG_CONFIG_PATH accordingly. Here is the logic for detecting where moc is:

D18645: BasicListItem: use specified tint color when transparency is 0

mart added a comment. In D18645#456718 , @pwegner wrote: > https://github.com/KDE/kirigami/commit/c0f2a341a4c9e947cbb2ca914ba36a31728b05c4 > > This commit broke my app. It is too big for me to find a bug in there. > The app in question

D20846: [Task Manager] Don't show redundant "Actions" header in context menu with nothing but actions in it

ngraham created this revision. ngraham added reviewers: broulik, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Previously, the Actions header was always shown, even when the context menu consisted

D20576: Add new notifications KCM

broulik updated this revision to Diff 57047. broulik added a comment. - Drop remove feature for seen apps. They shouldn't really pile up, as discussed with VDG - Some cleanup REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20576?vs=56304=57047

D18645: BasicListItem: use specified tint color when transparency is 0

pwegner added a comment. https://github.com/KDE/kirigami/commit/c0f2a341a4c9e947cbb2ca914ba36a31728b05c4 This commit broke my app. It is too big for me to find a bug in there. The app in question is available here:

D20804: RFC: Try getting the X keyboard grab multiple times

zzag added a comment. > Wrote relevant matching kwin patch to close effects Have you uploaded it? :-) REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D20804 To: davidedmundson, #plasma, #kwin Cc: zzag, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel,

D20818: Add the Show Desktop applet (moved from kdeplasma-addons)

GB_2 updated this revision to Diff 57040. GB_2 added a comment. Move Minimize All too, so there is an alternative REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20818?vs=56973=57040 BRANCH arcpatch-D20818 REVISION DETAIL

D20817: Remove the Show Desktop applet (it's in plasma-desktop now)

GB_2 updated this revision to Diff 57039. GB_2 added a comment. Move Minimize All too, so there is an alternative REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20817?vs=56972=57039 BRANCH move-showdesktop-applet (branched from master) REVISION

D20585: [FormLayout] RFC: Use even top and bottom spacing for separator

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. ok, let's delay this still for a while REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D20585 To: filipf, mart, #kirigami, ngraham Cc: plasma-devel, domson,

D20585: [FormLayout] RFC: Use even top and bottom spacing for separator

filipf added a comment. @mart are you sure this is the right solution? From my tests the patch also adds extra spacing whenever there is an instance of `isSection`, but we'd only want it to do so when there is a separator present. Before: F6794817: Screenshot_20190426_133016.png

D20819: Make really sure we show an error message in case saving failed

This revision was automatically updated to reflect the committed changes. Closed by commit R856:6ae424de5d13: Make really sure we show an error message in case saving failed (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE

D18645: BasicListItem: use specified tint color when transparency is 0

mart added a comment. so, now the decision when to color an icon and when not should be a bit smarter... is this still necessary? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D18645 To: pwegner, #kirigami, mart Cc: plasma-devel, domson, dkardarakos, apol,

D20835: fix formatting in android build instructions

This revision was automatically updated to reflect the committed changes. Closed by commit R169:4f2293bd2e93: fix formatting in android build instructions (authored by neroburner, committed by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D20835: fix formatting in android build instructions

neroburner added a comment. In D20835#456484 , @apol wrote: > Can you land the patch or should we do it for you? please do it for me. It is my first interaction with Phabricator and I have no idea how to land the patch. I'm hoping

D20819: Make really sure we show an error message in case saving failed

broulik updated this revision to Diff 57019. broulik added a comment. - Show `error`, if any REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20819?vs=56975=57019 REVISION DETAIL https://phabricator.kde.org/D20819 AFFECTED FILES

D20810: Fix launcher URL comparison

This revision was automatically updated to reflect the committed changes. Closed by commit R119:b6b008bbf0ec: Fix launcher URL comparison (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20810?vs=56961=57017 REVISION DETAIL

D20835: fix formatting in android build instructions

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Can you land the patch or should we do it for you? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D20835 To: neroburner, apol Cc: apol, plasma-devel, domson,

D20818: Add the Show Desktop applet (moved from kdeplasma-addons)

GB_2 added a comment. Does that mean I can land it? REPOSITORY R119 Plasma Desktop BRANCH move-showdesktop-applet (branched from master) REVISION DETAIL https://phabricator.kde.org/D20818 To: GB_2, #plasma, #vdg, ngraham, apol Cc: apol, ltoscano, ngraham, #vdg, plasma-devel, #plasma,

D20835: fix formatting in android build instructions

neroburner created this revision. neroburner added a project: Kirigami. Herald added a subscriber: plasma-devel. neroburner requested review of this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D20835 AFFECTED FILES README.md To: neroburner Cc: