D20788: Reset model when there are new available connections

jgrulich added a comment. I think resetting the model might not be necessary, when addAvailableConnection() is called, it then updates item with a new available connection, which invalidates the filter anyway or at least it should. REPOSITORY R116 Plasma Network Management Applet REVISION

D20788: Reset model when there are new available connections

McPain planned changes to this revision. McPain added a comment. The patch "as-is" is broken. I had reports about resetting model right after clicking "Connect" button - model resets and there are no connection attempts. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL

D20871: Don't delete profiles and ports on update

apol added a comment. the patch looks good. +1 REPOSITORY R994 Pulseaudio Qt Bindings REVISION DETAIL https://phabricator.kde.org/D20871 To: nicolasfella, drosca Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D20859: Crash in sddmthemeinstaller invalid use of errorString

davidedmundson added a comment. Or swap the qWarning line with the messagebox We want the log regardless REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D20859 To: johngehrig, ngraham, davidedmundson, #plasma Cc: anthonyfieroni, plasma-deve

D20859: Crash in sddmthemeinstaller invalid use of errorString

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. That's not why its crashing. You have this. https://blogs.kde.org/2009/03/26/how-crash-almost-every-qtkde-application-and-how-fix-it-0 Kmessagebox hi

D20878: [containments/desktop] Port desktop settings pages to QQC2+Kirigami FormLayout and modernize UI

ngraham accepted this revision. ngraham added a comment. Very nice work. REPOSITORY R119 Plasma Desktop BRANCH containments-desktop-port-desktop-settings-pages-to-qqc2-plus-kirigami-formlayout-and-modernize-ui (branched from master) REVISION DETAIL https://phabricator.kde.org/D20878

D20859: Crash in sddmthemeinstaller invalid use of errorString

ngraham added a comment. Thanks for the patch! Let me know when the other issue is resolved too. @anthonyfieroni offered up some good ideas. REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D20859 To: johngehrig, ngraham, davidedmundson, #plasma

D19011: Thunderbolt KCM and KDED module

ngraham added a comment. I say let's get this in for 5.16. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19011 To: dvratil, #vdg, #plasma Cc: zzag, GB_2, knambiar, bernieinnocenti, andreask, ndavis, trickyricky26, abetts, fabianr, ngraham, broulik, ognarb,

D20849: [aboutpage] hide Authors header if there are no authors

This revision was automatically updated to reflect the committed changes. Closed by commit R169:dd877238bb5f: [aboutpage] hide Authors header if there are no authors (authored by nicolasfella). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20849?vs=57061&id=

D19011: Thunderbolt KCM and KDED module

dvratil updated this revision to Diff 57147. dvratil added a comment. - Update the icon - Rebase on current master REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19011?vs=54625&id=57147 BRANCH arcpatch-D19011 REVISION DETAIL https://phabricat

D20265: Introduce libnotificationmanager

broulik added inline comments. INLINE COMMENTS > mart wrote in jobsmodel.cpp:72 > any reason to go this way instead of Q_GLOBAL_STATIC ? > I guess you want to have cases in which none of it is ever created? tough the > case would be when there are no notification plasmoids, but in that case the

D20878: [containments/desktop] Port desktop settings pages to QQC2+Kirigami FormLayout and modernize UI

filipf accepted this revision. filipf added a comment. Works fine and looks good to me. This is probably a style issue, but it should be noted that these buttons shouldn't stay highlighted after they're pressed: F6798674: image.png INLINE COMMENTS

D20853: ProcessList: show SELinux context

topimiettinen added a comment. In D20853#457577 , @davidedmundson wrote: > Out of curiosity, do you use the remote processlist? No, but at first I thought ksysguardd was always used as a back end. It seems simple enough to be updated in

D20878: [containments/desktop] Port desktop settings pages to QQC2+Kirigami FormLayout and modernize UI

GB_2 updated this revision to Diff 57144. GB_2 added a comment. Don't set root size to childrenRect size REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20878?vs=57133&id=57144 BRANCH containments-desktop-port-desktop-settings-pages-to-qqc2-plus-k

D20867: Add Property to disable drawing of menu arrow indicators

hallas added a comment. In D20867#457575 , @davidedmundson wrote: > QToolButton::setArrowType? After reading the documents and experimenting a bit, I think that this property is not what we are looking for. The Arrow Type property is to

D20867: Add Property to disable drawing of menu arrow indicators

hallas added a comment. In D20867#457575 , @davidedmundson wrote: > QToolButton::setArrowType? I just tried that, but it doesn't seem like Breeze honors this property - at least not for the `QToolButton` produced by `KToolBarPopupAction`

D20867: Add Property to disable drawing of menu arrow indicators

davidedmundson added a comment. QToolButton::setArrowType? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D20867 To: hallas, ngraham Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D20867: Add Property to disable drawing of menu arrow indicators

davidedmundson added a comment. There shouldn't be any Breeze specific code in client apps. It's a sign of something being wrong. What's a navigation style toolbutton and where do you want to use this? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D20867 To: hal

D20853: ProcessList: show SELinux context

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Out of curiosity, do you use the remote processlist? REPOSITORY R106 KSysguard BRANCH processlist-add-cgroup REVISION DETAIL https://phabricator.kde.org/D20853 To: t

D20867: Add Property to disable drawing of menu arrow indicators

hallas added a comment. In D20867#457570 , @davidedmundson wrote: > There shouldn't be any Breeze specific code in client apps. It's a sign of something being wrong. > > What's a navigation style toolbutton and where do you want to use this?

D20878: [containments/desktop] Port desktop settings pages to QQC2+Kirigami FormLayout and modernize UI

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. One comment, please include when committing INLINE COMMENTS > ConfigFilter.qml:33-34 > > width: childrenRect.width > height: childrenRect.height > These lines

D20872: Use override

This revision was automatically updated to reflect the committed changes. Closed by commit R994:979c01b2d6ca: Use override (authored by nicolasfella). REPOSITORY R994 Pulseaudio Qt Bindings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20872?vs=57111&id=57138 REVISION DETAIL https

D20878: [containments/desktop] Port desktop settings pages to QQC2+Kirigami FormLayout and modernize UI

GB_2 updated this revision to Diff 57133. GB_2 added a comment. Fix some capitalizations, "Hide Files Matching" -> "Hide matching" REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20878?vs=57132&id=57133 BRANCH containments-desktop-port-desktop-set

D20878: [containments/desktop] Port desktop settings pages to QQC2+Kirigami FormLayout and modernize UI

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY - Port to QQC2+Kirigami FormLayout (except for the mimetype table, there is no QQC2 equivalent) - Im

KDE CI: Plasma » plasma-pa » kf5-qt5 FreeBSDQt5.12 - Build # 22 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-pa/job/kf5-qt5%20FreeBSDQt5.12/22/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 28 Apr 2019 08:17:20 + Build duration: 1 min 11 sec and counting CONSOLE OUTPUT [...truncate

KDE CI: Plasma » xdg-desktop-portal-kde » kf5-qt5 FreeBSDQt5.12 - Build # 15 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/xdg-desktop-portal-kde/job/kf5-qt5%20FreeBSDQt5.12/15/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 28 Apr 2019 08:17:19 + Build duration: 1 min 2 sec and counting

KDE CI: Plasma » xdg-desktop-portal-kde » kf5-qt5 SUSEQt5.12 - Build # 13 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/xdg-desktop-portal-kde/job/kf5-qt5%20SUSEQt5.12/13/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 28 Apr 2019 08:17:18 + Build duration: 1 min 52 sec and counting JUnit Tests Name: (r