D20930: Update WireGuard to match NetworkManager 1.16 interface

andersonbruce updated this revision to Diff 57790. andersonbruce added a comment. - Update labels on Add and Remove peer buttons REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20930?vs=57741&id=57790 BRANCH TwoTabs REVISION DETA

D20930: Update WireGuard to match NetworkManager 1.16 interface

andersonbruce added a comment. In D20930#462775 , @ngraham wrote: > In D20930#462774 , @andersonbruce wrote: > > > Personally I like the Add and Remove buttons to be together where they were, and to

D20930: Update WireGuard to match NetworkManager 1.16 interface

ngraham added a comment. In D20930#462774 , @andersonbruce wrote: > Personally I like the Add and Remove buttons to be together where they were, and to simply change the wording to "Add New Peer" and "Remove This Peer". I think this still makes

D20930: Update WireGuard to match NetworkManager 1.16 interface

andersonbruce added a comment. In D20930#462547 , @ngraham wrote: > So much better! > > I have one more little suggestion for the buttons: move the "Remove Peer" button into the bottom of the tab for that peer to make it clear what it applie

D20265: Introduce libnotificationmanager

davidedmundson added a comment. I have a bunch of minor comments, but nothing that's a big show-stopper. Then I think we're probably best shipping it soon. INLINE COMMENTS > notificationmanagerplugin.cpp:36 > +qmlRegisterType(uri, 1, 0, "Notifications"); > +qmlRegisterType(); > +

D21088: [quicklaunch] Port settings window to QQC2+Kirigami FormLayout and modernize UI

filipf accepted this revision. filipf added a comment. This revision is now accepted and ready to land. Everything looks good to me now! REPOSITORY R114 Plasma Addons BRANCH quicklaunch-modernize-settings-window (branched from master) REVISION DETAIL https://phabricator.kde.org/D21088

D21088: [quicklaunch] Port settings window to QQC2+Kirigami FormLayout and modernize UI

This revision was automatically updated to reflect the committed changes. Closed by commit R114:12eba77542c1: [quicklaunch] Port settings window to QQC2+Kirigami FormLayout and modernize UI (authored by ngraham). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde

D21027: [Notes] Fix icons being almost invisible with light backgrounds

filipf updated this revision to Diff 57785. filipf added a comment. - add space after comment slashes - add punctuation in the comments for the added function REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21027?vs=57776&id=57785 BRANCH backgroun

D21088: [quicklaunch] Port settings window to QQC2+Kirigami FormLayout and modernize UI

ngraham added a comment. Oops, how embarrassing. I had misunderstood the feature somehow. Fixed! REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D21088 To: ngraham, #vdg, #plasma Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali

D21088: [quicklaunch] Port settings window to QQC2+Kirigami FormLayout and modernize UI

ngraham updated this revision to Diff 57784. ngraham added a comment. Fix embarrassing error REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21088?vs=57779&id=57784 BRANCH quicklaunch-modernize-settings-window (branched from master) REVISION DETAIL

D21074: [System Monitor] Port settings window to QQC2+Kirigami FormLayout and modernize UI

This revision was automatically updated to reflect the committed changes. Closed by commit R120:1a980bedc4d1: [System Monitor] Port settings window to QQC2+Kirigami FormLayout and modernize… (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator

D21074: [System Monitor] Port settings window to QQC2+Kirigami FormLayout and modernize UI

ngraham updated this revision to Diff 57780. ngraham marked 2 inline comments as done. ngraham added a comment. Address review comments REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21074?vs=57737&id=57780 BRANCH systemmonitor-modernize-setting

D21088: [quicklaunch] Port settings window to QQC2+Kirigami FormLayout and modernize UI

filipf added a comment. Hmm I can't set the number of columns anymore when in vertical position. Before: F6815689: image.png REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D21088 To: ngraham, #vdg, #plasma Cc: filip

D21027: [Notes] Fix icons being almost invisible with light backgrounds

ngraham added inline comments. INLINE COMMENTS > main.qml:60 > > +//define colors used for icons in ToolButtons and for text in TextArea > +//this is deliberately _NOT_ the theme color as we are over a known > bright background Add a space between the slashes and the text. Also since

D21088: [quicklaunch] Port settings window to QQC2+Kirigami FormLayout and modernize UI

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY - Port to QQC2+Kirigami FormLayout style - Use standard import names - Adjust some strings

D21074: [System Monitor] Port settings window to QQC2+Kirigami FormLayout and modernize UI

filipf added inline comments. INLINE COMMENTS > ConfigGeneral.qml:113 > +Kirigami.FormLayout { > +id: formLayout > + We should do `anchors.left: parent.left` and `anchors.right: parent.right` here so the layout is horizontally centered. > ConfigGeneral.qml:121 > + > +Ki

D21027: [Notes] Fix icons being almost invisible with light backgrounds

filipf updated this revision to Diff 57776. filipf added a comment. remove some hack I was working on for scrollbar color REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21027?vs=57775&id=57776 BRANCH background-appropriate-icon-colors (branched fro

D21027: [Notes] Fix icons being almost invisible with light backgrounds

filipf updated this revision to Diff 57775. filipf added a comment. write a function for text and icon colors so as to not duplicate code everywhere REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21027?vs=57578&id=57775 BRANCH background-appropria

D21026: Fix ToolButton remaining in a pressed state after press

filipf added a comment. @mart does this look good to you? As you're the author I wouldn't want to merge without your approval. REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH no-highlight-color-after-press (branched from master) REVISION DETAIL https://phabricator.kde.org/D2

D21062: [Lock, login & logout screen] Add visual feedback to action buttons when pressed

filipf marked an inline comment as done. filipf added a comment. Here's what I'm trying to avoid: F6815617: ActionButtonPressedEffect When pressing fast and in the lock screen we can see the circle is still in the process of being scaled to 1. I

D21075: [QQC2 Slider Style] Fix wrong handle positioning when initial value is 1

filipf added a comment. So I looked up Google's documentation and it turns out sliders do have to be mirrored: https://material.io/design/usability/bidirectionality.html#mirroring-elements https://material.io/design/components/sliders.html#usage As for the implementation, @broulik men

D20930: Update WireGuard to match NetworkManager 1.16 interface

ngraham added a comment. So much better! I have one more little suggestion for the buttons: move the "Remove Peer" button into the bottom of the tab for that peer to make it clear what it applies to, and change the text to say, "Remove this Peer". The Remove button can stay where it is,

D21082: Fix lid open/closed configurations

hoffmannrobert created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. hoffmannrobert requested review of this revision. REVISION SUMMARY Screen configurations on notebooks couldn't distinguish properly between open lid and closed lid configurations. The

D16425: Added new Suspend then Hibernate option

meven added a comment. In D16425#449330 , @avaldes wrote: > This is how the module looks with the new option: > F6770639: image.png > It looks the same as the "Even when an external monitor is connected

D20576: Add new notifications KCM

broulik updated this revision to Diff 57758. broulik added a comment. - Don't leak `KNotification` - Ensure proper transient REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20576?vs=57652&id=57758 REVISION DETAIL https://phabricator.kde.org/D2057

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.12 - Build # 20 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.12/20/ Project: stable-kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 08 May 2019 10:55:22 + Build duration: 52 min and counting JUnit Tests Na

D20576: Add new notifications KCM

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. I don't like this thing with source proxy. But I can kinda see what it's doing and it looks like it'll work. Lets go for it REPOSITORY R119 Plasma Desktop REVISION D

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 18 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/18/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Wed, 08 May 2019 10:55:21 + Build duration: 11 min and counting JUnit Tests Name: (r

D21075: [QQC2 Slider Style] Fix wrong handle positioning when initial value is 1

filipf updated this revision to Diff 57752. filipf added a comment. fix handle behavior for right to left layouts REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21075?vs=57738&id=57752 BRANCH fix-qqc2-slider-when-from-is-1 (bra

KDE CI: Plasma » powerdevil » stable-kf5-qt5 SUSEQt5.12 - Build # 19 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.12/19/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Wed, 08 May 2019 10:55:17 + Build duration: 4 min 3 sec and counting JUnit Tests Name: (

KDE CI: Plasma » systemsettings » stable-kf5-qt5 SUSEQt5.12 - Build # 25 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/stable-kf5-qt5%20SUSEQt5.12/25/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Wed, 08 May 2019 10:55:16 + Build duration: 3 min 22 sec and counting JUnit Tests Na

D21075: [QQC2 Slider Style] Fix wrong handle positioning when initial value is 1

filipf added a comment. In D21075#462419 , @broulik wrote: > Hm, right, seems the slider behaves incorrectly without this patch, too :/ Still I think `visualPosition` is what we want to be using About Qt's unmodified slider, isn't that on

D21075: [QQC2 Slider Style] Fix wrong handle positioning when initial value is 1

broulik added a comment. Hm, right, seems the slider behaves incorrectly without this patch, too :/ Still I think `visualPosition` is what we want to be using REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D21075 To: filipf, mart, #plasma,

D21075: [QQC2 Slider Style] Fix wrong handle positioning when initial value is 1

filipf added a comment. In D21075#462393 , @broulik wrote: > -1 > This breaks the slider in right-to-left mode. Run `qmlscene -reverse` to see Hmm seems to be behaving the same as before, just that the handle is now on the tickmark.

D17007: Do hash and hex name based output hashes

romangg updated this revision to Diff 57751. romangg added a comment. Deprecate hash function instead of altering its behavior. This way we can use the new function, which does hash the output names correctly, in cases where it makes sense and no user configs break. REPOSITORY R110 KScre

D16898: [kcm] Remove profiles code

This revision was automatically updated to reflect the committed changes. Closed by commit R104:7283fb5630df: [kcm] Remove profiles code (authored by romangg). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16898?vs=45519&id=57748 REVISION DETAIL https://ph

D21075: [QQC2 Slider Style] Fix wrong handle positioning when initial value is 1

broulik added a comment. -1 This breaks the slider in right-to-left mode. Run `qmlscene -reverse` to see REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH fix-qqc2-slider-when-from-is-1 (branched from master) REVISION DETAIL https://phabricator.kde.org/D21075 To: filipf, mar

KDE CI: Plasma » drkonqi » stable-kf5-qt5 WindowsMSVCQt5.11 - Build # 5 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/stable-kf5-qt5%20WindowsMSVCQt5.11/5/ Project: stable-kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 08 May 2019 07:01:10 + Build duration: 3 min 4 sec and counting CONSOLE OUTPUT