D19829: kicker: add option to make root level icons visible

GB_2 added a comment. Ping REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19829 To: i.Dark_Templar, hein, #plasma, #vdg, GB_2 Cc: GB_2, ngraham, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D21111: Added new option to use GlobalProtect with openconnect

avaldes added a comment. networkmanager-openconnect has added support in master for global protect , so now we can use it from plasma. This was tested in my machine with Plasma

D21111: Added new option to use GlobalProtect with openconnect

avaldes created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. avaldes requested review of this revision. REVISION SUMMARY This adds a new option to the dropdown and a new desktop file to create a connection to a Palo

D16997: [kcm] Expose interface to control output property retention

romangg updated this revision to Diff 57835. romangg added a comment. Rebase on series changes. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16997?vs=57720=57835 BRANCH 1controlKcm REVISION DETAIL https://phabricator.kde.org/D16997 AFFECTED FILES common/control.cpp

D21110: On config read adjust outputs positions to global value changes

romangg created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY Some global output values directly influence the positions of outputs relative to each other, at the moment namely scale and

D16995: Consider identical display models in ControlConfig

romangg added a comment. In D16995#462174 , @romangg wrote: > If there is no control file, the output retention falls back to global. If there is no global file we set some default values. It should instead take the ones from the config file.

D16996: Add method to write retention to configuration control files

romangg updated this revision to Diff 57834. romangg added a comment. Rebase on series changes. REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16996?vs=57719=57834 BRANCH 1controlWrite REVISION DETAIL https://phabricator.kde.org/D16996 AFFECTED

D16995: Consider identical display models in ControlConfig

romangg updated this revision to Diff 57833. romangg added a comment. Rebase on series changes. REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16995?vs=57718=57833 BRANCH 1controlNameSpecific REVISION DETAIL https://phabricator.kde.org/D16995

D16994: Split Control class into configurations and outputs control classes

romangg updated this revision to Diff 57832. romangg added a comment. Rebase on series changes. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16994?vs=57717=57832 BRANCH 1controlClass REVISION DETAIL https://phabricator.kde.org/D16994 AFFECTED FILES common/control.cpp

D16993: Add a common directory for functionality being used by kcm and daemon

romangg updated this revision to Diff 57831. romangg added a comment. Rebase on series changes. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16993?vs=57716=57831 BRANCH 1commonInterfacesWithClass REVISION DETAIL https://phabricator.kde.org/D16993 AFFECTED FILES

D16992: Introduce secondary control channel of the KScreen daemon

romangg updated this revision to Diff 57830. romangg added a comment. Rebase on series changes. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16992?vs=57715=57830 BRANCH 1controlRetention REVISION DETAIL https://phabricator.kde.org/D16992 AFFECTED FILES kded/CMakeLists.txt

D16991: Introduce concept of global and individual output data retention

romangg updated this revision to Diff 57829. romangg added a comment. - Fallback read global part from config - No global write for disabled outputs - Use hashMd5 function for global output file names CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16991?vs=57714=57829 BRANCH

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

ngraham added a comment. I'm afraid I don't think I have the technical chops to adequately review this, but hopefully @romangg does! :) Or any of the other #plasma people. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D21105: Port widget settings window to QQC2+Kirigami FormLayout and modernize UI

ngraham created this revision. ngraham added reviewers: VDG, Plasma, drosca. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY - Port to QQC2+Kirigami FormLayout style - Use standard import names - Adjust

D21104: Port widget settings window to QQC2+Kirigami FormLayout

ngraham created this revision. ngraham added reviewers: VDG, jgrulich. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added 1 blocking reviewer(s): jgrulich. ngraham requested review of this revision. REVISION SUMMARY - Port to QQC2+Kirigami FormLayout style -

D21027: [Notes] Fix icons being almost invisible with light backgrounds

broulik added inline comments. INLINE COMMENTS > main.qml:63 > +// an unknown colour over a known colour is a bad move as you end up > with white on yellow. > +function textIconColor() { > +if (plasmoid.configuration.color === "black" || > plasmoid.configuration.color ===

D20797: [dict] Modernize configuration window

filipf marked 5 inline comments as done. filipf added inline comments. INLINE COMMENTS > mart wrote in ConfigDictionaries.qml:55 > Control { > > which should have the highlight rectangle as background: > > and the Label as contentItem: > > this will give it some nice paddings, as now it looks

D21102: Mark "Connection Activated" notifications as low priority

broulik added a comment. +1 REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D21102 To: ngraham, broulik, #plasma, jgrulich Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D21102: Mark "Connection Activated" notifications as low priority

ngraham created this revision. ngraham added reviewers: broulik, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. ngraham requested review of this revision. broulik added a comment. +1 REVISION SUMMARY In 5.16 onwards, low

D20797: [dict] Modernize configuration window

filipf updated this revision to Diff 57813. filipf added a comment. - use Kirigami.Theme for color, remove syspal - replace ListView Item with Control and have it be the delegate - replace Text with Label and have it be ListView's contentItem NOTE: keyboard navigation still not

D20797: [dict] Modernize configuration window

GB_2 added inline comments. INLINE COMMENTS > ConfigDictionaries.qml:33 > > SystemPalette { > id: syspal This can be removed when you chang the the other color properties. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D20797 To: filipf, dfaure,

D21097: Handle apps which set the desktopFileName property with filename suffix

ngraham added a comment. +1 conceptually. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D21097 To: kossebau, #plasma, broulik Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi added a comment. In D20186#462883 , @GB_2 wrote: > Ping Hey... Have you tried this patch ? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20186 To: atulbi, ngraham, romangg, davidedmundson,

D21026: Fix ToolButton remaining in a pressed state after press

mart added a comment. but now it doesn't display the checked state in any way? REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH no-highlight-color-after-press (branched from master) REVISION DETAIL https://phabricator.kde.org/D21026 To: filipf, mart, #plasma, ngraham,

KDE CI: Plasma » plasma-pa » kf5-qt5 FreeBSDQt5.12 - Build # 31 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-pa/job/kf5-qt5%20FreeBSDQt5.12/31/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 09 May 2019 13:11:17 + Build duration: 1 hr 4 min and counting CONSOLE OUTPUT [...truncated

D20797: [dict] Modernize configuration window

mart requested changes to this revision. mart added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > ConfigDictionaries.qml:55 > > delegate: Item { > +width: root.width Control { which should have the highlight rectangle as

D20490: Rewrite notifications dataengine to work with libnotificationmanager

sitter closed this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20490 To: broulik, sitter Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20491: Rewrite applicationjobs dataengine to work with libnotificationmanager

sitter closed this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20491 To: broulik, #plasma, sitter Cc: mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D20930: Update WireGuard to match NetworkManager 1.16 interface

ngraham accepted this revision. ngraham added a comment. Thanks for the info. I appreciate that you've taken so much time to think this through, and thanks for helping me understand how this works. LGTM from a #VDG perspective! REPOSITORY R116 Plasma

D20490: Rewrite notifications dataengine to work with libnotificationmanager

broulik added a comment. All merged https://cgit.kde.org/plasma-workspace.git/commit/?id=3c52fc3bc05e0f351d4998ad54edae1a4e21a043 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20490 To: broulik, #plasma, mart Cc: plasma-devel, jraleigh, GB_2, ragreen,

D20491: Rewrite applicationjobs dataengine to work with libnotificationmanager

broulik added a comment. All merged https://cgit.kde.org/plasma-workspace.git/commit/?id=3c52fc3bc05e0f351d4998ad54edae1a4e21a043 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20491 To: broulik, #plasma Cc: mart, plasma-devel, jraleigh, GB_2, ragreen,

D20265: Introduce libnotificationmanager

broulik added a comment. All merged https://cgit.kde.org/plasma-workspace.git/commit/?id=3c52fc3bc05e0f351d4998ad54edae1a4e21a043 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20265 To: broulik, #plasma, sitter Cc: hein, mart, nicolasfella,

D20265: Introduce libnotificationmanager

sitter closed this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20265 To: broulik, #plasma, sitter Cc: hein, mart, nicolasfella, davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D21097: Handle apps which set the desktopFileName property with filename suffix

kossebau created this revision. kossebau added reviewers: Plasma, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kossebau requested review of this revision. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH handledesktopfilenamesuffix

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

GB_2 added a comment. Ping REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20186 To: atulbi, ngraham, romangg, davidedmundson, #plasma Cc: GB_2, jriddell, knambiar, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.12 - Build # 246 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.12/246/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 09 May 2019 09:59:33 + Build duration: 3 min 12 sec and counting JUnit Tests Name:

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.12 - Build # 245 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.12/245/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 09 May 2019 09:48:43 + Build duration: 36 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 198 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/198/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 09 May 2019 09:48:43 + Build duration: 55 sec and counting CONSOLE OUTPUT [...truncated 585

D18519: [KColorSchemeEditor] Turn Save button into Save As

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R119:cc63a8af3913: [KColorSchemeEditor] Turn Save button into Save As (authored by broulik). REPOSITORY R119 Plasma

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 197 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/197/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 09 May 2019 09:39:52 + Build duration: 1 min 18 sec and counting CONSOLE OUTPUT

D21061: [Task Manager] Use libnotificationmanager for notification badges and application job reporting

This revision was automatically updated to reflect the committed changes. Closed by commit R119:00962d089177: [Task Manager] Use libnotificationmanager for notification badges and… (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21061?vs=57697=57798#toc REPOSITORY

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 196 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/196/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 09 May 2019 09:38:12 + Build duration: 1 min 5 sec and counting CONSOLE OUTPUT

D20576: Add new notifications KCM

This revision was automatically updated to reflect the committed changes. Closed by commit R119:be5819d0cab7: Merge branch kcm-redesign/notifications (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20576?vs=57758=57797 REVISION

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 195 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/195/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 09 May 2019 09:35:13 + Build duration: 1 min 31 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.12 - Build # 244 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.12/244/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 09 May 2019 09:42:22 + Build duration: 41 sec and counting CONSOLE OUTPUT

D20266: Add new notification plasmoid

broulik closed this revision. broulik added a comment. All merged https://cgit.kde.org/plasma-workspace.git/commit/?id=3c52fc3bc05e0f351d4998ad54edae1a4e21a043 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20266 To: broulik, #plasma, #vdg, mart Cc: mart,