D20930: Update WireGuard to match NetworkManager 1.16 interface

andersonbruce marked 8 inline comments as done. andersonbruce added a comment. Update to fix some comments. INLINE COMMENTS > jgrulich wrote in connectionicon.cpp:403 > You can now use NetworkManager::Device::WireGuard. There is still a discrepancy between the enum defined by NetworkManager

D20930: Update WireGuard to match NetworkManager 1.16 interface

andersonbruce updated this revision to Diff 57888. andersonbruce added a comment. - Correct review comments REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20930?vs=57790&id=57888 BRANCH TwoTabs REVISION DETAIL https://phabrica

D21134: [Notifications] Tweak paddings

apol added a comment. +1 I too am missing some spacing. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21134 To: ngraham, #vdg, broulik Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D21134: [Notifications] Tweak paddings

ngraham created this revision. ngraham added reviewers: VDG, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY The new notification pop-ups are great, but they can feel a bit cramped. This patch slight

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.12 - Build # 228 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.12/228/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 10 May 2019 20:45:32 + Build duration: 20 min and counting JUnit Tests Name: projectroot Failed

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.12 - Build # 145 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.12/145/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 10 May 2019 17:25:16 + Build duration: 4 min 6 sec and counting CONSOLE OUTPUT [...truncated 2551 line

D21131: ScrollBar: Make it work as a horizontal scroll bar as well

This revision was automatically updated to reflect the committed changes. Closed by commit R858:f7f99e8b8ca4: ScrollBar: Make it work as a horizontal scroll bar as well (authored by apol). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.or

D21102: Mark "Connection Activated" notifications as low priority

This revision was automatically updated to reflect the committed changes. Closed by commit R116:1ce4ea2f9af1: Mark "Connection Activated" notifications as low priority (authored by ngraham). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.or

D21104: Port widget settings window to QQC2+Kirigami FormLayout

This revision was automatically updated to reflect the committed changes. Closed by commit R116:48543b1b1192: Port widget settings window to QQC2+Kirigami FormLayout (authored by ngraham). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.12 - Build # 227 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.12/227/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 10 May 2019 15:42:30 + Build duration: 8 min 17 sec and counting CONSOLE OUTPUT [...truncated 25

D21082: Fix lid open/closed configurations

romangg added a comment. So your goal is to support the following use case: User wants to set different screens properties (for example positions) on the same screen arrangement for when the lid is closed and when it is opened. Correct? Had the lidOpenend mechanic this goal from the begi

D19603: Fix colours of header bar for active and inactive windows

This revision was automatically updated to reflect the committed changes. Closed by commit R98:df538d149294: Fix colours of header bar for acitve and inactive windows (authored by davidedmundson). REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19603?vs=5

D21128: Improve keyboard navigation

apol updated this revision to Diff 57870. apol added a comment. Remove unnecessary name REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21128?vs=57865&id=57870 BRANCH master REVISION DETAIL https://phabricator.kde.org/D21128 AFFECTED FILES src/cont

D21128: Improve keyboard navigation

apol marked an inline comment as done. apol added inline comments. INLINE COMMENTS > mart wrote in delegaterecycler.cpp:373 > this doesn't look right. especially because it will help with keyboard > navigation, but not with accessibility at all. > > The proper solutuion should be make DelegateR

D21131: ScrollBar: Make it work as a horizontal scroll bar as well

apol created this revision. apol added reviewers: Kirigami, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY It was only taking into account the height so always working as vertical. This tracks the orientat

D21129: Require KF5 5.58.0 like the rest of Plasma

This revision was automatically updated to reflect the committed changes. Closed by commit R114:2a2e73781481: Require KF5 5.58.0 like the rest of Plasma (authored by heikobecker). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21129?vs=57866&id=57867 RE

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

romangg requested changes to this revision. romangg added a comment. This revision now requires changes to proceed. Looks really nice. I have yet to try it out, but following a code review. In general it is good practice to make class member variables private and have protected getters/se

D21128: Improve keyboard navigation

mart requested changes to this revision. mart added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > PrivateActionToolButton.qml:100 > + > +readonly property var p0: Shortcut { > +sequence: label.MnemonicData.sequence why p0?

D21129: Require KF5 5.58.0 like the rest of Plasma

heikobecker created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. heikobecker requested review of this revision. REPOSITORY R114 Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D21129 AFFECTED FILES CMakeLists.txt To: he

D21128: Improve keyboard navigation

apol created this revision. apol added reviewers: Kirigami, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Forward DelegateRecycler keyboard events to the actual delegate. Have PrivateActionToolButton tr

D21111: Added new option to use GlobalProtect with openconnect

avaldes added a comment. In D2#463270 , @jgrulich wrote: > In D2#463216 , @avaldes wrote: > > > networkmanager-openconnect has added support in master for global protect

D21111: Added new option to use GlobalProtect with openconnect

avaldes updated this revision to Diff 57861. avaldes added a comment. - Changes based on code review REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2?vs=57837&id=57861 BRANCH globalprotect (branched from master) REVISION DET

D20930: Update WireGuard to match NetworkManager 1.16 interface

jgrulich added inline comments. INLINE COMMENTS > kcm.cpp:527 > + > +if (connection.isEmpty()) { // the "positive" part will arrive > with connectionAdded > +// TODO display success if (!connection.isEmpty()) { return; } > connectionicon.cpp:403 >

D20943: Update tests cmake to WebEngine port

This revision was automatically updated to reflect the committed changes. Closed by commit R111:58770026d43a: Update tests cmake to WebEngine port (authored by davidedmundson). REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20943?vs=57341&id=57855 R

D19752: [Splash KCM] Use InlineMessage for testing error

This revision was automatically updated to reflect the committed changes. Closed by commit R119:bbd7fcb3a300: [Splash KCM] Use InlineMessage for testing error (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19752?vs=53864&id=57850

D21111: Added new option to use GlobalProtect with openconnect

jgrulich added inline comments. INLINE COMMENTS > CMakeLists.txt:62 > install(FILES plasmanetworkmanagement_openconnect_juniperui.desktop > DESTINATION ${KDE_INSTALL_KSERVICES5DIR}) > +install(FILES > plasmanetworkmanagement_openconnect_globalprotect.desktop DESTINATION > ${

D21111: Added new option to use GlobalProtect with openconnect

jgrulich added a comment. In D2#463216 , @avaldes wrote: > networkmanager-openconnect has added support in master for global protect ,

D21114: [Microphone Indicator] Avoid duplicate application names

broulik created this revision. broulik added reviewers: Plasma, drosca. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. TEST PLAN VirtualBox grabs all recording devices and would show up multiple times. REPOSITORY R115 Plasma

D21113: Allow hiding option items depending on available extension and version in the host

broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY We already have somewhat of a versioning system available in the host and it stores and exp

D21112: Support message response and reply callbacks

broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This allows to make use of the sendReply/sendResponse callbacks allowing for the callee to