D21278: [Touchpad KCM] Fix kded crashing at startup

atulbi added a comment. In D21278#466801 , @davidedmundson wrote: > > m_connection seems to be having null or 0x0 value. > > Which means we're calling XcbAtom::atom after being constructed from the default constructor not the proper one. >

D21278: [Touchpad KCM] Fix kded crashing at startup

atulbi added a comment. In D21278#466804 , @romangg wrote: > > by kded on key press other than Kded Keyboard shortcuts > > Do you mean it's sent on shortcut or not? Just wondering why I couldn't replicate the issue in my testing. kded

D19745: Fix system tray UI/UX & refactor

ratijastk added a comment. @davidedmundson Thanks. It is my first contribution to KDE/Plasma, so I **do hope** that I don't have a commit access. INLINE COMMENTS > davidedmundson wrote in CompactApplet.qml:34 > You will enter this branch if the system tray is on the left. > > It d

D19631: [sddm-theme/lock screen] Overhaul font sizes

rikmills added a comment. Not looking good. F6835091: c0924558f6.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19631 To: rooty, #vdg, #plasma, ngraham, filipf Cc: rikmills, davidedmundson, plasma-devel, jrale

D19631: [sddm-theme/lock screen] Overhaul font sizes

filipf added a comment. In D19631#467156 , @rikmills wrote: > Not looking good. > > F6835091: c0924558f6.png Why does it look different than Neon? F6835124: image.png

D19631: [sddm-theme/lock screen] Overhaul font sizes

rikmills added a comment. > ! In D19631#467167 , @filipf wrote: > > Why does it look different than Neon? Seems neon have a settings tweak to force more font Noto (especially for sddm). Cherry picking that... REPOSITORY R120 Plasma

D19631: [sddm-theme/lock screen] Overhaul font sizes

filipf added a comment. In D19631#467170 , @rikmills wrote: > > ! In D19631#467167 , @filipf wrote: > > > > Why does it look different than Neon? > > Seems neon have a settings tweak to force mo

D21296: Add the option to configure the realm

enriquem created this revision. enriquem added a reviewer: jgrulich. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added 1 blocking reviewer(s): jgrulich. enriquem requested review of this revision. REVISION SUMMARY Add an option in the advanced elements dialog

D21278: [Touchpad KCM] Fix kded crashing at startup

atulbi updated this revision to Diff 58319. atulbi added a comment. - Now we have separate m_touchpadOffAtom for synaptics and Libinput. On Libinput, used m_enabled prop. - setTouchpadOff will be ignored on X Libinput. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://ph

D21234: Use a more conventional sidebar header apparance in desktop view

zanny added a comment. Testing out the beta release that includes this change has the search bar overflow the menu list with high (160, in the example) DPI settings: F6838228: Screenshot_20190519_193434.png It gets worse the higher the DPI gets

D21278: [Touchpad KCM] Fix kded crashing at startup

romangg added a comment. Codewise looks fine. Good adaption in comparison to first revision! Question remains if we want to further disconnect/deactivate the applet functionality in case libinput is used. We don't need to watch the keyboard presses at all. Same holds for the Wayland case, wh

D21296: Add the option to configure the realm

jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. Looks good. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D21296 To: enriquem, jgrulich Cc: plasma-devel, jraleigh, GB_2, ragreen, Pi