D21399: Compress color changes without a QTimer

2019-05-25 Thread Volker Krause
vkrause created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. vkrause requested review of this revision. REVISION SUMMARY This class exists in large quantities, so this avoids creating hundreds of QTimer instances just for the signal compression. RE

D21399: Compress color changes without a QTimer

2019-05-25 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Cool! :) REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D21399 To: vkrause, apol Cc: apol, plasma-devel, domson, dkardarakos, davidedmundson, mart, h

D21408: RFC: [Notifications] Better notification number alignment

2019-05-25 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This tries to use `fontSizeMode` but in conjunction with `QtRendering` to achieve better numb

D21408: RFC: [Notifications] Better notification number alignment

2019-05-25 Thread Kai Uwe Broulik
broulik added a comment. F6849423: Screenshot_20190525_182118.png Still looks awful at times :( REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21408 To: broulik, #plasma, #vdg Cc: plasma-devel, jraleigh, GB_2, ragreen

D19745: Fix system tray UI/UX & refactor

2019-05-25 Thread Kai Uwe Broulik
broulik added a comment. Mouse buttons aren't propagated to the applet anymore, e.g. middle click on volume icon to mute no longer works. INLINE COMMENTS > AbstractItem.qml:22 > import QtQuick 2.1 > +import QtQuick.Layouts 1.12 > import org.kde.plasma.core 2.0 as PlasmaCore You sure this

D21408: RFC: [Notifications] Better notification number alignment

2019-05-25 Thread Noah Davis
ndavis added a comment. Here is a video showing unread notification numbers up to 21 with this patch. The font settings that affect the unread notification number (general) are at the default settings. https://www.youtube.com/watch?v=Npw2XY2x8tI REPOSITORY R120 Plasma Workspace REVIS

D19745: Fix system tray UI/UX & refactor

2019-05-25 Thread Nathaniel Graham
ngraham added a comment. @ratijastk, are you interested in sending a follow-up patch to address @broulik's comments? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19745 To: ratijastk, #vdg, #plasma, broulik, mart, hein, davidedmundson Cc: aacid, davidre,

D21408: RFC: [Notifications] Better notification number alignment

2019-05-25 Thread Nathaniel Graham
ngraham added a comment. In D21408#469997 , @broulik wrote: > F6849423: Screenshot_20190525_182118.png Still looks awful at times :( When there are 2 or digits, maybe the circle can expand to become

D21385: Improve AppData description

2019-05-25 Thread Nathaniel Graham
ngraham updated this revision to Diff 58668. ngraham added a comment. Rebase REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21385?vs=58621&id=58668 BRANCH arcpatch-D21385 REVISION DETAIL https://phabricator.kde.org/D21385 AFFECTED FIL

D21385: Improve AppData description

2019-05-25 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R134:d95e7295063f: Improve AppData description (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21385?vs=58668&id=58669 REVISION DE