D21296: Add the option to configure the realm

2019-05-26 Thread Jan Grulich
This revision was automatically updated to reflect the committed changes. Closed by commit R116:179cd8baea41: Add the option to configure the realm (authored by jgrulich). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D15341: [Plasma Search KCM] Add a UI tab for editing shortcuts.

2019-05-26 Thread James Smith
smithjd updated this revision to Diff 58698. smithjd added a comment. - [Plasma Search KCM] Re-organize the tab and widget layouts. - Add edit actions. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15341?vs=41183=58698 BRANCH

D14739: [KRunner] Allow modifying the keyboard shortcuts.

2019-05-26 Thread James Smith
smithjd updated this revision to Diff 58697. smithjd added a comment. - [KRunner] Change start of line shortcut to CTRL + S. - [KRunner] Re-work the shortcut handling to allow modifying the shortcuts. - Make edit actions configurable. - Follow standard shortcuts nomenclature. - Fix

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

2019-05-26 Thread Nathaniel Graham
ngraham added a comment. Tested; LGTM. While you're cleaning up the UI, you could probably remove the group box too, and just add a left-aligned label above the list view. What do you think? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D21414 To:

D21417: [ActionListItem] Make QML imports and tooltip consistent

2019-05-26 Thread Aleix Pol Gonzalez
apol added a comment. But BasicListItem already is a Control. https://doc.qt.io/qt-5/qml-qtquick-controls2-itemdelegate.html REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D21417 To: GB_2, #plasma, #vdg Cc: apol, #vdg, plasma-devel, #plasma,

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

2019-05-26 Thread Stefan Brüns
bruns added a comment. The code change looks sane for me, although I haven't tested it. The summary should mention: - what is currently wrong (space consumed by spacer) - what was done to fix it (spacer removed, so the folder list can stretch) Can you add a before/after

D21417: [ActionListItem] Make QML imports and tooltip consistent

2019-05-26 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY T10862 and T10873 TEST

D21296: Add the option to configure the realm

2019-05-26 Thread Nathaniel Graham
ngraham added a comment. @jgrulich, are you going to land this, or would you like me to do it? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D21296 To: enriquem, jgrulich Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot,

D21408: RFC: [Notifications] Better notification number alignment

2019-05-26 Thread Noah Davis
ndavis added a comment. The patch makes the position of the numbers more consistent, but it's consistently slightly to the left of center. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21408 To: broulik, #plasma, #vdg Cc: ngraham, ndavis, plasma-devel,

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

2019-05-26 Thread Kishore Gopalakrishnan
kishoreg created this revision. kishoreg added a reviewer: Baloo. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kishoreg requested review of this revision. REVISION SUMMARY I just removed a spacer. It seems like it was added intentionally, so I'm not sure if removing

D19796: [Device Notifier] Restore Solid notification messages

2019-05-26 Thread Stefan Brüns
bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. This is just much to complicated, adding layer over layer does not help. Also, the second problem is unrelated to the change you mention - the "hasMessage" property could only

D21408: RFC: [Notifications] Better notification number alignment

2019-05-26 Thread Kai Uwe Broulik
broulik added a comment. In D21408#470122 , @ngraham wrote: > When there are 2 or digits, maybe the circle can expand to become pill-shaped The circle comes from Plasma theme, cannot transform it. REPOSITORY R120 Plasma Workspace

D21296: Add the option to configure the realm

2019-05-26 Thread Enrique Melendez
enriquem added a comment. In D21296#467329 , @jgrulich wrote: > Looks good. Thank you. Anything I need to do further? How is this supposed to be merged into the master branch? I don't think I have credentials to do so. REPOSITORY R116

D21399: Compress color changes without a QTimer

2019-05-26 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R169:e5a6ac33f787: Compress color changes without a QTimer (authored by vkrause). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21399?vs=58644=58679 REVISION DETAIL