D21436: Use onClicked for Home button

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. My bad! REPOSITORY R134 Discover Software Store BRANCH use-onclicked-for-home-button (branched from Plasma/5.16) REVISION DETAIL https://phabricator.kde.org/D21436 To: GB_2,

D21435: [ActionTextField] Make QML tooltip consistent

ngraham added a comment. Argh, I explicitly did NOT accept as Kirigami but Phab did it anyway. :( REPOSITORY R169 Kirigami BRANCH actiontextfield-make-qml-tooltip-consistent (branched from master) REVISION DETAIL https://phabricator.kde.org/D21435 To: GB_2, #plasma, #vdg, #kirigami,

D21435: [ActionTextField] Make QML tooltip consistent

ngraham added subscribers: mart, ngraham. ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. @mart? REPOSITORY R169 Kirigami BRANCH actiontextfield-make-qml-tooltip-consistent (branched from master) REVISION DETAIL

D21408: RFC: [Notifications] Better notification number alignment

ndavis added a comment. In D21408#470827 , @cfeck wrote: > Just an idea: run "kcharselect", type "circled digit" resp. "circled number". For values <= 20, unicode has pre-rendered glyphs. Unfortunately, there is a jump in size from 10 to

D21408: RFC: [Notifications] Better notification number alignment

cfeck added a comment. Just an idea: run "kcharselect", type "circled digit" resp. "circled number". For values <= 20, unicode has pre-rendered glyphs. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21408 To: broulik, #plasma, #vdg Cc: cfeck,

D21434: [Notifications KCM] Try both model indices

nicolasfella added a comment. Works for me +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D21434 To: broulik, #plasma, nicolasfella Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D21435: [ActionTextField] Make QML tooltip consistent

ognarb added a reviewer: Kirigami. ognarb added a comment. +1 REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D21435 To: GB_2, #plasma, #vdg, #kirigami Cc: ognarb, #vdg, plasma-devel, #plasma, domson, dkardarakos, apol, davidedmundson, mart, hein

D21436: Use onClicked for Home button

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY BUG: 407636 FIXED-IN: 5.16.0 Buttons should use onClicked instead of onPressed. TEST PLAN

D21435: [ActionTextField] Make QML tooltip consistent

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY T10873 TEST PLAN Hover over for example the Discover search

D21434: [Notifications KCM] Try both model indices

broulik created this revision. broulik added reviewers: Plasma, nicolasfella. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY We prefer applicatons over services, however, when configuring a KDE application we

D21433: [kdecoration] Unset resize borders for maximized clients

zzag created this revision. zzag added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY So far this decoration theme was setting resize borders unconditionally, without actually taking into

D21432: [kdecoration] Unset resize borders for maximized clients

zzag created this revision. zzag added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY So far this decoration theme was setting resize borders unconditionally, without actually taking into

D21417: [ActionListItem] Make QML imports and tooltip consistent

GB_2 updated this revision to Diff 58733. GB_2 added a comment. Clean indentation REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21417?vs=58721=58733 BRANCH actionlistitem-make-qml-imports-and-tooltip-consistent (branched from master)

D21417: [ActionListItem] Make QML imports and tooltip consistent

This revision was automatically updated to reflect the committed changes. Closed by commit R134:7b778dbe90fe: [ActionListItem] Make QML imports and tooltip consistent (authored by GB_2). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D21417: [ActionListItem] Make QML imports and tooltip consistent

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Otherwise it's good to go. INLINE COMMENTS > ActionListItem.qml:44 > > -ToolTip.visible: hovered > -ToolTip.text: action.shortcut ? action.shortcut : p0.nativeText > +

D21429: [Fonts KCM] Switch default UI font to Noto Sans Display

hein added a comment. I'm not sold on this. "Display" fonts typically have spacing and metrics optimized for large sizes and use cases like signage. The FAQ entry quoted in the task you linked talks about Noto Sans UI. I'd like some more solid documentation on how Display relates to this

D21429: [Fonts KCM] Switch default UI font to Noto Sans Display

GB_2 added a comment. In D21429#470715 , @hein wrote: > Why? Read the task mentioned in the description... > See T10980 for more info. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D21429: [Fonts KCM] Switch default UI font to Noto Sans Display

hein added a comment. Why? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D21429 To: GB_2, #plasma, #vdg, bshah Cc: hein, bshah, plasma-devel, #vdg, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

ngraham added a comment. Great! I think a bit of padding between the checkbox and the label would help too. Then this'll be a great UI upgrade! INLINE COMMENTS > configwidget.ui:60 > + > + Do not search in these locations > + Now this string needs to end

D21429: [Fonts KCM] Switch default UI font to Noto Sans Display

GB_2 updated this revision to Diff 58730. GB_2 added a comment. Also update KRDB REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21429?vs=58727=58730 BRANCH switch-default-ui-font-to-noto-sans-display (branched from master) REVISION DETAIL

D21429: [Fonts KCM] Switch default UI font to Noto Sans Display

bshah requested changes to this revision. bshah added a comment. This revision now requires changes to proceed. Please make sure you also update kcms/krdb/krdb.cpp as well ^^ REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D21429 To: GB_2, #plasma, #vdg, bshah

D21431: [kaccess] Don't talk to ksmserver

broulik created this revision. broulik added reviewers: Plasma, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY We don't need any of its session restoration capabilities but it still talks to

D21430: [Plasma Integration] Switch default UI font to Noto Sans Display

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY See T10980 for more info. TEST PLAN Noto Sans Display should

D21429: [Fonts KCM] Switch default UI font to Noto Sans Display

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY See T10980 for more info. TEST PLAN Noto Sans Display should

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

kishoreg updated this revision to Diff 58723. kishoreg edited the summary of this revision. kishoreg added a comment. This patch incorporates Nate's suggestion to remove the box around the 'exclude folders' area. I've added screenshots of all three cases (with spacer, with box, and without

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

kishoreg added a comment. Before change: F6854280: Screenshot_20190519_105621.png Initial patch: F6854282: Screenshot_20190527_181359.png With box removed: F6854285: Screenshot_20190527_190128.png

D21422: [Notifications] Fix translations in popup

victorr added a comment. In D21422#470541 , @victorr wrote: > > We also need this patch.F6854024: plasma-workspace-fix.patch > > It is possible that I am mistaken. > Need to check again. > Today,

D21038: Also store the player's frame ID

fvogt added a comment. Couldn't find anything wrong, but I'm currently missing the overview of all MPRIS stuff in here to actually review properly... REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D21038 To: broulik, #plasma, davidedmundson,

D21408: RFC: [Notifications] Better notification number alignment

ndavis added a comment. In D21408#470480 , @broulik wrote: > - Use `QtRendering` as I originally intended > > Does this make it any better? The numbers seem to be slightly smaller and fit in the circle slightly better, but they're

D21423: [Notifications] Don't show blue icon when a notification is active

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21423 To: broulik, #plasma, #vdg, ndavis Cc: ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel,

D21112: Support message response and reply callbacks

fvogt requested changes to this revision. fvogt added a comment. This revision now requires changes to proceed. `browser.runtime.sendMessage` does not seem to have a callback parameter. See https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/runtime/sendMessage:

D21417: [ActionListItem] Make QML imports and tooltip consistent

GB_2 updated this revision to Diff 58721. GB_2 added a comment. Remove unneeded parent property REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21417?vs=58720=58721 BRANCH actionlistitem-make-qml-imports-and-tooltip-consistent (branched

D21417: [ActionListItem] Make QML imports and tooltip consistent

GB_2 updated this revision to Diff 58720. GB_2 added a comment. Remove workaround and put tooltip into property REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21417?vs=58689=58720 BRANCH

D21113: Allow hiding option items depending on available extension and version in the host

fvogt added inline comments. INLINE COMMENTS > options.js:82 > > +function subsystemStatus() { > +return new Promise((resolve, reject) => { AFAICT it doesn't conflict, but IMO it's a bit confusing if there's both a global array `subsystemStatus` in extension.js and a function

D21417: [ActionListItem] Make QML imports and tooltip consistent

apol added a comment. > Ok, weird. If I do it without the Control it shows this error: `qrc:/qml/ActionListItem.qml:44 Cannot assign object to list property "_basicDefault"` Try putting it into a property so that it's not assigned as the parent's default item. REPOSITORY R134

D21422: [Notifications] Fix translations in popup

victorr added a comment. In D21422#470534 , @victorr wrote: > In D21422#470522 , @broulik wrote: > > > Which files are you missing? `main.qml` and `FullRepresentation.qml` aren't changed on purpose

D21426: Remove unrelated code to make sure oxygen font is installed

This revision was automatically updated to reflect the committed changes. Closed by commit R120:707fbb4c4537: Remove unrelated code to make sure oxygen font is installed (authored by bshah). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D21422: [Notifications] Fix translations in popup

victorr added a comment. In D21422#470522 , @broulik wrote: > Which files are you missing? `main.qml` and `FullRepresentation.qml` aren't changed on purpose as it's not neccessary there. We also need this patch.F6854024:

D21426: Remove unrelated code to make sure oxygen font is installed

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. eww We need to do something to make sure startkde and startplasma/startplasmacompositor don't keep going out of sync. REPOSITORY R120 Plasma Workspace BRANCH

D21426: Remove unrelated code to make sure oxygen font is installed

bshah created this revision. bshah added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bshah requested review of this revision. REVISION SUMMARY Relevant code is already removed from startkde, remove it from plasma wayland session as well TEST

D21422: [Notifications] Fix translations in popup

broulik added a comment. Which files are you missing? `main.qml` and `FullRepresentation.qml` aren't changed on purpose as it's not neccessary there. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21422 To: broulik, #plasma, aacid, yurchor Cc: victorr,

D21422: [Notifications] Fix translations in popup

victorr added a comment. This does not fix all files. I made such a patch two days ago.F6854006: plasma-workspace-5.15.90-fix_locales.patch REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21422 To: broulik,

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

bshah closed this revision. bshah added a comment. This was merged in https://phabricator.kde.org/D21362 , thanks for your patch. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12925 To: progwolff, #plasma, mart Cc: bshah, rkflx, ngraham, mart, plasma-devel,

D21362: Fixes for fonts kcm

bshah closed this revision. bshah added a comment. Merged manually. 1958f1ca1e4fcfacade554e4b196daaa0d7425f0 , 873cbc1da8f3f2b589f9f2722a4e15a8fcbfe4e5

D21335: Don't write a anti-aliasing settings from startkde

This revision was automatically updated to reflect the committed changes. Closed by commit R120:1af4680ea846: Dont write a anti-aliasing settings from startkde (authored by bshah). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21335?vs=58544=58715

D21408: RFC: [Notifications] Better notification number alignment

broulik updated this revision to Diff 58711. broulik added a comment. - Use `QtRendering` as I originally intended Does this make it any better? REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21408?vs=58658=58711 REVISION DETAIL

D21408: RFC: [Notifications] Better notification number alignment

broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in CompactRepresentation.qml:116 > This doesn't match your description Ha, no wonder nothing changed. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21408 To: broulik, #plasma, #vdg Cc:

D21408: RFC: [Notifications] Better notification number alignment

davidedmundson added inline comments. INLINE COMMENTS > CompactRepresentation.qml:116 > +text: compactRoot.unreadCount || "" > +renderType: Text.NativeRendering > } This doesn't match your description REPOSITORY R120 Plasma Workspace REVISION DETAIL

D19745: Fix system tray UI/UX & refactor

ratijastk added inline comments. INLINE COMMENTS > broulik wrote in AbstractItem.qml:22 > You sure this high version number is neccessary? Not exactly. But old layouts used to have a load of restrictions, for sure. > broulik wrote in AbstractItem.qml:30 > Avoid doing negated disjunctions for

D21038: Also store the player's frame ID

broulik added a comment. Ping REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D21038 To: broulik, #plasma, davidedmundson, fvogt Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D21423: [Notifications] Don't show blue icon when a notification is active

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Also consider a notification as unread only when it isn't active anymore. TEST PLAN

D21422: [Notifications] Fix translations in popup

This revision was automatically updated to reflect the committed changes. Closed by commit R120:41e41b194c1f: [Notifications] Fix translations in popup (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21422?vs=58703=58704

D21422: [Notifications] Fix translations in popup

yurchor accepted this revision. yurchor added a comment. This revision is now accepted and ready to land. Thanks. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21422 To: broulik, #plasma, aacid, yurchor Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel,

D21422: [Notifications] Fix translations in popup

broulik created this revision. broulik added reviewers: Plasma, aacid, yurchor. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY The popup is a pure QML singleton and as such doesn't inherit the i18n context

Re: Proposal: passing user idle time to systemd-logind

Am 2019-05-24 21:51, schrieb Aleix Pol: On Wed, May 22, 2019 at 6:13 PM Germano Massullo wrote: Hello, I am writing to you to propose the following reasoning, hoping that it can help making easier (just a bit) third parties development work on Linux. I am currently developing BOINC client

D21417: [ActionListItem] Make QML imports and tooltip consistent

GB_2 added a comment. In D21417#470381 , @apol wrote: > But BasicListItem already is a Control. > https://doc.qt.io/qt-5/qml-qtquick-controls2-itemdelegate.html Ok, weird. If I do it without the Control it shows this error: