KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 28 - Still Failing!

2019-06-02 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/28/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Mon, 03 Jun 2019 03:34:52 + Build duration: 59 min and counting CONSOLE OUTPUT

D13095: Scren brightness follow a quatratic progression

2019-06-02 Thread Nathaniel Graham
ngraham added a comment. In D13095#472946 , @kjslag wrote: > In D13095#467997 , @ngraham wrote: > > > Moving the brightness to zero is supposed to turn the //backlight// off, not the //screen//

D21546: Make the icon applet use the same shadow settings as desktop icons

2019-06-02 Thread Nathaniel Graham
ngraham added a comment. In step 2, you need to merge 5.12. It asks you which branch you want to merge into the current one. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21546 To: filipf, ngraham, #vdg Cc: ngraham, plasma-devel, ericadams, jraleigh,

D21552: Update default Samba log path

2019-06-02 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: sitter, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY The current default path (`var/log/samba.log`) has not existed in years and is

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 27 - Still Failing!

2019-06-02 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/27/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sun, 02 Jun 2019 12:50:55 + Build duration: 7 hr 55 min and counting CONSOLE OUTPUT

D21545: Make the Trashcan applet use the same shadow settings as desktop icons

2019-06-02 Thread Filip Fila
This revision was automatically updated to reflect the committed changes. Closed by commit R119:83ef545a35ab: Make the Trashcan applet use the same shadow settings as desktop icons (authored by filipf). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D21546: Make the icon applet use the same shadow settings as desktop icons

2019-06-02 Thread Filip Fila
filipf added a comment. Sorry for not using merge, can someone please update the wiki (https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22) or explain the case when landing on 2 stable branches because it wouldn't merge when I was doing step 2 for 5.16.

D21546: Make the icon applet use the same shadow settings as desktop icons

2019-06-02 Thread Filip Fila
This revision was automatically updated to reflect the committed changes. Closed by commit R120:e2764c8e4a95: Make the icon applet use the same shadow settings as desktop icons (authored by filipf). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D21545: Make the Trashcan applet use the same shadow settings as desktop icons

2019-06-02 Thread Nathaniel Graham
ngraham added inline comments. INLINE COMMENTS > filipf wrote in main.qml:154 > Should I copy all of the code from `FolderItemDelegate.qml`? It's: > > `width: Math.round(Math.min(label.implicitWidth + units.smallSpacing, > parent.width - units.smallSpacing))` Not necessary since this is a

D21545: Make the Trashcan applet use the same shadow settings as desktop icons

2019-06-02 Thread Filip Fila
filipf added inline comments. INLINE COMMENTS > main.qml:154 > } > +width: Math.round(text.implicitWidth + units.smallSpacing) // make > sure label is not blurry > text: (dirModel.count === 0) ? i18n("Trash\nEmpty") : > i18np("Trash\nOne item", "Trash\n %1 items",

D21545: Make the Trashcan applet use the same shadow settings as desktop icons

2019-06-02 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Huh, how about that. Stable branch please. REPOSITORY R119 Plasma Desktop BRANCH trashcan-consistent-shadows (branched from master) REVISION DETAIL

D21408: RFC: [Notifications] Better notification number alignment

2019-06-02 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Since it doesn't regress anything, then I say yeah. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21408 To: broulik, #plasma, #vdg, ngraham Cc:

D21546: Make the icon applet use the same shadow settings as desktop icons

2019-06-02 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Stable branch please! REPOSITORY R120 Plasma Workspace BRANCH icon-applet-consistent-shadows (branched from master) REVISION DETAIL https://phabricator.kde.org/D21546 To: filipf,

D21546: Make the icon applet use the same shadow settings as desktop icons

2019-06-02 Thread Filip Fila
filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY We changed the desktop shadows in 10278e79f116 , but we

D21545: Make the Trashcan applet use the same shadow settings as desktop icons

2019-06-02 Thread Filip Fila
filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY We changed desktop shadows in 10278e79f116 , but we also

D21192: Allow user to edit wrong password on lockscreen while waiting for graceLocked period to end

2019-06-02 Thread Filip Fila
filipf added a comment. I only worked on the visuals of the theme so I'm not 100% sure either, but there is extra dummy data that might be worth looking it, sddm.qml in particular: https://github.com/KDE/plasma-workspace/tree/master/sddm-theme/dummydata REPOSITORY R120 Plasma Workspace

D21408: RFC: [Notifications] Better notification number alignment

2019-06-02 Thread Kai Uwe Broulik
broulik added a comment. Should we go with this now to improve the situation a little bit at least? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21408 To: broulik, #plasma, #vdg Cc: lavender, cfeck, davidedmundson, ngraham, ndavis, plasma-devel,

D21527: Fix the 'Report bug' button being always disabled

2019-06-02 Thread Daniel Vrátil
This revision was automatically updated to reflect the committed changes. Closed by commit R871:dd95de337e30: Fix the Report bug button being always disabled (authored by dvratil). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21527?vs=58992=59019 REVISION