D21610: Redesign Advanced tab

This revision was automatically updated to reflect the committed changes. Closed by commit R123:e020446f7019: Redesign Advanced tab (authored by filipf). REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21610?vs=59282=59305 REVISION

D16425: Added new Suspend then Hibernate option

avaldes marked 3 inline comments as done. avaldes added a comment. In D16425#475148 , @ericadams wrote: > I apologize if this is the wrong place to add this comment but I have a laptop where this applies and would benefit me. I am happy to help

D13278: Set default border value in all places

This revision was automatically updated to reflect the committed changes. Closed by commit R31:133eeece41e2: Set default border value in all places (authored by ngraham). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13278?vs=35379=59299 REVISION DETAIL

D13481: Recommend window border size "None"

This revision was automatically updated to reflect the committed changes. Closed by commit R31:e15989fb1f0d: Recommend window border size None (authored by romangg). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13481?vs=36009=59296 REVISION DETAIL

D21629: [Task Manager] Use ToolButtons for buttons in popup, rather than mouseArea+icon

ngraham updated this revision to Diff 59289. ngraham added a comment. Remove TODO and formalize that the buttons should all be the same size REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21629?vs=59270=59289 BRANCH

D21027: [Notes] Fix icons being almost invisible with light backgrounds

filipf marked 3 inline comments as done. filipf added a comment. Should work fairly well now with the 2 dependencies. REPOSITORY R114 Plasma Addons BRANCH background-appropriate-icon-colors (branched from master) REVISION DETAIL https://phabricator.kde.org/D21027 To: filipf, #plasma,

D21027: [Notes] Fix icons being almost invisible with light backgrounds

filipf updated this revision to Diff 59286. filipf added a comment. - use readonly property instead of function - make icon sizes scalable REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21027?vs=57785=59286 BRANCH

D21629: [Task Manager] Use ToolButtons for buttons in popup, rather than mouseArea+icon

filipf added a comment. In D21629#475353 , @abetts wrote: > +1 > > We might need to add some padding so the button frame doesn't overlay content on the background As far as I can tell the button is actually within it's own

D21610: Redesign Advanced tab

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Shipit! Master only, obviously REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH redesign-sddm-advanced-tab (branched from master) REVISION DETAIL

D21610: Redesign Advanced tab

filipf updated this revision to Diff 59282. filipf added a comment. improve string "Relogin after quit" REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21610?vs=59280=59282 BRANCH redesign-sddm-advanced-tab (branched from master)

D21610: Redesign Advanced tab

filipf added a comment. In D21610#475386 , @ngraham wrote: > In D21610#475385 , @filipf wrote: > > > My suggestion is to rename it to "Log in again after logging off" > > > Much better! How

D21610: Redesign Advanced tab

ngraham added a comment. In D21610#475385 , @filipf wrote: > My suggestion is to rename it to "Log in again after logging off" Much better! How about "Log in again after immediately after logging off" to emphasize how instant it is? Or

D21610: Redesign Advanced tab

filipf added a comment. In D21610#475382 , @ngraham wrote: > Much better, thanks! Works now. > > One final thing, maybe: can we re-word "Relogin after quit"? I admit I have no idea what it even does! It's also got an English error ("relogin"

D21627: [Task manager] Use Windows-style middle-click behaviors for entries and thumbnails

This revision was automatically updated to reflect the committed changes. Closed by commit R119:62c099c023de: [Task manager] Use Windows-style middle-click behaviors for entries and… (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D21610: Redesign Advanced tab

ngraham added a comment. Much better, thanks! Works now. One final thing, maybe: can we re-word "Relogin after quit"? I admit I have no idea what it even does! It's also got an English error ("relogin" isn't a word) and it has no tooltip to explain what it does. Needs a bit of loving.

D21610: Redesign Advanced tab

filipf updated this revision to Diff 59280. filipf added a comment. use toggled instead of clicked REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21610?vs=59232=59280 BRANCH redesign-sddm-advanced-tab (branched from master)

D21629: [Task Manager] Use ToolButtons for buttons in popup, rather than mouseArea+icon

ngraham added a comment. In D21629#475353 , @abetts wrote: > +1 > > We might need to add some padding so the button frame doesn't overlay content on the background That's a pre-existing bug only visible when the pop-up isn't

D21629: [Task Manager] Use ToolButtons for buttons in popup, rather than mouseArea+icon

abetts added a comment. +1 We might need to add some padding so the button frame doesn't overlay content on the background REPOSITORY R119 Plasma Desktop BRANCH use-toolbuttons-in-popup-delegates (branched from master) REVISION DETAIL https://phabricator.kde.org/D21629 To:

D21629: [Task Manager] Use ToolButtons for buttons in popup, rather than mouseArea+icon

ngraham added inline comments. INLINE COMMENTS > filipf wrote in ToolTipInstance.qml:336 > Do we also have the issue here that the tool button will grow in size but not > the icon inside it? Seems OK when I bump up the scaling. Nah, the out-of-the-box behavior is fine, that comment is just

D21629: [Task Manager] Use ToolButtons for buttons in popup, rather than mouseArea+icon

ndavis added a comment. In D21629#475324 , @filipf wrote: > BTW when talking about consistency, do we also apply this change to the media player applet? The media player applet already has ToolButtons. REPOSITORY R119 Plasma Desktop

D21629: [Task Manager] Use ToolButtons for buttons in popup, rather than mouseArea+icon

filipf accepted this revision. filipf added a comment. +1 buttons should be buttons unless there's really strong designer reasons such as in the login screen etc. I'm also enjoying this a lot more than than just having icons. BTW when talking about consistency, do we also apply this

D21494: Close KSplash when the desktops are visible

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. I wrote a patch to delay uiReady till the wallpaper is loaded. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D21494 To:

D21627: [Task manager] Use Windows-style middle-click behaviors for entries and thumbnails

ngraham added a comment. Thanks. I had a feeling that the default settings change would not be too controversial but I won't land this until I get at least one positive review from a #plasma person since the new middle-click-to-close behavior for

D21629: [Task Manager] Use ToolButtons for buttons in popup, rather than mouseArea+icon

filipf added a comment. It is also makes it consistent with the notification popup. Let me give it a quick spin. REPOSITORY R119 Plasma Desktop BRANCH use-toolbuttons-in-popup-delegates (branched from master) REVISION DETAIL https://phabricator.kde.org/D21629 To: ngraham, #plasma,

D21629: [Task Manager] Use ToolButtons for buttons in popup, rather than mouseArea+icon

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. Makes sense to be consistent about how we present buttons. REPOSITORY R119 Plasma Desktop BRANCH use-toolbuttons-in-popup-delegates (branched from master) REVISION DETAIL

D21629: [Task Manager] Use ToolButtons for buttons in popup, rather than mouseArea+icon

ngraham created this revision. ngraham added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Right now, the Task Manager's popup has various buttons in it that do not look or feel

D21627: Use Windows-style middle-click behaviors for Task Manager entries and thumbnails

ngraham added a comment. The current default is None. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D21627 To: ngraham, #plasma, #vdg Cc: ndavis, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed,

D21627: Use Windows-style middle-click behaviors for Task Manager entries and thumbnails

ndavis added a comment. Is the current default group/ungroup or is the current default none? If the former is true, why is this better? If the latter, then +1 because it's useful. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D21627 To: ngraham, #plasma,

D21627: Use Windows-style middle-click behaviors for Task Manager entries and thumbnails

ngraham created this revision. ngraham added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY The Windows 10 Task Manager equivalent opens a new instance when middle-clicking an open

D21623: [ToolButton] Pass custom icon size to StyleItem

broulik created this revision. broulik added reviewers: Plasma, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Follow up on D20418 . Not sure what I was testing back

D21620: Handle Esc properly when focus is in searchbox

jgrulich added a comment. In D21620#475194 , @ngraham wrote: > @jgrulich unless you object, I'll land this on the stable branch once my comment has been addressed. Feel free to land it. REPOSITORY R116 Plasma Network Management Applet

D21620: Handle Esc properly when focus is in searchbox

ngraham added a comment. @jgrulich unless you object, I'll land this on the stable branch once my comment has been addressed. INLINE COMMENTS > Toolbar.qml:154 > onVisibleChanged: if (!visible) text = "" > -Keys.onEscapePressed: searchToggleButton.checked = false > +

D21620: Handle Esc properly when focus is in searchbox

kishoreg created this revision. kishoreg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. kishoreg requested review of this revision. REVISION SUMMARY BUG: 408290 If we place the focus in the searchbar,

Plasma 5.16 tars are ready

Tars are ready for packaging Release due on Tuesday

D16425: Added new Suspend then Hibernate option

ericadams added a comment. I apologize if this is the wrong place to add this comment but I have a laptop where this applies and would benefit me. I am happy to help test this if you find it helpful. Thanks. REPOSITORY R122 Powerdevil BRANCH arcpatch-D16425_1 REVISION DETAIL

Re: [orca-list] Accessibility in Plasmas new notification system

Howdy Joanie, oh this is pritty awsome! thanks for this information. I will forward it to plasma-devel and kbroulik. fore sure they will like your answer! mercy, cheers chrys Zitat von Joanmarie Diggs : Hey Chrys. Regarding notifications, it should be pretty simple: 1. Give it

D21610: Redesign Advanced tab

ngraham added a comment. Ah you're right, that's a pre-existing issue. However it does get worse with this redesign since the Advanced page is now much more compact. Oh well. I've found one new issue: when auto-login is enabled and you go to the Advanced page, its checkbox is checked

D21619: Wallpaper: delay calling UIReady until the image is actually loaded

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY The desktop image is loaded asyncronously in another thread. This is a

D21593: [showdesktop][minimzeall] Reduce the maximum panel icon size

ngraham added a comment. @ndavis in the future, the best way to do this would be to land it on the `Plasma/5.16` branch, then merge that branch to master. This process is detailed at https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22 REPOSITORY R119

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 22 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/22/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Thu, 06 Jun 2019 12:37:06 + Build duration: 6 min 59 sec and counting JUnit Tests

KDE CI: Plasma » drkonqi » stable-kf5-qt5 WindowsMSVCQt5.11 - Build # 6 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/stable-kf5-qt5%20WindowsMSVCQt5.11/6/ Project: stable-kf5-qt5 WindowsMSVCQt5.11 Date of build: Thu, 06 Jun 2019 12:37:08 + Build duration: 6 min 43 sec and counting CONSOLE

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.12 - Build # 24 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.12/24/ Project: stable-kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 06 Jun 2019 12:37:07 + Build duration: 1 min 56 sec and counting JUnit Tests

Accessibility in Plasmas new notification system

Howdy Joanie, I just give an talk to kbroulik ( the creator of Plasmas new awsome notification system). see here: https://blog.broulik.de/2019/05/next-generation-plasma-notifications/ He told me that accessibility is not yet implemented. But I see notifications are an very importaint

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.12 - Build # 23 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.12/23/ Project: stable-kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 06 Jun 2019 11:02:01 + Build duration: 22 min and counting CONSOLE OUTPUT

D21593: [showdesktop][minimzeall] Reduce the maximum panel icon size

This revision was automatically updated to reflect the committed changes. Closed by commit R119:f4fe4a65de85: [showdesktop][minimizeall] Reduce the maximum panel icon size (authored by ndavis). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 21 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/21/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Thu, 06 Jun 2019 11:02:00 + Build duration: 7 min 56 sec and counting CONSOLE OUTPUT

D21593: [showdesktop] Reduce the maximum panel icon size

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. should be pushed to 5.16 as well REPOSITORY R119 Plasma Desktop BRANCH show-desktop-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D21593 To: ndavis, #vdg,

D21593: [showdesktop] Reduce the maximum panel icon size

broulik added a comment. > I couldn't figure out how to make the widget get the icon from the desktop theme Plasma `IconItem` primarily uses icons from Plasma theme, if such exists, or told so otherwise by setting `usesPlasmaTheme` to `false` REPOSITORY R119 Plasma Desktop REVISION

D21610: Redesign Advanced tab

filipf added a comment. I believe that's due to the other tab. If you try to resize the Themes tab height-wise, you'll notice the scrollbar appears when the bottom buttons start disappearing. I'll investigate some more though. REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION

D9037: use desktop file actions instead of global shortcuts

This revision was automatically updated to reflect the committed changes. Closed by commit R120:cac7af89b7eb: use desktop file actions instead of global shortcuts (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE