KDE CI: Plasma » kinfocenter » kf5-qt5 SUSEQt5.12 - Build # 59 - Fixed!

2019-06-24 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/kinfocenter/job/kf5-qt5%20SUSEQt5.12/59/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 25 Jun 2019 03:20:53 + Build duration: 8 min 29 sec and counting JUnit Tests Name: (root)

KDE CI: Plasma » kwin » stable-kf5-qt5 SUSEQt5.12 - Build # 66 - Failure!

2019-06-24 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/stable-kf5-qt5%20SUSEQt5.12/66/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Mon, 24 Jun 2019 21:00:12 + Build duration: 1 hr 3 min and counting CONSOLE OUTPUT

KDE CI: Plasma » kinfocenter » kf5-qt5 SUSEQt5.12 - Build # 58 - Failure!

2019-06-24 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kinfocenter/job/kf5-qt5%20SUSEQt5.12/58/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 24 Jun 2019 20:41:45 + Build duration: 1 hr 17 min and counting CONSOLE OUTPUT [...truncated

D22028: Improve QWidget KCM and QML KCM consistency

2019-06-24 Thread Méven Car
This revision was automatically updated to reflect the committed changes. Closed by commit R102:4d5321648e9a: Improve QWidget KCM and QML KCM consistency (authored by meven). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22028?vs=60485=60619 REVISION

D18860: Add comment / description to the translations kcm

2019-06-24 Thread Jonah Brüchert
jbbgameich added a comment. ping REVISION DETAIL https://phabricator.kde.org/D18860 To: jbbgameich, hein, #plasma, ngraham Cc: apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D22084: Span wayland objects to lifespan of the QApplication

2019-06-24 Thread Nathaniel Graham
ngraham added a comment. Would this happen to fix https://bugs.kde.org/show_bug.cgi?id=372789? REPOSITORY R130 Frameworks integration plugin using KWayland REVISION DETAIL https://phabricator.kde.org/D22084 To: davidedmundson, #plasma Cc: ngraham, anthonyfieroni, zzag, plasma-devel,

D22075: [Notifications] Swap configure and clear buttons in full representation header

2019-06-24 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R120:11387ca37f91: [Notifications] Swap configure and clear buttons in full representation header (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D22084: Span wayland objects to lifespan of the QApplication

2019-06-24 Thread Anthony Fieroni
anthonyfieroni added inline comments. INLINE COMMENTS > anthonyfieroni wrote in waylandintegration.cpp:95-99 > Since qApp is the parent are they needed? When destroyed qApp will call > delete on m_waylandBlurManager, no? Or that's when removed during the normal execution? REPOSITORY R130

D22084: Span wayland objects to lifespan of the QApplication

2019-06-24 Thread Anthony Fieroni
anthonyfieroni added inline comments. INLINE COMMENTS > waylandintegration.cpp:95-99 > connect(m_waylandBlurManager, > ::Client::BlurManager::removed, this, > [this] () { > m_waylandBlurManager->deleteLater(); > -m_waylandBlurManager =

D22084: Span wayland objects to lifespan of the QApplication

2019-06-24 Thread Vlad Zagorodniy
zzag added a comment. Is there any reason for not making WaylandIntegration a child of qApp? (disclaimer: I don't have full insight into the problem) REPOSITORY R130 Frameworks integration plugin using KWayland REVISION DETAIL https://phabricator.kde.org/D22084 To: davidedmundson,

D22084: Span wayland objects to lifespan of the QApplication

2019-06-24 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY We must release all wayland objects before the QPA connection is closed.

D22078: Use the native resolution image

2019-06-24 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R120:be12c1a1262b: Use the native resolution image (authored by apol). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22078?vs=60594=60597 REVISION DETAIL

D22079: Show an entry on the system tray indicator when a portal is needed

2019-06-24 Thread Aleix Pol Gonzalez
apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. apol requested review of this revision. REVISION SUMMARY This way it's still accessible if I lose the notification somehow.

D22078: Use the native resolution image

2019-06-24 Thread Aleix Pol Gonzalez
apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Instead of loading the image size of the scaled window, use the actual resolution of the display. This

D22077: [Colors KCM] Add title bar to preview delegate

2019-06-24 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Makes the difference between Breeze and Breeze Light more pronounced. TEST PLAN Depends on

D22075: [Notifications] Swap configure and clear buttons in full representation header

2019-06-24 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This makes it consistent with the configure button of the items in the list below. BUG:

D20908: RFC: Redesign QML applet configuration windows

2019-06-24 Thread Filip Fila
filipf updated this revision to Diff 60584. filipf added a comment. highlight effect: remove unused ID and bettery opacity values REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20908?vs=60583=60584 BRANCH master REVISION DETAIL

D20908: RFC: Redesign QML applet configuration windows

2019-06-24 Thread Filip Fila
filipf updated this revision to Diff 60583. filipf added a comment. Also implement the upcoming highlight style REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20908?vs=60115=60583 BRANCH master REVISION DETAIL

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.12 - Build # 322 - Still unstable!

2019-06-24 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.12/322/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 24 Jun 2019 14:32:44 + Build duration: 4 min 1 sec and counting JUnit Tests Name:

D21702: Ship color schemes with Oxygen

2019-06-24 Thread Filip Fila
This revision was automatically updated to reflect the committed changes. Closed by commit R113:70243942ef1d: Ship color schemes with Oxygen (authored by filipf). REPOSITORY R113 Oxygen Theme CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21702?vs=59464=60582 REVISION DETAIL

D21701: [kcm-colors] Do not ship any additional color schemes

2019-06-24 Thread Filip Fila
This revision was automatically updated to reflect the committed changes. Closed by commit R119:b137ee56fa66: [kcm-colors] Do not ship any additional color schemes (authored by filipf). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D21701: [kcm-colors] Do not ship any additional color schemes

2019-06-24 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Tested removing the color schemes on disk and re-adding them from the new items you created on store.kde.org and everything worked perfectly. Let's do it. REPOSITORY R119 Plasma

D21701: [kcm-colors] Do not ship any additional color schemes

2019-06-24 Thread Filip Fila
filipf added a comment. All of the color schemes deprecated here are now in the newly-created repo: https://invent.kde.org/kde/kde-vdg-extras/tree/master/deprecated/plasma-desktop/kcms/colors/schemes ... and on the KDE Store: https://www.pling.com/u/kdecommunity/ REPOSITORY

D22070: make scripted sleep no-op

2019-06-24 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R120:b8f2dc039f64: make scripted sleep no-op (authored by sitter). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22070?vs=60568=60570 REVISION DETAIL

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 35 - Still Failing!

2019-06-24 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/35/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Mon, 24 Jun 2019 11:09:16 + Build duration: 2 min 56 sec and counting CONSOLE OUTPUT

D21745: show details examples in label itself instead of unexpected tooltip

2019-06-24 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R871:a00df4badcd1: show details examples in label itself instead of unexpected tooltip (authored by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21745?vs=60565=60569#toc REPOSITORY

D22070: make scripted sleep no-op

2019-06-24 Thread Harald Sitter
sitter added a comment. follow up to D21895 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22070 To: sitter, davidedmundson, mart Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot,

D22070: make scripted sleep no-op

2019-06-24 Thread Harald Sitter
sitter created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY this was implemented using a nested loop, which is simply not viable because nested looping may work on inconsistent object states

D21745: show details examples in label itself instead of unexpected tooltip

2019-06-24 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. +1 shipit! REPOSITORY R871 DrKonqi BRANCH examples REVISION DETAIL https://phabricator.kde.org/D21745 To: sitter, ngraham, #vdg Cc: plasma-devel, LeGast00n, jraleigh,

D22068: Send downloads when downloads plugin is loaded

2019-06-24 Thread Kai Uwe Broulik
broulik added a comment. Or maybe I should remove the old code since the change to "update existing job when being signalled a creation" was only added in May REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D22068 To: broulik, #plasma, fvogt Cc:

D21762: do not use long deprecated QString::toAscii

2019-06-24 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R120:4cf47ad6818d: do not use long deprecated QString::toAscii (authored by sitter). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21762?vs=60564=60567

KDE CI: Plasma » plasma-workspace » stable-kf5-qt5 SUSEQt5.12 - Build # 121 - Failure!

2019-06-24 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/stable-kf5-qt5%20SUSEQt5.12/121/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Mon, 24 Jun 2019 10:32:49 + Build duration: 9 min 53 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.12 - Build # 297 - Unstable!

2019-06-24 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.12/297/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 24 Jun 2019 10:32:49 + Build duration: 5 min 20 sec and counting JUnit Tests Name:

D21895: print a warning when invoking the scripting API's sleep()

2019-06-24 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R120:3563f51309cc: print a warning when invoking the scripting APIs sleep() (authored by sitter). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D21745: show details examples in label itself instead of unexpected tooltip

2019-06-24 Thread Harald Sitter
sitter added a comment. F6930248: Screenshot_20190624_122741.png REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D21745 To: sitter, ngraham, #vdg Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel,

D21745: show details examples in label itself instead of unexpected tooltip

2019-06-24 Thread Harald Sitter
sitter updated this revision to Diff 60565. sitter added a comment. set smallest readable font as well. as seen in gwenview REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21745?vs=59586=60565 BRANCH examples REVISION DETAIL

D21762: do not use long deprecated QString::toAscii

2019-06-24 Thread Harald Sitter
sitter updated this revision to Diff 60564. sitter added a comment. and update again because arcanist hates me REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21762?vs=60563=60564 BRANCH no-toascii REVISION DETAIL

D21762: do not use long deprecated QString::toAscii

2019-06-24 Thread Harald Sitter
sitter updated this revision to Diff 60563. sitter added a comment. concat qstrings as suggested by @apol REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21762?vs=59639=60563 BRANCH no-toascii REVISION DETAIL

D19855: Fix bugzilla login page widgets tab order

2019-06-24 Thread Harald Sitter
sitter commandeered this revision. sitter edited reviewers, added: marcelomariano; removed: sitter. sitter added a comment. Ah yes, so it is. REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D19855 To: sitter, cfeck, #plasma, marcelomariano Cc: plasma-devel,

D21959: Fix selectedNameFilter() multiple matches

2019-06-24 Thread Robert Hoffmann
hoffmannrobert added a comment. Can you please push it for me, I don't have commit access. Thanks. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH fix_selectedNameFilter REVISION DETAIL https://phabricator.kde.org/D21959 To: hoffmannrobert, #frameworks, apol, dfaure

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.12 - Build # 296 - Failure!

2019-06-24 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.12/296/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 24 Jun 2019 09:09:58 + Build duration: 22 min and counting CONSOLE OUTPUT

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.12 - Build # 321 - Failure!

2019-06-24 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.12/321/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 24 Jun 2019 09:16:04 + Build duration: 15 min and counting CONSOLE OUTPUT Started by

D22060: [Task Manager] Prefer PID match even when desktop entry doesn't match

2019-06-24 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R119:4a6a518a8b4c: [Task Manager] Prefer PID match even when desktop entry doesnt match (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D22068: Send downloads when downloads plugin is loaded

2019-06-24 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY We call `sendDownloads()` immediately when connecting to the port which looks racy.

D22066: [sysemtray] Port away from foreach

2019-06-24 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R120:c3e61edd9ce1: [sysemtray] Port away from foreach (authored by nicolasfella). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22066?vs=60555=60559 REVISION

D22066: [sysemtray] Port away from foreach

2019-06-24 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. TEST PLAN system tray build with -DQT_NO_FOREACH, still does system tray things REPOSITORY R120

D22065: Introduce PluginManager

2019-06-24 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This adds a dedicated class for loading/unloading and sending data to a plugin rather than

D10750: wayland: Add support for zwp_linux_dmabuf

2019-06-24 Thread Roman Gilg
romangg added inline comments. INLINE COMMENTS > fredrik wrote in abstract_egl_backend.cpp:427 > We would need to create a separate EGL image and a separate texture for each > plane. > The scene would need to bind each of those textures to separate texture > binding points, and we would need