D22128: [Kickoff] Redo tab bar separator's geometry

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. Sorry, my bad once again. I hadn't actually applied D22108 . It works for me now. The tab highlight width problem must be somewhere else since this patch

KDE CI: Plasma » breeze » kf5-qt5 FreeBSDQt5.12 - Build # 60 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/breeze/job/kf5-qt5%20FreeBSDQt5.12/60/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 28 Jun 2019 19:39:42 + Build duration: 2 hr 0 min and counting CONSOLE OUTPUT [...truncated 150

D22128: [Kickoff] Redo tab bar separator's geometry

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. whoops, didn't mean to accept REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22128 To: filipf, #plasma, #vdg, ndavis Cc: ngraham, ndavis, plasma-

D22128: [Kickoff] Redo tab bar separator's geometry

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. In D22128#487943 , @ngraham wrote: > Even after also applying D22108 it's better but still not quite touc

D22128: [Kickoff] Redo tab bar separator's geometry

filipf added a comment. In D22128#487943 , @ngraham wrote: > Even after also applying D22108 it's better but still not quite touching the line for me (1x scale, 1080p screen): F6941090: Screenshot_20190628_14

D22128: [Kickoff] Redo tab bar separator's geometry

ngraham added a comment. Even after also applying D22108 it's better but still not quite touching the line for me (1x scale, 1080p screen): F6941090: Screenshot_20190628_145136.png REPOSITORY R119 Plasma Desktop R

D22104: Do not capitalize placeholder username

filipf closed this revision. filipf added a comment. This was landed but arc is confused: https://cgit.kde.org/user-manager.git/commit/?id=f78202c2face8d64af63281fd4c4eb4237314cc5. REPOSITORY R128 User Manager REVISION DETAIL https://phabricator.kde.org/D22104 To: filipf, #plasma, ngrah

D22104: Do not capitalize placeholder username

filipf updated this revision to Diff 60809. filipf added a comment. I lost the original clone, arc patch doesn't work; I have to update the current diff to land REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22104?vs=60697&id=60809 BRANCH arcpatch-

D21969: Remove qtquickcontrols dir

This revision was automatically updated to reflect the committed changes. Closed by commit R31:49c5b6966ecd: Remove qtquickcontrols dir (authored by ndavis). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21969?vs=60253&id=60806 REVISION DETAIL https://phabri

D22139: port to KOSRelease

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. I see most of these are addressed in D22141 . REPOSITORY R871 DrKonqi BRANCH kosrelease REVISION DETAIL https://phabricator.kde.org/D22139 To: sitte

D22139: port to KOSRelease

apol added a comment. T INLINE COMMENTS > systeminformation.cpp:249 > > QString SystemInformation::fetchOSReleaseInformation() const > { How about removing the function and just using KOSRelease? Or at least rename to `readOSPrettyName` > systeminformationtest.cpp:85 > QCOMPAR

D22135: pack drkonqi into a transient static lib we can use for unit testing

apol added a comment. +1 for the spirit of the patch, I see you use the library in the other patches. INLINE COMMENTS > CMakeLists.txt:85 > +# transient static lib we can use to link autotests against > +add_library(libdrkonqi STATIC ${drkonqi_SRCS}) > As a name it's a bit weird, the file

D21969: Remove qtquickcontrols dir

apol added a comment. In D21969#487596 , @davidedmundson wrote: > Super long term I think we do want to have this, with the desktop-style widget wrapper being only a fallback. > > But we can always restore from history and even if we did wan

D22132: Initialize view with the right size

This revision was automatically updated to reflect the committed changes. Closed by commit R133:d8e70beb4593: Initialize view with the right size (authored by apol). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22132?vs=60754&id=60798 REVISION DETAIL

KDE CI: Plasma » drkonqi » kf5-qt5 FreeBSDQt5.12 - Build # 70 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20FreeBSDQt5.12/70/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 28 Jun 2019 16:01:11 + Build duration: 11 min and counting JUnit Tests Name: projectroot.src.

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 44 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/44/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Fri, 28 Jun 2019 16:01:20 + Build duration: 1 min 19 sec and counting CONSOLE OUTPUT [...tr

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 43 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/43/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Fri, 28 Jun 2019 15:58:56 + Build duration: 2 min 11 sec and counting CONSOLE OUTPUT [...tr

KDE CI: Plasma » drkonqi » kf5-qt5 FreeBSDQt5.12 - Build # 69 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20FreeBSDQt5.12/69/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 28 Jun 2019 15:58:56 + Build duration: 42 sec and counting CONSOLE OUTPUT [...truncated 365 li

KDE CI: Plasma » drkonqi » kf5-qt5 FreeBSDQt5.12 - Build # 68 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20FreeBSDQt5.12/68/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 28 Jun 2019 15:55:11 + Build duration: 2 min 46 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 42 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/42/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Fri, 28 Jun 2019 15:55:11 + Build duration: 2 min 21 sec and counting CONSOLE OUTPUT [...tr

D22138: Remove 1 pixel margin around side panels, use QPalette::Base for background

ngraham added a comment. Umm OK, sorry if I've said something wrong. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D22138 To: hpereiradacosta, mart, #vdg, ndavis, filipf Cc: ngraham, ndavis, filipf, mart, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 41 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/41/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Fri, 28 Jun 2019 14:46:50 + Build duration: 2 min 9 sec and counting CONSOLE OUTPUT [...tru

KDE CI: Plasma » drkonqi » kf5-qt5 FreeBSDQt5.12 - Build # 67 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20FreeBSDQt5.12/67/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 28 Jun 2019 14:46:50 + Build duration: 1 min 3 sec and counting CONSOLE OUTPUT [...truncated 3

D22138: Remove 1 pixel margin around side panels, use QPalette::Base for background

hpereiradacosta added a comment. In D22138#487668 , @ngraham wrote: > Thanks @hpereiradacosta! This looks fantastic. Adding @ndavis and @filipf for comment since they've been working on this project too from other angles. No need for than

D21944: Show shortcut in menu item when specified

ngraham added a comment. @apol, is this good to go now? REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D21944 To: astippich, mart, ngraham, apol Cc: apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himc

D21761: move SolidUiServer::showActionsDialog to hotplug dataengine

This revision was automatically updated to reflect the committed changes. Closed by commit R120:f67d61b39149: move SolidUiServer::showActionsDialog to hotplug dataengine (authored by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21761?vs=59651&id=60785#toc REPOSITORY R120 Pla

D22142: switch platform guessing to a static hash

sitter created this revision. sitter added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY makes it slightly less of an eye sore TEST PLAN builds REPOSITORY R871 DrKonqi BRANCH guess-

D22141: rename lsbRelease to prettyName and set it from os-release as well

sitter created this revision. sitter added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY previously when lsb_release was not present or working we'd fall back to os-release, but then not t

D20569: RFC: Use more compact OSD

ngraham added a comment. Using notifications for the OSD is an interesting idea. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20569 To: broulik, #plasma, #vdg Cc: abetts, ngraham, davidedmundson, hein, Codezela, Fuchs, filipf, zzag, plasma-devel, LeGast0

D22139: port to KOSRelease from kcoreaddons

sitter created this revision. sitter added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY this parses os-release correctly and also looks in both supported paths. adjust test to now actuall

D22138: Remove 1 pixel margin around side panels, use QPalette::Base for background

ngraham added subscribers: filipf, ndavis, ngraham. ngraham added reviewers: VDG, ndavis, filipf. ngraham added a comment. Thanks @hpereiradacosta! This looks fantastic. Adding @ndavis and @filipf for comment since they've been working on this project too from other angles. REPOSITORY R31 B

D22138: Remove 1 pixel margin around side panels, use QPalette::Base for background

hpereiradacosta created this revision. hpereiradacosta added a reviewer: mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. hpereiradacosta requested review of this revision. REVISION SUMMARY This patch removes unneeded 1 pixel margin around side panels (namely QAbst

D22122: use pwquality_strerror to get error strings

sitter updated this revision to Diff 60770. sitter added a comment. use fromUtf8 REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22122?vs=60726&id=60770 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22122 AFFECTED FILES src/passwor

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 40 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/40/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Fri, 28 Jun 2019 12:13:04 + Build duration: 2 min 15 sec and counting CONSOLE OUTPUT [...tr

KDE CI: Plasma » drkonqi » kf5-qt5 FreeBSDQt5.12 - Build # 66 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20FreeBSDQt5.12/66/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 28 Jun 2019 12:13:04 + Build duration: 1 min 10 sec and counting CONSOLE OUTPUT [...truncated

D22134: replace garbage symlink hack with QFINDTESTDATA

This revision was automatically updated to reflect the committed changes. Closed by commit R871:db96614df73f: replace symlink hack with QFINDTESTDATA (authored by sitter). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22134?vs=60763&id=60769 REVISION DETAIL

D22137: test SystemInformation class

sitter created this revision. sitter added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY - has a new Config struct, encapsulates data we need to mangle for testing - new completeness state

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 39 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/39/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Fri, 28 Jun 2019 11:52:39 + Build duration: 2 min 4 sec and counting CONSOLE OUTPUT [...tru

D22135: pack drkonqi into a transient static lib we can use for unit testing

sitter created this revision. sitter added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY without the static lib this is fairly cumbersome because most classes depend on config-drkonqi and

KDE CI: Plasma » drkonqi » kf5-qt5 FreeBSDQt5.12 - Build # 65 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20FreeBSDQt5.12/65/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 28 Jun 2019 11:52:39 + Build duration: 45 sec and counting CONSOLE OUTPUT [...truncated 371 li

D22122: use pwquality_strerror to get error strings

davidedmundson added subscribers: ltoscano, davidedmundson. davidedmundson added a comment. Concept makes sense. +1 @ltoscano can you confirm you're ok from an i18n side. REPOSITORY R128 User Manager REVISION DETAIL https://phabricator.kde.org/D22122 To: sitter, #plasma Cc: davide

D22134: replace garbage symlink hack with QFINDTESTDATA

sitter created this revision. sitter added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY the latter encapsulates very smart logic to find test fixtures which works just about all the time

D21969: Remove qtquickcontrols dir

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Super long term I think we do want to have this, with the desktop-style widget wrapper being only a fallback. But we can always restore from history and even if we did w

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 38 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/38/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Fri, 28 Jun 2019 09:05:18 + Build duration: 2 min 25 sec and counting CONSOLE OUTPUT [...tr

D19612: port to bugzilla REST API

This revision was automatically updated to reflect the committed changes. Closed by commit R871:a4330e626f8e: port to bugzilla REST API (authored by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19612?vs=60693&id=60758#toc REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE

KDE CI: Plasma » drkonqi » kf5-qt5 FreeBSDQt5.12 - Build # 64 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20FreeBSDQt5.12/64/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 28 Jun 2019 09:05:18 + Build duration: 1 min 39 sec and counting CONSOLE OUTPUT [...truncated

D22128: [Kickoff] Redo tab bar separator's geometry

filipf added a comment. Don't know, I removed both of the patches and the issue's still there. Yeah this was 2x scaling and the indicator should be 6px. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22128 To: filipf, #plasma, #vdg Cc: ndavis, plasma-devel,