D22401: change debug dir order to prefer appDir and do not duplicate Debuggers

sitter updated this revision to Diff 61640. sitter added a comment. - constify - use qasconst on both loops - don't make string concatations unecessarily complicate REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22401?vs=61595&id=61640 BRANCH debugge

D22034: Introduce ContainmentLayoutManager QML plugin

mart updated this revision to Diff 61642. mart added a comment. - manage differently screen resize and other kind of resizes - fix snapping on RTL and BTT positioning REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22034?vs=61576&id=61642 BRANCH

D22418: wayland: make automatic backend selection truly automatic

alexeymin created this revision. alexeymin added reviewers: romangg, zzag. Herald added a project: KWin. Herald added a subscriber: kwin. alexeymin requested review of this revision. REVISION SUMMARY Choose backend automatically, based on actually available plugins at runtime, independently of

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

davidre updated this revision to Diff 61648. davidre added a comment. - Only restore wallpaper on startup - Guard against empty path I couldn't understand why this was being called with an empty string so I just guard against it at the call site. Maybe this also helps @ngrahams crash

D22404: do not dereference `current` outside guard condition

This revision was automatically updated to reflect the committed changes. Closed by commit R871:88918ab8a59d: do not dereference `current` outside guard condition (authored by sitter). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22404?vs=61600&id=61650 REV

D22400: disambiguate the names of Debugger

This revision was automatically updated to reflect the committed changes. Closed by commit R871:76f5df262eb4: disambiguate the names of Debugger (authored by sitter). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22400?vs=61594&id=61651 REVISION DETAIL htt

D22398: always log raw exception data

This revision was automatically updated to reflect the committed changes. Closed by commit R871:68ccdf540ee3: always log raw exception data (authored by sitter). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22398?vs=61592&id=61652 REVISION DETAIL https://

D22399: prevent exhausting the maximum size of bug reports

This revision was automatically updated to reflect the committed changes. Closed by commit R871:c07434bf8e2e: prevent exhausting the maximum size of bug reports (authored by sitter). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22399?vs=61593&id=61654 REVIS

D22403: qobject_cast rather than dynamic_cast

This revision was automatically updated to reflect the committed changes. Closed by commit R871:ec63673c3695: qobject_cast rather than dynamic_cast (authored by sitter). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22403?vs=61599&id=61649 REVISION DETAIL

D22402: only benchmark once

This revision was automatically updated to reflect the committed changes. Closed by commit R871:854c95323993: only benchmark once (authored by sitter). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22402?vs=61598&id=61653 REVISION DETAIL https://phabricator

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 62 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/62/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Fri, 12 Jul 2019 12:51:15 + Build duration: 2 min 39 sec and counting CONSOLE OUTPUT [...tr

Re: RFC: Running clang-format across all Plasma (and more?) repos

On Thursday 11 Jul 2019 14:18:08 David Edmundson wrote: > One topic discussed at the recent Plasma sprint was that we should run > a code formatting tool (clang-format) over all our repos to ease all > future review comments about whitespace. > > All new contributions simply have to run the same t

D22401: change debug dir order to prefer appDir and do not duplicate Debuggers

This revision was automatically updated to reflect the committed changes. Closed by commit R871:d8cf681eb060: change debug dir order to prefer appDir and do not duplicate Debuggers (authored by sitter). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22401?vs=6

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 63 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/63/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Fri, 12 Jul 2019 13:17:20 + Build duration: 1 min 50 sec and counting CONSOLE OUTPUT [...tr

Re: RFC: Running clang-format across all Plasma (and more?) repos

> Presumably this would impose a common coding style throughout all KDE > repositories? Or would each project be able to specify its own clang-format > configuration? In past discussions about KDE coding style, it was accepted > that > while Frameworks and PIM libraries would adopt a common style,

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

ngraham added a comment. I no longer have any crashes with this latest version! \o/ REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22121 To: davidre, #plasma, davidedmundson Cc: davidedmundson, msdobrescu, ngraham, filipf, plasma-devel, LeGast00n, jraleigh

D22191: Implement syncing of theme preferences between SDDM and Plasma

filipf updated this revision to Diff 61669. filipf added a comment. Use KMessageBox to show information whether or not the sync and reset operations succeeded REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22191?vs=61480&id=61669 BR

D22426: Add Unsplash POTD Provider

guoyunhe created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. guoyunhe requested review of this revision. REVISION SUMMARY Add Unsplash Wallpaper as picture of the day provider. Unsplash provides high quality photos under public domain license. REPOSI

D22426: Add Unsplash POTD Provider

filipf added a comment. Unsplash has very good wallpapers; in my opinion this automatically becomes the most attractive POTD plugin. Keep in mind though that when I tried to add Unsplash wallpapers to KDE in D18078 I was told I need to contact the au

D22426: Add Unsplash POTD Provider

guoyunhe added a comment. Photos on Unsplash are under CC0 (public domain) now. So here shouldn't be copyright issues. I do think it is good to show photographers' credits. But that will require changes to POTD class and wallpaper widget. REPOSITORY R114 Plasma Addons REVISION DETAIL

D22426: Add Unsplash POTD Provider

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Very nice. Works great and I don't see any problems with the code here. Let's try to avoid a ton of bikeshedding over the licenses since these are CC0 IMO. REPOSITORY R114 Plasma Addons

D22333: Move Solid::Device::listFromQuery calls to a separate thread

bruns added a comment. In D22333#494415 , @apol wrote: > In D22333#494389 , @bruns wrote: > > > Again, where is it blocking? Which backend? > > > udisks2 mainly, but every backend can block by i

D22426: Add Unsplash POTD Provider

This revision was automatically updated to reflect the committed changes. Closed by commit R114:e0b126692a87: Add Unsplash POTD Provider (authored by Guo Yunhe ). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22426?vs=61678&id=61679 R

D22426: Add Unsplash POTD Provider

guoyunhe updated this revision to Diff 61678. guoyunhe added a comment. Fix Unix new line format REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22426?vs=61673&id=61678 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22426 AFFECTED FI

D22429: Make "Updates Available" nofication persistent but low priority

ngraham created this revision. ngraham added reviewers: apol, Discover Software Store. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Discover's "Updates are available" notification currently suffers from some

D22191: Implement syncing of theme preferences between SDDM and Plasma

ngraham added inline comments. INLINE COMMENTS > advanceconfig.cpp:207 > +qDebug() << job->errorText(); > +KMessageBox::error(this, i18n("Synchronization failed.")); > +} else { "Synchronization failed." is a pretty frustrating error message. The user will wonder, "How did i

D22191: Implement syncing of theme preferences between SDDM and Plasma

filipf updated this revision to Diff 61681. filipf added a comment. remove message box on successful operation, use job error text when the operation fails REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22191?vs=61669&id=61681 BRANC

D22191: Implement syncing of theme preferences between SDDM and Plasma

filipf added a comment. Failure messages do seem to be generated F7013711: image.png REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH sddm-theme-syncing (branched from master) REVISION DETAIL https://phabricator.kde.org/D22191 To: filip

D22191: Implement syncing of theme preferences between SDDM and Plasma

ngraham accepted this revision. ngraham added a comment. Technical gibberish is better than nothing at least. :) REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH sddm-theme-syncing (branched from master) REVISION DETAIL https://phabricator.kde.org/D22191 To: filipf, #plasma, ngra

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 SUSEQt5.12 - Build # 150 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20SUSEQt5.12/150/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Fri, 05 Jul 2019 11:47:55 + Build duration: 10 min and counting JUnit Tests Name: (

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 290 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/290/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 05 Jul 2019 11:48:10 + Build duration: 32 min and counting JUnit Tests Name: (root) Failed:

Re: RFC: Running clang-format across all Plasma (and more?) repos

On Donnerstag, 11. Juli 2019 16:18:08 CEST David Edmundson wrote: > One topic discussed at the recent Plasma sprint was that we should run > a code formatting tool (clang-format) over all our repos to ease all > future review comments about whitespace. > > All new contributions simply have to run

D22390: ksmserver/autostart: remove qstandardpaths queries

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R120:a75b330f9868: ksmserver/autostart: remove qstandardpaths queries (authored by apol). REPOSITORY R120 Plasma Workspac

D22333: Move Solid::Device::listFromQuery calls to a separate thread

apol added a comment. In D22333#494774 , @bruns wrote: > Also, the code is calling non-threadsafe code from multiple threads now (e.g. once from each the two dataengines helper threads). Each one will call the udisks2 `Manager::deviceCache()` me

D22333: Move Solid::Device::listFromQuery calls to a separate thread

bruns added a comment. In D22333#494810 , @apol wrote: > In D22333#494774 , @bruns wrote: > > > Also, the code is calling non-threadsafe code from multiple threads now (e.g. once from each the two da

D22429: Make "Updates Available" notification persistent but low priority

This revision was automatically updated to reflect the committed changes. Closed by commit R134:b9bf6a37ef6f: Make "Updates Available" notification persistent but low priority (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org

D22418: wayland: make automatic backend selection truly automatic

graesslin added a comment. Is there a real world situation where KWin is getting compiled twice with different settings? When adding the ifdefs this was based on feedback from distributions REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D22418 To: alexeymin, romangg,