D22767: Calculate first clickable point, from the top-left

kmaterka created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kmaterka requested review of this revision. REVISION SUMMARY Wine is using XWindow Shape Extension for transparent tray icons. We need to find first clickable point starting from top-left.

[Breeze] [Bug 374311] it is too easy to activate context menu item if mouse moves during right-click

https://bugs.kde.org/show_bug.cgi?id=374311 Nate Graham changed: What|Removed |Added URL||https://bugreports.qt.io/br |

[Breeze] [Bug 374311] it is too easy to activate context menu item if mouse moves during right-click

https://bugs.kde.org/show_bug.cgi?id=374311 Christoph Feck changed: What|Removed |Added CC||marklikesvideogames@gmail.c

D22766: Fix positioning of output identifiers on screens with different dprs

volkov created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. volkov requested review of this revision. REVISION SUMMARY Find QScreen corresponding to KScreen::Output and use its geometry to position the output identifier. REPOSITORY R104 KScreen

D22494: Attempt to support different collections of Unsplash

ngraham added inline comments. INLINE COMMENTS > potdprovider.cpp:54 > +} > +} > } The lack of error handling and else blocks for all the ifs in this new code makes me feel a bit nervous. > config.qml:208 > + > +function setCategory() { > +

D22453: [Applet] Use the more user-friendly term "recording" instead of "capture"

ngraham abandoned this revision. ngraham added a comment. Somehow Phab didn't notice that this landed. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D22453 To: ngraham, #plasma, #vdg, drosca, filipf Cc: davidedmundson, filipf, broulik,

D22752: [kcms/fonts] Replace warning message with inline message when applying changes

This revision was automatically updated to reflect the committed changes. Closed by commit R119:eae23d5d141b: [kcms/fonts] Replace warning message with inline message when applying changes (authored by filipf). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D22735: Introduce ResultsModel with better data processing and filtering

broulik closed this revision. broulik added a comment. Merged into master REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D22735 To: broulik, #plasma, davidedmundson Cc: apol, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel,

D22752: [kcms/fonts] Replace warning message with inline message when applying changes

ngraham accepted this revision. ngraham added a comment. Nice improvement. REPOSITORY R119 Plasma Desktop BRANCH no-more-warning-message (branched from master) REVISION DETAIL https://phabricator.kde.org/D22752 To: filipf, #plasma, #vdg, ngraham, davidedmundson Cc: davidedmundson,

D22453: [Applet] Use the more user-friendly term "recording" instead of "capture"

davidedmundson resigned from this revision. davidedmundson added a comment. Thanks REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D22453 To: ngraham, #plasma, #vdg, drosca, filipf Cc: davidedmundson, filipf, broulik, plasma-devel, LeGast00n,

D22762: Take in consideration flat() for the All Applications menu

This revision was automatically updated to reflect the committed changes. Closed by commit R119:0b9eb1e70c96: Take in consideration flat() for the All Applications menu (authored by tcanabrava). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D22760: [Notifications] Keep new delegate hidden until room has been cleared

This revision was automatically updated to reflect the committed changes. Closed by commit R120:f5515049b37f: [Notifications] Keep new delegate hidden until room has been cleared (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D22762: Take in consideration flat() for the All Applications menu

tcanabrava created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tcanabrava requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH flatAllApps REVISION DETAIL https://phabricator.kde.org/D22762 AFFECTED FILES

D22760: [Notifications] Keep new delegate hidden until room has been cleared

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Looks nicer when there's a notification flood. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22760 To: broulik, #plasma, ngraham Cc: ngraham,

D22494: Attempt to support different collections of Unsplash

ngraham added a comment. All right, that's just fine! REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D22494 To: guoyunhe, #plasma Cc: ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai,

D22742: Show about distro KCM in System Settings' System Administration category

ngraham added a comment. Yeah I slightly prefer it as well, for just that reason. REPOSITORY R102 KInfoCenter BRANCH show-about-distro-kcm-in-systemsettings (branched from master) REVISION DETAIL https://phabricator.kde.org/D22742 To: ngraham, #vdg, #plasma, filipf Cc: filipf,

D22742: Show about distro KCM in System Settings' System Administration category

filipf accepted this revision. filipf added a comment. This revision is now accepted and ready to land. +1 for the feature, with how everyone is used to phones nowadays, I think a fair share of users would expect to see this information in system settings. I like this approach more than

D22453: [Applet] Use the more user-friendly term "recording" instead of "capture"

ngraham updated this revision to Diff 62601. ngraham added a comment. Change one more instance that I missed before REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22453?vs=61735=62601 BRANCH capture-to-recording (branched from master)

D18860: Add comment / description to the translations kcm

hein added a comment. Good stuff  REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18860 To: jbbgameich, hein, #plasma, ngraham, bshah Cc: bshah, sitter, apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf,

D22453: [Applet] Use the more user-friendly term "recording" instead of "capture"

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Don't have an opinion either way about the change, but we need to be consistent throughout src/kcm/package/contents/ui/Applications.qml:87:text:

D22453: [Applet] Use the more user-friendly term "recording" instead of "capture"

filipf accepted this revision. filipf added a comment. This revision is now accepted and ready to land. Might also be worth checking if "capture" is used elsewhere and replace it there as well. REPOSITORY R115 Plasma Audio Volume Applet BRANCH capture-to-recording (branched from master)

D21905: [Digital Clock] Open KOrganizer with event details on click

dvratil added a comment. Also, could someone take a look at https://phabricator.kde.org/D21902 please? :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21905 To: dvratil, #plasma Cc: broulik, apol, ngraham, plasma-devel, LeGast00n, jraleigh,

D22453: [Applet] Use the more user-friendly term "recording" instead of "capture"

ngraham added a comment. @drosca #plasma ping REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D22453 To: ngraham, #plasma, #vdg, drosca Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2,

D21905: [Digital Clock] Open KOrganizer with event details on click

dvratil added inline comments. INLINE COMMENTS > apol wrote in CalendarView.qml:196 > Maybe it should only be enabled if there's events to show? This ListItem represents an event, so there's always an event :) REPOSITORY R120 Plasma Workspace REVISION DETAIL

D21905: [Digital Clock] Open KOrganizer with event details on click

dvratil updated this revision to Diff 62597. dvratil added a comment. - Implement Kai's suggestion REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21905?vs=60070=62597 BRANCH master REVISION DETAIL https://phabricator.kde.org/D21905 AFFECTED

D22735: Introduce ResultsModel with better data processing and filtering

broulik updated this revision to Diff 62595. broulik added a comment. - Fix running results automatically - Fix warnings REPOSITORY R112 Milou CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22735?vs=62540=62595 REVISION DETAIL https://phabricator.kde.org/D22735 AFFECTED

D22735: Introduce ResultsModel with better data processing and filtering

davidedmundson added a comment. Nearly all good INLINE COMMENTS > ResultsView.qml:90 > +if (runAutomatically) { > +runCurrentIndex(); > +} This recreates the bug I just fixed! Adding a Qt.callLater round this would also work REPOSITORY R112 Milou

D22494: Attempt to support different collections of Unsplash

guoyunhe added a comment. In D22494#502354 , @ngraham wrote: > One UI improvement I could see is to allow multi-selection of categories, so for example you could see images from all the nature-related categories but not Car or Sports. > >

D18860: Add comment / description to the translations kcm

This revision was automatically updated to reflect the committed changes. Closed by commit R120:59b1f923be29: Add comment / description to the translations kcm (authored by jbbgameich). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D22579: Load QtQuickSettings from ksplashqml

This revision was automatically updated to reflect the committed changes. Closed by commit R120:c7c5f9a1a7e9: Load QtQuickSettings from ksplashqml (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22579?vs=62106=62591

D22753: [taskmanager] Simplifiy one of the two PID lookups

This revision was automatically updated to reflect the committed changes. Closed by commit R120:afc59d51c7b7: [taskmanager] Simplifiy one of the two PID lookups (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D22760: [Notifications] Keep new delegate hidden until room has been cleared

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY When a new notification comes in, we first displace the existing ones to make room and then

D22005: Accept local paths

meven added inline comments. INLINE COMMENTS > apol wrote in actionlist.cpp:256 > if (QDir::isAbsolutePath(resource)) { > resource = QUrl::fromLocalFile(resource); > } This should be done in applets/kicker/plugin/kastatsfavoritesmodel.cpp as well line 162 and line 275. I have a

D22738: Remove some uses on QDesktopWidget

hein added inline comments. INLINE COMMENTS > pagermodel.cpp:123 > +}; > +for (QScreen* screen : qGuiApp->screens()) > +configureScreen(screen); Missing braces around single-line block and no const REPOSITORY R119 Plasma Desktop REVISION DETAIL

D22757: Guard against missing xrandr extension

broulik added inline comments. INLINE COMMENTS > screenpool.cpp:46 > if (KWindowSystem::isPlatformX11()) { > qApp->installNativeEventFilter(this); > const xcb_query_extension_reply_t* reply = > xcb_get_extension_data(QX11Info::connection(), _randr_id); How about not

D19784: Avoid calling QT_LSTAT and accessing recent documents

meven added a comment. Since this patch icons for folders in recent documents have been replaced with the application-octet-stream icon. SkipMimeTypeFromContent should be avoided for local directories. We need a better way to detect if the folder is a network folder before making