D22616: Remove phonon KCM

sitter added a comment. Still WIP REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22616 To: nicolasfella, sitter Cc: ngraham, pino, plasma-devel, sitter, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jen

D22940: Add a label to the lockscreen config's "Show media controls" checkbox and make the QML imports consistent

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY F7164807 TEST PLAN Open the Appearance tab of the Screen Lock

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

GB_2 added a comment. The `icons` folder can be deleted since it's not used anymore I think. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D22468 To: romangg, #plasma, #kwin Cc: GB_2, gvarsanyi, davidedmundson, ngraham, mvourlakos, knambiar, broulik, filipf, plasma

D21978: RFC: Fix search not returning results in Kickoff when cursor is below tabbar

GB_2 added a comment. In D21978#497409 , @filipf wrote: > Ping, I'm still seeing the issue with the other patch landed. Me too. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D21978 To: filipf, hein, #pla

KDE CI: Plasma » systemsettings » stable-kf5-qt5 FreeBSDQt5.13 - Build # 8 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/stable-kf5-qt5%20FreeBSDQt5.13/8/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 05 Aug 2019 06:23:43 + Build duration: 2 hr 58 min and counting CONSOLE OUTPUT

KDE CI: Plasma » systemsettings » stable-kf5-qt5 FreeBSDQt5.13 - Build # 9 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/stable-kf5-qt5%20FreeBSDQt5.13/9/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 05 Aug 2019 09:22:09 + Build duration: 1 min 36 sec and counting

D22874: Remove the ShellManager

ndavis added a comment. After this patch, when I run `plasmashell --replace &` 3 times in a row, the following happens: 1st time: Plasmashell runs F7165069: 1.txt 2nd time: Plasmashell segfaults with `"No such object path '/org/kde/plasmashe

D22874: Remove the ShellManager

broulik added a comment. I get the `plasmashell --replace` not working correctly occasionally. I don't think this is related to any of this. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22874 To: apol, #plasma, davidedmundson, bshah Cc: broulik, ndavis,

D22767: Calculate first clickable point, from the top-left

kmaterka removed a reviewer: Plasma: Workspaces. kmaterka added inline comments. INLINE COMMENTS > davidedmundson wrote in sniproxy.cpp:576 > This point was marked as closed, but not changed. Probably my fault for not > expanding. > > We move the window so that it's at x-clickPoint > The relat

D22874: Remove the ShellManager

ndavis added a comment. In D22874#506843 , @broulik wrote: > I get the `plasmashell --replace` not working correctly occasionally. I don't think this is related to any of this. I'm pretty sure it is. I can reliably reproduce tge bug with

D22874: Remove the ShellManager

broulik added a comment. I can repdroduce plasmashell crashing. The `--replace` option is fine but it just crashes on teardown. Thread 1 "plasmashell" received signal SIGSEGV, Segmentation fault. 0x71fafd66 in QScopedPointer >::operator-> (this=) at ../../include/QtC

D22857: [Notifications KCM] Add checkbox for enabling do not disturb mode when screens are mirrored

broulik updated this revision to Diff 63105. broulik edited the summary of this revision. broulik edited the test plan for this revision. broulik added a comment. - Shuffle checkboxes around a bit REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22857?

Re: [System Tray]

pon., 5 sie 2019 o 06:55 David Edmundson napisał(a): > On Thu, Aug 1, 2019 at 10:30 AM Konrad Materka wrote: > > > > Hi, > > > > recently I was fixing two bugs related to SystemTray (in review: > > https://phabricator.kde.org/D22804, > > https://phabricator.kde.org/D22767). I noticed that code is

D21524: Keep existing configurations' strings               

apol added a comment. Is this only necessary for gtk2? INLINE COMMENTS > appearancegtk2.cpp:125 > +{ > +QRegularExpression regExp{propertyName + "=[^\n]*($|\n)"}; > const? > appearancegtk2.cpp:136 > +if (nonStringProperties.contains(propertyName)) { > +newConfigString = QS

D22945: Fix --replace option

apol created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Wait for the other process to unregister before starting the new one. TEST PLAN Reproduced the problem Noah mentioned and addressed it.

D22945: Fix --replace option

broulik added a comment. Also can you split the crash fix and `--replace` option change please INLINE COMMENTS > main.cpp:136 > corona->setShell(cliOptions.value(shellPluginOption)); > +QObject::connect(QCoreApplication::instance(), > &QCoreApplication::aboutToQuit, corona, &QObject

D22616: Remove phonon KCM

sitter added a comment. https://phabricator.kde.org/source/phonon/browse/master/settings/ REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22616 To: nicolasfella, sitter Cc: ngraham, pino, plasma-devel, sitter, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen,

D22945: Fix --replace option

apol added inline comments. INLINE COMMENTS > broulik wrote in main.cpp:136 > Can you explain? The `ShellCorona` is parented to the app, so is destroyed > with it. Is the `deleteLater` even still processed at this point? aboutToQuit is called much earlier than the actual destruction. > broulik

D22616: Remove phonon KCM

ngraham added a comment. Sweet, thanks! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22616 To: nicolasfella, sitter Cc: ngraham, pino, plasma-devel, sitter, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed

D22940: Add label to the lockscreen config's "Show media controls" checkbox and make QML imports consistent

GB_2 updated this revision to Diff 63117. GB_2 added a comment. Put checkbox id property above text property REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22940?vs=63099&id=63117 BRANCH add-label-to-show-lockscreen-media-controls-checkbox-and-

D22947: Set needsAuthorization

broulik created this revision. broulik added reviewers: Plasma, VDG, GB_2. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Was commented for some reason. BUG: 410605 FIXED-IN: 5.17.0 TEST PLAN - OK and

D22948: Fix crash when dropping ShellManager

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY The corona needs to be closed earlier. TEST PLAN Now we don't hit the race-condition when closing REPOS

D22945: Fix --replace option

apol updated this revision to Diff 63120. apol added a comment. Split into two REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22945?vs=63109&id=63120 BRANCH replace REVISION DETAIL https://phabricator.kde.org/D22945 AFFECTED FILES shell/ma

D22947: Set needsAuthorization

This revision was automatically updated to reflect the committed changes. Closed by commit R258:dc868b4ee1b3: Set needsAuthorization (authored by broulik). REPOSITORY R258 Plymouth KCM CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22947?vs=63118&id=63121 REVISION DETAIL https://p

D22844: [kcm-colors] Export colorscheme to GTK color definitions

cblack updated this revision to Diff 63123. cblack added a comment. Add KRdbExportGtkColors flag to kcminit_style() REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22844?vs=63025&id=63123 BRANCH kcm-colors-gtk (branched from master) REVISION DETAI

D22940: Add label to the lockscreen config's "Show media controls" checkbox and make QML imports consistent

ngraham requested changes to this revision. ngraham added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > config.qml:17 > id: showMediaControls > +text: i18nd("plasma_lookandfeel_org.kde.lookandfeel", "Show") > } This short string needs tra

D22940: Add label to the lockscreen config's "Show media controls" checkbox and make QML imports consistent

GB_2 updated this revision to Diff 63125. GB_2 added a comment. Add translation context REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22940?vs=63117&id=63125 BRANCH add-label-to-show-lockscreen-media-controls-checkbox-and-make-qml-imports-cons

D22940: Add label to the lockscreen config's "Show media controls" checkbox and make QML imports consistent

This revision was automatically updated to reflect the committed changes. Closed by commit R120:b4ccffec69ec: Add label to the lockscreen config's "Show media controls" checkbox and make… (authored by GB_2). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.o

D22122: use pwquality_strerror to get error strings

This revision was automatically updated to reflect the committed changes. Closed by commit R128:29768b08aa06: use pwquality_strerror to get error strings (authored by sitter). REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22122?vs=60770&id=63130 REVISIO

D22948: Fix crash when dropping ShellManager

This revision was automatically updated to reflect the committed changes. Closed by commit R120:7ad59526f104: Fix crash when dropping ShellManager (authored by apol). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22948?vs=63119&id=63131 REVISION DET

D22952: Kirigami.Icon: Fix loading bigger images when source is a URL

apol created this revision. apol added reviewers: Frameworks, Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Port to using the QImage::load() that takes a QIODevice and only do it when the execution

D22945: Fix --replace option

apol updated this revision to Diff 63134. apol added a comment. x REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22945?vs=63120&id=63134 BRANCH replace REVISION DETAIL https://phabricator.kde.org/D22945 AFFECTED FILES shell/main.cpp To: a

D22893: introduce the Defaults group for panel values

apol added a comment. looks good to me overall. INLINE COMMENTS > panel.cpp:249 > if (panel()) { > -QMetaObject::invokeMethod(panel(), "restore"); > } Doesn't restore need calling now? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22893

D22953: Make the System Settings category headers look consistent with other Kirigami lists

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY F7167951: Consistent System Settings Category Headers.png TEST

D21524: Keep existing configurations' strings               

gikari updated this revision to Diff 63142. gikari added a comment. Remove redundant QString constructors and apply const modifier to QRegularExpression REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21524?vs=58987&id=63142 BRANCH arcp

D21524: Keep existing configurations' strings               

gikari marked 4 inline comments as done. gikari added a comment. In D21524#506866 , @apol wrote: > Is this only necessary for gtk2? Yes. Gtk3 settings.ini custom entries remain untouchable, when settings are applied. REPOSITORY R99 KDE

D22953: Make the System Settings category headers look consistent with other Kirigami lists

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. So much better!!! REPOSITORY R124 System Settings BRANCH make-systemsettings-category-headers-consistent (branched from master) REVISION DETAIL https://phabricator.kde.org/D22953

D22953: Make the System Settings category headers look consistent with other Kirigami lists

This revision was automatically updated to reflect the committed changes. Closed by commit R124:1fff71c11e63: Make the System Settings category headers look consistent with other Kirigami… (authored by GB_2). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.o

D22684: [Klipper] Fix clipboard history management

pdabrowski updated this revision to Diff 63145. pdabrowski edited the summary of this revision. pdabrowski edited the test plan for this revision. pdabrowski added a comment. New, much better solution. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

D22955: Add icon used by Kirigami.AboutPage

hein created this revision. hein added reviewers: Frameworks, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. hein requested review of this revision. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D22955 AFFECTED FILES

D22684: [Klipper] Fix clipboard history management

pdabrowski updated this revision to Diff 63147. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22684?vs=63145&id=63147 REVISION DETAIL https://phabricator.kde.org/D22684 AFFECTED FILES applets/clipboard/contents/ui/ClipboardPage.qml applets/cli

D22684: [Klipper] Fix clipboard history management

pdabrowski added a comment. New, much better solution. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22684 To: pdabrowski, #plasma, #plasma_workspaces, ngraham, davidedmundson Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, Zren

D22948: Fix crash when dropping ShellManager

ndavis added a comment. This stops Plasmashell from segfaulting, but now it exits (code 1) with this message every other time `plasmashell --replace &` is run: org.kde.kactivities.lib.core: Killing the consumer org.kde.kactivities.lib.core: Killing the consumer org.kde.kactiviti

D22955: Add icon used by Kirigami.AboutPage

This revision was automatically updated to reflect the committed changes. Closed by commit R169:c17c048ec2f7: Add icon used by Kirigami.AboutPage (authored by hein). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22955?vs=63146&id=63152 REVISION DETAIL htt

D22948: Fix crash when dropping ShellManager

apol added a comment. Yep, see D22945 . REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22948 To: apol, #plasma, mart Cc: ndavis, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, l

D22952: Kirigami.Icon: Fix loading bigger images when source is a URL

apol updated this revision to Diff 63153. apol added a comment. simplify REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22952?vs=63133&id=63153 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22952 AFFECTED FILES src/icon.cpp src/icon

D22960: Add handle icons

hein created this revision. hein added reviewers: Frameworks, apol, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. hein requested review of this revision. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D22960 AFFECTED F

D22948: Fix crash when dropping ShellManager

ndavis added a comment. Ah, thanks. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22948 To: apol, #plasma, mart Cc: ndavis, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg,

D22945: Fix --replace option

ndavis added a comment. I can confirm that this fixes the bug. Thanks! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22945 To: apol Cc: ndavis, broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai,

D22952: Kirigami.Icon: Fix loading bigger images when source is a URL

broulik added inline comments. INLINE COMMENTS > icon.cpp:406 > +m_networkReply = qnam->get(request); > +connect(m_networkReply.data(), &QNetworkReply::finished, this, > [this](){handleFinished(m_networkReply); }); > } Just noticed, doesn't the `m_networkReply` leak? It's n