D23342: Add a per-process network information plugin

meven requested changes to this revision. meven added a comment. This revision now requires changes to proceed. The command `sudo setcap cap_net_raw+ep ksgrd_network_helper` needs to be documented outside of just the commit message, in `plugins/process/network/README.md` at least. This coul

D23342: Add a per-process network information plugin

meven added a comment. It works nicely. I thought it missed a screenshot here. F7303942: Screenshot_20190901_084433.png REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D23342 To: ahiemstra, #plasma Cc: meven, davidedmundso

D23287: Create a plugin framework for processes

meven added inline comments. INLINE COMMENTS > process_data_provider.cpp:23 > +#include "process_attribute.h" > + > +using namespace KSysGuard; Missing `#include ` Results in build error : kde/src/libksysguard/processcore/process_data_provider.cpp:30:33: error: field ‘m_attributes’ has inco

D23174: Improve the look of the Activities KCM UI

GB_2 added a comment. In D23174#519704 , @ngraham wrote: > Hooray! > > Next, do you think you could clean up the applications list so there aren't all those duplicates and they all get icons? Unfortunately, I don't know the code base

D23392: [energy KCM] Add battery Technology

meven added a comment. ping Possible since D23157 REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D23392 To: meven, broulik, ngraham Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel

D23542: Promote KCM to top level and rename accordingly

ngraham closed this revision. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D23542 To: ngraham, #vdg, #plasma, drosca, nicolasfella, sitter Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot,

D23158: [Kickoff] Improve appearance of draggable button grid in settings window

ngraham added a comment. Ping. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23158 To: ngraham, #vdg, #plasma, davidedmundson, GB_2 Cc: GB_2, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, himcesj

D23283: When asked to switch sessions, jump to session creation if there's nothing to switch to

ngraham added a comment. Ping. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23283 To: ngraham, #plasma, #vdg Cc: gregormi, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, al

D23387: [Folder view] Scale selection and preview buttons with item size

ngraham added a comment. Ping. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23387 To: ngraham, hein, #plasma, #vdg Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jens

D23368: [Energy KCM] Port away from WorkspaceComponents.BatteryIcon and improve presentation

This revision was automatically updated to reflect the committed changes. Closed by commit R102:d6da69a584ae: [Energy KCM] Port away from WorkspaceComponents.BatteryIcon and improve… (authored by ngraham). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D233

D23622: [kicker/kickoff] Use better icon for edit application

ngraham added a comment. While we're at it, I think the text could be improved too. "Edit Application", when read literally (as an average user is likely to do) implies that this actually alters the app itself, which is not accurate. REPOSITORY R119 Plasma Desktop REVISION DETAIL https:

D23623: [kicker/kickoff] Use discover icon for manage application action

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Definitely better. REPOSITORY R119 Plasma Desktop BRANCH discoicon REVISION DETAIL https://phabricator.kde.org/D23623 To: nicolasfella, #plasma, hein, ngraham Cc: plasma-devel, Le

D23623: [kicker/kickoff] Use discover icon for manage application action

nicolasfella created this revision. nicolasfella added reviewers: Plasma, hein, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY While not 100% technically correct since another app might be associa

D23622: [kicker/kickoff] Use better icon for edit application

nicolasfella created this revision. nicolasfella added reviewers: Plasma, hein, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY As the TODO comment suggests the old one is not very good here REPOS

D23621: [kicker/kickoff] Add icon to forget recent docs action

nicolasfella created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH recentdocsicon REVISION DETAIL https://phabricator.kde.org/D23621 AFFECTED FILES applets/kic

D23308: Add a warning message about needing globally installed theme files

filipf updated this revision to Diff 65084. filipf added a comment. - remove "in the root directory" REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23308?vs=64997&id=65084 BRANCH sync-warning (branched from master) REVISION DETAIL

D23620: Fix speaker test not showing sinks/buttons

nicolasfella added a subscriber: aacid. nicolasfella added a comment. @aacid IIRC you reported this issue to me at the Valencia sprint REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D23620 To: nicolasfella, #plasma, drosca Cc: aacid, plasma-devel,

D23620: Fix speaker test not showing sinks/buttons

nicolasfella created this revision. nicolasfella added reviewers: Plasma, drosca. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY Initially no sink is selected in the combobox which leads to an empty speake

D23308: Add a warning message about needing globally installed theme files

ngraham added inline comments. INLINE COMMENTS > ngraham wrote in advancedconfig.ui:246 > Maybe mention the actual path "In the root directory" is both unhelpful and > inaccurate if read literally All right, just get rid of "(in the root directory)" then. REPOSITORY R123 SDDM Configuration P

D23594: Use sensor index for request ID in SystemMonitorEngine::updateSensors()

davidedmundson added a comment. You're right. -N response to "someSensorName?" (which returns metadata of a sensor) -1 response to "monitors" (which lists things) +N response to a given call > . I couldn't find a place that actually calls that function, so I couldn't verify the

D23308: Add a warning message about needing globally installed theme files

filipf added inline comments. INLINE COMMENTS > filipf wrote in advancedconfig.ui:246 > I would assume it's `/usr/share/` but I don't know it that's true for all > distros and BSD? /usr/share would just be less inaccurate then anyway, these "theme files" mentioned are all installed in differen

D23308: Add a warning message about needing globally installed theme files

filipf added inline comments. INLINE COMMENTS > ngraham wrote in advancedconfig.ui:154 > Looks unrelated This reverts an unrelated change I made in: https://github.com/KDE/sddm-kcm/commit/f9e753551cdd8f41ca2fb15bfc6610afc5e09a59#diff-19d487873d9e40d7bbcc52ca9926efceR177 > ngraham wrote in adva

D23391: Clean up not needed Q_INVOKABLE

This revision was automatically updated to reflect the committed changes. Closed by commit R102:3d94131ee08a: Clean up not needed Q_INVOKABLE (authored by meven). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23391?vs=65038&id=65039 REVISION DETAIL htt

D23391: Clean up not needed Q_INVOKABLE

meven updated this revision to Diff 65038. meven added a comment. Remove unnecessary root. REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23391?vs=65036&id=65038 BRANCH arcpatch-D23391 REVISION DETAIL https://phabricator.kde.org/D23391 AFFECTED F

D23391: Clean up not needed Q_INVOKABLE

meven updated this revision to Diff 65036. meven added a comment. rebase REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23391?vs=65035&id=65036 BRANCH arcpatch-D23391 REVISION DETAIL https://phabricator.kde.org/D23391 AFFECTED FILES Modules/ene

D23391: Clean up not needed Q_INVOKABLE

meven updated this revision to Diff 65035. meven added a comment. Add a function initCurrentBattery to initialize currentBattery property and associated ones REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23391?vs=64457&id=65035 BRANCH arcpatch-D233

D23391: Clean up not needed Q_INVOKABLE

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Lovely! INLINE COMMENTS > main.qml:97 > Component.onCompleted: { > -currentBattery = kcm.batteries.get(0) > -currentVendor = kcm.batteries.vendor(0) > -curren

D22912: Fix build with clang 9.0

mvourlakos closed this revision. mvourlakos added a comment. this code has already been applied... https://phabricator.kde.org/source/latte-dock/browse/master/app/settings/delegates/persistentmenu.h REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D22912 To: bero