D10362: Change reveal password button logic

2019-09-06 Thread Björn Feber
GB_2 updated this revision to Diff 65541. GB_2 added a comment. Fix diff REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10362?vs=65540&id=65541 BRANCH arcpatch-D10362 REVISION DETAIL https://phabricator.kde.org/D10362 AFFECTED FILE

D10362: Change reveal password button logic

2019-09-06 Thread Björn Feber
GB_2 updated this revision to Diff 65540. GB_2 added a comment. This revision is now accepted and ready to land. Change `onPressedChanged` back to `onClicked` and only show the button when there is text inside the TextField, like in the PolKit dialog REPOSITORY R242 Plasma Framework (Librar

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-06 Thread Björn Feber
GB_2 added a comment. In D23712#526883 , @cblack wrote: > I preferred the sidebar as well, but a sidebar with the necessary width to fit the label + the largest icon name in Breeze without layout issues would be obscenely large, and would take o

D22169: [plasma-active-window-control] Use new activities icon

2019-09-06 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R884:c29390fab0c4: [plasma-active-window-control] Use new activities icon (authored by GB_2). REPOSITORY R884 Active Window Control Applet for Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.o

D22170: [latte-dock] Use new activities icon

2019-09-06 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R878:c264a0a9e3fe: [latte-dock] Use new activities icon (authored by GB_2). REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22170?vs=60869&id=65536 REVISION DETAIL

D22168: [plasma-desktop] Use new activities icon

2019-09-06 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R119:267b9134c8b1: [plasma-desktop] Use new activities icon (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22168?vs=65531&id=65534 REVISION D

D22167: [plasma-workspace] Use new activities icon

2019-09-06 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R120:9ad1b5502e1a: [plasma-workspace] Use new activities icon (authored by GB_2). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22167?vs=60865&id=65533 REVISI

D22168: [plasma-desktop] Use new activities icon

2019-09-06 Thread Björn Feber
GB_2 updated this revision to Diff 65531. GB_2 added a comment. Rebase on master REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22168?vs=60866&id=65531 BRANCH arcpatch-D22168 REVISION DETAIL https://phabricator.kde.org/D22168 AFFECTED FILES

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-06 Thread Carson Black
cblack updated this revision to Diff 65530. cblack added a comment. Add 22 size to preview, and hardcode sizes since they shouldn't need to respect any settings. REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23712?vs=65505&id=65530 BRANCH modernizat

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-06 Thread Carson Black
cblack added a comment. In D23712#526852 , @ndavis wrote: > In D23712#526826 , @trickyricky26 wrote: > > > I love this patch, however I am curious as to why you moved the sidebar to the bottom. >

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-06 Thread Noah Davis
ndavis added a comment. In D23712#526826 , @trickyricky26 wrote: > I love this patch, however I am curious as to why you moved the sidebar to the bottom. > Judging from your screenshot, it results in quite a bit of empty horizontal space.

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-06 Thread TrickyRicky
trickyricky26 added a comment. I love this patch, however I am curious as to why you moved the sidebar to the bottom. Judging from your screenshot, it results in quite a bit of empty horizontal space. Conceptually I think it is nicer to have the scrollable view go to the bottom of the wi

D23342: Add a per-process network information plugin

2019-09-06 Thread Arjen Hiemstra
ahiemstra added a comment. That's correct. The reason for that is that a non-root process is not allowed to read which inodes root process has open, thus there is no way for the helper to map from incoming port to process ID. The only way I know of solving that is by having the helper run as

D23734: Remove the "fail_delay()" function

2019-09-06 Thread Jason Franklin
jfranklin abandoned this revision. jfranklin added a comment. Problem exists in linux-pam. I will fix the issue there. Abandoning revision. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D23734 To: jfranklin, #plasma, #kwin, zzag Cc: zzag, plasma-devel, LeGa

D23734: Remove the "fail_delay()" function

2019-09-06 Thread Vlad Zagorodniy
zzag added a comment. Thank you for looking further into this issue. Just abandon the revision. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D23734 To: jfranklin, #plasma, #kwin, zzag Cc: zzag, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas

D23734: Remove the "fail_delay()" function

2019-09-06 Thread Jason Franklin
jfranklin added a comment. I investigated this further in the linux-pam repository, and I ended up creating this issue . The developers there acknowledged that the documentation was not correct and have asked for a PR to fix it. Thus,

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-06 Thread Nathaniel Graham
ngraham added a comment. Just noticed something odd: the multi-size view shows an 8px version, but not the 22px version. Only one type of icon uses the 8px version (emblems) but 22px is more common. We should add that too. Also the last two slider values are still displayed incorrectly i

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

2019-09-06 Thread Björn Feber
GB_2 updated this revision to Diff 65509. GB_2 added a comment. Use Plasma highlight effect REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19822?vs=55003&id=65509 BRANCH arcpatch-D19822 REVISION DETAIL https://phabricator.kde.org/D19822 AFFECT

D23728: [kicker/kickoff] Use icon from appstream handler

2019-09-06 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R119:26c1ea64c636: [kicker/kickoff] Use icon from appstream handler (authored by nicolasfella). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23728?vs=65408&id=6

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-06 Thread Carson Black
cblack marked 18 inline comments as done. cblack added inline comments. INLINE COMMENTS > ngraham wrote in view.cpp:41 > Probably makes sense to reduce this to 600 if we can get the layout to adjust > adequately. There's already icon names that are too long for the minimum 800 width window, so

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-06 Thread Carson Black
cblack updated this revision to Diff 65505. cblack added a comment. Updates based off of feedback REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23712?vs=65483&id=65505 BRANCH modernization (branched from master) REVISION DETAIL https://phabricator

D23732: [kded] Support fractional output scale

2019-09-06 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > output.cpp:357 > +// Round scale to one digit. > +info[QStringLiteral("scale")] = int(output->scale() * 10 + 0.5) / 10.; > + i don't understand why we need/want this. KConfig won't corrupt a double through a save/restore. REPOSITO

D23734: Remove the "fail_delay()" function

2019-09-06 Thread Vlad Zagorodniy
zzag added a comment. Um, pam_unix I suppose... REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D23734 To: jfranklin, #plasma, #kwin, zzag Cc: zzag, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesl

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

2019-09-06 Thread Victor Ryzhykh
victorr added a comment. F7323570: now_qml.patch F7323571: Screenshot_20190906_111728.jpeg REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D22468 To: romangg, #plasma, #kwin, #vdg Cc:

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

2019-09-06 Thread Roman Gilg
romangg added a comment. In D22468#526465 , @ngraham wrote: > Like so: > `xi18n("@info", "the first 100 charactersthe next 100 charactersand so on");` I meant the 100 chars line limit of the code source file. REPOSITORY R104 KScreen