D12827: Added process details in the process list context menu

meven added a comment. In D12827#527480 , @chrisx wrote: > Patch updated. Any suggestions? You have a few code indentation issues, that you can take care of. https://phabricator.kde.org/D12827#inline-130952 And I think you should re

D23798: Polish Displays KCM UI

ngraham updated this revision to Diff 65706. ngraham marked 3 inline comments as done. ngraham added a comment. Address more review comments REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23798?vs=65687&id=65706 BRANCH clean-up-ui (branched from master)

D23808: Don't create() windows that aren't native, upon receiving a palette change event.

dfaure created this revision. dfaure added reviewers: carewolf, davidedmundson, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. dfaure requested review of this revision. TEST PLAN run kmail or falkon, then run kcmshell5 fonts, change font size ASSERT: "!d->

D23803: [Folder View] Add subtle shadows to icons

broulik added a comment. Ah never mind. It's in the if check like the label. Nice! REPOSITORY R119 Plasma Desktop BRANCH add-subtle-icon-shadow-to-folderview (branched from master) REVISION DETAIL https://phabricator.kde.org/D23803 To: ngraham, hein, #plasma, #vdg, filipf, ndavis Cc:

D23803: [Folder View] Add subtle shadows to icons

broulik added a comment. Can you check whether it's works with software rendering - we don't want desktop icons to entirely disappear in this case. REPOSITORY R119 Plasma Desktop BRANCH add-subtle-icon-shadow-to-folderview (branched from master) REVISION DETAIL https://phabricator.kde

D23803: [Folder View] Add subtle shadows to icons

GB_2 added a comment. In D23803#528128 , @cfeck wrote: > Isn't Qt Quick amazing? Indeed! REPOSITORY R119 Plasma Desktop BRANCH add-subtle-icon-shadow-to-folderview (branched from master) REVISION DETAIL https://phabricator.kde.org

D23803: [Folder View] Add subtle shadows to icons

cfeck added a comment. Isn't Qt Quick amazing? REPOSITORY R119 Plasma Desktop BRANCH add-subtle-icon-shadow-to-folderview (branched from master) REVISION DETAIL https://phabricator.kde.org/D23803 To: ngraham, hein, #plasma, #vdg, filipf, ndavis Cc: cfeck, ndavis, filipf, plasma-devel,

D23798: Polish Displays KCM UI

GB_2 added a comment. I have a suggestion for the "save output properties" option. INLINE COMMENTS > Panel.qml:90 > > Kirigami.FormData.label: i18n("Save values of an output:") > Kirigami.FormData.buddyFor: globalRetentionRadio "Save output properties:" > Panel.q

D23798: Polish Displays KCM UI

GB_2 added inline comments. INLINE COMMENTS > ngraham wrote in main.qml:123 > And I could use some help with the issue detailed in the comment here. You don't need any of that. Just do `kcm.outputModel.count > 1`. BTW, I'd also use a different minimum height if this component is hidden. REPOSI

D23803: [Folder View] Add subtle shadows to icons

ndavis accepted this revision. ndavis added a comment. +1 REPOSITORY R119 Plasma Desktop BRANCH add-subtle-icon-shadow-to-folderview (branched from master) REVISION DETAIL https://phabricator.kde.org/D23803 To: ngraham, hein, #plasma, #vdg, filipf, ndavis Cc: ndavis, filipf, plasma-de

D23803: [Folder View] Add subtle shadows to icons

filipf accepted this revision. filipf added a comment. This revision is now accepted and ready to land. Tried it out, I like the way it looks. REPOSITORY R119 Plasma Desktop BRANCH add-subtle-icon-shadow-to-folderview (branched from master) REVISION DETAIL https://phabricator.kde.org/D

D23803: [Folder View] Add subtle shadows to icons

ngraham created this revision. ngraham added reviewers: hein, Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Folder View items currently have shadows behind their labels, but not their icons.

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

ngraham accepted this revision. ngraham added a comment. Works and looks great to me. @hein, are you okay with this now? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19822 To: faridb, #plasma, #vdg, ngraham, hein, GB_2 Cc: GB_2, mart, hein, filipf, mvourlak

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

GB_2 updated this revision to Diff 65691. GB_2 added a comment. Fix diff REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19822?vs=65509&id=65691 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19822 AFFECTED FILES applets/taskmanag

D23786: Remove some spacing on lockscreen that was causing elements to get cut off on small displays

filipf added a comment. Yikes, we need to fix that. So what this patch does is moves *all* of the UI up a bit. One issue is you should then also definitely check and modify the Breeze SDDM theme so the two look identical. But... you could maybe skip that and use an alternative a

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

ngraham added a comment. This patch doesn't apply anymore. I think something went wrong with adding that last change. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19822 To: faridb, #plasma, #vdg, ngraham, hein, GB_2 Cc: GB_2, mart, hein, filipf, mvourlakos

D23798: Polish KCM UI

ngraham added inline comments. INLINE COMMENTS > main.qml:123 > outputs: kcm.outputModel > +// visible: kcm.numberOfOutputs > 1 // FIXME: this is -1 here; > does it get set too late? > } And I could use some help with the issue detailed in the comment here. RE

D23798: Polish KCM UI

ngraham updated this revision to Diff 65687. ngraham added a comment. Remove unnecessarily-added id for main layout REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23798?vs=65685&id=65687 BRANCH clean-up-ui (branched from master) REVISION DETAIL https:

D23798: Polish KCM UI

ngraham updated this revision to Diff 65685. ngraham added a comment. Use same slider style for the per-output Wayland version REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23798?vs=65684&id=65685 BRANCH clean-up-ui (branched from master) REVISION DETA

D23798: Polish KCM UI

ngraham updated this revision to Diff 65684. ngraham added a comment. ...And also capitalize correctly REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23798?vs=65683&id=65684 BRANCH clean-up-ui (branched from master) REVISION DETAIL https://phabricator

D23798: Polish KCM UI

ngraham updated this revision to Diff 65683. ngraham marked 2 inline comments as done. ngraham added a comment. Add icons to pushbuttons REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23798?vs=65674&id=65683 BRANCH clean-up-ui (branched from master) REV

D23786: Remove some spacing on lockscreen that was causing elements to get cut off on small displays

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM. Any objections? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23786 To: kishoreg, #plasma, #vdg, ngraham Cc: ngraham, plasma-devel, LeGast00n, T

D23793: Add icons to Kicker/Kickoff context menu items and correct capitalizations

This revision was automatically updated to reflect the committed changes. Closed by commit R119:6fbfc3ded129: Add icons to Kicker/Kickoff context menu items and correct capitalizations (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2

D10362: Change reveal password button logic

This revision was automatically updated to reflect the committed changes. Closed by commit R242:fb18347e4dea: Change reveal password button logic (authored by GB_2). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10362?vs=65592&id=65681 REV

D23798: Polish KCM UI

ngraham added a comment. In D23798#527978 , @ndavis wrote: > What are "Values of an output"? I don't understand what these 2 settings do. I agree that this part is rather confusing. @romangg can confirm, but as far as I understand it,

D23798: Polish KCM UI

filipf added a comment. In D23798#527978 , @ndavis wrote: > What are "Values of an output"? I don't understand what these 2 settings do. +1 REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D23798 To: ngraham, roma

D23798: Polish KCM UI

ndavis added a comment. What are "Values of an output"? I don't understand what these 2 settings do. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D23798 To: ngraham, romangg, #vdg, #kwin Cc: ndavis, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampa

D23795: HiDPI icon in buttons and menus

This revision was automatically updated to reflect the committed changes. Closed by commit R106:774764b0c5e8: HiDPI icon in buttons and menus (authored by Guo Yunhe ). REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23795?vs=65662&id=65680

D23794: HiDPI icon pixmap

This revision was automatically updated to reflect the committed changes. Closed by commit R111:5906261d6776: HiDPI icon pixmap (authored by Guo Yunhe ). REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23794?vs=65661&id=65679 REVISI

D23798: Polish KCM UI

GB_2 added a comment. +1 INLINE COMMENTS > Screen.qml:65 > onClicked: kcm.identifyOutputs() > text: i18n("Identify") > focusPolicy: Qt.NoFocus Icon: "documentinfo" > Screen.qml:71 > onClicked: resetTotalSize() > text: i18n("Ce

D23799: Get rid of khtml usage (kill classic mode)

ognarb added a comment. +1 is there a task somewhere where we can track all the KDE projects still using khtml? REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D23799 To: svuorela, vkrause, plasma-devel, #plasma Cc: ognarb, ngraham, #plasma, GB_2, sitter,

D23799: Get rid of khtml usage (kill classic mode)

ngraham added a comment. +1 REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D23799 To: svuorela, vkrause, plasma-devel, #plasma Cc: ngraham, #plasma, GB_2, sitter, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliez

D23799: Get rid of khtml usage (kill classic mode)

GB_2 added a comment. +1, let's also focus on fixing bugs for the other two views. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D23799 To: svuorela, vkrause, plasma-devel Cc: GB_2, sitter, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, Pitel

D23799: Get rid of khtml usage (kill classic mode)

vkrause added a comment. +1 REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D23799 To: svuorela, vkrause, plasma-devel Cc: sitter, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreute

D23799: Get rid of khtml usage (kill classic mode)

sitter added a comment. +1 REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D23799 To: svuorela, vkrause, plasma-devel Cc: sitter, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuter

D23799: Get rid of khtml usage (kill classic mode)

svuorela created this revision. svuorela added reviewers: vkrause, plasma-devel. Herald added a project: Plasma. svuorela requested review of this revision. REVISION SUMMARY khtml is going away, so remove the classic mode that relies on it TEST PLAN It's optional, so it can go without much be

D23798: Polish KCM UI

ngraham added a comment. I was not 100% sure about the method I chose to get the number of outputs, so I would appreciate if #kwin folks could me know if this is wrong or there's a better way. REPOSITORY R104 KScreen REVISION DETAIL https://phabri

D23798: Polish KCM UI

ngraham created this revision. ngraham added reviewers: romangg, VDG, KWin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This patch improves and polishes the new KScreen KCM's UI in a variety of ways. A pict

D23520: Add time line to X axis

alexde added a comment. *Friendly ping to the reviewers.* REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D23520 To: alexde, #vdg, ngraham, #plasma Cc: bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, hi

D21273: Add support for newer linux kernel power_supply API

meven added a comment. Thank you @luc4 for pinging again I have tested it, it works nicely, apparently the code you are replacing has not been working for a while. The code looks good to me. F7332944: Screenshot_20190909_102057.png I wou