D23952: Remove panel toolbox and clean up editing options

2019-09-22 Thread Björn Feber
GB_2 planned changes to this revision. GB_2 added a comment. In D23952#532716 , @ngraham wrote: > I agree that we can't only have this UI be in a context menu, and we need to expose it somewhere visible too (i.e. in System Settings like we discus

D24147: fix compatibility with Qt5.11

2019-09-22 Thread Matthieu Gallien
mgallien added a comment. It has been reported in debian https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=940939 REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D24147 To: mgallien, #kirigami Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, davided

D22359: Revert "[showdesktop][minimizeall] Reduce the maximum panel icon size"

2019-09-22 Thread Noah Davis
ndavis added a comment. In D22359#536055 , @ngraham wrote: > Is there any way we can preserve the original goal of using a monochrome icon here for small sizes? Maybe we could add an option to force a specific icon size. It would be lite

D22359: Revert "[showdesktop][minimizeall] Reduce the maximum panel icon size"

2019-09-22 Thread KonqiDragon
KonqiDragon added a comment. In D22359#536066 , @ngraham wrote: > In D22359#536064 , @KonqiDragon wrote: > > > In D22359#536063 , @ngraham wrote: > > >

D22359: Revert "[showdesktop][minimizeall] Reduce the maximum panel icon size"

2019-09-22 Thread Noah Davis
ndavis added a comment. In D22359#536066 , @ngraham wrote: > Those are in the System Tray, which always shows monochrome icons. Show Desktop is a standalone widget, which has logic to switch its icon between monochrome and colorful icons dependi

D22359: Revert "[showdesktop][minimizeall] Reduce the maximum panel icon size"

2019-09-22 Thread Noah Davis
ndavis added a comment. In D22359#536064 , @KonqiDragon wrote: > In D22359#536063 , @ngraham wrote: > > > In D22359#536057 , @ndavis wrote: > > > > >

D22359: Revert "[showdesktop][minimizeall] Reduce the maximum panel icon size"

2019-09-22 Thread Nathaniel Graham
ngraham added a comment. In D22359#536064 , @KonqiDragon wrote: > In D22359#536063 , @ngraham wrote: > > > In D22359#536057 , @ndavis wrote: > > > > >

D22359: Revert "[showdesktop][minimizeall] Reduce the maximum panel icon size"

2019-09-22 Thread KonqiDragon
KonqiDragon added a comment. In D22359#536063 , @ngraham wrote: > In D22359#536057 , @ndavis wrote: > > > In D22359#536055 , @ngraham wrote: > > > > > I

D22359: Revert "[showdesktop][minimizeall] Reduce the maximum panel icon size"

2019-09-22 Thread Nathaniel Graham
ngraham added a comment. In D22359#536057 , @ndavis wrote: > In D22359#536055 , @ngraham wrote: > > > Is there any way we can preserve the original goal of using a monochrome icon here for small siz

D22359: Revert "[showdesktop][minimizeall] Reduce the maximum panel icon size"

2019-09-22 Thread Noah Davis
ndavis added a comment. In D22359#536058 , @KonqiDragon wrote: > I really don't like that in the Plasma 5.17 Beta you returned a colored icon, when in Plasma 5.16 you added a monochrome icon i was glad. I don't like this regression. We need to

D22359: Revert "[showdesktop][minimizeall] Reduce the maximum panel icon size"

2019-09-22 Thread KonqiDragon
KonqiDragon added a comment. I really don't like that in the Plasma 5.17 Beta you returned a colored icon, when in Plasma 5.16 you added a monochrome icon i was glad. I don't like this regression. We need to talk with #consistency and #vdg

D22359: Revert "[showdesktop][minimizeall] Reduce the maximum panel icon size"

2019-09-22 Thread Noah Davis
ndavis added a comment. In D22359#536055 , @ngraham wrote: > Is there any way we can preserve the original goal of using a monochrome icon here for small sizes? Yes, it is already done. Lower the panel icon size to at least 22px. REPOSIT

D22359: Revert "[showdesktop][minimizeall] Reduce the maximum panel icon size"

2019-09-22 Thread Nathaniel Graham
ngraham added a comment. Is there any way we can preserve the original goal of using a monochrome icon here for small sizes? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22359 To: ndavis, #vdg, #plasma, davidedmundson Cc: ngraham, davidedmundson, filipf, p

D24147: fix compatibility with Qt5.11

2019-09-22 Thread Matthieu Gallien
mgallien created this revision. mgallien added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. mgallien requested review of this revision. REVISION SUMMARY Kirigami2 requires Qt 5.11 but D22974 broke that prom

D24146: Bug 410988, Button 'C' now does the same as 'AC'.

2019-09-22 Thread Maxim Marshev
maximma created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. maximma requested review of this revision. REPOSITORY R114 Plasma Addons BRANCH calculatorApplet (branched from master) REVISION DETAIL https://phabricator.kde.org/D24146 AFFECTED FILES

D22974: Allow usage of QQC2 actions on Kirigami components and now make K.Action based on QQC2.Action

2019-09-22 Thread Matthieu Gallien
mgallien added a comment. This patch breaks compatibility with Qt5.11 where Qt Quick Controls2 is in version 2.4. I noticed it after Debian upgraded the package and I am unable to let Elisa run with it. I will try to work on a fix. REPOSITORY R169 Kirigami REVISION DETAIL https://phab

Re: Fwd: Plasma 5.17 beta Discover system updates regression

2019-09-22 Thread Luca Beltrame
In data domenica 22 settembre 2019 14:20:21 CEST, Myriam Schweingruber ha scritto: (this might come in twice, due to gmane seemingly eating a message) > FYI, this is now reported on both Arch and Neon, with several dozen > duplicates in this bug report: https://bugs.kde.org/show_bug.cgi?id=41128

D24129: Fix clipping and use a real ScrollView for the Display Configuration KCM screen overview

2019-09-22 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a subscriber: romangg. ngraham added a comment. This revision is now accepted and ready to land. Looks like `Plasma/5.17` material to me. @romangg, do you agree? REPOSITORY R104 KScreen BRANCH master REVISION DETAIL https://phabricator.kde.

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.12 - Build # 362 - Fixed!

2019-09-22 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.12/362/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 18 Sep 2019 15:12:27 + Build duration: 8 hr 37 min and counting JUnit Tests Name: (root) Failed: 0 tes

Fwd: Plasma 5.17 beta Discover system updates regression

2019-09-22 Thread Myriam Schweingruber
FYI, this is now reported on both Arch and Neon, with several dozen duplicates in this bug report: https://bugs.kde.org/show_bug.cgi?id=411286 Looks like a very serious regression to me... Regards, Myriam PS. the reporter is not subscribed to the mailing list, if you want to answer him directly

KDE CI: Plasma » plasma-browser-integration » kf5-qt5 FreeBSDQt5.13 - Build # 78 - Fixed!

2019-09-22 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-browser-integration/job/kf5-qt5%20FreeBSDQt5.13/78/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 19 Sep 2019 01:16:43 + Build duration: 1 hr 41 min and counting

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 399 - Fixed!

2019-09-22 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/399/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 19 Sep 2019 21:11:54 + Build duration: 36 min and counting JUnit Tests Name: (root) Failed:

D24129: Fix clipping and use a real ScrollView for the Display Configuration KCM screen overview

2019-09-22 Thread Björn Feber
GB_2 updated this revision to Diff 66614. GB_2 added a comment. Remove unneeded lines REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24129?vs=66577&id=66614 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24129 AFFECTED FILES kcm/package