KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 404 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/404/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 25 Sep 2019 03:31:38 + Build duration: 24 min and counting CONSOLE OUTPUT [...truncated 170

D24011: Provide a telemetrics kcm module for Plasma

davidedmundson added a comment. Code for plasmashell part is fine. Ship it on that part. Might be nicer as an extra file outside ShellCorona which is already way too big. Especially when we add in more metrics. INLINE COMMENTS > shellcorona.cpp:94 > > +class PanelCountSource : public KUs

D24208: [Notifications] Dodge Plasma dialogs

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY The notification popup typically gets in the way of the system tray popup. In case it would

D24205: [GTK3] Make selection-mode headerbars closer to Adwaita

IlyaBizyaev added a comment. Could you show how this change affects the default color scheme? REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D24205 To: cblack, #breeze Cc: IlyaBizyaev, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ra

D24205: [GTK3] Make selection-mode headerbars closer to Adwaita

cblack created this revision. cblack added a reviewer: Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY Headerbars in selection mode are now colored in a similar manner as in Adwaita. REPOSITORY R98 Br

D24204: Move save failure message above options

broulik created this revision. broulik added reviewers: Plasma, fvogt, ognarb. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY With the number of options in there, it can be easily missed. TEST PLAN F7426029:

D24203: Add settings change listener

broulik created this revision. broulik added reviewers: Plasma, fvogt, ognarb. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY I found it's on `chrome.storage` and not `chrome.storage.sync`. This also works wit

D24161: Make KCM look more like applet

sefaeyeoglu updated this revision to Diff 66783. sefaeyeoglu added a comment. Import QtQuick.Controls as QQC2 and fix ToolTip delay REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24161?vs=9&id=66783 BRANCH feat-applet-ux REVISION

D24161: Make KCM look more like applet

sefaeyeoglu added inline comments. INLINE COMMENTS > ngraham wrote in Applications.qml:49 > I don't think the addition of the word "Streams" adds useful information here. The applet already says Streams here. > ngraham wrote in MuteButton.qml:32 > Using the attached `ToolTip` property is just f

D24187: WIP: Start of the accessibility KCM

tcanabrava updated this revision to Diff 66782. tcanabrava added a comment. - Initial Working Gestures REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24187?vs=66781&id=66782 BRANCH kcm_acess REVISION DETAIL https://phabricator.kde.org/D24187 A

D24187: WIP: Start of the accessibility KCM

tcanabrava updated this revision to Diff 66781. tcanabrava added a comment. - Rename kcm_access to kcmaccess - Fix typos - Qml Loads. Now, fix beaury - Fix imports and labels - Fix most layouts - Fix layout for the mouse navigation REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

ngraham added a comment. Yep, I figured you could figure that part out. :) REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D23274 To: GB_2, #plasma, #vdg Cc: ngraham, mart, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

GB_2 added a comment. In D23274#537221 , @ngraham wrote: > Try this patch to your patch: P471 Addendum to D23274 Thanks! The only issue that's left now is that the subcategory doesn't get reset (when go

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

GB_2 updated this revision to Diff 66780. GB_2 added a comment. Use Nate's fix and enable button when clicking a most used item REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23274?vs=64682&id=66780 BRANCH add-show-intro-page-button-to-system-set

D24194: Add per-domain media controls blacklist

broulik updated this revision to Diff 66776. broulik edited the test plan for this revision. broulik added a comment. - Add dummy icon when there's no controls REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24194?vs=66760&id=66776 REVISI

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

ngraham added a comment. Try this patch to your patch: P471 Addendum to D23274 REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D23274 To: GB_2, #plasma, #vdg Cc: ngraham, mart, #vdg, plasma-devel, #plasma, LeGast00n, The-Fer

D24181: Changing "Paste Without Formatting" in Notes applet to "Paste"

ngraham added a comment. In D24181#536786 , @broulik wrote: > In D24181#536785 , @ltoscano wrote: > > > Out of curiosity: doesn't usually the default Paste action (ctrl-V) paste with formatting? Sho

D23378: Check if sddm user exists

filipf added a comment. @davidedmundson is this okay now? REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH sddm-user-check (branched from master) REVISION DETAIL https://phabricator.kde.org/D23378 To: filipf, #plasma, davidedmundson, ngraham, #vdg, fvogt Cc: davidedmundson, plasm

D24161: Make KCM look more like applet

ngraham added inline comments. INLINE COMMENTS > Applications.qml:49 > enabled: eventStreamView.count || sinkInputView.count > -text: i18nd("kcm_pulseaudio", "Playback") > +text: i18nd("kcm_pulseaudio", "Playback Streams") > disabledText: i18ndc("

D24110: Enable removing multiple devices at once

This revision was automatically updated to reflect the committed changes. Closed by commit R97:e586f2794b74: Enable removing multiple devices at once (authored by umanovskis, committed by ngraham). REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24110?vs=66735

D24147: fix compatibility with Qt5.11

This revision was automatically updated to reflect the committed changes. Closed by commit R169:d2570246a555: fix compatibility with Qt5.11 (authored by mgallien). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24147?vs=6&id=66764 REVISION DETAIL https

D24193: Bump QtQuick.Controls dependency to 2.12 (from Qt 5.12).

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. In D24193#537123 , @ouwerkerk wrote: > If Kirigami is supposed to depend on Qt 5.11, then *why* were these old imports there in t

D24193: Bump QtQuick.Controls dependency to 2.12 (from Qt 5.12).

ouwerkerk added a comment. And if so, sure I can 'fix' this by downgrading to QQC 2.4 instead but in that case: is this 'safe'? I.e. does this introduce bugs/regressions? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D24193 To: ouwerkerk, mart, #plasma Cc: anthony

D24192: WIP: Active page follow the focus

broulik added inline comments. INLINE COMMENTS > PageRow.qml:162 > + > +while (item_parent && !(item_parent instanceof Page)) { > +item_parent = item_parent.parent; Does this work in Qt 5.11? I recall `typeof` for QML types only being implemented in Qt 5.12 REPOSITORY R16

D24193: Bump QtQuick.Controls dependency to 2.12 (from Qt 5.12).

ouwerkerk added a comment. If Kirigami is supposed to depend on Qt 5.11, then *why* were these old imports there in the first place? They cannot work with Qt 5.11, because then the max QQC version is 2.4 Maybe I am misunderstanding something here? Are you saying the old Kirigami code ef

D24193: Bump QtQuick.Controls dependency to 2.12 (from Qt 5.12).

mart added a comment. we have to depend from 2 qt versions ago as per KDE frameworks policy, so max version that can be used is Qt 5.11 REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D24193 To: ouwerkerk, mart, #plasma Cc: anthonyfieroni, plasma-devel, fbampaloukas

D24193: Bump QtQuick.Controls dependency to 2.12 (from Qt 5.12).

anthonyfieroni added reviewers: mart, Plasma. anthonyfieroni added a comment. Kirigami itself depends on 5.11 https://phabricator.kde.org/source/kirigami/browse/master/CMakeLists.txt$8 so update version to that one https://doc.qt.io/qt-5/qtquickcontrols-index.html REPOSITORY R169 Kirigami

D24194: Add per-domain media controls blacklist

broulik created this revision. broulik added reviewers: Plasma, VDG, fvogt, ognarb. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Allows disabling them for a specific domain in case it causes trouble or unwan

D24193: Bump QtQuick.Controls dependency to 2.12 (from Qt 5.12).

ouwerkerk created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ouwerkerk requested review of this revision. REVISION SUMMARY It is a bad idea to depend on non-existent versions: we should more clearly mark our intended QQC dependency version (ie. Qt

D24187: WIP: Start of the accessibility KCM

tcanabrava updated this revision to Diff 66758. tcanabrava added a comment. - Remove the ui file REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24187?vs=66746&id=66758 BRANCH kcm_acess REVISION DETAIL https://phabricator.kde.org/D24187 AFFECTE

D24192: WIP: Active page follow the focus

ognarb added a subscriber: mart. ognarb added inline comments. INLINE COMMENTS > PageRow.qml:172 > +print("focus not current item"); > +root.removePage(columnView.currentItem); > +print("pop"); @mart removePage doesn't work well, how can I change the current p

D24192: WIP: Active page follow the focus

ognarb created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ognarb requested review of this revision. REVISION SUMMARY This doesn't work well yet. - Need a long time (2-4 seconde) before the page is updated - Loss focus after changing page REP

D24191: Let plugin add additional status information

This revision was automatically updated to reflect the committed changes. Closed by commit R856:309ded7b3ba6: Let plugin add additional status information (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24191?vs=66752&i

D24191: Let plugin add additional status information

fvogt added inline comments. INLINE COMMENTS > broulik wrote in abstractbrowserplugin.h:47 > Not too happy about making it public, but it is used by `Settings`. Other > alternative would be to make a getter in `PluginManager` which then calls > this... or also making `Settings` a `friend class`

D24191: Let plugin add additional status information

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. Seems a bit weird to merge it at the top-level instead of adding a new key, but it's unlikely to result in abuse. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabr

D24191: Let plugin add additional status information

broulik added inline comments. INLINE COMMENTS > abstractbrowserplugin.h:47 > + */ > +virtual QJsonObject status() const; > + Not too happy about making it public, but it is used by `Settings`. Other alternative would be to make a getter in `PluginManager` which then calls this... or a

D24190: Let options page scroll

This revision was automatically updated to reflect the committed changes. Closed by commit R856:fb4cfa20bfb0: Let options page scroll (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24190?vs=66751&id=66753 REVISION DET

D24191: Let plugin add additional status information

broulik created this revision. broulik added reviewers: Plasma, fvogt, ognarb. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This can be used to communicate further status information, e.g. whether an externa

D24190: Let options page scroll

broulik created this revision. broulik added reviewers: Plasma, fvogt, ognarb. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY There'll be more options in the future TEST PLAN - Scrolls vertically now - The

D24165: Add SettingsUtil utility class

This revision was automatically updated to reflect the committed changes. Closed by commit R856:64d6bab15fe6: Add SettingsUtils utility class (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24165?vs=66690&id=66750 REVI

D24110: Enable removing multiple devices at once

ngraham added a comment. Yep, will do in a little while. REPOSITORY R97 Bluedevil BRANCH dev-multiselect REVISION DETAIL https://phabricator.kde.org/D24110 To: umanovskis, #vdg, #plasma, ngraham Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, rag

D24165: Add SettingsUtil utility class

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. Appears to work on ESR REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D24165 To: broulik, #plasma, fvogt, ognarb Cc: plasma-devel, LeGast00n, The-

D24110: Enable removing multiple devices at once

umanovskis added a comment. Thanks! Would you land this for me? REPOSITORY R97 Bluedevil BRANCH dev-multiselect REVISION DETAIL https://phabricator.kde.org/D24110 To: umanovskis, #vdg, #plasma, ngraham Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB

D24110: Enable removing multiple devices at once

ngraham accepted this revision. ngraham added a comment. Lovely work. 👌 REPOSITORY R97 Bluedevil BRANCH dev-multiselect REVISION DETAIL https://phabricator.kde.org/D24110 To: umanovskis, #vdg, #plasma, ngraham Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampalou

D24187: WIP: Start of the accessibility KCM

tcanabrava created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tcanabrava requested review of this revision. REVISION SUMMARY please don't review it yet Remove uneeded Item Beginning of the Modifier Keys KeyboardFilters start Activa

D24178: Add ability to cycle through sources in mediacontroller applet

dylanmcdougall added inline comments. INLINE COMMENTS > ngraham wrote in ExpandedRepresentation.qml:121 > Why [W]? W for Walk? Seems kind of arbitrary; "walk" isn't really a word I > would associate with this. In any event this seems like the kind of thing > that would benefit from being a glob

D14796: Port Keyboard input modules and Expand scope to cover input method configuration

yerilov added a comment. This fails to build now. > The longer we wait, the harder it will be to integrate So true. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14796 To: gpark, hein Cc: davideichelsdoerfer, yerilov, kucharczyk, lavender, ngraham,

D24110: Enable removing multiple devices at once

umanovskis marked an inline comment as done. umanovskis added inline comments. INLINE COMMENTS > ngraham wrote in devices.cpp:209 > You could rename this function to `removeSelectedDevices()` and handle both > single and multi-selection behaviors in it. Done, looks cleaner now - there's still a

D24110: Enable removing multiple devices at once

umanovskis updated this revision to Diff 66735. umanovskis added a comment. - Handle all device deletion in one function, reducing duplication REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24110?vs=66653&id=66735 BRANCH dev-multiselect REVISION DETAIL

D24181: Changing "Paste Without Formatting" in Notes applet to "Paste"

ltoscano added a comment. What changes is the patch needed. If we agree that Paste means "paste with formatting", then the string don't need to be changed, just the shortcut. REPOSITORY R114 Plasma Addons BRANCH notes-applet-tuning (branched from master) REVISION DETAIL https://phabri

D24181: Changing "Paste Without Formatting" in Notes applet to "Paste"

yerilov added a comment. I have no objections regarding default action, be it paste with or w/o formatting, it's rather a common sense fix: name what we use for Ctrl+V as "Paste", but and another action should get more detailed description. It also looks good in menu: