D24223: [RFC] Add global themes that mimic other platforms' workflows

2019-09-25 Thread Fabian Riethmayer
fabianr added a comment. > It doesn't auto-hide by default in macOS. I decided to make it span the full width of the screen because not doing this is IMO one of the dumbest parts of that macOS dock, because it pointlessly wastes the bottom-left-most and bottom-right-most pixels, which are t

D24223: [RFC] Add global themes that mimic other platforms' workflows

2019-09-25 Thread Fabian Riethmayer
fabianr added a comment. > I'd also consider to make the global theme also change plasma theme, color scheme or even application style so that it switches to a even more similiar interface. If Cupertino global theme switched to a light version of https://store.kde.org/p/1252328/, that would

D24181: Changing "Paste Without Formatting" in Notes applet to "Paste"

2019-09-25 Thread Luigi Toscano
ltoscano added a comment. I think that the Kate use case is different, as it provides only one paste action. Whenever else there are two paste actions available, it's always "paste" (with formatting) associated to ctrl-V and "paste without formatting" to ctrl-shift-V. So maybe you are talkin

D24181: Changing "Paste Without Formatting" in Notes applet to "Paste"

2019-09-25 Thread Vladimir Yerilov
yerilov added a comment. Funny thing: I stopped using Notes due to this formatting thing so long ago that I cannot remember when exactly. There's a plaintext Kate file on my desktop instead. REPOSITORY R114 Plasma Addons BRANCH notes-applet-tuning (branched from master) REVISION DETAIL

D24181: Changing "Paste Without Formatting" in Notes applet to "Paste"

2019-09-25 Thread Vladimir Yerilov
yerilov added a comment. @huftis Having thought about this I guess I have my attitude towards the default `Ctlr+V` 'Paste' action: it should be without formatting. I can explain why. Notes applet is not an application. The reason it exists is to contain quick notes and tasks, memos, etc.

D24181: Changing "Paste Without Formatting" in Notes applet to "Paste"

2019-09-25 Thread Nathaniel Graham
ngraham added a comment. In D24181#537896 , @davidedmundson wrote: > > If this behavior is considered objectionable and people hate it (personally I like it), perhaps an alternative approach would be to add a UI to toggle individual notes betwe

D24181: Changing "Paste Without Formatting" in Notes applet to "Paste"

2019-09-25 Thread David Edmundson
davidedmundson added a comment. > If this behavior is considered objectionable and people hate it (personally I like it), perhaps an alternative approach would be to add a UI to toggle individual notes between rich text and plain text, with plain text being the default? See https://bugs.kde.

D24181: Changing "Paste Without Formatting" in Notes applet to "Paste"

2019-09-25 Thread Nathaniel Graham
ngraham added a comment. The reason we decided to make this change was because users were complaining that pasting text into the Notes widget preserved formatting. See https://bugs.kde.org/show_bug.cgi?id=396507. So clearly not everyone expected that. It's the classic conflict between "

D24223: [RFC] Add global themes that mimic other platforms' workflows

2019-09-25 Thread Nathaniel Graham
ngraham added a comment. In D24223#537838 , @mmustac wrote: > It took me some seconds to get it where "garden dwarf" points do :-D > I think the previews for all look and feel packages KDE ships by default should show somehow the same desktop.

D24223: [WIP] Add global themes that mimic other platforms' workflows

2019-09-25 Thread Nathaniel Graham
ngraham updated this revision to Diff 66859. ngraham added a comment. Add Unueco theme REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24223?vs=66852&id=66859 BRANCH add-cupertino-global-theme (branched from master) REVISION DETAIL https://phabri

D24181: Changing "Paste Without Formatting" in Notes applet to "Paste"

2019-09-25 Thread Karl Ove Hufthammer
huftis added a comment. I find ‘Ctrl + V’ doing a ‘paste without formatting’ (with or without the renaming) confusing, and it goes against the principle of least surprise, which is in general a bad idea. In all(?) other applications, ‘Ctrl + V’ does a normal paste, i.e. with formatting (if p

D24223: [WIP] Add global themes that mimic other platforms' workflows

2019-09-25 Thread Marijo Mustac
mmustac added a comment. It took me some seconds to get it where "garden dwarf" points do :-D I think the previews for all look and feel packages KDE ships by default should show somehow the same desktop. Meaning have the same menu open or the same applications in the same spot. Would mak

D24223: [WIP] Add global themes that mimic other platforms' workflows

2019-09-25 Thread Nathaniel Graham
ngraham added a comment. In D24223#537805 , @niccolove wrote: > In Cupertino, I think that the bottom panel should be limited in width and should auto-hide. It doesn't auto-hide by default in macOS. I decided to make it span the full wi

D24223: [WIP] Add global themes that mimic other platforms' workflows

2019-09-25 Thread Niccolò Venerandi
niccolove added a comment. In Cupertino, I think that the apps launcher should be limited in width and should auto-hide. Regarding a side panel, I think it's really easy and nice to make the system tray somehow full height, that would easily mimick macOS and W10

D24223: [WIP] Add global themes that mimic other platforms' workflows

2019-09-25 Thread Nathaniel Graham
ngraham updated this revision to Diff 66852. ngraham added a comment. Add Garden Dwarf theme REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24223?vs=66849&id=66852 BRANCH add-cupertino-global-theme (branched from master) REVISION DETAIL https://

D24225: [Notifications] Add spacing after positioning popup for bottom panel

2019-09-25 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R120:348260db171d: [Notifications] Add spacing after positioning popup for bottom panel (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24

D24223: [WIP] Add global themes that mimic other platforms workflows

2019-09-25 Thread Nathaniel Graham
ngraham added a comment. In D24223#537790 , @cblack wrote: > An application launcher of some sort (besides KRunner) seems to be missing The Redmond style has Kickoff. The Cupertino style has a stripped down kickoff that only shows pow

D24223: [WIP] Add global themes that mimic other platforms workflows

2019-09-25 Thread Carson Black
cblack added a comment. An application launcher of some sort (besides KRunner) seems to be missing In D24223#537788 , @ngraham wrote: > One thing I'm running into is the need for a panel style that's always hidden until a button in another p

D24223: [WIP] Add global themes that mimic other platforms workflows

2019-09-25 Thread Nathaniel Graham
ngraham added a comment. One thing I'm running into is the need for a panel style that's always hidden until a button in another panel is clicked. Both macOS and Windows 10 have right screen edge sidebars that only appear when a button in one of the default panels is clicked. I like this qui

D24223: [WIP] Add global themes that mimic other platforms workflows

2019-09-25 Thread Nathaniel Graham
ngraham updated this revision to Diff 66849. ngraham added a comment. Add "Redmond" theme REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24223?vs=66836&id=66849 BRANCH add-cupertino-global-theme (branched from master) REVISION DETAIL https://pha

D24228: [containments/desktop] Use new colorful filter icon

2019-09-25 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R119:29310a940b35: [containments/desktop] Use new colorful filter icon (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24228?vs=66842&id=66848

D24228: [containments/desktop] Use new colorful filter icon

2019-09-25 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY F7431292: Desktop Configuration Filter Icon.png TEST PLAN Op

D24223: Add "Cupertino" global theme that mimics the macOS workflow

2019-09-25 Thread Nathaniel Graham
ngraham updated this revision to Diff 66836. ngraham added a comment. - Show day of the week - Show a button to trigger KRunner where the Spotlight button lives in macOS - Add an auto-hiding right panel that has a calendar and notification history REPOSITORY R114 Plasma Addons CHANGES S

D24224: Start of the accessibility KCM

2019-09-25 Thread Jeremy Whiting
whiting added a comment. Thanks for taking this on Tomaz, Just throwing some ideas out but if it would help to have less tabs it might be useful to put all the keyboard features on one tab called Keyboard instead of the 3 it has now (Modifier Keys, Keyboard Filters and Activation Gestures) T

D24225: [Notifications] Add spacing after positioning popup for bottom panel

2019-09-25 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Definitely better. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24225 To: broulik, #plasma, #vdg, ngraham Cc: ngraham, fvogt, plasma-devel, LeGast00n

D24224: Start of the accessibility KCM

2019-09-25 Thread Tomaz Canabrava
tcanabrava updated this revision to Diff 66834. tcanabrava added a comment. - Make buttons work REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24224?vs=66831&id=66834 BRANCH kcm_acess REVISION DETAIL https://phabricator.kde.org/D24224 AFFECTED

D24225: [Notifications] Add spacing after positioning popup for bottom panel

2019-09-25 Thread Fabian Vogt
fvogt added a comment. Seems to work here REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24225 To: broulik, #plasma, #vdg Cc: fvogt, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai,

D24223: Add "Cupertino" global theme that mimics the macOS workflow

2019-09-25 Thread Nathaniel Graham
ngraham added a comment. Ahh, great ideas! REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D24223 To: ngraham, #vdg, #plasma Cc: cblack, broulik, mvourlakos, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, h

D24223: Add "Cupertino" global theme that mimics the macOS workflow

2019-09-25 Thread Carson Black
cblack added a comment. Some suggestions: - Have the clock show day of the week - Add an applet that triggers KRunner by the system tray (can't remember if Plasma upstream has one) - Add a "sidebar" panel to the right with a calendar and notifications applet (auto hiding of course)

D24225: [Notifications] Add spacing after positioning popup for bottom panel

2019-09-25 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Otherwise we'll start of with a bigger gap to the bottom than in e.g. a top panel TEST PLAN

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

2019-09-25 Thread Björn Feber
GB_2 added a comment. In D23718#536359 , @ngraham wrote: > The frame's alignment and padding seem off: F7416705: Screenshot_20190923_075306.png > > Could we use a list more like the one used in the Virtu

D24224: Start of the accessibility KCM

2019-09-25 Thread Tomaz Canabrava
tcanabrava created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tcanabrava requested review of this revision. REVISION SUMMARY This is a 1 - 1 translation of the QWidgets version of the Accessibility KCM - Most of the functionality is there, and the l

D23274: Add "Show intro page" button to System Settings sidebar

2019-09-25 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R124:de351c8ed6c3: Add "Show intro page" button to System Settings sidebar (authored by GB_2). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23274?vs=66829&id=66830#toc REPOSITORY R124 System Se

D23274: Add "Show intro page" button to System Settings sidebar

2019-09-25 Thread Björn Feber
GB_2 updated this revision to Diff 66829. GB_2 added a comment. Swap menu and home button position REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23274?vs=66806&id=66829 BRANCH arcpatch-D23274 REVISION DETAIL https://phabricator.kde.org/D23274

D23274: Add "Show intro page" button to System Settings sidebar

2019-09-25 Thread Nathaniel Graham
ngraham added a comment. Yeah I would say so. REPOSITORY R124 System Settings BRANCH arcpatch-D23274 REVISION DETAIL https://phabricator.kde.org/D23274 To: GB_2, #plasma, #vdg, ngraham Cc: ngraham, mart, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas

D23274: Add "Show intro page" button to System Settings sidebar

2019-09-25 Thread Björn Feber
GB_2 added a comment. Shouldn't the "Show intro page" button be on the left, like in Discover, and the hamburger menu button on the right, like in for example Dolphin? REPOSITORY R124 System Settings BRANCH arcpatch-D23274 REVISION DETAIL https://phabricator.kde.org/D23274 To: GB_2,

D24223: Add "Cupertino" global theme that mimics the macOS workflow

2019-09-25 Thread Nathaniel Graham
ngraham added a comment. Maybe the contents of the Settings menu could live there, with the addition of Quit. Then again this almost seems like a change we'd want to make in KXMLGui because apps could benefit when using in-window menubars, not just when using a global menu. It's never made s

D24223: Add "Cupertino" global theme that mimics the macOS workflow

2019-09-25 Thread Kai Uwe Broulik
broulik added a comment. In D24223#537622 , @ngraham wrote: > You mean a thing to add the current app/window's name to the left of the global menu? What's what Window Title does, and it's quite nice. Pretty much. Ideally also with some co

D24223: Add "Cupertino" global theme that mimics the macOS workflow

2019-09-25 Thread Nathaniel Graham
ngraham added a comment. In D24223#537620 , @broulik wrote: > Fwiw I would totally love a patch to add an "application menu" to global menu applet and/or having a dedicated applet in plasma addons You mean a thing to add the current app/w

D24223: Add "Cupertino" global theme that mimics the macOS workflow

2019-09-25 Thread Kai Uwe Broulik
broulik added a comment. Fwiw I would totally love a patch to add an "application menu" to global menu applet and/or having a dedicated applet in plasma addons REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D24223 To: ngraham, #vdg, #plasma Cc: broulik, mvourl

D24223: Add "Cupertino" global theme that mimics the macOS workflow

2019-09-25 Thread Nathaniel Graham
ngraham added a subscriber: mvourlakos. ngraham added a comment. Note that this cannot be landed yet because it requires @mvourlakos' Window Title applet, which is not yet upstreamed. I tried to use Active Window Control, which is a KDE project, but it was too buggy and crashy and I found it

D24223: Add "Cupertino" global theme that mimics the macOS workflow

2019-09-25 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. TEST PLAN Entry in the Global Theme KCM: F7430169: Global Theme.png

D22885: Add global animation speed slider to workspace options KCM

2019-09-25 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R119:d2f545bfdc5d: Add global animation speed slider to workspace options KCM (authored by davidedmundson). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22885?v

D24187: WIP: Start of the accessibility KCM

2019-09-25 Thread Tomaz Canabrava
tcanabrava updated this revision to Diff 66823. tcanabrava added a comment. - Remove the ui file - Rename kcm_access to kcmaccess - Fix typos - Qml Loads. Now, fix beaury - Fix imports and labels - Fix most layouts - Fix layout for the mouse navigation - Initial Working Gestures

D24181: Changing "Paste Without Formatting" in Notes applet to "Paste"

2019-09-25 Thread Luigi Toscano
ltoscano added a comment. I think that this requires a bit more of discussion; "Paste" has a specific and well expected meaning. REPOSITORY R114 Plasma Addons BRANCH notes-applet-tuning (branched from master) REVISION DETAIL https://phabricator.kde.org/D24181 To: yerilov, ngraham Cc:

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

2019-09-25 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM! REPOSITORY R124 System Settings BRANCH arcpatch-D23274 REVISION DETAIL https://phabricator.kde.org/D23274 To: GB_2, #plasma, #vdg, ngraham Cc: ngraham, mart, #vdg, plasma-de

D24158: use KBusyIndicatorWidget for all busy indication uses

2019-09-25 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R871:871ed0a975a5: use KBusyIndicatorWidget for all busy indication uses (authored by sitter). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24158?vs=1&id=66807 RE

D24214: fix default version selection to allow for renamed "unspecified" versions

2019-09-25 Thread Harald Sitter
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R871:b769764b4727: fix default version selection to allow for renamed "unspecified" versions (authored by sitter). REPOSITO

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

2019-09-25 Thread Marco Martin
mart updated this revision to Diff 66806. mart added a comment. - correctly hide subcat column REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23274?vs=66780&id=66806 BRANCH arcpatch-D23274 REVISION DETAIL https://phabricator.kde.org/D23274 AF

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.13 - Build # 14 - Still Failing!

2019-09-25 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.13/14/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Wed, 25 Sep 2019 10:51:09 + Build duration: 6 min 29 sec and counting CONSOLE OUTPUT [...tr

D24214: fix default version selection to allow for renamed "unspecified" versions

2019-09-25 Thread Harald Sitter
sitter created this revision. sitter added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY plasmashell for example has a "master" instead of "unspecified". if we still tried to file a bug ag