D24649: Set new icon for battery applet

nicolasfella created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY It's not visible in the desktop system tray, but it is visible in the Plasma Mobile drawer where it is the only colorful

D24648: Don't show context drawer if all actions are invisible

ngraham added a comment. +1 REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D24648 To: nicolasfella, mart Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, ahiemstra, davidedmundson, mart, hein

D24648: Don't show context drawer if all actions are invisible

nicolasfella created this revision. nicolasfella added a reviewer: mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY Discover can be in a state where the only action in the context drawer is

D24645: Drop Configure from KCM title

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R116:a495e38eee01: Drop Configure from KCM title (authored by nicolasfella). REPOSITORY R116 Plasma Network Management

D24635: feedback kcm: Improve wording and presentation of the user feedback settings

apol added a comment. In D24635#547136 , @ngraham wrote: > Thanks. Can we just surface that then? We'd show a UI for the global on/off switch and than additionally allow turning telemetry on or off for apps and Plasma. That seems like it might

D24645: Drop Configure from KCM title

nicolasfella created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. nicolasfella requested review of this revision. REVISION SUMMARY None of the desktop KCMs has configure in the title REPOSITORY R116 Plasma Network

D24635: feedback kcm: Improve wording and presentation of the user feedback settings

ngraham added a comment. Thanks. Can we just surface that then? We'd show a UI for the global on/off switch and than additionally allow turning telemetry on or off for apps and Plasma. That seems like it might be less confusing than coming up with an abstraction surrounding it. REPOSITORY

D24635: feedback kcm: Improve wording and presentation of the user feedback settings

davidedmundson added a comment. > If the framework doesn't really support this To hopefully clarify, the framework works as follows: Global Enabled | App Enabled* | Result off |off | off off |on

D24614: Micro optimizations

aacid closed this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D24614 To: aacid, zzag Cc: zzag, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg,

D24635: feedback kcm: Improve wording and presentation of the user feedback settings

ngraham added a comment. I would really prefer a for the UX to indicate that that telemetry is off by default and needs to be manually turned on, or else it's confusing and disconcerting to the user. If the framework doesn't really support this, then we should change the implementation in

D24530: [XembedSNIProxy] If available, always use 32-bit color.

ngraham added a comment. FWIW since you landed this on master rather than `Plasma/5.17`, it will only be in Plasma 5.18, not 5.17.1. At this point, if it's critical to go into 5.17.1, you should cherry-pick the commit onto the `Plasma/5.17` branch since landing it there and merging

D24635: feedback kcm: Improve wording and presentation of the user feedback settings

davidedmundson added a comment. Implementation wise, that seems to match what now kuserfeedback clearly in mind, so ++. UX wise, I'm not completely sold. It still sounds like it's on by default till you read the long explanatory text to explain that just because it's not not disabled

D24616: [applets/systemtray] Remove unused imports

ngraham added a comment. In D24616#546801 , @filipf wrote: > In D24616#546649 , @ngraham wrote: > > > Could also port entirely away from PlasmaComponents and PlasmaExtras without too much effort. I

D24634: [WIP] Allow contextualActions to flow into the header toolbar

ngraham added a comment. Oh, this is so nice! REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D24634 To: ahiemstra, #kirigami Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, ahiemstra, davidedmundson, mart, hein

D24613: Use a lighter star color for non-default devices

This revision was automatically updated to reflect the committed changes. Closed by commit R115:e2965af722d9: Use a lighter star color for non-default devices (authored by ngraham). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D24635: feedback kcm: Improve wording and presentation of the user feedback settings

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Show the kill switch as such. It's about fordbidding all applications to submit data. They will be

D24634: [WIP] Allow contextualActions to flow into the header toolbar

ahiemstra updated this revision to Diff 67906. ahiemstra added a comment. - Use the right width for showing the more button when all actions are visible REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24634?vs=67905=67906 BRANCH

D24634: [WIP] Allow contextualActions to flow into the header toolbar

ahiemstra created this revision. ahiemstra added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY This replaces the custom layouting code in ToolBarPageHeader with an ActionToolBar,

D24470: feedback kcm: Use a horizontal slider like GammaRay does

This revision was automatically updated to reflect the committed changes. Closed by commit R120:42511d6f404b: feedback kcm: Use a horizontal slider like GammaRay does (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24470?vs=67472=67902#toc REPOSITORY R120 Plasma

D24503: Integrate the normal keyboard layout switcher

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R119:f2e579f9b366: Integrate the normal keyboard layout switcher (authored by apol). REPOSITORY R119 Plasma Desktop

D24265: support global edit mode

mart added a comment. In D24265#545990 , @GB_2 wrote: > This works very well now except for the vertical desktop toolbox. I don't think being able to have a vertical toolbox is practical, you can't really read the button labels and it's also

D24264: edit mode action and dbus

mart added a comment. In D24264#546001 , @GB_2 wrote: > It still leaves the edit mode when closing a panel controller toolbox which isn't consistent with the widget explorer and it has a few side effects such as not being able to edit three

D24265: support global edit mode

mart updated this revision to Diff 67899. mart added a comment. - get rid of the vertical mode REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24265?vs=67898=67899 BRANCH mart/editMode REVISION DETAIL https://phabricator.kde.org/D24265

D24265: support global edit mode

mart updated this revision to Diff 67898. mart added a comment. - don't auto close edit mode REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24265?vs=67719=67898 BRANCH mart/editMode REVISION DETAIL https://phabricator.kde.org/D24265 AFFECTED

D24454: Include an emoji picker

This revision was automatically updated to reflect the committed changes. Closed by commit R119:1449633fccfa: Include an emoji picker (authored by apol). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24454?vs=67730=67897 REVISION DETAIL

D24616: [applets/systemtray] Remove unused imports

filipf marked an inline comment as done. filipf added inline comments. INLINE COMMENTS > broulik wrote in PlasmoidPopupsContainer.qml:31 > `units` effectively comes from `PlasmaCore` missed that, sorry restored now:

Monday meeting notes for 14/10/2019

Bhushan - Mostly downstream changes in pmos related to plasma mobile and dialing/calls - Work on 2nd weekly blog post for plasma mobile - oh and also testing shell changes in mobile side Nico Fe * bought a new Nexus 5X because the old one crapped out. Spent a day getting Plasma on it * Added API

D24615: Fix crash with sortAllByName/Description

This revision was automatically updated to reflect the committed changes. Closed by commit R103:3d4640bea622: Fix crash with sortAllByName/Description (authored by ahmadsamir). REPOSITORY R103 KMenu Editor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24615?vs=67855=67891 REVISION

D24530: [XembedSNIProxy] If available, always use 32-bit color.

This revision was automatically updated to reflect the committed changes. Closed by commit R120:5e934611316b: [XembedSNIProxy] If available, always use 32-bit color. (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

Re: Plasma 5.17 tars available

New 5.17.0 kwin tar to disable rotation with drm https://phabricator.kde.org/D24112 sha256 d99443978a0f5f12d93d1d877312144d9387762933e12ac614992ae6e92daed7 On Fri, 11 Oct 2019 at 22:08, Jonathan Riddell wrote: > I've updated 5.17 tars for ksysguard and plasma-desktop > > >

D24607: Fix showing menu toolbutton when no drawer is available

This revision was automatically updated to reflect the committed changes. Closed by commit R169:15871270ae55: Fix showing menu toolbutton when no drawer is available (authored by nicolasfella). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D24194: Add per-origin media controls blacklist

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R856:ca085f500183: Add per-origin media controls blacklist (authored by broulik). REPOSITORY R856 Plasma Browser

D24530: [XembedSNIProxy] If available, always use 32-bit color.

davidedmundson added a comment. You can merge now :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24530 To: kmaterka, davidedmundson, #plasma_workspaces, #plasma Cc: mlaurent, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2,

D24616: [applets/systemtray] Remove unused imports

broulik added inline comments. INLINE COMMENTS > PlasmoidPopupsContainer.qml:31 > > Layout.minimumWidth: units.gridUnit * 12 > Layout.minimumHeight: units.gridUnit * 12 `units` effectively comes from `PlasmaCore` REPOSITORY R120 Plasma Workspace REVISION DETAIL

D24265: support global edit mode

mart added a comment. In D24265#546025 , @GB_2 wrote: > BTW, it would also be nice to have click and hold on the panel to open the panel controller toolbox :-) maybe. Ii feel it kinda overkill REPOSITORY R119 Plasma Desktop BRANCH

D24616: [applets/systemtray] Remove unused imports

This revision was automatically updated to reflect the committed changes. Closed by commit R120:64e5c75f4f1f: [applets/systemtray] Remove unused imports (authored by filipf). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24616?vs=67857=67878

D24616: [applets/systemtray] Remove unused imports

filipf added a comment. In D24616#546649 , @ngraham wrote: > Could also port entirely away from PlasmaComponents and PlasmaExtras without too much effort. I suppose that's best done in a separate patch though. We would use QQC2 for

D24530: [XembedSNIProxy] If available, always use 32-bit color.

mlaurent added a comment. Hi, You can't commit yet as nobody accepted this patch. Regards REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24530 To: kmaterka, davidedmundson, #plasma_workspaces, #plasma Cc: mlaurent, plasma-devel, LeGast00n,

D24614: Micro optimizations

zzag accepted this revision. zzag added a comment. This revision is now accepted and ready to land. > Add some const & for things that return const & so there's no need to make a copy For what it's worth, copy elision is guaranteed starting from C++17. \o/ REPOSITORY R31 Breeze

D24283: Add clang format file

cullmann added a comment. There will anyways be one "big" change in the history, but normally git will be able to handle that well by ignoring space changes for blame or diff. I don't think without the aligning the change will be much smaller. REPOSITORY R120 Plasma Workspace REVISION

D24530: [XembedSNIProxy] If available, always use 32-bit color.

kmaterka added a comment. I have Develop Account now. Is review finished or something more is needed? Can I push this change? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24530 To: kmaterka, davidedmundson, #plasma_workspaces, #plasma Cc: plasma-devel,

D24283: Add clang format file

zzag added a comment. In D24283#545620 , @cullmann wrote: > For the alignment of comments, I am not sure, it makes the stuff a lot more readable in many cases and after the initial re-format you don't have a lot of jitter normally. As I

D24615: Fix crash with sortAllByName/Description

mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. it seems ok for me. Thanks REPOSITORY R103 KMenu Editor BRANCH ahmad/takechildren-crash-on-index-rootItem (branched from master) REVISION DETAIL