D24767: [SystemTray] Support for AttentionIcon

kmaterka added a comment. As part of: https://www.freedesktop.org/wiki/Specifications/StatusNotifierItem/StatusNotifierItem/ REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24767 To: kmaterka, #plasma, #plasma_workspaces Cc: plasma-devel, LeGast00n, The-F

D24768: Fix incorrect Credits model for Kirigami.AboutPage

IlyaBizyaev created this revision. IlyaBizyaev added a reviewer: Kirigami. IlyaBizyaev added a project: Kirigami. Herald added a subscriber: plasma-devel. IlyaBizyaev requested review of this revision. REVISION SUMMARY Credits section currently displays the list of translators. This fixes a

D24767: [SystemTray] Support for AttentionIcon

kmaterka created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kmaterka requested review of this revision. REVISION SUMMARY Adding support for Attention Icon to StatusNotifier tray icons BUG: 341255 TEST PLAN As described in bug report, Konversat

Re: Discover and KSysGuard in kde.org/applications?

Since neither Discover nor KSysguard has a website, having both applications in kde.org/applications would allow both applications to still have a 'web presence'. This can be useful if we want to link to Discover from somewhere else. And kde.org/applications is not only display applications par

Re: Discover and KSysGuard in kde.org/applications?

Sure, but they also lose effectiveness. For example, I don't know if the wallpapers installed from Discover will work fine on Gnome, or LXQt. What about icon themes? Aleix On Fri, Oct 18, 2019 at 11:04 PM Nate Graham wrote: > > Personally I would like to see then listed there. They're standalone

D24766: Revert change to make the notification persistent

ngraham added a comment. I had a feeling this would be popular. :) REPOSITORY R134 Discover Software Store BRANCH revert-sticky-notifications (branched from Plasma/5.17) REVISION DETAIL https://phabricator.kde.org/D24766 To: ngraham, apol, broulik, #discover_software_store Cc: ognarb,

D24766: Revert change to make the notification persistent

This revision was automatically updated to reflect the committed changes. Closed by commit R134:d9db05ddef96: Revert change to make the notification persistent (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24766?vs=68265

Re: Discover and KSysGuard in kde.org/applications?

Personally I would like to see then listed there. They're standalone apps that can be installed without Plasma, after all. Nate On 10/18/19 3:03 PM, Aleix Pol wrote: On Fri, Oct 18, 2019 at 2:11 PM Jonathan Riddell wrote: Would Plasma team like these listed on the KDE Apps webpage? So fa

Re: Discover and KSysGuard in kde.org/applications?

On Fri, Oct 18, 2019 at 2:11 PM Jonathan Riddell wrote: > > Would Plasma team like these listed on the KDE Apps webpage? So far I've not > had them because Plasma is a product of KDE that is not a standalone app. Hi Jonathan, I would say it's okay that they are not, I agree with your resoning.

D24766: Revert change to make the notification persistent

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. 😁 REPOSITORY R134 Discover Software Store BRANCH revert-sticky-notifications (branched from Plasma/5.17) REVISION DETAIL https://phabricator.kde.org/D24766 To: ngraham, apol, broulik, #

D24766: Revert change to make the notification persistent

ngraham updated this revision to Diff 68265. ngraham marked an inline comment as done. ngraham added a comment. Don't stop keeping track of the notification, so we can still close it when Discover is launched REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabr

D24766: Revert change to make the notification persistent

ngraham added a comment. That pares down the diff quite a bit. :) REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D24766 To: ngraham, apol, broulik, #discover_software_store Cc: ognarb, nicolasfella, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D24766: Revert change to make the notification persistent

apol added a comment. Other than that, LGTM INLINE COMMENTS > DiscoverNotifier.cpp:67 > KRun::runCommand(QStringLiteral("plasma-discover"), nullptr); > -if (m_updatesAvailableNotification) { > m_updatesAvailableNotification->close(); } > } I wouldn't remove these. It's good that i

D24766: Revert change to make the notification persistent

ognarb added a comment. +1 😁 REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D24766 To: ngraham, apol, broulik, #discover_software_store Cc: ognarb, nicolasfella, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBo

D24766: Revert change to make the notification persistent

nicolasfella added a comment. Yes please! REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D24766 To: ngraham, apol, broulik, #discover_software_store Cc: nicolasfella, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Z

D24766: Revert change to make the notification persistent

ngraham created this revision. ngraham added reviewers: apol, broulik, Discover Software Store. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Nobody liked it and it was annoying. From a conceptual standpoint,

[Breeze] [Bug 340137] Implement support for window groups (window tabs) in Breeze

https://bugs.kde.org/show_bug.cgi?id=340137 kouka...@gmail.com changed: What|Removed |Added CC||kouka...@gmail.com --- Comment #10 from kou

D24743: Update GTK settings according to Plasma settings

gikari updated this revision to Diff 68260. gikari added a comment. Fix daemon hangup on font change REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24743?vs=68258&id=68260 BRANCH gtk-settings-in-respective-kcms REVISION DETAIL https:

D24763: [kcms/nightcolor] Add hints to temperature slider direction

ngraham added a comment. In D24763#549955 , @broulik wrote: > Nevermind I am an idiot and don't know how (colo(u)r) temperature works. Which is exactly why we need these labels. :) REPOSITORY R119 Plasma Desktop BRANCH master REVISI

D24479: [KCM] Make multi-screen draggability more obvious

ngraham marked 3 inline comments as done. ngraham added inline comments. INLINE COMMENTS > davidedmundson wrote in Output.qml:273 > This still needs fixing. Regardless of whether it happens to work now or not. Per discussion, we can do it this way for now since other pieces of code that are alr

D24763: [kcms/nightcolor] Add hints to temperature slider direction

broulik added a comment. Nevermind I am an idiot and don't know how (colo(u)r) temperature works. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D24763 To: davidedmundson, #plasma, ngraham Cc: broulik, ngraham, plasma-devel, LeGast00n, The-Fer

D24763: [kcms/nightcolor] Add hints to temperature slider direction

broulik added a comment. In right to left layout the labels must be swapped. F7623875: Screenshot_20191018_194633.png REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D24763 To: davidedmundson, #plasma,

D24479: [KCM] Make multi-screen draggability more obvious

ngraham updated this revision to Diff 68259. ngraham marked an inline comment as done. ngraham added a comment. Use anchors correctly so the new label elides if necessary REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24479?vs=67509&id=68259 BRANCH make-

D24743: Update GTK settings according to Plasma settings

gikari added inline comments. INLINE COMMENTS > broulik wrote in gtkconfig.cpp:116 > In what way? There's a comment in the style KCM saying > > // # FIXME - Doesn't apply all settings correctly due to bugs in > KApplication/KToolbar > KGlobalSettings::self()->emitChange(KGlobalSettings:

D24743: Update GTK settings according to Plasma settings

gikari updated this revision to Diff 68258. gikari added a comment. Fix pidof launching and remove static from the regexp's REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24743?vs=68256&id=68258 BRANCH gtk-settings-in-respective-kcms R

D24743: Update GTK settings according to Plasma settings

gikari updated this revision to Diff 68256. gikari marked 16 inline comments as done. gikari added a comment. Fix most of the issues brought by @broulik REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24743?vs=68187&id=68256 BRANCH gtk-s

D24765: [WIP] Notification applet on the phone

mart requested review of this revision. mart added a comment. behavior on mobile F7623351: vokoscreen-2019-10-18_18-05-35.mp4 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24765 To: mart, #plasma Cc: plasma-devel,

D24765: [WIP] Notification applet on the phone

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY some optimizations for tablet mode (touch first, but also on transformable laptops flipped to tablet) a

D24763: [kcms/nightcolor] Add hints to temperature slider direction

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Fixit then shipit! INLINE COMMENTS > main.qml:153 > +} > +Item {} > +} Oh and one more thing, this should probably be a vertical spacer so the

D24763: [kcms/nightcolor] Add hints to temperature slider direction

davidedmundson updated this revision to Diff 68251. davidedmundson added a comment. Made the patch even cooler REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24763?vs=68250&id=68251 BRANCH master REVISION DETAIL https://phabricator.kde.org/D247

D24763: [kcms/nightcolor] Add hints to temperature slider direction

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Nice. INLINE COMMENTS > main.qml:151 > +QQC2.Label { > +text: i18nc("Night colour blue-ish", "Cold") > +} This should be "Co

D24763: [kcms/nightcolor] Add hints to temperature slider direction

davidedmundson added a comment. F7623296: Screenshot_20191018_165943.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24763 To: davidedmundson, #plasma Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampalo

D24763: [kcms/nightcolor] Add hints to temperature slider direction

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. TEST PLAN Looked at it REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL h

D24758: [KEditFileType] Add a desktop file

This revision was automatically updated to reflect the committed changes. Closed by commit R126:9b2c7dec61de: [KEditFileType] Add a desktop file (authored by meven). REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24758?vs=68243&id=68245 REVISION DET

D24740: [Media Controller] Multiple artists support

K900 added a comment. Re: lockscreen/toolbar stuff: maybe the metadata parsing should go into the dataengine instead? I could write up a patch to move the metadata parsing logic there, and then we can have the actual QML bits refer to the specific parsed fields that will come pre-sanitized (

D24758: [KEditFileType] Add a desktop file

kossebau added inline comments. INLINE COMMENTS > meven wrote in CMakeLists.txt:57 > We have a bunch of apps to update, I used this because I found it in krusader > code Yes, due to having no proper cmake deprecation warnings there are still some with old code. But lots of porting already happ

D24758: [KEditFileType] Add a desktop file

meven added inline comments. INLINE COMMENTS > kossebau wrote in CMakeLists.txt:57 > KDE_INSTALL_APPDIR, please. XDG_APPS_INSTALL_DIR is deprecated, cmp. > https://api.kde.org/ecm/kde-module/KDEInstallDirs.html We have a bunch of apps to update, I used this because I found it in krusader code

D24758: [KEditFileType] Add a desktop file

meven marked an inline comment as done. meven added a comment. Thanks @kossebau @broulik REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D24758 To: meven, broulik, ngraham Cc: kossebau, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2

D24758: [KEditFileType] Add a desktop file

meven updated this revision to Diff 68243. meven added a comment. Replace OnlyShowIn= by NoDisplay=true USe KDE_INSTALL_APPDIR instead of deprecated XDG_APPS_INSTALL_DIR REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24758?vs=68239&id=68243 BRAN

D24727: Fix NOAA picture of the day provider

This revision was automatically updated to reflect the committed changes. Closed by commit R114:432470576605: Fix NOAA picture of the day provider (authored by Guo Yunhe ). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24727?vs=68225&i

D24727: Fix NOAA picture of the day provider

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. works well enough it seems F7622741: yJIMcaK.jpg REPOSITORY R114 Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D247

D24758: [KEditFileType] Add a desktop file

kossebau added inline comments. INLINE COMMENTS > CMakeLists.txt:57 > install( FILES filetypes.desktop DESTINATION ${KDE_INSTALL_KSERVICES5DIR} ) > +install(PROGRAMS org.kde.keditfiletype.desktop DESTINATION > ${XDG_APPS_INSTALL_DIR} ) KDE_INSTALL_APPDIR, please. XDG_APPS_INSTALL_DIR is depr

D24759: [ksmserver] Drop unused logout effect widget

davidedmundson created this revision. davidedmundson added reviewers: Plasma, KWin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY At some point there was an effect in kwin to fade to a grey (with a we

D24758: [KEditFileType] Add a desktop file

broulik added a comment. Should this be `NoDisplay` since you can't just launch it without an argument REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D24758 To: meven, broulik, ngraham Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, G

D24758: Add a desktop for utility keditfiletype

meven updated this revision to Diff 68239. meven added a comment. Add missing .desktop file REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24758?vs=68238&id=68239 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24758 AFFECTED FIL

D24758: Add a desktop for utility keditfiletype

meven created this revision. meven added reviewers: broulik, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Allow to display its Icon in Wayland BUG: 383615 REPOSITORY R126 KDE CLI Utilities BRANCH

D24757: Port away from KIconThemes

This revision was automatically updated to reflect the committed changes. Closed by commit R119:e06e897f9d45: Port away from KIconThemes (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24757?vs=68232&id=68237 REVISION DETAIL htt

D24756: Port away from KIconThemes

This revision was automatically updated to reflect the committed changes. Closed by commit R120:88c1f2093cac: Port away from KIconThemes (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24756?vs=68231&id=68236 REVISION DETAIL h

D24727: Fix NOAA picture of the day provider

ngraham added a comment. If it works for you @sitter then feel free to ignore me. But I believe my testing methodology is sound: I'm living in my built-from-source plasma session and I apply the patch, build and install kdeplasma-addons to `~/kde/usr`, and then restart plasmashell. This work

D24732: Rewrite AppChooser dialog

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Aha, the old one was indeed still running! I can see the new one now. - My request to give the scrollview a frame and the background isn't implemented yet. - My request to

D24732: Rewrite AppChooser dialog

jgrulich added a comment. In D24732#549750 , @ngraham wrote: > On my system, it's at `/usr/lib64/libexec/xdg-desktop-portal-kde`. I tried overriding that file with the one I just built from source (because it didn't seem to use the built-from-so

D24732: Rewrite AppChooser dialog

ngraham added a comment. On my system, it's at `/usr/lib64/libexec/xdg-desktop-portal-kde`. I tried overriding that file with the one I just built from source (because it didn't seem to use the built-from-source one at `~/kde/usr/lib64/libexec/xdg-desktop-portal-kde`) but even then, I still

D24265: support global edit mode

mart added a comment. In D24265#549691 , @davidedmundson wrote: > Can you explain the intended difference between top and topcenter? when the toolbox is at topcenter, it snaps at center screen ,and if the resolution changes it will be mo

D24265: support global edit mode

mart updated this revision to Diff 68235. mart added a comment. - remove dead code REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24265?vs=67899&id=68235 BRANCH mart/editMode REVISION DETAIL https://phabricator.kde.org/D24265 AFFECTED FILES

D24264: edit mode action and dbus

mart updated this revision to Diff 68234. mart added a comment. - explanation++ - remove redundant check REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24264?vs=67707&id=68234 BRANCH mart/editMode REVISION DETAIL https://phabricator.kde.org

D24743: Update GTK settings according to Plasma settings

gikari added a comment. In D24743#549712 , @ngraham wrote: > Nice work! So what's our update story here? If a user has set something from the GTK KCM that's not the same as the data set by the applicable other KCM, who wins, and what happens whe

D24750: Fix reading environment variables with newline

This revision was automatically updated to reflect the committed changes. Closed by commit R120:595ab88bc2ee: Fix reading environment variables with newline (authored by fvogt). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24750?vs=68217&id=68233 R

D24757: Port away from KIconThemes

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY At least where trivially possible. TEST PLAN T11637 -

D24743: Update GTK settings according to Plasma settings

ngraham added a comment. Nice work! So what's our update story here? If a user has set something from the GTK KCM that's not the same as the data set by the applicable other KCM, who wins, and what happens when said user upgrades to 5.18 (which is presumably the release that will have this)?

D24750: Fix reading environment variables with newline

adridg accepted this revision. adridg added a comment. This revision is now accepted and ready to land. Looked for -0 alternatives, couldn't find any. Dave tells me there's sufficient fallbacks, and otherwise we'll just patch it out in packaging. REPOSITORY R120 Plasma Workspace BRANCH P

D24756: Port away from KIconThemes

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY At least where trivially possible. TEST PLAN T11637 -

Discover and KSysGuard in kde.org/applications?

Would Plasma team like these listed on the KDE Apps webpage? So far I've not had them because Plasma is a product of KDE that is not a standalone app. Jonathan

D24479: [KCM] Make multi-screen draggability more obvious

davidedmundson added inline comments. INLINE COMMENTS > davidedmundson wrote in Output.qml:273 > > Or the KCM re-creating the outputModel which would be weird. > > It would, but: > > connect (m_config.get(), &ConfigHandler::outputModelChanged, >this, &KCMKScreen::outputModelChange

D24265: support global edit mode

davidedmundson added a comment. Can you explain the intended difference between top and topcenter? INLINE COMMENTS > ToolBoxButton.qml:87 > id: stateTimer > -interval: 100 > +interval: 0//toolBoxButton.state.indexOf("center") != -1 ? 0 : 100 > onTriggered: up

D24265: support global edit mode

GB_2 added a comment. Why not? Currently you have to open the context menu for the panel or desktop, so it's inconsistent and confusing if you want to move a widget and the don't get the option to (without click+hold). REPOSITORY R119 Plasma Desktop BRANCH mart/editMode REVISION DETAIL

D24264: edit mode action and dbus

davidedmundson accepted this revision. davidedmundson added inline comments. INLINE COMMENTS > appletslayout.cpp:534 > +QMouseEvent *me = static_cast(event); > +if (me->button() == Qt::LeftButton || (me->buttons() & > Qt::LeftButton)) { > +mousePressEvent(me); the fi

D24727: Fix NOAA picture of the day provider

guoyunhe updated this revision to Diff 68225. guoyunhe added a comment. Validate QUrl of image REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24727?vs=68185&id=68225 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24727 AFFECTED FILE

D24265: support global edit mode

mart added a comment. In D24265#549634 , @GB_2 wrote: > I'd also add the "Customize Layout..." menu item to the widget context menu, that way you can discover it much more easily. i would prefer not REPOSITORY R119 Plasma Desktop BRAN

D24727: Fix NOAA picture of the day provider

sitter added a comment. When I put the code in a minimal standalone program I can confirm that the code works just fine. Are you sure your testing methodology is sound @ngraham ? In point of fact if (url.isEmpty()) { should actually be `url.isValid` because the requirement is

D24265: support global edit mode

GB_2 added a comment. I'd also add the "Customize Layout..." button to the widget menu, that way you can discover it much more easily. REPOSITORY R119 Plasma Desktop BRANCH mart/editMode REVISION DETAIL https://phabricator.kde.org/D24265 To: mart, #plasma, ngraham Cc: ngraham, GB_2,

D24750: Fix reading environment variables with newline

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Thanks for the swift action REPOSITORY R120 Plasma Workspace BRANCH Plasma/5.17 REVISION DETAIL https://phabricator.kde.org/D24750 To: fvogt, #plasma, apol, davidedm

D24265: support global edit mode

mart added a comment. In D24265#549583 , @GB_2 wrote: > An "Add Panel..." button in the toolbox would be very useful too :-) maybe.. tough it must have a submenus that loads the available installed panel layouts... may get messy REPOSITO

D24751: installdbgsymbols_suse: Pass --plus-content debug to zypper

fvogt created this revision. fvogt added reviewers: lbeltrame, cgiboudeaux. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. fvogt requested review of this revision. REVISION SUMMARY This way the repository with debuginfo does not have to be enabled manually before clic

D24260: [Style KCM] Don't explicitly reload KWin's configuration

This revision was automatically updated to reflect the committed changes. Closed by commit R119:58fe6dabbb0f: [Style KCM] Don't explicitly reload KWin's configuration (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24260?vs=66947&i

D24265: support global edit mode

GB_2 added a comment. An "Add Panel..." button in the toolbox would be very useful too :-) REPOSITORY R119 Plasma Desktop BRANCH mart/editMode REVISION DETAIL https://phabricator.kde.org/D24265 To: mart, #plasma, ngraham Cc: ngraham, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jr

D24265: support global edit mode

GB_2 added a comment. Only one last issue: the widget resizing handles disappear when you are on a blank area of the widget handle (the bar to the left/right). INLINE COMMENTS > GB_2 wrote in ToolBoxButton.qml:292 > This should probably be changed to "Finish Customizing Layout" to match the

D24732: Rewrite AppChooser dialog

jgrulich added a comment. In D24732#549249 , @ngraham wrote: > Finally, I would consider adding the "Other applications are available in Discover" text to the bottom, so it doesn't interrupt the dialog's flow. I'm not sure about that, bec

D24732: Rewrite AppChooser dialog

jgrulich updated this revision to Diff 68218. jgrulich added a comment. Address review comments REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24732?vs=68140&id=68218 BRANCH new-app-dialog REVISION DETAIL https://ph

D24744: Remove unneeded options in GTK KCM

broulik added a comment. Ideally, we'd also sync `SH_ScrollBar_LeftClickAbsolutePosition` to GTK and drop the cursor to position radios REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D24744 To: gikari, #vdg, #plasma Cc: broulik, filipf, GB_2, plasm

D24750: Fix reading environment variables with newline

fvogt added a comment. Note, the "-0" option is only available in GNU env, not in BSD /env... I can't think of a better way to fix this though other than implementing env ourselves in native code. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24750 To: f

D24744: Remove unneeded options in GTK KCM

GB_2 added a comment. In D24744#549486 , @gikari wrote: > In D24744#549450 , @GB_2 wrote > > > Well, it'll be gone completely soon and the GTK theme comboboxes will be in the Application Style KCM.

D24750: Fix reading environment variables with newline

fvogt updated this revision to Diff 68217. fvogt added a comment. arc is a PoS REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24750?vs=68216&id=68217 BRANCH Plasma/5.17 REVISION DETAIL https://phabricator.kde.org/D24750 AFFECTED FILES star

D24750: Fix reading environment variables with newline

fvogt created this revision. fvogt added reviewers: Plasma, apol. Herald added a project: Plasma. fvogt requested review of this revision. REVISION SUMMARY Use '\0' as separator as '\n' is likely to appear in values. BUG: 413130 TEST PLAN /etc/profile.d/mc.sh exported an mc() function,

D24740: [Media Controller] Multiple artists support

This revision was automatically updated to reflect the committed changes. Closed by commit R120:1be4bb880fde: [Media Controller] Multiple artists support (authored by lesf0, committed by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24740?v